[08:03] good morning peeps! [08:05] morning Chipaca [10:56] Muy buenos días a todos! [11:20] facubatista: I just lied to stub! [11:20] facubatista: src is *not* in our dispatch's pythonpatgh [11:20] facubatista: i thought we'd agreed to that :-| [11:20] Chipaca, i think we should if we don't right now [11:20] mmm [11:21] unless python always includes siblings. [11:21] we talked about mod, and then we said that all charms were symlinking from lib to that anyway [11:21] about 'mod' dir, I mean [11:22] don't remember about 'src' [11:22] I wouldn't include mod, because you generally want a subdir of that anyway [11:23] Issue operator#339 opened: debug-code silently fails if src/charm.py is not executable [11:24] Chipaca, you already set my pr as non draft? Or it just accepted our earlier attempts [11:24] jam: i did it [11:32] Issue operator#339 closed: debug-code silently fails if src/charm.py is not executable [11:33] Issue operator#339 opened: debug-code silently fails if src/charm.py is not executable [11:41] Issue operator#339 closed: debug-code silently fails if src/charm.py is not executable [11:42] Issue operator#339 opened: debug-code silently fails if src/charm.py is not executable [11:43] Chipaca, jam, added 'src' to PYTHONPATH - https://github.com/canonical/charmcraft/pull/63 [11:43] PR charmcraft#63: Added 'src' to PYTHONPATH [11:44] facubatista, Chipaca : isn't it automatically part of PYTHONPATH if you exec src/charm.py ? [11:46] ah, wait, we don't want 'src' hardcoded [11:46] that PR is wrong [11:48] jam: not part of pythonpath, but effectively the same thing [11:48] but i thought it wouldn't work when going via the symlinks [11:48] maybe i was wrong? [11:49] trying to get it to break here :) [11:49] so, there's something the site thing is doing [11:49] if you run it in isolated mode, it fails [11:50] Chipaca, what do you mean? [11:50] facubatista: I mean: if you have src/charm.py importing potato, and you have src/potato.py [11:50] facubatista: and you do 'python3 src/charm.py' [11:50] it works [11:50] it will find potato, at least on ubuntu focal [11:50] but now try with python3 -I src/charm.py [11:50] and it no longer finds potato.py [11:51] so the site configuration is doing something [11:51] i'd have to dig to figure it out [11:51] this means we probably want src/ on the pythonpath so it works in pythons weirder than just plain ubuntu [11:51] https://bugs.launchpad.net/juju/+bug/1885555 [11:51] but i need more data to be confident :) [11:54] Chipaca, -I: "In isolated mode sys.path contains neither the script’s directory..." [11:54] Chipaca, so, the -I is removing the script dir [11:54] not that something else is adding it [11:55] "All PYTHON* environment variables are ignored, too. " [11:55] Chipaca, so, if you run it isolated, it would not respect our path fixings either, so... [12:29] facubatista: ah :-) thanks [12:29] facubatista: yeah i knew it ignored pythonpath, i wasn't suggesting to run it with that [12:29] facubatista: I just wanted -S, i guess [12:41] facubatista: jam: https://discourse.juju.is/t/charmcraft-bi-weekly-dev-summary-2020w25-26/3289 [12:42] facubatista: jam: can you give it a quick read in case i forgot anything, before sending it out to the non-editable things? [12:42] yes [12:44] Chipaca, I just remembered we need to confirm whether collect-metrics is going to cause problems. I'll start working on that tomorrow after all my meetings. [12:44] Chipaca, the "snap" part looks too detailed, I wonder if we should have a tl;dr part [12:44] PR operator#323 closed: 317 state get [12:44] (meetings today) [12:44] jam: congrats on landing that [12:45] Chipaca, is it worth holding the summary for tomorrow and be able to just announce 0.7 ? [12:46] jam: i'm happy to do a smaller we-got-0.7-up one on wednesday [12:46] can't we release 0.7 today? [12:47] It seems like we could [12:47] should I do those changes to ops.lib.use before that? [12:50] Chipaca, autoimport ? [12:50] I'd happily review it for you [13:01] Chipaca, meeting? [13:02] omw [13:41] Chipaca, I noted that it did include PyYAML but no .so extensions [13:42] i think it including pyyaml is a bug :) but that's just me [13:42] Chipaca, I'd rather not, but that is a side effect if people prefer "include system packages = false" [13:43] i wonder which yaml you get when you import it tho [13:47] all of them simultaneously [13:48] jam: maybe then it'll be fastest! [14:06] Chipaca, jam, as a conclusion from the debugging some minutes ago... shall we fix dispatch execution bits or not? [14:21] facubatista: i think we should, but not zomg-release-this [14:24] Chipaca, https://github.com/canonical/charmcraft/issues/64 [15:05] * facubatista -> lunch [16:16] jam, facubatista, if you're still around jay responded [16:20] jam, facubatista, never mind then :) [16:42] * facubatista is back [16:59] and I'm EOD :-) [16:59] facubatista: 👋 ttfn [16:59] PR operator#340 opened: make ops.lib.autoimport use optional [17:00] Chipaca, bye [21:16] * facubatista eods