| mup | Issue operator#341 opened: ops.lib fails to import packages with '-' in their metadata <Created by stub42> <https://github.com/canonical/operator/issues/341> | 04:51 |
|---|---|---|
| mup | Issue operator#342 opened: ops.lib.autoload does not log what it is doing <Created by stub42> <https://github.com/canonical/operator/issues/342> | 04:58 |
| mup | PR operator#343 opened: Allow library metadata to include hyphens <Created by stub42> <https://github.com/canonical/operator/pull/343> | 05:03 |
| mup | Issue operator#344 opened: Cleaner error message when use_juju_for_storage is True wrt Juju 2.6 <Created by jameinel> <https://github.com/canonical/operator/issues/344> | 05:35 |
| mup | Issue operator#345 opened: Harness could start with config initialized from config.yaml <Created by jameinel> <https://github.com/canonical/operator/issues/345> | 06:05 |
| mup | PR operator#343 closed: Allow library metadata to include hyphens <Created by stub42> <Closed by stub42> <https://github.com/canonical/operator/pull/343> | 06:09 |
| mup | PR operator#346 opened: Improve ops.lib line matching regexp <Created by stub42> <https://github.com/canonical/operator/pull/346> | 06:09 |
| mup | Issue operator#347 opened: use_juju_for_storage=True breaks if metrics are in use <Created by jameinel> <https://github.com/canonical/operator/issues/347> | 07:17 |
| mup | Issue operator#348 opened: Support collect-metrics normally once Juju runs it as a normal hook <Created by jameinel> <https://github.com/canonical/operator/issues/348> | 08:09 |
| mup | PR operator#349 opened: 347 juju storage and collect metrics <Created by jameinel> <https://github.com/canonical/operator/pull/349> | 09:00 |
| jam | morning Chipaca | 09:01 |
| Chipaca | jam: hiya | 09:01 |
| Chipaca | jam: how's things? | 09:02 |
| jam | Chipaca, relatively ok. personal stuff is progressing. | 09:02 |
| jam | https://github.com/canonical/operator/pull/349 is up | 09:02 |
| mup | PR #349: 347 juju storage and collect metrics <Created by jameinel> <https://github.com/canonical/operator/pull/349> | 09:02 |
| jam | though I'd like to understand scope of testing it | 09:02 |
| jam | I did put it in a real charm and test it | 09:02 |
| jam | and also figured out why my previous charm *didn't* fail | 09:02 |
| jam | Chipaca, it seems Juju doesn't call 'collect-metrics' if you don't have 'metrics.yaml' defined. | 09:02 |
| jam | see also #347 for the context of why I implemented it the way I did. | 09:03 |
| mup | Issue #347: use_juju_for_storage=True breaks if collect-metrics is in use <Created by jameinel> <https://github.com/canonical/operator/issues/347> | 09:03 |
| facubatista | Muy buenos dÃas a todos! | 10:35 |
| Chipaca | facubatista: (null) | 10:36 |
| Chipaca | hmmh | 10:36 |
| Chipaca | facubatista: 👋 ! | 10:36 |
| Chipaca | hexchat is dumb sometimes | 10:36 |
| facubatista | Chipaca, storm of Nones! | 10:36 |
| stub | So yeah, thought I had a problem with relative imports. But I just can't get ops.lib to import my package if __init__.py tries to import something else in the same package directory, relative or legacy syntax. And absolute won't work since I don't have an absolute module path. | 11:02 |
| Chipaca | stub: giving it a try here | 13:06 |
| Chipaca | stub: indeed it falls over | 13:15 |
| Chipaca | stub: the spec does have 'submodule_search_locations' set to the right thing so i need to dig further into why it isn't working | 13:27 |
| mup | PR operator#350 opened: Improve ops.lib line matching regexp <Created by jameinel> <https://github.com/canonical/operator/pull/350> | 14:16 |
| jam | Chipaca, facubatista https://github.com/canonical/operator/pull/350/files# tests added | 14:19 |
| mup | PR #350: Improve ops.lib line matching regexp <Created by jameinel> <https://github.com/canonical/operator/pull/350> | 14:19 |
| jam | which tells me we probably still need to tweak the regex | 14:19 |
| jam | it allows: LIBFOO='something'and some more stuff | 14:19 |
| jam | and treats the 'and some more stuff' as a comment | 14:19 |
| karimsye | I have been hitting this error: ops.model.ModelError: b'ERROR file set "data" requires volume source\n' | 14:43 |
| karimsye | https://www.irccloud.com/pastebin/7dXXTOnd/ | 14:44 |
| jam | Chipaca, facubatista : operator#349 | 15:21 |
| mup | PR #349: 347 juju storage and collect metrics <Created by jameinel> <https://github.com/canonical/operator/pull/349> | 15:21 |
| jam | is updated, just waiting on tests | 15:21 |
| Chipaca | jam: nice | 15:23 |
| jam | Chipaca, I also have #350, though I don't know if we want to land it. | 15:23 |
| mup | PR #350: Improve ops.lib line matching regexp <Created by jameinel> <https://github.com/canonical/operator/pull/350> | 15:23 |
| Chipaca | #346 is also updated fwiw | 15:23 |
| mup | PR #346: Improve ops.lib line matching regexp <Created by stub42> <https://github.com/canonical/operator/pull/346> | 15:23 |
| Chipaca | er | 15:23 |
| jam | Chipaca, and approved by me | 15:23 |
| Chipaca | not that one, t'other one, but yanno | 15:23 |
| jam | (your pr was approved by me, I knew what you meant :) | 15:24 |
| jam | I'm EOD, you can land whatever you feel relevant for 0.7 | 15:24 |
| jam | karimsye, is that metadata.yaml or the pod spec? | 15:24 |
| jam | I'm not positive, but quick reading of the validation code seems to say you'd want to be updating the pod spec with a source | 15:24 |
| jam | karimsye, probably more of a question for #juju | 15:25 |
| karimsye | jam: that is the metadata.yaml | 15:25 |
| karimsye | jam: thanks I will check with them | 15:25 |
| Chipaca | aha! | 15:35 |
| Chipaca | oho! | 15:35 |
| * Chipaca saw the gruffalo | 15:35 | |
| mup | Issue operator#351 opened: ops.lib.use does not support submodules <Created by chipaca> <https://github.com/canonical/operator/issues/351> | 15:44 |
| mup | PR operator#352 opened: make ops.lib.use support relative submodules <Created by chipaca> <https://github.com/canonical/operator/pull/352> | 15:48 |
| Chipaca | stub: ^ | 15:49 |
| * facubatista is back | 16:07 | |
| mup | Issue operator#347 closed: use_juju_for_storage=True breaks if collect-metrics is in use <Created by jameinel> <Closed by jameinel> <https://github.com/canonical/operator/issues/347> | 16:19 |
| mup | PR operator#349 closed: 347 juju storage and collect metrics <Created by jameinel> <Merged by jameinel> <https://github.com/canonical/operator/pull/349> | 16:19 |
| mup | PR operator#340 closed: make ops.lib.autoimport use optional <Created by chipaca> <Merged by chipaca> <https://github.com/canonical/operator/pull/340> | 18:51 |
| mup | PR operator#350 closed: Improve ops.lib line matching regexp <Created by jameinel> <Merged by chipaca> <https://github.com/canonical/operator/pull/350> | 19:25 |
| mup | Issue operator#341 closed: ops.lib fails to import packages with '-' in their metadata <Created by stub42> <Closed by chipaca> <https://github.com/canonical/operator/issues/341> | 19:26 |
| mup | PR operator#346 closed: Improve ops.lib line matching regexp <Created by stub42> <Closed by chipaca> <https://github.com/canonical/operator/pull/346> | 19:27 |
| Chipaca | facubatista: 'm afraid i need your eyes on #353 | 19:49 |
| mup | PR #353: don't use --long in "get describe" for version <Created by chipaca> <https://github.com/canonical/operator/pull/353> | 19:49 |
| mup | PR operator#353 opened: don't use --long in "get describe" for version <Created by chipaca> <https://github.com/canonical/operator/pull/353> | 19:49 |
| facubatista | Chipaca, let's see | 20:32 |
| facubatista | Chipaca, +1ed | 20:32 |
| facubatista | Chipaca, and I'm here for an hour or so, if you need something else | 21:12 |
| Chipaca | facubatista: ack, thanks | 21:38 |
| mup | PR operator#353 closed: don't use --long in "get describe" for version <Created by chipaca> <Merged by chipaca> <https://github.com/canonical/operator/pull/353> | 21:38 |
| === ChanServ changed the topic of #smooth-operator to: general discussion of the operator framework || github.com/canonical/operator || ops 0.7.0 || charmcraft 0.2.0 | ||
| Chipaca | facubatista: done :-D | 21:45 |
| facubatista | Chipaca, great!! | 21:48 |
| Chipaca | two more PRs coming up | 21:48 |
| mup | PR operator#354 opened: post-release fallback version bump <Created by chipaca> <https://github.com/canonical/operator/pull/354> | 21:50 |
| mup | PR operator#355 opened: readme tweaks (including link to the api docs) <Created by chipaca> <https://github.com/canonical/operator/pull/355> | 21:53 |
| Chipaca | facubatista: where's the handling/catching of the store sending the wrong data? ie in whoami we just do e.g. name=response['display-name'], which will throw a KeyError in our code rather than telling the user what the problem was. I _think_ you said you were abstracting that handling somewhere but i don't see it | 22:08 |
| facubatista | Chipaca, I still don't have it | 22:13 |
| facubatista | Chipaca, but I have this XXX in current branch, that will turn out in a filed issue before landing: | 22:13 |
| facubatista | # XXX Facundo 2020-06-30: Every time we consume data from the Store (after a succesful | 22:13 |
| facubatista | # call) we need to wrap it with a context manager that will raise UnknownError (after | 22:13 |
| facubatista | # logging in debug the received response). This would catch API changes, for example, | 22:13 |
| facubatista | # without making charmcraft to badly crash. | 22:13 |
| Chipaca | facubatista: 🙌 | 22:14 |
| Chipaca | facubatista: did a first pass on your current pr | 22:16 |
| Chipaca | and now i am going to 💤 | 22:16 |
| facubatista | Chipaca, see you tomorrow | 22:17 |
| Chipaca | facubatista: anything more i can do for you before disappearing in a clod of <deleted>? | 22:17 |
| facubatista | Chipaca, nop, relax, thanks! | 22:18 |
| Chipaca | 👋 :-) | 22:18 |
| * facubatista eods | 22:36 | |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!