[04:51] Issue operator#341 opened: ops.lib fails to import packages with '-' in their metadata [04:58] Issue operator#342 opened: ops.lib.autoload does not log what it is doing [05:03] PR operator#343 opened: Allow library metadata to include hyphens [05:35] Issue operator#344 opened: Cleaner error message when use_juju_for_storage is True wrt Juju 2.6 [06:05] Issue operator#345 opened: Harness could start with config initialized from config.yaml [06:09] PR operator#343 closed: Allow library metadata to include hyphens [06:09] PR operator#346 opened: Improve ops.lib line matching regexp [07:17] Issue operator#347 opened: use_juju_for_storage=True breaks if metrics are in use [08:09] Issue operator#348 opened: Support collect-metrics normally once Juju runs it as a normal hook [09:00] PR operator#349 opened: 347 juju storage and collect metrics [09:01] morning Chipaca [09:01] jam: hiya [09:02] jam: how's things? [09:02] Chipaca, relatively ok. personal stuff is progressing. [09:02] https://github.com/canonical/operator/pull/349 is up [09:02] PR #349: 347 juju storage and collect metrics [09:02] though I'd like to understand scope of testing it [09:02] I did put it in a real charm and test it [09:02] and also figured out why my previous charm *didn't* fail [09:02] Chipaca, it seems Juju doesn't call 'collect-metrics' if you don't have 'metrics.yaml' defined. [09:03] see also #347 for the context of why I implemented it the way I did. [09:03] Issue #347: use_juju_for_storage=True breaks if collect-metrics is in use [10:35] Muy buenos días a todos! [10:36] facubatista: (null) [10:36] hmmh [10:36] facubatista: 👋 ! [10:36] hexchat is dumb sometimes [10:36] Chipaca, storm of Nones! [11:02] So yeah, thought I had a problem with relative imports. But I just can't get ops.lib to import my package if __init__.py tries to import something else in the same package directory, relative or legacy syntax. And absolute won't work since I don't have an absolute module path. [13:06] stub: giving it a try here [13:15] stub: indeed it falls over [13:27] stub: the spec does have 'submodule_search_locations' set to the right thing so i need to dig further into why it isn't working [14:16] PR operator#350 opened: Improve ops.lib line matching regexp [14:19] Chipaca, facubatista https://github.com/canonical/operator/pull/350/files# tests added [14:19] PR #350: Improve ops.lib line matching regexp [14:19] which tells me we probably still need to tweak the regex [14:19] it allows: LIBFOO='something'and some more stuff [14:19] and treats the 'and some more stuff' as a comment [14:43] I have been hitting this error: ops.model.ModelError: b'ERROR file set "data" requires volume source\n' [14:44] https://www.irccloud.com/pastebin/7dXXTOnd/ [15:21] Chipaca, facubatista : operator#349 [15:21] PR #349: 347 juju storage and collect metrics [15:21] is updated, just waiting on tests [15:23] jam: nice [15:23] Chipaca, I also have #350, though I don't know if we want to land it. [15:23] PR #350: Improve ops.lib line matching regexp [15:23] #346 is also updated fwiw [15:23] PR #346: Improve ops.lib line matching regexp [15:23] er [15:23] Chipaca, and approved by me [15:23] not that one, t'other one, but yanno [15:24] (your pr was approved by me, I knew what you meant :) [15:24] I'm EOD, you can land whatever you feel relevant for 0.7 [15:24] karimsye, is that metadata.yaml or the pod spec? [15:24] I'm not positive, but quick reading of the validation code seems to say you'd want to be updating the pod spec with a source [15:25] karimsye, probably more of a question for #juju [15:25] jam: that is the metadata.yaml [15:25] jam: thanks I will check with them [15:35] aha! [15:35] oho! [15:35] * Chipaca saw the gruffalo [15:44] Issue operator#351 opened: ops.lib.use does not support submodules [15:48] PR operator#352 opened: make ops.lib.use support relative submodules [15:49] stub: ^ [16:07] * facubatista is back [16:19] Issue operator#347 closed: use_juju_for_storage=True breaks if collect-metrics is in use [16:19] PR operator#349 closed: 347 juju storage and collect metrics [18:51] PR operator#340 closed: make ops.lib.autoimport use optional [19:25] PR operator#350 closed: Improve ops.lib line matching regexp [19:26] Issue operator#341 closed: ops.lib fails to import packages with '-' in their metadata [19:27] PR operator#346 closed: Improve ops.lib line matching regexp [19:49] facubatista: 'm afraid i need your eyes on #353 [19:49] PR #353: don't use --long in "get describe" for version [19:49] PR operator#353 opened: don't use --long in "get describe" for version [20:32] Chipaca, let's see [20:32] Chipaca, +1ed [21:12] Chipaca, and I'm here for an hour or so, if you need something else [21:38] facubatista: ack, thanks [21:38] PR operator#353 closed: don't use --long in "get describe" for version === ChanServ changed the topic of #smooth-operator to: general discussion of the operator framework || github.com/canonical/operator || ops 0.7.0 || charmcraft 0.2.0 [21:45] facubatista: done :-D [21:48] Chipaca, great!! [21:48] two more PRs coming up [21:50] PR operator#354 opened: post-release fallback version bump [21:53] PR operator#355 opened: readme tweaks (including link to the api docs) [22:08] facubatista: where's the handling/catching of the store sending the wrong data? ie in whoami we just do e.g. name=response['display-name'], which will throw a KeyError in our code rather than telling the user what the problem was. I _think_ you said you were abstracting that handling somewhere but i don't see it [22:13] Chipaca, I still don't have it [22:13] Chipaca, but I have this XXX in current branch, that will turn out in a filed issue before landing: [22:13] # XXX Facundo 2020-06-30: Every time we consume data from the Store (after a succesful [22:13] # call) we need to wrap it with a context manager that will raise UnknownError (after [22:13] # logging in debug the received response). This would catch API changes, for example, [22:13] # without making charmcraft to badly crash. [22:14] facubatista: 🙌 [22:16] facubatista: did a first pass on your current pr [22:16] and now i am going to 💤 [22:17] Chipaca, see you tomorrow [22:17] facubatista: anything more i can do for you before disappearing in a clod of ? [22:18] Chipaca, nop, relax, thanks! [22:18] 👋 :-) [22:36] * facubatista eods