| * stephencheng[m] sent a long message: < https://matrix.org/_matrix/media/r0/download/matrix.org/UmJRfYpxKKIsZmUmAMaDKbmM > | 01:01 | |
| wallyworld | kelvinliu: here's a small vsphere fix https://github.com/juju/juju/pull/11800 | 02:44 |
|---|---|---|
| kelvinliu | looking now | 02:44 |
| kelvinliu | wallyworld: so this fix is to fix the workaround of /MyFolder/MyDC/vm/juju-root | 02:55 |
| kelvinliu | but not fix the vm-fold sets to `juju-root`, right? | 02:55 |
| wallyworld | kelvinliu: i used the same logic from their on site patch - it's just for handling a vmfolder that is not a subpath of the DC folder | 03:00 |
| kelvinliu | dcfolders.VmFolder.InventoryPath == /MyDC/vm but | 03:00 |
| kelvinliu | the real dc folder is /MyFolder/MyDC/ | 03:01 |
| wallyworld | yeah https://github.com/nobuto-m/juju/commit/26ab58c38fb3bc41905f8085c6939bc3628181b5 | 03:01 |
| kelvinliu | yeah, I know | 03:01 |
| kelvinliu | that's just a workaround | 03:01 |
| wallyworld | the vmfolder should be able to point anyhwere though right? | 03:02 |
| kelvinliu | with current fix, if the vmfold sets to juju-root, we will still get the error `folder path "/MyDC/vm/juju-root" not found` | 03:04 |
| wallyworld | so they need to set the vmfolder correctly | 03:04 |
| wallyworld | if an absolute path is needed, they should provide that | 03:05 |
| wallyworld | or no? | 03:05 |
| kelvinliu | $ govc find | grep juju-root | 03:05 |
| kelvinliu | /MyFolder/MyDC/vm/juju-root | 03:05 |
| kelvinliu | vsphere API thinks the dc fold is /MyDC/vm/juju-root | 03:06 |
| kelvinliu | I think this might be fix for their particular issue with the workaround, but we will need find why the API tells the wrong datacentre path | 03:08 |
| kelvinliu | wallyworld: so we will just ask them to test ur branch or? | 03:08 |
| wallyworld | kelvinliu: yeah, we can ask them to test th edge snap. i thought juju just appended "jju-root" to whatever the folder ended up as? | 03:10 |
| kelvinliu | yeah, that's what Juju does currently | 03:10 |
| kelvinliu | the problem here is the root DC fold was wrong in the API | 03:11 |
| wallyworld | so i think this will be ok - they have the option of a relative or absolute path, their choice | 03:11 |
| wallyworld | i don't know why the DC fold was wrong | 03:11 |
| kelvinliu | wallyworld: did u see petro's comment? | 03:12 |
| kelvinliu | It seems govmomi is not returning the entire absolute path with | 03:13 |
| wallyworld | i did see them but don't understand the api enough | 03:13 |
| kelvinliu | [/MyFolder/]MyDC/vm/juju-root | 03:13 |
| kelvinliu | wallyworld: just approved to allow them to test it. | 03:16 |
| wallyworld | sgtm ty | 03:16 |
| kelvinliu | ty for the fix | 03:18 |
| === ionutbalutoiu_ is now known as ionutbalutoiu | ||
| === mpontillo_ is now known as mpontillo | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!