| mup | PR snapcraft#3196 closed: cli: unset false boolean flags in environment <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3196> | 00:32 |
|---|---|---|
| === jamesh_ is now known as jamesh | ||
| mup | PR snapd#8973 opened: tests: moving journalctl.sh to a new journal-state tool <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/8973> | 04:25 |
| mborzecki | morning | 05:32 |
| mup | PR snapd#8870 closed: interfaces: add gconf interface <Needs Samuele review> <Reviewed> <Created by jdstrand> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/8870> | 06:41 |
| mup | PR snapd#8970 closed: tests: rename user-tool to user-state, fix --help <Simple 😃> <Created by zyga> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/8970> | 06:46 |
| pstolowski | mor ning | 07:05 |
| mborzecki | pstolowski: hey | 07:15 |
| mvo | good morning pstolowski | 07:15 |
| pstolowski | o/ | 07:15 |
| mborzecki | mvo: good morning to you too | 07:15 |
| mup | PR snapd#8971 closed: tests: rename lxd-tool to lxd-state <Simple 😃> <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/8971> | 07:16 |
| mvo | mborzecki: and to you :) | 07:16 |
| mborzecki | mvo: can you reopen https://github.com/snapcore/snapd/pull/8883 ? wanted to restart the spread jobs, but i can't reopen after closing it | 07:16 |
| mup | PR #8883: packaging: stop snapd early on purge <Test Robustness> <Created by mvo5> <Closed by bboozzoo> <https://github.com/snapcore/snapd/pull/8883> | 07:16 |
| mborzecki | mvo: oh w8, nvm, i can ;P | 07:16 |
| mborzecki | mvo: fwiw, the spread job was suprisingly green (?), wanted to double check if that's a fluke or that last commit actually changed the net effect of prerm | 07:19 |
| zyga-x240 | good morning | 07:19 |
| pstolowski | hey zyga-x240 ! online already? | 07:19 |
| zyga-x240 | hey | 07:20 |
| zyga-x240 | yeah, I'm waiting | 07:20 |
| pstolowski | got it | 07:20 |
| zyga-x240 | I'll be back again after 14-15 probably | 07:20 |
| zyga-x240 | I may be at the standup | 07:20 |
| pstolowski | zyga-x240: can you re-ack #8939? it got +1 from Jamie | 07:20 |
| mup | PR #8939: snap-confine: don't die if a device from sysfs path cannot be found by udev <Bug> <Needs security review> <Security-High> <Squash-merge> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8939> | 07:20 |
| zyga-x240 | yeah, let me look | 07:20 |
| mvo | mborzecki: oh, nice | 07:22 |
| mvo | mborzecki: keep me updated :) | 07:22 |
| zyga-x240 | pstolowski: +1 | 07:24 |
| pstolowski | ty | 07:24 |
| mup | PR snapd#8969 closed: tests: fix argument handling of apt-state <Created by zyga> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/8969> | 07:31 |
| pstolowski | mvo: i suppose we may want #8839 for a point release, in which case it's best to squash-merge? | 07:33 |
| mup | PR #8839: tests: add debug for 20.04 prepare failure <Test Robustness> <Created by mvo5> <Merged by zyga> <https://github.com/snapcore/snapd/pull/8839> | 07:33 |
| jamesh | alan_g: https://github.com/snapcore/snapd/pull/8699#issuecomment-653401466 | 07:48 |
| mup | PR #8699: interfaces/desktop-launch: support confined snaps launching other snaps <Needs Samuele review> <Needs security review> <Created by AlanGriffiths> <https://github.com/snapcore/snapd/pull/8699> | 07:48 |
| jamesh | ^^ I put together a simple spread test to get you started | 07:48 |
| mvo | pstolowski: 8839 the debug stuff? I don't think we need it for the point release I htink we know wha tis wrong | 07:50 |
| pstolowski | mvo: grr i meant #8939, sorry | 07:51 |
| mup | PR #8939: snap-confine: don't die if a device from sysfs path cannot be found by udev <Bug> <Needs security review> <Security-High> <Squash-merge> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8939> | 07:51 |
| mvo | pstolowski: oh, yeah, that for sure | 07:51 |
| mup | PR snapd#8939 closed: snap-confine: don't die if a device from sysfs path cannot be found by udev <Bug> <Needs security review> <Security-High> <Squash-merge> <Created by stolowski> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/8939> | 07:56 |
| mup | PR snapd#8974 opened: spread.yaml: remove tests/lib/tools from PATH <Created by zyga> <https://github.com/snapcore/snapd/pull/8974> | 08:06 |
| alan_g | jamesh, thanks. I'll try to get to it next week. (Depending how busy the sprint gets.) | 08:11 |
| mup | PR snapd#8975 opened: tests: shorten lxd-state undo-mount-changes <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/8975> | 08:16 |
| mup | PR snapd#8976 opened: snap-confine: don't die if a device from sysfs path cannot be found by udev (2.45) <Bug> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8976> | 08:26 |
| pstolowski | hmmm, ^ this fails against 2.45 with 'packaging/debian-sid/changelog:6:18: "miscellanious" is a misspelling of "miscellaneous | 08:38 |
| zyga-x240 | pstolowski: fix the typo :) | 08:38 |
| zyga-x240 | pstolowski: it's okay | 08:38 |
| pstolowski | zyga-x240: yeah, but same change just landed in master (and the typo is not in my PR) | 08:39 |
| zyga-x240 | yeah but if it's landing to a release branch it should be fixed there | 08:39 |
| zyga-x240 | not sure why it wasn't picked up before | 08:39 |
| pstolowski | ok | 08:39 |
| zyga-x240 | fixing masteri s also good | 08:39 |
| pstolowski | ok, master is good, the typo is only in 2.45 | 08:42 |
| pstolowski | pushed a fix to my PR | 08:43 |
| zyga-x240 | super, thank you :) | 08:44 |
| zyga-x240 | I've broken out another chunk of refresh-app-awareness https://github.com/snapcore/snapd/pull/8977 | 08:58 |
| mup | PR #8977: cmd/snap: track started apps and hooks <Created by zyga> <https://github.com/snapcore/snapd/pull/8977> | 08:58 |
| mup | PR snapd#8977 opened: cmd/snap: track started apps and hooks <Created by zyga> <https://github.com/snapcore/snapd/pull/8977> | 09:01 |
| mborzecki | mvo: https://github.com/snapcore/snapd/pull/8883 did not fail in prepare for the 2nd time in a row | 09:08 |
| mup | PR #8883: packaging: stop snapd early on purge <Test Robustness> <Created by mvo5> <https://github.com/snapcore/snapd/pull/8883> | 09:08 |
| mborzecki | errand, back in 1h | 09:09 |
| zyga-x240 | https://github.com/snapcore/snapd/pull/8975 needs a second review, +/- 13 lines | 09:26 |
| mup | PR #8975: tests: shorten lxd-state undo-mount-changes <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/8975> | 09:26 |
| zyga-x240 | and the super short https://github.com/snapcore/snapd/pull/8974 completes the tools transition | 09:29 |
| mup | PR #8974: spread.yaml: remove tests/lib/tools from PATH <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/8974> | 09:29 |
| zyga-x240 | pedronis: after ^ the README file needs changing, let me know if you want to do that yourself | 09:29 |
| * zyga-x240 goes to the doctor now | 09:34 | |
| zyga-x240 | see you later, if I make it back in time for the standup | 09:34 |
| mvo | mborzecki: nice | 09:49 |
| mborzecki | re | 10:17 |
| mborzecki | mvo: so https://github.com/snapcore/snapd/pull/8883 passed for the 3rd time, maybe it's the righ fix after all | 10:50 |
| mup | PR #8883: packaging: stop snapd early on purge <Test Robustness> <Created by mvo5> <https://github.com/snapcore/snapd/pull/8883> | 10:50 |
| mvo | mborzecki: nice! | 10:53 |
| mvo | mborzecki: yeah, let's go with it, we should probably squash it | 10:54 |
| mborzecki | mvo: will do | 10:54 |
| mvo | mborzecki: thank you! | 11:00 |
| mup | PR snapd#8975 closed: tests: shorten lxd-state undo-mount-changes <Simple 😃> <Created by zyga> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/8975> | 11:02 |
| ogra | regarding https://bugs.launchpad.net/snapd/+bug/1881588 ... | 11:05 |
| mup | Bug #1881588: pre-seeding lxd on Core appliances breaks console-conf user creation <id-5ef638e8ed708765e909cfe8> <snapd:Invalid by anonymouse67> <subiquity:In Progress | 11:05 |
| mup | by mwhudson> <subiquity (Ubuntu):Invalid> <subiquity (Ubuntu Xenial):Confirmed> <subiquity (Ubuntu Bionic):Confirmed> <https://launchpad.net/bugs/1881588> | 11:05 |
| ogra | what exactly makes snapd decide that a system is managed ? | 11:05 |
| ogra | i thought this only happens if "snap create-user" was used ? | 11:05 |
| ogra | (seems lxd simply calls useradd chrooted into /var/lib/snapd/hostfs at runtime ... which as i understand should not mark the system as managed) | 11:07 |
| pedronis | snap managed true means we have users in auth (over time it will mean other things), that's all there is to it | 11:10 |
| pedronis | as discussed in the bug there's just some confusion around it and what the console-conf logic does | 11:11 |
| pedronis | afaiu | 11:14 |
| ogra | ah, i always thought there is an extra setting | 11:15 |
| ogra | i.e. a flag the create-user sets | 11:15 |
| pedronis | no there's a flag for the reverse to let you create users even there are already some | 11:18 |
| ogra | well, the managed check should ignore users below UID 1000 i think | 11:18 |
| pedronis | there's no bug in snapd | 11:19 |
| pedronis | we don't check users on the system | 11:19 |
| pedronis | we check users only inside snapd | 11:19 |
| pedronis | there's just confusion | 11:19 |
| ogra | (the first non-system user definitely gets 1000) | 11:19 |
| ogra | hmm, k | 11:19 |
| pedronis | it's all based on len(auth.Users(state)), that code doesn't consider anything on disk, but the state in snapd | 11:21 |
| ogra | ok | 11:44 |
| mborzecki | mvo: with some commits dropped and others squashed it's passing again https://github.com/snapcore/snapd/pull/8883 (and needs reviews) | 12:24 |
| mup | PR #8883: packaging: stop snapd early on purge <Test Robustness> <Created by mvo5> <https://github.com/snapcore/snapd/pull/8883> | 12:24 |
| mvo | mborzecki: nice | 12:45 |
| zyga-x240 | re | 12:49 |
| zyga-x240 | back just in time | 12:49 |
| mup | PR snapcraft#3198 opened: snap: drop legacy, switch to core20 for bootstrap <Created by xnox> <https://github.com/snapcore/snapcraft/pull/3198> | 12:53 |
| zyga-x240 | cachio: https://github.com/snapcore/snapd/pull/8973#pullrequestreview-442392657 | 13:01 |
| mup | PR #8973: tests: moving journalctl.sh to a new journal-state tool <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/8973> | 13:01 |
| zyga-x240 | nice work! | 13:01 |
| mup | PR snapcraft#3195 closed: extensions: introduce flutter-master <enhancement> <specification> <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3195> | 13:08 |
| zyga-x240 | https://github.com/snapcore/snapd/pull/8974 is green, it's super short and completes the tool transition | 13:21 |
| mup | PR #8974: spread.yaml: remove tests/lib/tools from PATH <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/8974> | 13:21 |
| zyga-x240 | mborzecki: https://www.raspberrypi.org/documentation/configuration/config-txt/conditional.md | 13:26 |
| zyga-x240 | mborzecki: pi bootloader has support for gpio directly | 13:26 |
| zyga-x240 | mborzecki: perhaps we could use that as well | 13:26 |
| mborzecki | zyga-x240: yeah, dave pointed me to that doc too | 13:26 |
| zyga-x240 | specifically, you can make decisions on those | 13:26 |
| mborzecki | zyga-x240: need to do some reding, but we still may need to go through uboot for the extra integration we do with snapd | 13:26 |
| pedronis | mvo: sorry, battery got empty (though it was telling me I had a few more minutes) | 13:41 |
| mvo | pedronis: no worries | 13:43 |
| mvo | pedronis: we just finished anyway, I was just rambling | 13:43 |
| * zyga-x240 is sorry for shaking the laptop so much, 90C is really hot | 13:43 | |
| * zyga-x240 reboots to fix touchpad | 13:56 | |
| zyga-x240 | re | 14:14 |
| zyga-x240 | again, fridge helps :) | 14:14 |
| zyga-x240 | pstolowski: https://github.com/snapcore/snapd/pull/8960 nice commit message | 15:08 |
| mup | PR #8960: o/snapstate,servicestate: use service-control task for service actions (9/9) <Needs Samuele review> <Services ⚙️> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8960> | 15:08 |
| pstolowski | zyga-x240: thanks, trying to help as much as possible with reviews ;) | 15:12 |
| zyga-x240 | :) | 15:12 |
| === mpontillo_ is now known as mpontillo | ||
| mup | PR snapcraft#3199 opened: extensions: introduce flutter-dev <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3199> | 15:54 |
| * zyga-x240 needs a coffee | 15:54 | |
| cachio | /me lunch | 16:21 |
| mup | PR snapcraft#3200 opened: flutter v1 plugin: pull from source-subdir if set <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3200> | 19:14 |
| mvo | sil2100: sorry for bothering you with snapd SRU topics, but AIUI the validations is fully done and I wonder if we can release snapd to -updates? maybe monday (I understand friday is a bad time) | 19:17 |
| mup | PR snapcraft#3199 closed: extensions: introduce flutter-dev <enhancement> <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3199> | 22:40 |
| mup | PR snapd#8978 opened: secboot: update tpm connection error handling <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/8978> | 22:59 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!