=== ec0_ is now known as ec0
[09:32] <stickupkid> achilleasa, CR if you're around? fixes your concerns around reading stdin https://github.com/juju/juju/pull/11796
[09:34] <achilleasa> stickupkid: looking
[10:38] <achilleasa> stickupkid: got more questions
[10:39] <stickupkid> achilleasa, because it's expected to use the very annoying options in the command
[10:40] <stickupkid> achilleasa, that parseOneArg does more than you think
[10:43] <stickupkid> achilleasa, also your code - os.Stdin isn't an io.Reader
[10:45] <achilleasa> it's not?
[10:45] <achilleasa> it should be an *os.File
[10:46] <stickupkid> let me try
[10:47] <achilleasa> stickupkid: so, does the ignoreagentversion bit also work for stdin inputs? I am confused :D
[10:47] <stickupkid> achilleasa, works for everything
[10:53] <stickupkid> achilleasa, if you don't add the ignore flag you get this error message
[10:53] <stickupkid> juju model-config --format=yaml | juju model-config -
[10:53] <stickupkid> ERROR "agent-version"" must be set via "upgrade-model"
[10:58] <stickupkid> achilleasa, you free for a sec?
[11:00] <achilleasa> stickupkid: sure; meet you in daily
[11:41] <zeestrat> Hey Juju folks, I have an existing model (v 2.5.8) with MAAS backend where I just added a new AZ and machines in that AZ but when I try to deploy new units it fails when provisioning as it does not recognise the new AZ and the machines in it. I tried `juju update-cloud <nameofmymaascloud>` but that didn't do the trick. How do I get Juju to recognise/update AZs from MAAS?
[11:42] <stickupkid> achilleasa, ^ that's reload spaces right?
[11:43] <zeestrat> I presumed reload spaces only reload the network spaces from MAAS and not the AZ?
[11:48] <achilleasa> stickupkid: I think that reload-spaces only refreshes subnets and spaces. Not sure about AZs though
[11:48] <stickupkid> yeah, that's why I asked, I'm not sure either
[11:48] <manadart_> zeestrat: We are working on independent modelling of AZs this cycle, but at present AZs are stored as part of subnet data, which is discovered during `reload-spaces`.
[11:50] <manadart_> zeestrat: If that does not work, it might be a MAAS provisioning bug.
[11:50] <zeestrat> manadart_: I see. I'll give it a try. Thank you. P.S Is there a way to inquire what AZs juju knows about?
[11:51] <manadart_> zeestrat: That is precisely the work we have on the table, including notification when a new one becomes available :)
[11:51] <zeestrat> manadart_: Great :) Any bugs or PRs I can subscribe to to follow along?
[12:01] <zeestrat> manadart_: Unfortunately it looks like `reload-spaces` didn't do the trick.
[12:02] <manadart_> zeestrat: Got some logs you can put in a pastebin?
[12:14] <zeestrat> manadart_: I tried scouring the machine logs, but not a lot to find. Here's what I have: https://paste.ubuntu.com/p/QhzdvNwBs7/ Let me know if there is something else I should look at
[12:21] <manadart_> zeestrat: I need to look at the (old ;)) 2.5 code to get the real work on this. But have you tried using placement instead of a constraint? I.e. `--to zone=x`.
[12:31] <zeestrat> manadart_: Much appreciated! Yes, I tried `juju deploy ubuntu ubuntu --to zone=hcc-dev-rack4` for example, but that just hangs on pending: https://paste.ubuntu.com/p/MDWhGt5tPh/
[12:47] <manadart_> zeestrat: Are you running HA?
[12:48] <zeestrat> manadart_: If you mean HA controllers, yes, 3x.
[12:49] <manadart_> zeestrat: OK, so what you need to do is restart each of the controller machine agents.
[12:49] <manadart_> zeestrat: This is a bug in the provisioner, which has a cache of distribution groups for distributing new machines across AZs.
[12:50] <manadart_> zeestrat: So as per the cycle work, we need to make it aware of the fact that new AZs can come online.
[12:50] <manadart_> I replicated your situation and restarting my controller fixed it.
[12:52] <zeestrat> manadart_: I can work with that :) Is the `reload-spaces` still required in addition to the restarts?
[12:52] <manadart_> zeestrat: No.
[12:53] <manadart_> zeestrat: If you create a bug for this, I'll triage it and add it to the feature task list.
[12:54] <zeestrat> manadart_: Gotcha, will do. I'll give it a spin in dev here just to check. Thank you very much for digging in! (And apologies for the old version. Had this one since 2.0 and we're slowly catching up)
[12:55]  * manadart_ nods.
[13:15] <zeestrat> manadart_: Worked as a charm in dev, thanks again! For writing up the issue, is it a general provisioner issue or limited to HA and/or MAAS?
[13:15] <manadart_> zeestrat: Glad you're up. It's a general provisioner error.
[13:51] <zeestrat> manadart_: Created https://bugs.launchpad.net/juju/+bug/1886666 Please edit as you see fit.
[13:51] <mup> Bug #1886666: juju 2.5.8 does not recognise new AZs created in cloud after deployment of controller <juju:New> <https://launchpad.net/bugs/1886666>
[13:52] <manadart_> zeestrat: Great, thanks.
[14:44] <jam> stickupkid, thanks for the review
[14:44] <stickupkid> jam, nps
[16:16] <manadart_> achilleasa: Got time to look at some more link-layer mechanics? https://github.com/juju/juju/pull/11807
[16:20] <achilleasa> manadart_: looking
[16:27] <achilleasa> manadart_: got a small nit about DocID(). Take a look at my comment and let me know what you think
[16:56] <stickupkid> hml, I updated my PR to rename charm to entity
[16:56] <hml> stickupkid: ack
[16:57] <stickupkid> hml, but I left the json tag for the client as "charm" so it will still work with their API
[16:57] <hml> :-)
[16:57] <stickupkid> see here https://github.com/juju/juju/pull/11793/commits/a0a9060221f382d83648a63427d513094114b543#diff-0c3b53c2399932098ef150096b7df011R15
[16:57] <hml> stickupkid: i’ve started working on the review
[16:58] <stickupkid> i'm still unsure if we want an entity or a charm or bundle type.
[16:58] <stickupkid> but for now let's do this
[16:58] <hml> stickupkid: in my rework of where info convert is done… i used entity inside the apiserver, charm/bundle outside
[17:14] <manadart_> achilleasa: Replied to your comment. Have to head home now, so will look tomorrow.