| mborzecki | morning | 05:27 |
|---|---|---|
| pedronis | mborzecki: hi, I would appreciate reviews for #8907 and #8984 | 06:39 |
| mup | PR #8907: asserts: implement Database.FindSequence <validation-sets :white_check_mark:> <Created by pedronis> <https://github.com/snapcore/snapd/pull/8907> | 06:39 |
| mup | PR #8984: asserts: integer headers: disallow prefix zeros and make parsing more uniform <validation-sets :white_check_mark:> <Created by pedronis> <https://github.com/snapcore/snapd/pull/8984> | 06:39 |
| mborzecki | pedronis: hi, will do | 06:40 |
| pedronis | thx | 06:42 |
| pstolowski | morning | 07:03 |
| mborzecki | mvo: pedronis: sent out the tiny spec for uc20 recovery on rpi, please take a look | 07:11 |
| mborzecki | pedronis: mvo: i'll write down something similar about grub.cfg command line and share it with you guys | 07:12 |
| pedronis | mborzecki: ok, I'll see when I can look at it | 07:15 |
| pedronis | pstolowski: hi, #8907 needs a review, I also made #8984 | 07:15 |
| mup | PR #8907: asserts: implement Database.FindSequence <validation-sets :white_check_mark:> <Created by pedronis> <https://github.com/snapcore/snapd/pull/8907> | 07:15 |
| mup | PR #8984: asserts: integer headers: disallow prefix zeros and make parsing more uniform <validation-sets :white_check_mark:> <Created by pedronis> <https://github.com/snapcore/snapd/pull/8984> | 07:15 |
| pstolowski | pedronis: hi, will review today | 07:16 |
| mvo | mborzecki: thank you | 07:19 |
| === pedronis_ is now known as pedronis | ||
| zyga | good morning | 07:51 |
| zyga | sorry for starting late, I woke up very early due to pain and then tired to sleep again after taking painkillers | 07:52 |
| mup | PR core18#159 closed: 030-fix-timedatectl.chroot: fix quoting issues <Created by mvo5> <Merged by sil2100> <https://github.com/snapcore/core18/pull/159> | 08:41 |
| zyga | drat, lucy just walked over the keyboard and sigquit spread | 09:31 |
| pstolowski | zyga: haha | 09:52 |
| zyga | what are the chances... | 09:54 |
| * zyga is debugging some weird failures | 09:57 | |
| zyga | mborzecki: something weird is going on in feature/track-launched-apps on tumbleweed | 10:06 |
| zyga | on master that test passes | 10:07 |
| zyga | on the feature branch it fails | 10:07 |
| zyga | as if making the transient scope actually affected the existing tracking using the pid cgroup | 10:07 |
| zyga | but why only on tumbleweed? | 10:07 |
| * zyga investigates | 10:07 | |
| zyga | maybe they moved to cgroupv2? | 10:08 |
| zyga | notably the test does not fail in the big branch where we use the new information for the same decision | 10:08 |
| zyga | so maybe ...? | 10:08 |
| zyga | baaah | 10:25 |
| zyga | and now it passes | 10:25 |
| zyga | what the heck?! | 10:25 |
| * zyga thinks and tries to drink coffee | 10:26 | |
| mborzecki | ok, docs updated, now onto the reviews | 10:34 |
| * sdhd-sascha Ooh, too much beer yesterday | 10:35 | |
| zyga | mborzecki: thanks | 10:36 |
| mborzecki | zyga: can you review https://github.com/snapcore/snapd/pull/8883 ? | 11:01 |
| mup | PR #8883: packaging: stop snapd early on purge <Test Robustness> <Created by mvo5> <https://github.com/snapcore/snapd/pull/8883> | 11:01 |
| zyga | mborzecki: after the call | 11:07 |
| zyga | mborzecki: https://github.com/snapcore/snapd/pull/8883/checks?check_run_id=845292346 fails | 11:22 |
| mup | PR #8883: packaging: stop snapd early on purge <Test Robustness> <Created by mvo5> <https://github.com/snapcore/snapd/pull/8883> | 11:22 |
| mborzecki | uh, 14.40 | 11:23 |
| mborzecki | pff fun | 11:23 |
| zyga | re | 12:02 |
| zyga | mborzecki: ping me when ready | 12:02 |
| zyga | I'm debugging something related to old tracking | 12:02 |
| ijohnson|sprint | mborzecki: took a real quick look at your doc | 12:03 |
| mborzecki | ijohnson|sprint: hey, thanks | 12:13 |
| zyga | eh, I add logging and now it passes | 12:31 |
| zyga | there must be something racy there | 12:31 |
| zyga | all right, it failed now | 12:32 |
| zyga | ahh, I have a feeling I know what's wrong | 12:34 |
| zyga | mborzecki: heh, start transient scope keeps on giving | 12:57 |
| * zyga thinks | 12:57 | |
| zyga | thinks it's time to join the call | 12:58 |
| mborzecki | heh ;) | 12:58 |
| mup | PR snapd#8986 opened: tests: new snaps-state command - part1 <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/8986> | 13:03 |
| ijohnson|sprint | zyga: I managed to fix my layout verification PR, it was as expected to use Layout.Path instead of the key in the map | 13:13 |
| zyga | thanks! | 13:13 |
| mvo | ondra: hey, I played with the latest go which has some linker improvements - the snap-bootstrap binary is down from 11mb stripped to 7.7mb stripped. so low mem snapd looks more feasible | 13:42 |
| * zyga break for meds and some rest | 13:59 | |
| * cachio lunch | 15:37 | |
| pstolowski | cachio: +1 for your 'run nested' pr, please ping someone for 2nd review | 15:55 |
| cachio | Psi-Jack, thanks | 16:38 |
| Psi-Jack | What? | 16:38 |
| ogra | just take the credit, don't complain ... | 16:55 |
| cachio | Psi-Jack, sorry, was pstolowski but he quited | 16:55 |
| Psi-Jack | lol | 16:56 |
| cachio | Psi-Jack, I think it is the seconds time I do the same | 16:56 |
| cachio | hehe | 16:56 |
| Psi-Jack | Yep! | 16:57 |
| * zyga tested 16.04 and 18.04 and systemd is not racy there | 17:16 | |
| zyga | trying 20.04 and adding workaround in software on our side | 17:16 |
| zyga | 20.04 also passes, trying 20.10 which should be close to sid | 17:28 |
| zyga | but this suggests either a regression in systemd | 17:28 |
| zyga | or a "feature" | 17:28 |
| zyga | 20.10 testing now.. | 17:44 |
| zyga | amd it seems to pass | 17:44 |
| zyga | maybe we have patches in systemd | 17:44 |
| zyga | jdstrand: ^ more tracking mystery | 17:44 |
| zyga | going to test debian-9 vs sid | 17:47 |
| sdhd-sascha | hey people, i really regret my level of alcohol, yesterday ;-) sorry ;-) | 17:53 |
| ogra | it was rather obvious 🙂 | 17:54 |
| sdhd-sascha | ogra: thank you ;-) i try to go another way in future ;-) | 17:57 |
| sdhd-sascha | did anybody mention the birds, and there song's? here in bavaria, they decrease volume. Then after lockdown they increase there songs... And now, they have learn both ;-) | 18:01 |
| zyga | hmm, debian, even sid does not fail, so it is really just tumbleweed or was my sample size too small | 18:08 |
| mup | PR snapd#8907 closed: asserts: implement Database.FindSequence <validation-sets :white_check_mark:> <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/8907> | 18:09 |
| sdhd-sascha | ogra: i share your love for graph-algos . But didn't have a hint how to optimize it?! | 18:09 |
| cachio | zyga, hi | 18:10 |
| zyga | cachio: hi | 18:11 |
| cachio | I was checking and to run shellcheck on tools tests we need to install the shellcheck snap | 18:11 |
| cachio | but for that we need to have the snap command available | 18:11 |
| cachio | zyga, does it make sense? | 18:11 |
| zyga | cachio: yes, I ran into this myself, it's not fortunate but perhaps unavoidable | 18:12 |
| cachio | zyga, currently we prepare the suite with --prepare-suite-each-minimal-no-snaps | 18:12 |
| zyga | cachio: alternatively, don't install it | 18:12 |
| zyga | cachio: but install it only on one system | 18:12 |
| zyga | cachio: and run shellcheck e.g. only on ubuntu 20.04 | 18:12 |
| zyga | this way we test on more systems | 18:12 |
| zyga | and shellcheck at least once | 18:12 |
| zyga | note that that suite does not have full snapd ready | 18:12 |
| zyga | so it may not be possible to install snaps | 18:13 |
| cachio | but then we also need to have snap to test the snaps tool that I just created | 18:13 |
| sdhd-sascha | ooh, just a "deb" problem ? or others have that too? | 18:13 |
| cachio | zyga, but for that I could install snapd and then purge | 18:13 |
| zyga | cachio: hmmm | 18:14 |
| zyga | cachio: perhaps the snap helper needs different strategy | 18:14 |
| zyga | cachio: for generic helpers I would not install snapd | 18:14 |
| zyga | cachio: perhaps the snap helper needs to live in main | 18:14 |
| zyga | (as in tests) | 18:14 |
| mup | PR snapd#8984 closed: asserts: integer headers: disallow prefix zeros and make parsing more uniform <validation-sets :white_check_mark:> <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/8984> | 18:14 |
| cachio | zyga, you need the test | 18:14 |
| sdhd-sascha | cachio: i love purge... But there was a AI, which should sort a list. The AI has won, with purging the complete list ;-) | 18:14 |
| cachio | zyga, so I'll move the test to main in that case | 18:15 |
| zyga | cachio: I think that's better | 18:15 |
| cachio | zyga, good | 18:15 |
| zyga | thanks! | 18:16 |
| zyga | what's the name of the tool btw? | 18:16 |
| cachio | snaps-state | 18:17 |
| ogra | schnaps-state ... | 18:18 |
| cachio | zyga, but it could change | 18:18 |
| zyga | cachio: do you want it to be on PATH? | 18:18 |
| zyga | cachio: note that the naming rules differ between the two | 18:18 |
| cachio | zyga, no | 18:18 |
| cachio | just to be on path when we debug | 18:18 |
| zyga | ok | 18:18 |
| zyga | hmm? | 18:18 |
| zyga | how would that work? | 18:18 |
| cachio | I'll use it like $TESTSTOOLS"/snap-state | 18:19 |
| cachio | so it should be fine | 18:19 |
| zyga | I see | 18:19 |
| zyga | if you want it on path it could be called tests.snap or something like that | 18:20 |
| zyga | I think that's okay too | 18:20 |
| zyga | no strong opinion either way | 18:20 |
| cachio | ok, so far it is ok | 18:24 |
| cachio | having this "$TESTSTOOLS"/snap-state is it ok | 18:24 |
| cachio | zyga, also we could have a test targeted to ubuntu-18.04 which runs shellcheck for all the bash files in tools | 18:30 |
| zyga | cachio: I think we kind of do that already (perhaps) via run-checks but yeah | 18:31 |
| zyga | but I really prefer each tool test to check itself | 18:31 |
| zyga | then it's obvious | 18:31 |
| cachio | ok | 18:31 |
| sdhd-sascha | zyga: cachio: hey, at high-level language, it's possible to write once, and work everywhere ;-) | 18:31 |
| * sdhd-sascha short afk | 18:33 | |
| mup | PR snapcraft#3205 opened: spread tests: higher timeout for extension tests <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3205> | 18:56 |
| zyga | jdstrand: o/ | 19:15 |
| zyga | jdstrand: some weird news | 19:15 |
| zyga | https://github.com/snapcore/snapd/pull/8977#issuecomment-655057400 | 19:15 |
| mup | PR #8977: cmd/snap: track started apps and hooks <Created by zyga> <https://github.com/snapcore/snapd/pull/8977> | 19:15 |
| zyga | at this rate systemd will remove the API before it becomes reliable and we can merge it | 19:16 |
| mup | PR snapd#8957 closed: tests: improve nested tests flexibility <Created by mvo5> <Merged by cmatsuoka> <https://github.com/snapcore/snapd/pull/8957> | 19:25 |
| zyga | jdstrand: FYI https://github.com/snapcore/snapd/pull/8977/commits/e2a21fbb16000ec87632f7f34a860d121933e1e9 | 19:32 |
| mup | PR #8977: cmd/snap: track started apps and hooks <Created by zyga> <https://github.com/snapcore/snapd/pull/8977> | 19:32 |
| mup | PR snapcraft#3206 opened: tests: add missing asserts to python unit tests <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3206> | 19:51 |
| zyga | jdstrand: if you are keeping track, the patch to read is https://github.com/snapcore/snapd/pull/8977/commits/ee673c8a06c7f57e3a030bcf721c6d340e987303 | 19:54 |
| mup | PR #8977: cmd/snap: track started apps and hooks <Created by zyga> <https://github.com/snapcore/snapd/pull/8977> | 19:54 |
| cachio | zyga, updated #8949, #8950 and #8973 | 19:58 |
| mup | PR #8949: tests: new fs-state which replaces the files.sh helper <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/8949> | 19:58 |
| mup | PR #8950: tests: new str-tool which replaces the strings.sh helper <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/8950> | 19:58 |
| mup | PR #8973: tests: moving journalctl.sh to a new journal-state tool <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/8973> | 19:58 |
| lawl | hey, i'm trying to debug what i think is a race condition in snapd/ the pulseaudio snap-policy module. rebuilding a package with debug code everytime would be incredibly annoying though. So what i'm trying now is to start my app and then enter the sandbox with `nsenter` to give myself a shell in the snap application namespaces. | 19:59 |
| lawl | However when I run `pacmd` i get `No PulseAudio daemon running, or not running as session daemon.`, any ideas how to better debug this/provide a simple repro? | 19:59 |
| zyga | lawl: note that this is isufficient | 19:59 |
| zyga | the namespace is not the whole sandbox | 19:59 |
| zyga | if you want to be in the sandbox use snap run --shell | 19:59 |
| zyga | in addition, many wrappers "patch" the environment for things that are in different location | 19:59 |
| zyga | one such thing is the location of the pulse socket | 19:59 |
| zyga | there's a bug tracking that | 20:00 |
| zyga | in practice the socket is in $XDG_RUNTIME_DIR/.. | 20:00 |
| zyga | hope that hepls | 20:00 |
| zyga | *helps | 20:00 |
| lawl | yeah, XDG_RUNTIME_DIR was empty, i checked, i'll try `snap run --shell`, thanks | 20:00 |
| lawl | ugh, it seems `pacmd` checks for a PID file and errors because it doesn't find it, that's annoying. | 20:07 |
| zyga | if that helps look at snapd tree | 20:08 |
| zyga | at tests/main/interfaces-pulseaudio/task.yaml | 20:08 |
| lawl | nope, really seems to be a specific check in `pacmd` that's failing, test doesn't seem to call `pacmd`. | 20:13 |
| lawl | I'll figure something out. | 20:13 |
| jdstrand | zyga: sorry, sprinting, but erf | 20:13 |
| jdstrand | zyga: is there an upstream bug? | 20:13 |
| lawl | Or, actually, can anyone point me to the pulseaudio `module-snap-policy`? I've tried google the source but couldn't find it, patching that with debug output might actually be easier | 20:16 |
| zyga | jdstrand: I didn't file one yet | 20:27 |
| zyga | jdstrand: but it looks like it | 20:27 |
| zyga | lawl: most likely in pulseaudio deb in ubuntu | 20:27 |
| zyga | lawl: 0700-modules-add-snappy-policy-module.patch | 20:28 |
| zyga | pastebin https://paste.ubuntu.com/p/GKMcz9ZPKj/ | 20:28 |
| lawl | ah, thanks! | 20:29 |
| mup | PR snapcraft#3205 closed: spread tests: higher timeout for extension tests <tooling> <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3205> | 20:31 |
| lawl | ahh, there we have it `snapd_client_get_snap_async` in `check_access`. it fetching access permissions async and not receiving them fast enough would explain exactly what i'm seeing | 20:31 |
| jdstrand | lawl: there are a couple of patches | 20:35 |
| jdstrand | one for the infra to do the mediation and one for the policy, iirc | 20:35 |
| * jdstrand gets url | 20:35 | |
| lawl | i see hi jdstrand btw. we already talked briefly on the forums about classic mode :) | 20:36 |
| lawl | i'm pretty sure the patch already linked is one one causing the issue, as i also see `AppArmor profile could not be retrieved.` spammed in the logs, which seems to come from this patch | 20:38 |
| jdstrand | lawl: ah, ok. if it isn't working for you, I suggest filing a bug at https://bugs.launchpad.net/ubuntu/+source/pulseaudio/+filebug | 20:42 |
| lawl | i can file a bug, but i don't have a small repro, i can provide my packaged snap i suppose | 20:43 |
| lawl | but i was hoping to provide a minimal repro | 20:43 |
| * jdstrand nods | 20:43 | |
| jdstrand | 'AppArmor profile could not be retrieved' is from a call to aa_gettaskcon(client->creds.pid, &context, NULL) | 20:46 |
| jdstrand | the error handling isn't looking at errno (it would be nice if the pa_log_error() included that) | 20:47 |
| lawl | yeah, so the bug is that PA reports permission denied and it spams this apparmor log the first time i start my snap after snapd is restarted or the system reboots | 20:48 |
| jdstrand | http://manpages.ubuntu.com/manpages/focal/man2/aa_getcon.2.html show the error conditions | 20:48 |
| lawl | i'll play around a bit with the patch to confirm my suspicions from glancing over the source in a VM tmrw and then file a bug | 20:49 |
| jdstrand | lawl: a description of the problem in a bug and saying you'll try to find a simple reproducer might be enough. jamesh may be able to spot the issue from a good description | 20:50 |
| jdstrand | cool, thanks! | 20:50 |
| jdstrand | the more info the better :) | 20:50 |
| ijohnson|sprint | cmatsuoka: did you want to review https://github.com/snapcore/snapd/pull/8956 ? it has 2 +1s and is green so I'm inclined to merge it :-) | 20:51 |
| mup | PR #8956: tests/core/gadget-update-pc: port to UC20 <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8956> | 20:51 |
| sdhd-sascha | It is not the software. And it is not the Hardware. It is bptj& | 20:52 |
| cmatsuoka | ijohnson|sprint: go ahead, I read it and don't have further comments | 21:18 |
| ijohnson|sprint | cmatsuoka: ack | 21:20 |
| cmatsuoka | in fact I should have approved it a few days ago, I probably closed the browser tab and didn't return | 21:22 |
| mup | PR snapd#8956 closed: tests/core/gadget-update-pc: port to UC20 <UC20> <Created by bboozzoo> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/8956> | 21:25 |
| mup | PR snapcraft#3204 closed: Improvements to the flutter plugin <bug> <Created by kenvandine> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3204> | 22:36 |
| mup | PR snapcraft#3206 closed: tests: add missing asserts to python unit tests <bug> <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3206> | 22:36 |
| === boistordu1 is now known as boistordu | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!