| === hazmat_ is now known as hazmat | ||
| kelvinliu | hpidcock: or tlm a small pr for python linting enhancement, +1 plz https://github.com/juju/juju/pull/11811 | 05:47 |
|---|---|---|
| hpidcock | kelvinliu: looking | 05:47 |
| kelvinliu | ty | 05:47 |
| hpidcock | kelvinliu: LGTM | 05:48 |
| tlm | cheers kelvinliu | 05:48 |
| kelvinliu | ty4rv | 05:49 |
| stickupkid | manadart_, CR if you've got a chance... trying to correctly model a charm so we can use that information with the refresh API that's upcoming - https://github.com/juju/charm/pull/311 | 10:12 |
| manadart_ | stickupkid: Yep, will look in a mo'. | 10:13 |
| achilleasa | manadart_: any particular reason for having ListSubnects (api/subnets) return a V1 result whereas the SubnetsByCIDR returns a V2 result? | 10:29 |
| achilleasa | I want to build a subnet ID -> CIDR map and ListSubnets does not return the ID back :-( | 10:30 |
| manadart_ | achilleasa: Doesn't appear to be any reason other than the new API version came after subnet ID was added, and prior use of the command did not use the ID. | 10:39 |
| achilleasa | manadart_: so I can simply just change the payload without really having to bump anything, right? It's a new field that nothing (except the new spike bits) will be using | 10:40 |
| manadart_ | stickupkid achilleasa: I guess technically we should bump the version for a new return type, but it is only additive... | 10:40 |
| achilleasa | it could cause issues with the python bits though... | 10:41 |
| stickupkid | achilleasa, manadart_ so maybe | 10:45 |
| stickupkid | depends, if it's purely addative, then you *can* get away with it | 10:46 |
| achilleasa | manadart_: hmmm... so the firewall worker does not have permission to list subnets. Does this mean that I need to copy the list subnets functionality in its facade? | 11:16 |
| achilleasa | oh wait. I might be using the wrong api connection here | 11:16 |
| achilleasa | nope... btw, where does the model manifold execute? The controller? | 12:06 |
| manadart_ | stickupkid achilleasa: Need a review: https://github.com/juju/juju/pull/11812 | 13:24 |
| stickupkid | manadart_, https://github.com/juju/juju/pull/11812#discussion_r452227586 | 13:45 |
| hml | stickupkid: fixing the merge conflicts between your change and mine is going to be fun. :-). git is not doing a great job of it. | 13:46 |
| stickupkid | 3 way merges never are | 13:46 |
| stickupkid | hml, ping when you do have 5 minutes | 13:47 |
| hml | stickupkid: ack | 13:47 |
| manadart_ | stickupkid: Thanks. Fixed the mask sig and the logging. | 13:51 |
| hml | stickupkid: daily? | 14:09 |
| manadart_ | stickupkid: https://github.com/juju/juju/pull/11813 merges that one patch forward. | 15:16 |
| manadart_ | achilleasa: Mechanical: https://github.com/juju/juju/pull/11814 | 15:34 |
| achilleasa | manadart_: done | 15:39 |
| manadart_ | achilleasa: Thanks. | 15:39 |
| === thedac_ is now known as thedac | ||
| === sadin999_ is now known as sadin999 | ||
| === arif-ali_ is now known as arif-ali | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!