| manadart_ | achilleasa: Forward merge of the gateway patch - https://github.com/juju/juju/pull/11817 | 09:27 |
|---|---|---|
| achilleasa | manadart_: looking | 09:28 |
| stickupkid | achilleasa, manadart_ CR https://github.com/juju/description/pull/83 | 11:01 |
| achilleasa | stickupkid: got a question around typed nils | 11:09 |
| stickupkid | achilleasa, no idea, i copied and pasted | 11:09 |
| stickupkid | I did wonder about that | 11:09 |
| stickupkid | I don't mind removing it, it's just seems convention, similarly to the HORRID underscore usage in the variable names | 11:13 |
| stickupkid | @achilleasa, ^ | 11:13 |
| stickupkid | hml, this wasn't as painful as I was expecting https://github.com/juju/juju/pull/11818 | 11:45 |
| hml | stickupkid: nice. | 11:46 |
| hml | stickupkid: i have one up for you when you’re back | 11:46 |
| hml | stickupkid: https://github.com/juju/juju/pull/11816 | 11:46 |
| manadart_ | achilleasa: Real small address additions - https://github.com/juju/juju/pull/11819 | 13:35 |
| stickupkid | hml, so the reason for the storeurl is for json and yaml (real) output | 13:51 |
| stickupkid | hml, as a link back to original content | 13:51 |
| stickupkid | hml, this isn't the download url | 13:51 |
| hml | stickupkid: okay on one, you lost me on 3. HO? | 13:53 |
| stickupkid | sure | 13:53 |
| manadart_ | achilleasa: https://github.com/juju/juju/pull/11820 merges that one forward. | 14:34 |
| achilleasa | hml: can you point me to an example for using a pre-upgrade step? | 14:35 |
| stickupkid | hml, if we don't find the series in metadata yaml, wat do? | 14:36 |
| hml | achilleasa: sure, let me find it | 14:36 |
| hml | achilleasa: https://github.com/juju/juju/pull/11542 - it worked due to environs depending on your reasons | 14:40 |
| achilleasa | hml: thanks! it's exactly what I need as the pre-upgrade step is provider-specific | 14:43 |
| hml | achilleasa: sweet! | 14:44 |
| stickupkid | hml, considering this metadata doesn't contain series information... https://api.snapcraft.io/v2/charms/find | 14:49 |
| hml | stickupkid: it’s not real metadata. had the same issue with info. put it in test only | 14:50 |
| achilleasa | hml: on the other hand I could make it a normal upgrade step I guess; we should probably refresh the subnets each time we upgrade anyway... | 14:50 |
| stickupkid | hml, updated my PR | 14:56 |
| hml | stickupkid: ack | 14:56 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!