| wallyworld | kelvinliu: trvial PR - we've had an outage on 2.7 due to a nil pointer https://github.com/juju/juju/pull/11823 | 03:55 |
|---|---|---|
| kelvinliu | wallyworld: just went to get some food, looking now | 04:10 |
| === arif-ali_ is now known as arif-ali | ||
| wallyworld | kelvinliu: trivial forward port of the previous 2.7 fix https://github.com/juju/juju/pull/11825 | 06:13 |
| kelvinliu | approved | 06:14 |
| wallyworld | ty | 06:14 |
| kelvinliu | np | 06:14 |
| manadart_ | achilleasa stickupkid: need a tick on https://github.com/juju/juju/pull/11820 | 08:32 |
| stickupkid | fyi: I never think empty is good for a unknown value https://github.com/juju/juju/pull/11820/files#diff-78b22e8095fbb037f2aea902e906cfb5R41 | 08:33 |
| achilleasa | stickupkid: it's probably the same if you are using iota. I've also seen the empty value for enum-like definitions being unexported and only used in the package for sanity checking | 08:45 |
| stickupkid | I just think it should be a value | 08:48 |
| stickupkid | error if it's not | 08:48 |
| achilleasa | unknown is a value ;-) | 08:49 |
| stickupkid | "" isn't ;p | 08:49 |
| achilleasa | technically, it's a typed empty value :D | 08:49 |
| stickupkid | ha | 08:49 |
| stickupkid | achilleasa, this fixes the 2.8 ci integration failures https://github.com/juju/juju/pull/11826 | 10:27 |
| achilleasa | stickupkid: looking | 10:28 |
| achilleasa | Can I get a CR and QA on the manual cleanup script backport? https://github.com/juju/juju/pull/11827? | 14:54 |
| achilleasa | and a cherry-pick for 2.8 https://github.com/juju/juju/pull/11828 | 15:07 |
| achilleasa | manadart_: I think I found a (hacky) workaround for getting the info we need for the subnets on bionic; as the controller instance will be already up, we can query its state (that api works on bionic) and extrapolate the subnet data. I think we won't be able to figure out the parent bridge though which is probably fine I guess | 15:30 |
| petevg | hml: I'm working on QA for https://github.com/juju/juju/pull/11822, btw. | 19:32 |
| hml | petevg: ty | 19:33 |
| petevg | np! | 19:33 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!