[03:55] <wallyworld> kelvinliu: trvial PR - we've had an outage on 2.7 due to  a nil pointer https://github.com/juju/juju/pull/11823
[04:10] <kelvinliu> wallyworld:  just went to get some food, looking now
=== arif-ali_ is now known as arif-ali
[06:13] <wallyworld> kelvinliu: trivial forward port of the previous 2.7 fix https://github.com/juju/juju/pull/11825
[06:14] <kelvinliu> approved
[06:14] <wallyworld> ty
[06:14] <kelvinliu> np
[08:32] <manadart_> achilleasa stickupkid: need a tick on https://github.com/juju/juju/pull/11820
[08:33] <stickupkid> fyi: I never think empty is good for a unknown value https://github.com/juju/juju/pull/11820/files#diff-78b22e8095fbb037f2aea902e906cfb5R41
[08:45] <achilleasa> stickupkid: it's probably the same if you are using iota. I've also seen the empty value for enum-like definitions being unexported and only used in the package for sanity checking
[08:48] <stickupkid> I just think it should be a value
[08:48] <stickupkid> error if it's not
[08:49] <achilleasa> unknown is a value ;-)
[08:49] <stickupkid> "" isn't ;p
[08:49] <achilleasa> technically, it's a typed empty value :D
[08:49] <stickupkid> ha
[10:27] <stickupkid> achilleasa, this fixes the 2.8 ci integration failures https://github.com/juju/juju/pull/11826
[10:28] <achilleasa> stickupkid: looking
[14:54] <achilleasa> Can I get a CR and QA on the manual cleanup script backport? https://github.com/juju/juju/pull/11827?
[15:07] <achilleasa> and a cherry-pick for 2.8 https://github.com/juju/juju/pull/11828
[15:30] <achilleasa> manadart_: I think I found a (hacky) workaround for getting the info we need for the subnets on bionic; as the controller instance will be already up, we can query its state (that api works on bionic) and extrapolate the subnet data. I think we won't be able to figure out the parent bridge though which is probably fine I guess
[19:32] <petevg> hml: I'm working on QA for https://github.com/juju/juju/pull/11822, btw.
[19:33] <hml> petevg: ty
[19:33] <petevg> np!