| Chipaca | good morning all! | 09:14 |
|---|---|---|
| jam | morning Chipaca | 09:56 |
| Chipaca | jam: how's things? | 09:57 |
| stub | jam: controller state dropped in with no changes, looks happy: https://pastebin.ubuntu.com/p/p6nx4wz8vm/ | 10:30 |
| facubatista | :helo: | 10:55 |
| facubatista | ¡Muy buenos días a todos! | 10:55 |
| facubatista | Chipaca, please remember my https://github.com/canonical/charmcraft/pull/75 | 12:16 |
| mup | PR charmcraft#75: Support for pushing bytes to the Storage <Created by facundobatista> <https://github.com/canonical/charmcraft/pull/75> | 12:16 |
| facubatista | Chipaca, do we plan to have "docs on the web" for charmcraft the tool? like a RTD or even a category in Juju's Discourse? Something to point to from the command line help | 12:29 |
| * facubatista brb | 12:42 | |
| * facubatista is back | 12:49 | |
| Chipaca | facubatista: saying we _plan_ to have that is a bit much, but I'm not opposed to the idea | 12:50 |
| facubatista | Chipaca, ack | 12:50 |
| Chipaca | jam: you didn't _actually_ review #352 btw, you just pretended to | 12:53 |
| mup | PR #352: make ops.lib.use support relative submodules <Created by chipaca> <https://github.com/canonical/operator/pull/352> | 12:53 |
| jam | fine... :) | 12:54 |
| * Chipaca reads that in beuno's voice | 12:55 | |
| mup | Issue operator#351 closed: ops.lib.use does not support submodules <Created by chipaca> <Closed by chipaca> <https://github.com/canonical/operator/issues/351> | 12:56 |
| mup | PR operator#352 closed: make ops.lib.use support relative submodules <Created by chipaca> <Merged by chipaca> <https://github.com/canonical/operator/pull/352> | 12:56 |
| * Chipaca lands ALL the things | 12:56 | |
| Chipaca | now i just need to do the same thing with all the issues | 12:57 |
| mup | PR operator#355 closed: readme tweaks (including link to the api docs) <Created by chipaca> <Merged by chipaca> <https://github.com/canonical/operator/pull/355> | 12:57 |
| jam | all the... small things... | 12:57 |
| Chipaca | it | 13:01 |
| Chipaca | it's not the size of the pr that matters | 13:01 |
| Chipaca | or something | 13:01 |
| Chipaca | brb fiddling with the hardware again | 13:10 |
| facubatista | jam, oops, sorry, you were saying something | 13:40 |
| jam | facubatista, I just said bye | 13:40 |
| facubatista | :) | 13:40 |
| * Chipaca zzz | 14:58 | |
| * Chipaca goes to get some tea | 14:59 | |
| Chipaca | facubatista: meeting? | 16:01 |
| Chipaca | facubatista: ah there you are :-) | 16:01 |
| Chipaca | I suddenly realised why I've been feeling "bleh" all day, when i noticed my face wasn't red because of a weird camera effect | 16:27 |
| Chipaca | it's actually that red in the mirror too | 16:27 |
| Chipaca | i guess i got a bit toasted running yesterday :-) | 16:27 |
| Chipaca | oh dang the dev summary | 16:41 |
| Chipaca | the sprint threw me off :-| | 16:41 |
| facubatista | je | 16:43 |
| Chipaca | i guess i'll write it up today and have you two check it as available | 16:43 |
| Chipaca | but not now, now i need a break, and maybe a meal | 16:43 |
| Chipaca | so ttfn, ttyl, etc ;-) | 16:44 |
| facubatista | :) | 16:44 |
| facubatista | Chipaca, jam, this is ready for review, now: https://github.com/canonical/charmcraft/pull/76 | 19:37 |
| mup | PR charmcraft#76: Store upload <Created by facundobatista> <https://github.com/canonical/charmcraft/pull/76> | 19:37 |
| crodriguez | hi facubatista . I'm trying to import charmcraft instead of having the submodule in my charm. I added it to my dev-requirements.in, ran make build, and deployed mycharm.charm . However, my charm fails on install because it does not find the ops module | 20:29 |
| crodriguez | I'm unsure of what I'm doing wrong here | 20:29 |
| facubatista | hola crodriguez | 20:30 |
| crodriguez | (all of this inside a virtualenv) | 20:30 |
| facubatista | crodriguez, import charmcraft or import ops? | 20:30 |
| facubatista | crodriguez, charmcraft is a command line tool, you should not import it | 20:30 |
| crodriguez | yeah that's what I meant. import ops.charm | 20:31 |
| facubatista | crodriguez, are you using charmcraft to build the charm? | 20:31 |
| facubatista | crodriguez, would you remind me the url of your project? | 20:32 |
| crodriguez | I mentioned charmcraft because that's the package to install. Maybe I got confused by Maglana's new template. He's using make, not charmcraft build | 20:33 |
| crodriguez | let me try to build it once more | 20:33 |
| * facubatista checks it | 20:33 | |
| crodriguez | it's a new project facubatista https://github.com/camille-rodriguez/charm-iscsi-connector | 20:33 |
| facubatista | it should be easier | 20:35 |
| facubatista | it looks that Makefile is using charmcraft to build | 20:36 |
| facubatista | but at the same time hiding it | 20:36 |
| facubatista | @(python -m charmcraft build 2>&1 || echo "charmcraft build error") | tee .last-build | 20:36 |
| facubatista | this template is doing so many things I fail to understand it | 20:36 |
| facubatista | crodriguez, I see your requirements.txt is fine | 20:37 |
| crodriguez | hah, he showed it to us this morning in a presentation. He wrote it a few days ago, so it's still fresh. But it's an attempt at automating build, adding tests, and providing a way to deal with pip dependencies by adding pip-compile | 20:38 |
| facubatista | you don't need to deal with pip dependencies | 20:38 |
| facubatista | charmcraft does | 20:38 |
| facubatista | `charmcraft` shouldn't be used as a dependency ideally, but from the snap | 20:39 |
| crodriguez | well charmcraft build or make build both are failing me rn so it's not the template lol | 20:39 |
| facubatista | crodriguez, 1' | 20:40 |
| crodriguez | this is a subordinate charm. Could it not be installing its dependencies correctly upon deployment? | 20:42 |
| facubatista | this template is not good | 20:43 |
| facubatista | it's super mixing old and new stuff | 20:43 |
| facubatista | crodriguez, let's start to clean it a little to make your charm work | 20:43 |
| crodriguez | alright I can revert to my previous commit, when I didnt have the template and still had the submodule | 20:44 |
| facubatista | crodriguez, that would be better | 20:44 |
| facubatista | crodriguez, and we work from there | 20:44 |
| facubatista | crodriguez, let me know when you did that so I re-clone | 20:44 |
| crodriguez | ok ! yeah I'll ping you whenever I'm ready | 20:45 |
| facubatista | crodriguez, I'm close to EOD, but I can wait for you | 20:45 |
| facubatista | crodriguez, or we can do this first time tomorrow... I just don't want to block you | 20:46 |
| crodriguez | oh same here, so don't wait on me. I'll update you tomorrow, thanks :) | 20:46 |
| crodriguez | I'm doing a bit of extra coding in the sprint after-hours, nothing urgent :) | 20:46 |
| facubatista | crodriguez, let's work on this together tomorrow, I'm super interested in enabling an easy path in these cases | 20:47 |
| facubatista | we can HO or whatever | 20:47 |
| * facubatista needs to reboot, brb | 20:48 | |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!