[03:54] <murthy> gwenview snap app doesn't open webp
[05:18] <mborzecki> morning
[06:48] <mborzecki> mvo: morning
[06:49] <mvo> hey mborzecki !
[06:49] <mvo> mborzecki: anything I can help with before my first cup of tea :) ?
[06:49] <mborzecki> mvo: are you grumpy before or after your cup of tea? :P
[06:50] <mvo> all the time!
[06:50] <mborzecki> haha
[06:50] <mborzecki> mvo: maybe this one: https://github.com/snapcore/snapd/pull/8999 if github does not 500 on you like it does on me
[06:50] <mup> PR #8999: strutil: add a helper for parsing kernel command line <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8999>
[06:51] <mvo> mborzecki: ok
[06:51] <mborzecki> mvo: thanks!
[07:04] <pstolowski> morning
[07:07] <mvo> good morning pstolowski
[07:14] <pstolowski> o/
[07:15] <mborzecki> pstolowski: heya
[07:20] <mvo> hey pstolowski
[07:23] <zyga> hmm
[07:23] <zyga> it's not a good sing
[07:23] <zyga> sign*
[07:23] <zyga> when github is down on Monday morning
[07:23] <pstolowski> oh
[07:23] <zyga> oh well
[07:24] <zyga> how are you guys feeling?
[07:25] <mvo> feeling good (a bit tired) but GH down is a bummer
[07:26] <zyga> mvo same feeling, though for different reasons
[07:26] <mvo> zyga: i can imagine
[07:26]  * mvo hugs zyga
[07:26] <zyga> painkillers wear off pretty quickly so mornings are a bit so-so
[07:26] <zyga> I will ask for replacements if possible today
[07:27] <zyga> but I think I slept better than yesterday which was again awful
[07:27] <zyga> so I'm not that tired
[07:55] <pstolowski> i didn't sleep too well last night (woke up at 2.00 to check news re elections)
[07:55] <pstolowski> and then couldn't sleep
[07:55] <pstolowski> was such a bummer
[08:08] <mborzecki> meh, github still down
[08:08] <mborzecki> get an angry unicorn or 500 octocat :/
[08:17] <jamesh> it seems to be slightly functional: https://www.githubstatus.com/
[08:17] <jamesh> it let me create a pull request moments ago
[08:18] <mup> PR snapcraft#3211 opened: pluginhandler: fix stage-snaps for v2 plugins <Created by jhenstridge> <https://github.com/snapcore/snapcraft/pull/3211>
[08:28] <pstolowski> just started working here
[08:32] <mborzecki> yay
[08:33] <mborzecki> tbh funny how github become a single point of failure ;)
[08:37] <jamesh> Switch to a distributed bug tracker?
[08:38] <zyga-mbp> re
[08:38] <zyga-mbp> if only distributed bug trackers came with nice usable UX
[08:38] <zyga-mbp> oh well
[08:40] <mborzecki> zyga-mbp: can you take a look at https://github.com/snapcore/snapd/pull/8996 ?
[08:41] <mup> PR #8996: packaging, cmd/snap-mgmt, tests: remove modules files on purge <Bug> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8996>
[08:41] <zyga-mbp> trying
[08:41] <zyga-mbp> yeah, loads now
[08:41] <zyga-mbp> ah that
[08:41] <zyga-mbp> I really think we should remove snaps for real
[08:41] <zyga-mbp> did you see the comment from jamie?
[08:41] <zyga-mbp> +1
[08:42] <mborzecki> yup, i think we got everything he listed covered now
[08:43] <zyga-mbp> mborzecki including the udev rules?
[08:44] <zyga-mbp> if so that's great
[08:44] <mborzecki> zyga-mbp:             find /etc/udev/rules.d -name "*-snap.${snap}.rules" -execdir rm -f "{}" \;
[08:44] <zyga-mbp> ok
[08:47] <mup> PR snapd#8996 closed: packaging, cmd/snap-mgmt, tests: remove modules files on purge <Bug> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/8996>
[08:48] <zyga-mbp> woah, thank you for the review on https://github.com/snapcore/snapd/pull/8977 guys!
[08:48] <mup> PR #8977: cmd/snap: track started apps and hooks <Created by zyga> <https://github.com/snapcore/snapd/pull/8977>
[08:52] <mvo> zyga-mbp: do you think you could review 8949 and 8950 again? it looks like sergio addressed the comments
[08:53] <zyga-mbp> sure
[08:53] <mvo> mborzecki: 8959 looks like something for you :)
[08:59] <mborzecki> mvo: yeah, high time for me to go over it
[08:59] <mborzecki> pstolowski: https://github.com/snapcore/snapd/pull/8995#discussion_r453497664 snapd is running as root, so we'd take up the space reserved for root too
[08:59] <mup> PR #8995: osutil: add CheckFreeSpace helper (1/N) <Disk space awareness> <Needs Samuele review> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8995>
[09:37] <mup> PR snapd#8978 closed: secboot: update tpm connection error handling <UC20> <Created by cmatsuoka> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8978>
[09:45] <zyga-mbp> reviewed https://github.com/snapcore/snapd/pull/8949#pullrequestreview-447087507
[09:45] <mup> PR #8949: tests: new fs-state which replaces the files.sh helper <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/8949>
[09:47] <mup> PR snapd#9000 opened: postrm, snap-mgmt: cleanup modules and other cherry-picks (2.45) <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9000>
[09:47] <mborzecki> ha, next one is over 9000
[09:49] <zyga-mbp> https://github.com/snapcore/snapd/pull/8950#pullrequestreview-447098901
[09:49] <mup> PR #8950: tests: new to-one-line tool which replaces the strings.sh helper <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/8950>
[09:50] <zyga-mbp> mborzecki can you review https://github.com/snapcore/snapd/pull/8949 please
[09:50] <mup> PR #8949: tests: new fs-state which replaces the files.sh helper <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/8949>
[09:50] <zyga-mbp> mainly to see how you feel about the helpers
[09:50] <zyga-mbp> I'm happy to see most of them, but one
[09:51] <mborzecki> whis this be some snap declaration related thing? https://forum.snapcraft.io/t/finding-reason-for-stopped-snap-service-at-bootup/18785/8
[09:52] <zyga-mbp> yeah
[09:52] <zyga-mbp> commented
[09:55] <zyga-mbp> small break for coffee and back to branches
[10:17] <zyga-mbp> pstolowski https://github.com/snapcore/snapd/pull/8995#pullrequestreview-447118858
[10:17] <mup> PR #8995: osutil: add CheckFreeSpace helper (1/N) <Disk space awareness> <Needs Samuele review> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8995>
[10:17] <zyga-mbp> pstolowski including https://github.com/snapcore/snapd/pull/8995#discussion_r453545090
[10:18] <pstolowski> zyga-mbp: thank you!
[10:26] <pstolowski> thanks for the reviews, i'll land this and push next one
[10:28] <zyga-mbp> ok
[11:24] <mborzecki> hmm unit tests in 2.45 branch aren't passing
[11:25] <mborzecki> oh, w8, that's soem directory that's not going away when i switch branches
[11:36] <zyga> huh?
[11:38] <mup> PR snapcraft#3212 opened: tests: expand spread coverage for stage-snaps <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3212>
[11:53] <mup> PR snapd#8995 closed: osutil: add CheckFreeSpace helper (1/N) <Disk space awareness> <Needs Samuele review> <Created by stolowski> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/8995>
[12:08] <mup> PR snapd#9001 opened: o/snapshotstate: helpers for calculating disk space needed for an automatic snapshot (2/N) <Disk space awareness> <Needs Samuele review> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9001>
[12:28] <mup> PR snapd#9002 opened: o/snapstate: integrate free space checks with install/refresh and remove (3/N) <Disk space awareness> <Needs Samuele review> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9002>
[12:39] <mborzecki> zyga: have you looked at the failures on centos-8 maybe? i'm trying to reproduce them, but the failing tests pass in isolation
[12:39] <mborzecki> zyga: and the problems seem to be related to user sessions
[12:39] <mborzecki> zyga: eg. this one https://github.com/snapcore/snapd/runs/864831282
[12:40] <zyga> I have not
[12:45] <zyga> mborzecki 2020-07-13T11:32:11.5181452Z Failed to create bus connection: No such file or directory
[12:45] <zyga> mborzecki I saw this a few times
[12:45] <zyga> mborzecki perhaps test history is useful
[12:45] <zyga> long so I won't paste it here
[12:46] <mborzecki> zyga: trying to run the same set of tests as the one that failed
[12:46] <zyga> mborzecki try -seed
[12:46] <mborzecki> zyga: i'm using cachio's spread build :P
[12:46] <zyga> aha
[12:47] <mborzecki> cmatsuoka: hi, can you take a look at https://github.com/snapcore/snapd/pull/8999 ?
[12:47] <mup> PR #8999: strutil: add a helper for parsing kernel command line <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8999>
[12:48] <cmatsuoka> mborzecki: sure, will do it as soon as I finish some fixes here
[12:48] <mborzecki> cmatsuoka: cool, thanks!
[12:58] <mborzecki> heh, adding some tests to bootloader, noticed we have no covarge of GetRecoverySystemEnv
[13:01] <zyga> omw
[13:43] <zyga> sorry about all the yawning
[13:43] <zyga> I need more coffee
[13:43] <zyga> elections elections elections
[14:02] <mup> Bug #1887238 changed: snap fails to reload udev rules in docker <docker> <udev> <Snappy:Won't Fix> <https://launchpad.net/bugs/1887238>
[14:11]  * zyga lunch
[14:33] <mup> PR snapd#9003 opened: bootloader: add helper for getting recovery system environment variables <Simple 😃> <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9003>
[14:34] <mborzecki> cmatsuoka: if you could also take a look at ^^ this is for the tweaks in 8993
[14:37] <cmatsuoka> mborzecki: ok!
[14:37] <mborzecki> cmatsuoka: it's super simple and hopefully can land easily
[14:37] <mborzecki> cmatsuoka: thanks
[14:48] <mup> PR snapd#8999 closed: strutil: add a helper for parsing kernel command line <UC20> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/8999>
[14:48] <mup> PR snapd#9000 closed: postrm, snap-mgmt: cleanup modules and other cherry-picks (2.45) <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9000>
[14:53] <cachio> zyga, hey, is it ok #8991 now?
[14:53] <mup> PR #8991: tests: preinstall shellcheck and run tests on focal <Simple 😃> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/8991>
[14:53] <zyga> yes :)
[14:58] <mup> PR snapd#8991 closed: tests: preinstall shellcheck and run tests on focal <Simple 😃> <Created by sergiocazzolato> <Merged by sergiocazzolato> <https://github.com/snapcore/snapd/pull/8991>
[15:28]  * cachio lunch
[16:14] <mup> PR snapd#9003 closed: bootloader: add helper for getting recovery system environment variables <Simple 😃> <UC20> <Created by bboozzoo> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/9003>
[18:09] <mup> PR snapd#9004 opened: bootloader/bootloadertest: fix comment typo <Simple 😃> <Skip spread> <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9004>
[20:20] <mup> PR snapd#9004 closed: bootloader/bootloadertest: fix comment typo <Simple 😃> <Skip spread> <UC20> <Created by bboozzoo> <Merged by cmatsuoka> <https://github.com/snapcore/snapd/pull/9004>
[23:25] <mup> PR snapcraft#3097 closed: colcon v2 plugin + ros2 extension <do-not-merge> <enhancement> <Created by cjp256> <Closed by cjp256> <https://github.com/snapcore/snapcraft/pull/3097>