| * Chipaca goes for coffee | 08:32 | |
| Chipaca | actually, let's make that a whole breakfast | 08:32 |
|---|---|---|
| jam | morning Chipaca, enjoy your breakfast | 08:58 |
| facubatista | ¡Muy buenos días a todos! | 11:04 |
| jam | morning facubatista | 11:16 |
| facubatista | hola jam | 11:17 |
| * Chipaca harrumphs some more | 11:49 | |
| facubatista | jam, please remember my https://github.com/canonical/charmcraft/pull/76 | 13:16 |
| mup | PR charmcraft#76: Store upload <Created by facundobatista> <https://github.com/canonical/charmcraft/pull/76> | 13:16 |
| facubatista | crodriguez, hola! please let's work on your charm when you have some minutes, thanks! | 13:16 |
| jam | facubatista, indeed, I have it open, just ran into some issues so didn't get a review completed | 13:16 |
| facubatista | jam, no rush, thanks! | 13:17 |
| crodriguez | morning facubatista ! I sent you an invite for a meeting later today. I'm in the field/sales sprint all day before that | 13:17 |
| facubatista | crodriguez, ah, oh, wonderful, thanks! | 13:18 |
| crodriguez | :) | 13:18 |
| crodriguez | facubatista: did you lose connection? | 18:45 |
| * facubatista totally lost internet for ~30s | 18:50 | |
| crodriguez | haha | 19:11 |
| crodriguez | is charmcraft build taking templates into consideration? I added a template folder under my charm root, but it is not copied over when I deploy the charm | 19:12 |
| crodriguez | also, it creates only the 3 mandatory hook names. It is not creating config-changed, etc. | 19:17 |
| facubatista | crodriguez, we're not including "templates", we need to fix that | 19:24 |
| crodriguez | yeah, I opened https://github.com/canonical/charmcraft/issues/80 | 19:24 |
| facubatista | I wonder if we should provide a "--include" option to let devs include whatever they want | 19:24 |
| crodriguez | I wonder why it wouldn't just include every folder you include in your charm, maybe only excluding what is excluded by .gitignore | 19:25 |
| facubatista | (which could be annotated in the charmcraft.yaml file, so no need to specify it always) | 19:25 |
| facubatista | crodriguez, but there's stuff one would want to avoid: the tests, for example, which may have fixture files that may make the zip large | 19:26 |
| crodriguez | ah we can configure the build with a charmcraft.yaml file ? interesting | 19:26 |
| facubatista | crodriguez, we WILL be able to :) | 19:26 |
| facubatista | sorry, we're yeat too young :p | 19:26 |
| crodriguez | haha until today I just deployed directly the charm without building and it was working fine. I guess charm build is necessary for dependency packages though | 19:27 |
| facubatista | crodriguez, regarding the hook names, it's included what's needed for the pre-dispatch jujus (and the operator framework will take care of the rest) | 19:27 |
| crodriguez | well if config-changed fails, I run debug-hooks, go into my unit, and want to re-run the hook. But the hook doesn't exist so it is really confusing | 19:28 |
| facubatista | mmm... maybe the operator framework is not creating them because all works through the dispatch mechanism? (not really using hooks) | 19:29 |
| facubatista | crodriguez, which juju do you have? | 19:29 |
| * facubatista brb | 19:29 | |
| crodriguez | 2.8.1-bionic-amd64 | 19:30 |
| facubatista | right, it's using dispatch | 19:37 |
| facubatista | jam, Chipaca, how do you trigger a "hook" using dispatch? | 19:37 |
| facubatista | crodriguez, I *think* it's by doing: JUJU_DISPATCH_PATH=hooks/config-changed ./dispatch | 19:38 |
| crodriguez | why is it not just existing in the /hooks folder like for all the reactive charms? this changes completely the troubleshooting experience | 20:20 |
| crodriguez | re:templates , could we just add templates in CHARM_OPTIONAL ? https://github.com/canonical/charmcraft/blob/master/charmcraft/commands/build.py#L38 Does this handle folders or only files? | 20:22 |
| facubatista | crodriguez, yes, if you add templates in CHARM_OPTIONAL it will work | 20:31 |
| facubatista | the question is what we *really* need... "templates" for sure, but what else? | 20:32 |
| crodriguez | hum that could be decided by reviewing existing charms | 20:33 |
| crodriguez | like reactive charms | 20:34 |
| facubatista | crodriguez, FWIW, we have https://github.com/canonical/charmcraft/issues/39 | 20:34 |
| crodriguez | ok yeah, my bug might be a duplicate then. It would be nice if a decision was taken soon though, because this pretty much prevents me from using charmcraft build rn. I might just do a PR for templates only until that broader question is resolved | 20:38 |
| facubatista | Chipaca, let's talk about this ↑ in tomorrow's standup, please :) | 20:47 |
| * facubatista eods | 21:06 | |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!