[08:32] * Chipaca goes for coffee [08:32] actually, let's make that a whole breakfast [08:58] morning Chipaca, enjoy your breakfast [11:04] ¡Muy buenos días a todos! [11:16] morning facubatista [11:17] hola jam [11:49] * Chipaca harrumphs some more [13:16] jam, please remember my https://github.com/canonical/charmcraft/pull/76 [13:16] PR charmcraft#76: Store upload [13:16] crodriguez, hola! please let's work on your charm when you have some minutes, thanks! [13:16] facubatista, indeed, I have it open, just ran into some issues so didn't get a review completed [13:17] jam, no rush, thanks! [13:17] morning facubatista ! I sent you an invite for a meeting later today. I'm in the field/sales sprint all day before that [13:18] crodriguez, ah, oh, wonderful, thanks! [13:18] :) [18:45] facubatista: did you lose connection? [18:50] * facubatista totally lost internet for ~30s [19:11] haha [19:12] is charmcraft build taking templates into consideration? I added a template folder under my charm root, but it is not copied over when I deploy the charm [19:17] also, it creates only the 3 mandatory hook names. It is not creating config-changed, etc. [19:24] crodriguez, we're not including "templates", we need to fix that [19:24] yeah, I opened https://github.com/canonical/charmcraft/issues/80 [19:24] I wonder if we should provide a "--include" option to let devs include whatever they want [19:25] I wonder why it wouldn't just include every folder you include in your charm, maybe only excluding what is excluded by .gitignore [19:25] (which could be annotated in the charmcraft.yaml file, so no need to specify it always) [19:26] crodriguez, but there's stuff one would want to avoid: the tests, for example, which may have fixture files that may make the zip large [19:26] ah we can configure the build with a charmcraft.yaml file ? interesting [19:26] crodriguez, we WILL be able to :) [19:26] sorry, we're yeat too young :p [19:27] haha until today I just deployed directly the charm without building and it was working fine. I guess charm build is necessary for dependency packages though [19:27] crodriguez, regarding the hook names, it's included what's needed for the pre-dispatch jujus (and the operator framework will take care of the rest) [19:28] well if config-changed fails, I run debug-hooks, go into my unit, and want to re-run the hook. But the hook doesn't exist so it is really confusing [19:29] mmm... maybe the operator framework is not creating them because all works through the dispatch mechanism? (not really using hooks) [19:29] crodriguez, which juju do you have? [19:29] * facubatista brb [19:30] 2.8.1-bionic-amd64 [19:37] right, it's using dispatch [19:37] jam, Chipaca, how do you trigger a "hook" using dispatch? [19:38] crodriguez, I *think* it's by doing: JUJU_DISPATCH_PATH=hooks/config-changed ./dispatch [20:20] why is it not just existing in the /hooks folder like for all the reactive charms? this changes completely the troubleshooting experience [20:22] re:templates , could we just add templates in CHARM_OPTIONAL ? https://github.com/canonical/charmcraft/blob/master/charmcraft/commands/build.py#L38 Does this handle folders or only files? [20:31] crodriguez, yes, if you add templates in CHARM_OPTIONAL it will work [20:32] the question is what we *really* need... "templates" for sure, but what else? [20:33] hum that could be decided by reviewing existing charms [20:34] like reactive charms [20:34] crodriguez, FWIW, we have https://github.com/canonical/charmcraft/issues/39 [20:38] ok yeah, my bug might be a duplicate then. It would be nice if a decision was taken soon though, because this pretty much prevents me from using charmcraft build rn. I might just do a PR for templates only until that broader question is resolved [20:47] Chipaca, let's talk about this ↑ in tomorrow's standup, please :) [21:06] * facubatista eods