| lubot | <ItzSwirlz> what do you mean by viewmodule? | 00:03 |
|---|---|---|
| lubot | <ItzSwirlz> @ItzSwirlz [So I have to add it to calamares as a new module], and I meant this as add it to /usr/lib/x86_linux_gnu thing/etc/calamares/ | 00:03 |
| lubot | <kc2bez> @ItzSwirlz [what do you mean by viewmodule?], move it out of the show section and into the exec section | 00:06 |
| lubot | <KaiLoveLinux> slap my dongle and call me slackware, i need to get workin | 00:06 |
| lubot | <ItzSwirlz> Oh | 00:06 |
| lubot | <The_LoudSpeaker> (Photo, 1280x719) https://i.imgur.com/Mh6OKAc.jpg why don't I see the groovy branch here? | 09:16 |
| lubot | <The_LoudSpeaker> ^ @tsimonq2 | 09:16 |
| lubot | <The_LoudSpeaker> I cloned and did a `git checkout` too still `ubuntu/groovy` doesn't exist | 09:25 |
| lubot | <aptghetto> Because it does not exist. | 09:50 |
| lubot | <tsimonq2> ^ | 12:09 |
| lubot | <tsimonq2> Feel free to create it | 12:09 |
| lubot | <ItzSwirlz> calamares be going brr | 15:43 |
| lubot | <The_LoudSpeaker> @aptghetto [Because it does not exist.], So D97 is yet to be uploaded? | 16:21 |
| The_LoudSpeaker | once your revision gets uploaded, we should see the groovy branch here right? apt-ghetto | 16:23 |
| apt-ghetto | The_LoudSpeaker: If it will be accepted, it should then be landed in a new branch for ubuntu/groovy | 16:24 |
| apt-ghetto | Theoretically, you could create the branch now, if you have access to the repo | 16:25 |
| The_LoudSpeaker | It got accepted afaik, kc2bez accepted it yesterday. | 16:26 |
| The_LoudSpeaker | yes I can create but I can pull from your branch first, then rebase my changes on top of yours and then create another revison | 16:27 |
| The_LoudSpeaker | else there might be clashes when I push | 16:28 |
| The_LoudSpeaker | I might do a direct git push. | 16:28 |
| lubot | <kc2bez> @The_LoudSpeaker [<The_LoudSpeaker> It got accepted afaik, kc2bez accepted it yesterday.], I accepted it but I have not landed it. | 16:30 |
| lubot | <kc2bez> You can add your revisions to the same diff. | 16:30 |
| The_LoudSpeaker | yup. I will do that. | 16:31 |
| * The_LoudSpeaker goes to fetch my previous revisions. | 16:31 | |
| apt-ghetto | You can create locally a new branch, then arc patch D97 and on top arc patch D<whatever> | 16:31 |
| The_LoudSpeaker | yup I am gonna do exactly that. | 16:32 |
| The_LoudSpeaker | uh oh! | 16:33 |
| The_LoudSpeaker | my data limit is again exausted for today. | 16:33 |
| The_LoudSpeaker | Will do make the changes in about 3 hrs. | 16:33 |
| apt-ghetto | Totally unrelated, but: Is there anything, that should be SRUed for 20.04.1? https://phab.lubuntu.me/T158 was once a candidate for SRU, but I never saw other support requests because of this. | 16:41 |
| The_LoudSpeaker | https://phab.lubuntu.me/D91 this was initally decided to be SRUed for 20.04.1 | 16:44 |
| The_LoudSpeaker | I will push it to groovy first today then it needs another tweak in cala setting and in the next daily build, we should see the grub theme. | 16:45 |
| The_LoudSpeaker | therotically | 16:46 |
| The_LoudSpeaker | If it runs fine then we cacn SRU it to 20.04.1 | 16:47 |
| apt-ghetto | Why does it need a tweak in cala-settings? | 16:48 |
| The_LoudSpeaker | the location of the theme needs to be specified in a cala module so that while installing grub after installation of Lubuntu, the theme gets activated too. | 17:14 |
| apt-ghetto | What does that mean? | 17:15 |
| The_LoudSpeaker | The package in discussion is a grub theme for Lubuntu. | 17:15 |
| The_LoudSpeaker | a default grub theme | 17:16 |
| The_LoudSpeaker | D91 is the diff that updates lubuntu-grub-theme | 17:16 |
| apt-ghetto | Yes, but what has it to do with Calamares? Or in other words, how does it work, if you install it on a normal system? | 17:16 |
| The_LoudSpeaker | if you install it on a normal system, you have to manually set GRUB_THEME = /location/of/theme.txt in /etc/default/grub | 17:17 |
| The_LoudSpeaker | and run a sudo update-grub | 17:17 |
| The_LoudSpeaker | a cala module does it for us during installation of Lubuntu | 17:17 |
| apt-ghetto | And why don't you do it like Ubuntu Mate? Without changing /etc/default/grub? | 17:18 |
| The_LoudSpeaker | I remember I tried that way, didn't work | 17:19 |
| The_LoudSpeaker | I had placed a file in /etc/default/grub.d/ | 17:20 |
| apt-ghetto | With D91, you have removed Grub as a Recommends, but now you try to change /etc/default/grub | 17:20 |
| apt-ghetto | What happens, if someone removes the package? | 17:21 |
| apt-ghetto | The variable is then still set in /etc/default/grub | 17:21 |
| apt-ghetto | In my opinion, you should not change a Grub config in any way, but simply do it like Ubuntu Mate with a file in plymouth | 17:22 |
| The_LoudSpeaker | Yeah I removed grub as recommends becaouse during Lubuntu installation, package gets installed first and then grub gets installed separately. Package doesn't install if grub is in recommends. also, an issue was filled against the package that it removed grub on legacy systems along with it when the package was removed. | 17:23 |
| The_LoudSpeaker | now coming to current implementation: | 17:23 |
| The_LoudSpeaker | right now on uninstalling the package, the theme.txt gets removed. | 17:24 |
| The_LoudSpeaker | hence even if a entry in /etc/default/grub (or whatever file the module will save it to) points to the file, the theme won't show up and the defualt current grub theme would show up. | 17:25 |
| The_LoudSpeaker | doing it the plymouth way only adds the background wallpaper to grub. | 17:25 |
| The_LoudSpeaker | here we have icons, scroll bars, menu padding, etc | 17:25 |
| The_LoudSpeaker | also, I am not sure whether the cala module will specifically modify /etc/default/grub or put a file under grub.d/ somewhere. | 17:26 |
| The_LoudSpeaker | that's the reason we didn't rush to put it in 20.04 | 17:27 |
| The_LoudSpeaker | I had a discussion with people in #grub and with wxl here before regarding the theme and this is the best possible way to o it. | 17:27 |
| The_LoudSpeaker | now the package doesn't depend on grub2 and hence can be installed / rermoved easily. | 17:29 |
| The_LoudSpeaker | instead of cala module, we can go with a file in /etc/default/grub.d/ but that might create problems if someone installs their own theme. the file in grub.d takes preference over /etc/defaulr/grub | 17:31 |
| apt-ghetto | Calamares modifies /etc/default/grub which has caused some trouble, because some variables were set wrongly/not according to the Ubuntu standard | 17:33 |
| The_LoudSpeaker | apt-ghetto: here's a picture of the theme in action: https://github.com/ramansarda2000/lubuntu-grub-theme/blob/master/lubuntu-grub-theme/preview.png | 17:33 |
| apt-ghetto | /etc/default/grub.d is the better place, but then you should create the config with the package and remove it also, not with Calamares | 17:34 |
| The_LoudSpeaker | apt-ghetto: I will be only modifying the GRUB_THEME variable shouldn't cause a problem to others because I have seen some themes directly modify this upon installation. | 17:35 |
| The_LoudSpeaker | yeah /etc/default/grub.d was the way we did it earlier but for some reason, it didn't show up on installation of lubuntu afaik. | 17:36 |
| The_LoudSpeaker | https://paste.ubuntu.com/p/7hsqNHvHbV/ | 18:21 |
| The_LoudSpeaker | I used origin/master | 18:21 |
| The_LoudSpeaker | wait I pushed it | 18:23 |
| The_LoudSpeaker | is this correct tsimonq2 ? https://phab.lubuntu.me/source/lubuntu-artwork/browse/ubuntu%252Fgroovy/ | 18:23 |
| The_LoudSpeaker | ^ kc2bez | 18:24 |
| The_LoudSpeaker | I think it is good. But I ended up giving only 1 version number change for both of the diffs. :facepalm: | 18:30 |
| * The_LoudSpeaker will be uploading it in an hour. till I wait for someone to confirm that the push as correct. | 18:32 | |
| lubot | <ItzSwirlz> Calamares no matter what I try isn't working with the module | 18:33 |
| lubot | <ItzSwirlz> @kc2bez , what's your take | 18:34 |
| The_LoudSpeaker | @ItzSwirlz which module? | 18:39 |
| lubot | <ItzSwirlz> @The_LoudSpeaker [<The_LoudSpeaker> @ItzSwirlz which module?], We're trying to import the startup sound in Ubiquity to calamares | 18:39 |
| lubot | <ItzSwirlz> it is the yaru theme's sound "system-ready" and we are trying to launch it in calamares. | 18:39 |
| lubot | <ItzSwirlz> https://github.com/Ubuntu-Cinnamon-Remix/calamares-settings-ubuntu/commit/8f71707655bea693df9e6267334300b4ef201f4d … [GitHub](https://github.com/Ubuntu-Cinnamon-Remix/calamares-settings-ubuntu/commit/8f71707655bea693df9e6267334300b4ef201f4d) | 18:40 |
| The_LoudSpeaker | oh i see. what's the blocker? | 18:40 |
| lubot | <ItzSwirlz> The usual. | 18:40 |
| lubot | <ItzSwirlz> can't load the module /shrug | 18:40 |
| lubot | <ItzSwirlz> God dammit | 18:43 |
| lubot | <ItzSwirlz> It needs to be in /usr/lib/x86_64-linux-gnu/calamares/modules. | 18:43 |
| lubot | <ItzSwirlz> What if we on the welcome screen TOLD IT to play IN ITS MODUEL | 18:46 |
| lubot | <ItzSwirlz> and then i need to make the source code | 18:48 |
| lubot | <ItzSwirlz> I think i have an idea | 19:01 |
| lubot | <ItzSwirlz> if it activates on the welcome screen-lets use the welcome module to help us | 19:01 |
| lubot | <ItzSwirlz> I see | 19:08 |
| lubot | <ItzSwirlz> a module is really a page | 19:08 |
| lubot | <ItzSwirlz> It could be a dummyprocess | 19:10 |
| lubot | <ItzSwirlz> but it has to be executed on welcome | 19:13 |
| lubot | <ItzSwirlz> calamares has to physically call it | 19:13 |
| lubot | <ItzSwirlz> So, NOTHING IS CONSISTENT! | 19:20 |
| lubot | <ItzSwirlz> The only way we can get this to work is if WE modify calamares's welcome to play the sound for us and add it as a field | 19:20 |
| lubot | <ItzSwirlz> Which would be a cute feature in calamares and should be added so we can do that | 19:21 |
| lubot | <ItzSwirlz> All the modul changes we made-ugh | 19:21 |
| lubot | <ItzSwirlz> They are just changing the settings of calamares not god damn doing any thing | 19:22 |
| lubot | <ItzSwirlz> So, what's the only thing we can do? | 19:22 |
| lubot | <ItzSwirlz> Import. A. Startup. Sound. Feature. In. The. Welcome. Module | 19:22 |
| lubot | <ItzSwirlz> And there you go. The end. | 19:22 |
| lubot | <ItzSwirlz> @kc2bez done | 19:22 |
| lubot | <ItzSwirlz> so... i guess we will therefore be opening a pr or just giving up | 19:23 |
| lubot | <ItzSwirlz> so-the plan is to open a pr to add a field in the C++ code to run "paplay file" in the configuration | 19:25 |
| lubot | <ItzSwirlz> but i'm not the developer and for all I can do, I can't do anything. | 19:25 |
| lubot | <ItzSwirlz> It truly is, the end. | 19:25 |
| lubot | <ItzSwirlz> and not even shellprocess works | 19:33 |
| lubot | <ItzSwirlz> phab task time | 19:33 |
| * The_LoudSpeaker goes to upload lubuntu-artwork | 19:45 | |
| The_LoudSpeaker | whoops! debuild -b failed | 19:48 |
| lubot | <kc2bez> @ItzSwirlz I left you a comment on GitHub. | 19:59 |
| lubot | <ItzSwirlz> I saw, but that won’t help. | 19:59 |
| lubot | <kc2bez> ok | 19:59 |
| lubot | <ItzSwirlz> Does the welcome module have a command entry? | 19:59 |
| lubot | <kc2bez> not that I know of. | 19:59 |
| lubot | <ItzSwirlz> Yeah-so the only way it would work is if we added to calamares a field for ready sound | 20:00 |
| lubot | <kc2bez> I can try to mess with it at some point but you might be right. | 20:00 |
| lubot | <ItzSwirlz> I’ve tried everything I could think of | 20:01 |
| lubot | <ItzSwirlz> In the meantime I’ll phab task it | 20:01 |
| lubot | <ItzSwirlz> https://phab.lubuntu.me/T168 | 20:07 |
| The_LoudSpeaker | kc2bez: please check rART | 20:30 |
| The_LoudSpeaker | whenever you are free | 20:30 |
| The_LoudSpeaker | also, how do I add a line at : https://phab.lubuntu.me/source/calamares-settings-ubuntu/browse/master/lubuntu/modules/grubcfg.conf upon cloning the repo from phab, I get an empty folder | 20:35 |
| The_LoudSpeaker | ^ wxl | 20:37 |
| wxl | that's weird | 20:43 |
| wxl | seems tobe there https://packages.ubuntu.com/groovy/all/calamares-settings-lubuntu/filelist | 20:44 |
| wxl | warning: remote HEAD refers to nonexistent ref, unable to checkout. | 21:06 |
| wxl | sounds like @tsimonq2 broke it as usual | 21:06 |
| lubot | <tsimonq2> Hahahahaha | 21:06 |
| wxl | @The_LoudSpeaker: fixed. for some reason @tsimonq2 had the URI set to clone from calamares, not calamares-settings-ubuntu | 21:08 |
| The_LoudSpeaker | okay. | 21:09 |
| The_LoudSpeaker | I will make a revision. | 21:09 |
| wxl | and normally that wouldn't be a problem except for the fact that there is only one branch on calamares-settings-ubuntu (master) and no such branch on calamares | 21:09 |
| The_LoudSpeaker | or should I just push? | 21:09 |
| wxl | i'll leave you to trust your judgement on that one :) | 21:10 |
| The_LoudSpeaker | I know you are around to clean up if I mess up. XD | 21:12 |
| wxl | if you mess up you can just revert your change :) | 21:15 |
| lubot | <tsimonq2> Oh nice | 21:18 |
| The_LoudSpeaker | yup. Just did that with rART, (force pushed twice) | 21:23 |
| lubot | <kc2bez> So, what did I miss in my walk home? @The_LoudSpeaker broke everything? XD | 21:27 |
| The_LoudSpeaker | about to | 21:27 |
| wxl | no, but we came to realize that @tsimonq2 did | 21:27 |
| The_LoudSpeaker | I can't push to calamares-settings-ubuntu | 21:27 |
| lubot | <kc2bez> Status quo then. | 21:27 |
| The_LoudSpeaker | asks username and passowrd for launchpad, says remote authorisation required. | 21:28 |
| The_LoudSpeaker | fatal: Authentication failed for 'https://git.launchpad.net/~ubuntu-qt-code/+git/calamares-settings-ubuntu/' | 21:28 |
| wxl | do you have everything set up to be able to push to launchpad in the first place? | 21:29 |
| The_LoudSpeaker | I think so yes | 21:29 |
| wxl | cuz all lubuntu devs are admins | 21:29 |
| The_LoudSpeaker | I have followed packaging requirements | 21:29 |
| wxl | (of ubuntu-qt-code) | 21:29 |
| The_LoudSpeaker | and even set up bzr | 21:29 |
| The_LoudSpeaker | I am an indirect member of ubuntu-qt-code | 21:31 |
| wxl | eh | 21:31 |
| wxl | i don't think anyone but repository owners can push | 21:31 |
| lubot | <kc2bez> should that be git+ssh instead of https? | 21:31 |
| wxl | probably? | 21:31 |
| The_LoudSpeaker | okay so I ill do a arc diff then | 21:32 |
| The_LoudSpeaker | ? | 21:32 |
| lubot | <kc2bez> ¯\_(ツ)_/¯ | 21:32 |
| wxl | what else do we have running on launchpad? | 21:32 |
| * wxl hands the broom to @tsimonq2 so he can finish cleaning up his mess | 21:32 | |
| The_LoudSpeaker | let me know when it is ready or when I should create a diff. | 21:33 |
| * The_LoudSpeaker goes to sleep | 21:33 | |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
