[05:23] <mborzecki> morning
[05:45] <mborzecki> hmmm Jul 20 07:43:15 galeon kernel: BUG: kernel NULL pointer dereference, address: 0000000000000008
[07:29] <zyga> pedronis we need your powers to force merge https://github.com/snapcore/snapd/pull/9037 and a few related master fixes
[07:29] <mup> PR #9037: tests: adjust xdg-open after launcher changes <Simple 😃> <⚠ Critical> <Created by zyga> <https://github.com/snapcore/snapd/pull/9037>
[07:32] <mborzeck1> zyga: hi, and yeah pinged pedronis in 9037 and #9034
[07:32] <mup> PR #9034: cmd/snap-seccomp/syscalls: add faccessat2 <Simple 😃> <⚠ Critical> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9034>
[07:33] <zyga-mbp> hi, yeah, thank you for linking them from the other pr
[07:33] <mborzeck1> zyga: btw. pushed the base template tweak jdstrand suggested in 9034, can you take a look?
[07:33] <zyga-mbp> I had a good weekend, mostly sleeping but relatively little pain
[07:33] <zyga-mbp> sure, looking
[07:34] <zyga-mbp> done
[07:34] <mborzeck1> zyga-mbp: that's nice ;) glad you're in a better mood
[07:34] <zyga-mbp> yeah, just 8 days left
[07:34] <zyga-mbp> feels like it's tomorrow
[07:35] <zyga-mbp> one day will be painful as I cannot take meds for testing
[07:35] <zyga-mbp> but I'll manage
[07:37] <zyga-mbp> mborzeck1 perhaps we could merge all fixes into one PR
[07:37] <zyga-mbp> to ensure nothing is still broken
[07:37] <mborzeck1> zyga-mbp: mhm, can try, let me open one
[07:37] <zyga-mbp> great, thanks
[07:38]  * zyga-mbp quickly pays taxes
[07:38] <pedronis> I just merged #9037
[07:38] <mup> PR #9037: tests: adjust xdg-open after launcher changes <Simple 😃> <⚠ Critical> <Created by zyga> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/9037>
[07:38] <mborzeck1> pedronis: cool, thanks!
[07:38] <zyga-mbp> woot
[07:38] <mborzeck1> pedronis: can you also land 9034 when the spread job finishes?
[07:38] <pedronis> mborzeck1: yes
[07:39] <mborzeck1> pedronis: and good morning :)
[07:39] <pedronis> mborzeck1: there was a weird core 20 prepare failure though
[07:39] <pedronis> we'll need to see the state of things
[07:39] <mborzeck1> pedronis: the one i looked at before seemed to be a result of missing #8883
[07:39] <mup> PR #8883: packaging: stop snapd early on purge <Test Robustness> <Created by mvo5> <https://github.com/snapcore/snapd/pull/8883>
[07:39] <zyga-mbp> mborzeck1 perhaps after the critical fixes land we can look at the purge problem again
[07:39] <zyga-mbp> ha :)
[07:41] <zyga-mbp> taxes paid
[07:41] <mup> PR snapd#9037 closed: tests: adjust xdg-open after launcher changes <Simple 😃> <⚠ Critical> <Created by zyga> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/9037>
[07:41] <pedronis> mborzecki: zyga-mbp: anyway we should try to focus on landing PRs for a bit, we definitely have too many open atm
[07:41] <zyga-mbp> agreed
[07:42] <mborzecki> pedronis: do you think we should have a chat about https://forum.snapcraft.io/t/installation-of-snap-with-content-snap-as-dependency/16103/11 ? looks like preqrequisites are only waited for in auto-connect, so link snap runs before and it is possible to start applications too early
[07:43] <pedronis> mborzecki: if we waited in link snap we could get mutual blocked things
[07:44] <pedronis> mborzecki: it's a big topic, it is kind of working as designed, in the sense that we don't have a concept of mandatory interfaces
[07:44] <mborzecki> pedronis: as in task deadlock? link snap could accidentally keep waiting for another link snap?
[07:45] <zyga-mbp> mborzecki could the new inhibition lock be of use?
[07:45] <zyga-mbp> we could inhibit startup until the dependencies are met
[07:46] <zyga-mbp> though it's not exactly designed for that
[07:46] <pedronis> mborzecki: yes, the logic if I remember works exactly because the waiting is assymmetric, but I would need to reload a lot of state
[07:47] <pedronis> mborzecki: anyway implicitly the current design says that app should do something reasonable if plugs are not connected, in practice if the content is libs that's hard
[07:47] <pedronis> zyga-mbp: yes, the lock can probably help, if we decide to go that way
[07:48] <mborzecki> pedronis: could you add a note to the topic stating it's somewhat convoluted and maybe we could discuss it once the PR count is down? even if the end game is just adding some comments to the code
[07:49] <pedronis> zyga-mbp: we would need to be careful with hooks though
[07:50] <zyga-mbp> yeah, I think it's not a perfect fit
[07:50] <zyga-mbp> because things appear to run, just stall
[07:50] <pedronis> I think that might be fine
[07:50] <pedronis> but anyway this is too complex to deal quickly right now
[07:52] <pedronis> mborzecki: I put it in my queue
[07:52] <mborzecki> pedronis: thank you!
[07:52] <pedronis> it also really relates to the desktop icon
[07:52] <pedronis> in practical ux terms
[07:58] <mborzecki> pedronis: yeah. perhaps it's a simple as making the desktop file appear later
[08:01] <zyga> jamesh https://github.com/snapcore/snapd/pull/8861#pullrequestreview-451379010
[08:01] <mup> PR #8861: data,packaging,wrappers: extend D-Bus service activation search path <Created by jhenstridge> <https://github.com/snapcore/snapd/pull/8861>
[08:01] <jamesh> zyga: looking
[08:01] <zyga> jamesh note that master is not fixed yet
[08:01] <zyga> good morning :)
[08:01] <zyga> but should be later today
[08:02] <jamesh> zyga: thanks.  That should get the wrappers PR unblocked
[08:03] <pedronis> gah: the last XXX in osutil became the package doc :/
[08:16] <zyga> pedronis please merge https://github.com/snapcore/snapd/pull/9034 as well
[08:16] <mup> PR #9034: cmd/snap-seccomp/syscalls: add faccessat2 <Simple 😃> <⚠ Critical> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9034>
[08:17] <zyga> pedronis I can send a quick PR correcting the XXX after master is fixed
[08:17] <mborzecki> zyga: i think centos-8 spread job is still running
[08:17] <zyga> oh, sorry, didn't see that
[08:17] <zyga> yeah
[08:17] <pedronis> yea, is still running something
[08:17] <pedronis> I'll do once it's done
[08:26] <zyga> brb
[08:32] <mborzecki> pedronis: all spread jobs are done now
[08:33] <zyga> I've upgraded github actions on a single runner to see how they behave
[08:33] <zyga> I'll be monitoring that runner today
[08:33] <zyga> the new release brings a whole bucket of fixes over what we hav
[08:35] <mborzecki> heh the tests/main/interfaces-process-control test is flaky
[08:35] <mborzecki> and failed in a funny way
[08:36] <zyga> oh, can you paste the link to the failure please
[08:36] <mborzecki> https://paste.ubuntu.com/p/kXKbbzgzwZ/ the test was verifying that pid 2499 does not exist, which is ok, but grep did not account for pids that start with 2499 (eg 24998)
[08:36] <zyga> lol
[08:36] <zyga> ok
[08:38] <mborzecki> once 9034 lands i'll open a fix, should land quickly
[08:44] <pedronis> mborzecki: I landed 9034
[08:44] <mborzecki> pedronis: thanks!
[08:44] <pedronis> centos exploded in a lot of funny ways fwiw
[08:46] <mup> PR snapd#9034 closed: cmd/snap-seccomp/syscalls: add faccessat2 <Simple 😃> <⚠ Critical> <Created by bboozzoo> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/9034>
[08:50] <zyga> mborzecki I've fixed the test
[08:51] <mborzecki> zyga: hm? process-control one?
[08:51] <zyga> yep
[08:51] <mborzecki> ah, ok, my local spread run has finished and was about to push a branch
[08:51] <zyga> how did you fix it?
[08:52] <zyga> I used kill with signal 0
[08:52] <zyga> https://github.com/snapcore/snapd/compare/master...zyga:fix/incorrect-pid-checks?expand=1
[08:55] <mborzecki> zyga: your fix is better, i tweaked the grep pattern to "$pid "
[08:55] <zyga> I'll rebase it on top of the fixed master and send the patch when that's possible
[08:56] <mborzecki> cool
[09:06] <zyga> pedronis btw, not sure if you noticed this before
[09:06] <zyga> https://forum.snapcraft.io/t/injecting-snapd-tools-into-base-snaps-and-keeping-them-up-to-date/12139/8?u=zyga
[09:09] <pedronis> zyga: yes, I noticed but didn't look at it closely yet
[09:18] <pedronis> mborzecki: I reviewed #9030
[09:18] <mup> PR #9030: bootloader/assets: helpers for registering per-edition snippets, register snippets for grub <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9030>
[09:20] <mborzecki> pedronis: thanks, i'm tweaking 9033 and will fix that one next
[09:21] <mup> PR snapd#9038 opened: tests: check for pids correctly <Test Robustness> <Created by zyga> <https://github.com/snapcore/snapd/pull/9038>
[09:23] <zyga> mborzecki ^
[09:33] <zyga> brb
[09:51] <pedronis> zyga: I pushed some small adjustments to #9028, could you double check them?
[09:51] <mup> PR #9028: interfaces: new helpers to get and compare system key, for use with seeding debug api (1/N) <Needs Samuele review> <Preseeding 🍞> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9028>
[09:51] <zyga> sure
[10:27] <zyga> time for meds
[10:56] <mborzecki> zyga: hmm https://paste.ubuntu.com/p/6h9PQm5QSK/ wierd, did /boot/efi just go away?
[10:57] <zyga> it seems we are no longer booting in EFI mode?
[10:57] <mborzecki> zyga: idk, why would that change?
[10:58] <zyga> I have no idea
[10:58] <zyga> new image?
[10:58] <zyga> some tweak to some panel I never saw
[10:58] <zyga> dunn
[10:58] <zyga> *dunno
[10:58] <mborzecki> same question, why would that change? :P
[10:58] <zyga> I think that's a question for cachio
[10:58] <zyga> he has more visibility into that layer
[10:58] <zyga> I just don't know at all
[10:59] <zyga> there's no trace of image updates that I know of
[10:59] <mborzecki> hmm store throwing 408 too
[11:00] <zyga> oh, thunder
[11:01] <zyga> but the sky is blue
[11:01]  * zyga looks
[11:07]  * zyga sent more reviews for the point release break-out PRs
[11:09] <zyga> https://github.com/snapcore/snapd/pull/9024#pullrequestreview-451499623
[11:10] <mup> PR #9024: sysconfig/cloudinit: add RestrictCloudInit <Created by mvo5> <https://github.com/snapcore/snapd/pull/9024>
[11:43] <pedronis> mborzecki: this is fix committed:  https://bugs.launchpad.net/snappy/+bug/1857128 because the portal stuff was landed?
[11:43] <mup> Bug #1857128: Missing configuration option to allow a snap to openFile without prompting <desktop> <Snappy:Confirmed> <https://launchpad.net/bugs/1857128>
[11:44] <mborzecki> pedronis: yes, it landed in https://github.com/snapcore/snapd/pull/8289, so maybe even fix released
[11:44] <mup> PR #8289: xdgopenproxy: forward requests to the desktop portal <Squash-merge> <Created by jhenstridge> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8289>
[11:45] <pedronis> yes, it was in 2.45
[11:46] <mborzecki> pedronis: are you switching the status in LP or should I/
[11:46] <pedronis> I'm switching it
[11:46] <mborzecki> pedronis: thanks
[11:48] <mup> Bug #1857128 changed: Missing configuration option to allow a snap to openFile without prompting <desktop> <Snappy:Fix Released> <https://launchpad.net/bugs/1857128>
[13:18] <mup> PR snapd#9033 closed: osutil, many: add helper for checking whether the process is a go test binary  <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/9033>
[13:26] <zyga-mbp> I'll be back in 5
[13:29] <zyga-mbp> I installed the new leap release
[13:29] <zyga-mbp> it's interesting that it's not a sync of tumbleweed
[13:29] <zyga-mbp> it's a more conservative upgrade
[14:15] <jdstrand> zyga-mbp: hey, it plugs gtk2-common-themes. here is the full snapcraft.yaml: https://git.launchpad.net/~jdstrand/+git/hamster-jdstrand/tree/snapcraft.yaml. note, that version of the yaml has the layout at the bottom commented out, but when I pinged you, I was using that layout
[14:17] <zyga-mbp> jdstrand hey, let me look
[14:17] <zyga-mbp> jdstrand do you have the machine where this happened?
[14:17] <jdstrand> zyga-mbp: yes
[14:17] <jdstrand> it is my laptop :)
[14:17] <zyga-mbp> jdstrand can you check if the mount profile had the layout entries?
[14:18] <jdstrand> zyga-mbp: you mean the fstab file?
[14:18] <zyga-mbp> yes
[14:18] <pedronis> ijohnson: do you want to look at https://github.com/snapcore/snapd/pull/9028 before it lands?
[14:18] <mup> PR #9028: interfaces: new helpers to get and compare system key, for use with seeding debug api (1/N) <Needs Samuele review> <Preseeding 🍞> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9028>
[14:19] <jdstrand> zyga-mbp: well, like I said, I removed the layout. I did look at that file and I'm quite sure it had it, but mountinfo after nsenter didn't
[14:20] <ijohnson> pedronis: sure let me quickly review it now
[14:21] <zyga-mbp> jdstrand mhm, the content interfaces there do not interact with /usr so I think we can rule out some bugs related to that
[14:21] <zyga-mbp> I cannot explain why that would happen
[14:22] <jdstrand> zyga-mbp: yeah, I don't really have enough info. I really just wanted you to know that I suspect it was happening after a refresh of the snapd snap
[14:23] <zyga-mbp> of snapd snap - hmm!
[14:23] <jdstrand> I can't say for sure though
[14:24] <jdstrand> zyga-mbp: but I moved to snapd from edge to get an interface that is only there, and I was seeing this issue daily. we know edge updates daily...
[14:24] <jdstrand> zyga-mbp: I don't know if it was coincidence or not though, but it made me suspicious
[14:25] <jdstrand> let me try something in a vm
[14:27] <zyga> re, sorry, even moving across vms suspens my laptop
[14:27] <zyga> er
[14:27] <zyga> not vms, rooms
[14:32] <pedronis> ijohnson: the preseed test issue seems to be constant on 20.10, not sure what is going on, but is not related to cloud-init in particular
[14:33] <mup> PR snapd#9028 closed: interfaces: new helpers to get and compare system key, for use with seeding debug api (1/N) <Needs Samuele review> <Preseeding 🍞> <Created by stolowski> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/9028>
[14:34] <ijohnson> pedronis: yes I will look into it shortly, just finishing up something else right now
[14:50] <pedronis> zyga-mbp: cachio: what is blocking #8950 ?
[14:50] <mup> PR #8950: tests: new to-one-line tool which replaces the strings.sh helper <Squash-merge> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/8950>
[14:51] <zyga-mbp> nothing from my POV
[14:52] <cachio> pedronis, a second review?
[14:52] <pedronis> zyga-mbp: cachio: there is discussion about a shellcheck override, that isn't to me if it's nice to have or a blocker
[14:52] <pedronis> *isn't clear
[14:52] <zyga-mbp> ah, that, we discussed that on mattermost and I'm +1 on the approach now
[14:53] <cachio> pedronis, currently we have a check in the unit/go test
[14:54] <cachio> we discussed that with zyga last week
[14:54] <cachio> I'll prepare a pr to make a geniric shellcheck on each test this week, the idea is that each test defines which is the tool to test and that should be enought
[14:56] <pedronis> zyga-mbp: cachio: I'm landing it then, there can always be follow up but is been open for enough time
[14:56] <zyga-mbp> thansk!
[14:56] <cachio> pedronis, tx
[14:56] <zyga-mbp> *thanks
[14:58] <mup> PR snapd#8950 closed: tests: new to-one-line tool which replaces the strings.sh helper <Squash-merge> <Created by sergiocazzolato> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/8950>
[15:14] <mup> PR snapcraft#3223 opened: sentry: don't report tool missing errors <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3223>
[15:29]  * cachio lunch
[17:00] <zyga-mbp> brb
[18:00] <mup> PR snapcraft#3224 opened: cli: provide option to install ca certs into build environment <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3224>
[19:32] <jdstrand> zyga: aha, here is your reproducer: https://bugs.launchpad.net/snapd/+bug/1888305
[19:32] <mup> Bug #1888305: layout lost after snapd refresh with long running content plugging snap <snapd:New> <https://launchpad.net/bugs/1888305>
[21:59] <ogra_> jdstrand, hmm ... do we have any interface where we could add mailbox access ?
[21:59] <ogra_> Jul 20 21:55:38 pi4 kernel: audit: type=1400 audit(1595282138.714:760😞 apparmor="DENIED" operation="open" profile="snap.node-red-rpi.node-red" name="/dev/vcio" pid=24279 comm="python" requested_mask="r" denied_mask="r" fsuid=0 ouid=0
[21:59] <ogra_> (heh ... silly emoji plugin)
[22:01] <ogra_> vcio seems to be the device to access the VC mailbox in the Pi GPU firmware
[22:05] <jdstrand> ogra_: yeah, we do not. that seems like perhaps an addition to the opengl interface
[22:06] <jdstrand> ogra_: I added a todo to investigate for 2.46
[22:06] <ogra_> thanks !