| OvenWerks | Eickmeyer[kde]1: does this look too convoluted: | 03:35 |
|---|---|---|
| OvenWerks | if (not nzd in blacklist) and ((def_config['DRIVER'] == "firewire") or (nzd != def_config['DEV'])): | 03:35 |
| OvenWerks | Thats all one line... | 03:35 |
| krytarik | if nzd not in blacklist and (def_config['DRIVER'] == "firewire" or nzd != def_config['DEV']): -- dropping a few parentheses here. >_> | 03:41 |
| OvenWerks | krytarik: Ya, I figured that was possible, the extras make for better readability | 03:43 |
| krytarik | Hmm, yeah possibly.. | 03:44 |
| OvenWerks | Anyway point taken, parentheses removed | 03:48 |
| krytarik | I mean there is always the consideration on Python to use parentheses or not, for readability or consistency with the rest of the code - but I did have a quick look at the existing code before suggesting that. :) | 03:50 |
| * OvenWerks tries to think if that part is even uploaded yet... I guess something similar | 03:52 | |
| OvenWerks | I think it was just: if nzd not in blacklist | 03:52 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!