[05:00] <mborzecki> morning
[05:56] <mborzecki> heh, vendor.json keep flipping between 2 revisions of secboot package
[06:58] <mborzecki> jamesh: iirc pulseaudio tests fail pretty consistently on 20.10, i don't remember whether it's the same case for preseed though
[06:58] <jamesh> mborzecki: thanks.
[07:01] <mborzecki> hmm interesting behavior of shellcheck https://github.com/koalaman/shellcheck/issues/650
[07:43] <mup> PR snapd#8851 closed: interface/fwupd: add more policies for making fwupd upstream strict <Needs security review> <Created by woodrow-shen> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/8851>
[08:13] <pedronis> mborzeck1: hi, could you finish the review of #8959 when you have a moment, I will also look at it today
[08:13] <mup> PR #8959: gadget,gadget/install: refactor partition table update <UC20> <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/8959>
[08:37] <mborzecki> it'd be nice if for queued check jobs, there'd be some info since when the job has been in that state
[08:38] <mup> PR snapd#9023 closed: sysconfig/cloudinit: add CloudInitStatus func + CloudInitState type <Created by mvo5> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/9023>
[08:43] <jamesh> pedronis: do you think https://github.com/snapcore/snapd/pull/8861 is good to merge then?
[08:43] <mup> PR #8861: data,packaging,wrappers: extend D-Bus service activation search path <Created by jhenstridge> <https://github.com/snapcore/snapd/pull/8861>
[08:45] <pedronis> jamesh: I need to look at it again, I'll try to do that today or tomorrow
[08:45] <jamesh> thanks.
[10:08] <mup> PR snapd#8959 closed: gadget,gadget/install: refactor partition table update <UC20> <Created by cmatsuoka> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/8959>
[13:41] <jdstrand> zyga: not sure if you say, but I have a reproducer: https://bugs.launchpad.net/snapd/+bug/1888305
[13:41] <mup> Bug #1888305: layout lost after snapd refresh with long running content plugging snap <snapd:New for zyga> <https://launchpad.net/bugs/1888305>
[13:41] <jdstrand> zyga: saw*
[13:41] <jdstrand> zyga: and hello :)
[13:44] <ijohnson> jdstrand: I think Zygmunt is off today
[13:54] <mup> PR core20#76 opened: hooks/001-extra-packages.chroot: add gdbserver <Created by anonymouse64> <https://github.com/snapcore/core20/pull/76>
[13:56] <mup> PR core18#163 opened: hooks/001-extra-packages.chroot: add gdbserver <Created by anonymouse64> <https://github.com/snapcore/core18/pull/163>
[14:04] <mup> PR snapd#9039 opened: cmd/snap-seccomp/syscalls: add faccessat2 (2.45) <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9039>
[14:05] <mborzecki> pedronis: ^^
[14:05] <pedronis> thanks
[14:26] <mborzecki> pedronis: fwiw google:ubuntu-20.10-64:tests/main/interfaces-audio-playback-record seems to be passing in isolation
[14:27] <pedronis> interesting
[14:29] <mborzecki> pedronis: the recording bit i handled by snap policy module which is added by ubuntu patches, and it queries the snapd api to get the connected plugs
[14:30] <pedronis> yes
[14:30] <mborzecki> pedronis: there shouldn't be any races there though
[14:34] <mborzecki> pedronis: otoh, it ECONNREFUSED, so maybe pulseaudio just died there?
[15:41] <zyga> o/
[15:41] <zyga> jdstrand: that's great news
[15:41] <ijohnson> hey zyga
[15:42]  * zyga woke up and catching up
[15:42] <zyga> today was not the best but it's almost over
[15:42] <zyga> ah
[15:43] <zyga> jdstrand: interesting that it is related to snapd refresh
[15:43] <zyga> it could be related to something i was looking at lately
[15:45] <zyga> jdstrand: https://forum.snapcraft.io/t/injecting-snapd-tools-into-base-snaps-and-keeping-them-up-to-date/12139
[15:45] <zyga> (the last comment there)
[15:45] <zyga> no need to read it but I suspect that's really just uncovering a bug we knew existed for a while
[15:45] <zyga> it's great that there's a reproducer, I will try to pull myself together and write a spread test based on your super detailed bug report
[15:46]  * cachio lunch
[15:47] <zyga> hey ijohnson :)
[16:08] <pedronis> ijohnson: I did a review of #9010
[16:08] <mup> PR #9010: cmd/snap-bootstrap/initramfs-mounts: call systemd-mount instead of the-tool <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9010>
[16:12] <pedronis> zyga: hi, I reviewed #8977 in my morning
[16:12] <mup> PR #8977: cmd/snap: track started apps and hooks <Created by zyga> <https://github.com/snapcore/snapd/pull/8977>
[16:13] <zyga> thank you, I didn't look yet
[16:13]  * zyga looks
[16:13] <zyga> ah, thanks I'll send some updates there shortly
[16:14] <zyga> I will be around normally tomorrow
[16:20] <jdstrand> zyga: cool, thanks (though, I was told today you're off, so, only do it if it is fun and relaxing :)
[16:20] <zyga> jdstrand: yes because it's a mystery and I want to know :)
[16:20] <jdstrand> :)
[16:21] <jdstrand> zyga: hopefully for a spread test you will create a smaller reproducer snap ;)
[16:23] <zyga> yes, I just did
[16:26] <pedronis> ijohnson: when you have time, #9030 needs your review
[16:26] <mup> PR #9030: bootloader/assets: helpers for registering per-edition snippets, register snippets for grub <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9030>
[16:26] <ijohnson> pedronis: yes I will review it today
[16:27] <ijohnson> and thanks for the review
[16:27] <pedronis> np, thank you
[16:33] <pedronis> mostly eod but I will look again later at the tests of some PRs to see if they are landable
[16:44] <zyga> jdstrand: btw, did you notice that the snap has this:     target: $SNAP/data-dir/icons
[16:44] <zyga> twice
[16:44] <zyga> (I guess we should validate better)
[16:47] <jdstrand> zyga: ah, no, thanks! this doesn't use sounds so I never noticed it
[16:49] <Elleo> what's the correct way to get the user's real home directory from within a snap?
[16:51] <zyga> Elleo: there isn't a perfect way but most people use /home/$LOGNAME
[16:51] <Elleo> zyga: okay, thanks
[16:51] <zyga> I have a patch somewhere that provides that but it's not proposed anywhere
[16:51] <Elleo> ah, okay
[16:52] <Elleo> I vaguely remembered some discussion of adding an "$ORIG_HOME" variable or something, but wasn't sure if that ever happened
[16:53] <zyga> right, I don't think it did
[17:48] <cachio> ijohnson, hey
[17:48] <cachio> ijohnson, about the comment https://github.com/snapcore/snapd/pull/9027#discussion_r458208030
[17:48] <mup> PR #9027: tests: refresh/revert snapd in uc20 <Run nested> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9027>
[17:49] <cachio> ijohnson, cmatsuoka requested me to force the reboot when we refresh and revert snapd
[17:49] <cachio> to check if tpm works well afte the reboot
[17:51] <cachio> or it is ok and I should leave the code you proposed without explaining why we force the reboot
[17:54] <ijohnson> cachio: I understand
[17:54] <ijohnson> cachio: it's okay to still do a reboot after the refresh
[17:54] <ijohnson> cachio but the code as is is masking whether or not snapd triggered a reboot for the given type of refresh
[17:54] <cachio> ijohnson, yes, that could be a problem
[17:55] <ijohnson> The code you have always reboots and so if there was a bug where we trigger a reboot when we shouldn't be, or vice versa, your code would mask the problem and make the test pass
[17:55] <cachio> or perhaps it does not work properly if we dont reboot
[17:55] <ijohnson> Yes exactly
[17:55] <cachio> perhaps I could test both scnarios
[17:56] <ijohnson> That's why I wanted you to refactor it to check what kind of snap was being refreshed, and ensure the change for snaps that don't automatically trigger a reboot don't trigger a reboot
[17:56] <cachio> 1 forcing reboot and also without reboot
[17:56] <ijohnson> I provided some example code for how to do that
[17:56] <ijohnson> cachio: I don't think we need two tests
[17:56] <ijohnson> Just make the existing test slightly more accommodating to the different scenarios
[17:57] <cachio> ijohnson, I mean, same test test both thinks
[17:57] <cachio> things
[17:58] <cachio> ijohnson, but in the code you proposed it is going to reboot always for snapd and pc snaps
[17:59] <cachio> it is waiting until the refresh is comppleted fedore the reboot
[17:59] <cachio> right?
[17:59] <ijohnson> cachio: yes it will reboot anyways but if snapd triggered the reboot it would make one of the commands fail if I understand what I wrote correctly
[17:59] <ijohnson> Yes exactly if the reboot was triggered as part of the refresh then I think that command would exit non-xero and the test would fail
[18:00] <cachio> ijohnson, ah, ok, in that case I'll apply that
[18:00] <cachio> thanks for the suggestion
[18:01] <ijohnson> cachio: yaw, hopefully it's not too difficult to make work
[18:01] <cachio> trying now
[18:21] <mup> PR snapd#9038 closed: tests: check for pids correctly <Test Robustness> <Created by zyga> <Merged by cmatsuoka> <https://github.com/snapcore/snapd/pull/9038>
[18:40] <zyga> jdstrand: interesting, the reproducer fails with
[18:40] <zyga> + test-snapd-app.sh -c test -d /usr/share/hamster-applet
[18:40] <zyga> update.go:85: cannot change mount namespace according to change mount (/snap/gtk-common-themes/1506/share/gtk2/Materia-compact /snap/test-snapd-app/x1/data-dir/themes/Materia-compact none bind,ro 0 0): cannot write to "/snap/gtk-common-themes/1506/share/gtk2/Materia-compact" because it would affect the host in "/snap"
[18:46] <mup> PR snapd#9040 opened: spread: add opensuse 15.2 and tumbleweed for qemu <Simple 😃> <Created by jdstrand> <https://github.com/snapcore/snapd/pull/9040>
[18:46] <jdstrand> zyga: huh
[18:47] <jdstrand> zyga: fyi, don't worry about tumbleweed lzo. I am doing it
[18:49] <zyga> k
[18:49] <zyga> that log is just a warning, not an error (in the sense that it doesn't stop)
[18:49] <zyga> but it's still wrong
[18:49] <jdstrand> yeah
[18:50]  * jdstrand idly wonders if his https://blog.strandboge.com/2019/04/16/cloud-images-qemu-cloud-init-and-snapd-spread-tests/ has been useful for others here... I've found it immensely useful for my spread testing :)
[19:11] <mup> PR snapd#9018 closed: cmd/snap-preseed: check that target path exists and is a directory on --reset <Preseeding 🍞> <Simple 😃> <Created by stolowski> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/9018>
[19:19] <zyga> kenvandine: hi
[19:19] <zyga> I found a small bug in gtk-common-themes
[19:19] <zyga> cat /snap/gtk-common-themes/current/meta/snap.yaml | grep Materia-dark-compact
[19:19] <zyga> this shows
[19:19] <zyga>       - $SNAP/share/gtk2/Materia-dark-compact
[19:20] <zyga> but
[19:20] <zyga> ls -ld /snap/gtk-common-themes/1506/share/gtk2/Materia-dark-compact
[19:20] <zyga> ls: cannot access '/snap/gtk-common-themes/1506/share/gtk2/Materia-dark-compact': No such file or directory
[19:20] <zyga> jdstrand: the error was a red herring
[19:31] <mup> PR snapd#9041 opened: osutil/group.go: treat all non-nil errs from user.Lookup{Group,} as Unknown* <Bug> <Preseeding 🍞> <⚠ Critical> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9041>
[19:41] <zyga> something is weird in a way that makes no sense
[19:41] <ijohnson> tell me about it
[19:41]  * ijohnson is slightly bitter about error checking getpwnam_r
[20:08] <pedronis> zyga: have we just too many PRs, started too many tests, or something else is off, we have some PRs with queued tests since hours, for example: https://github.com/snapcore/snapd/pull/9012
[20:08] <mup> PR #9012: release/2.45: merge 2.45.2 release <Created by mvo5> <https://github.com/snapcore/snapd/pull/9012>
[20:21] <zyga> pedronis: checking
[20:22] <zyga> only 4 spread runs in progress
[20:22] <zyga> now three
[20:22] <zyga> we may be queued on the github hosted tests
[20:23] <zyga> https://github.com/snapcore/snapd/actions?query=is%3Aqueued is very small
[20:23] <ijohnson> it's odd that there's a bunch of jobs that are still waiting though
[20:24] <ijohnson> for example https://github.com/snapcore/snapd/pull/9013
[20:24] <mup> PR #9013: many: merge 2.45.2 fixes back into master <⛔ Blocked> <Created by mvo5> <https://github.com/snapcore/snapd/pull/9013>
[20:25] <ijohnson> actually now that I mention it that's the only one I can find other than the one pedronis found
[20:25] <zyga> hmmm
[20:25] <zyga> I did the close & reopen dance
[20:25] <zyga> now they show up in the queue
[20:29] <zyga> ijohnson: when it says "expected"
[20:29] <zyga> it means that it's not queued
[20:29] <zyga> but the rules say it should run
[20:29] <ijohnson> ah interesting
[20:29] <zyga> so likely a bug on their side
[20:29] <zyga> I close/reopend both
[20:29] <zyga> that reliably fixes it
[20:29] <ijohnson> zyga: so does it work to close and re-open someone else's PR?
[20:29] <zyga> or not?
[20:29] <zyga> yeah
[20:29] <ijohnson> I seem to have thought that wasn't allowed
[20:30] <zyga> it didn't change from queued
[20:30] <zyga> er
[20:30] <ijohnson> but maybe I just misremember that
[20:30] <zyga> from expected
[20:31] <zyga> I wonder if the fact it has conflicts matters
[20:31] <zyga> could it be that actions don't run
[20:31] <zyga> because it cannot be merged
[20:31] <zyga> so it cannot create the workspace for actions?
[20:31] <ijohnson> mmm interesting
[20:31] <ijohnson> could be
[20:33] <zyga> eh, shit
[20:33] <zyga> I just got a note that I need to re-do blood tests
[20:33] <zyga> for unknown reason
[20:34] <zyga> so I need to go there again and endure the morning without painkillers
[20:34] <zyga> eh, ...
[20:34] <zyga> more details in the morning
[20:34] <ijohnson> oh I'm so sorry to hear that
[20:35] <zyga> oh well
[20:35] <ijohnson> hope everything's still ok for your surgery
[20:35] <zyga> every day is something now
[20:35] <zyga> but it's just a few more days
[20:35] <zyga> then it's going to be better
[20:36] <zyga> week to get the stitches removed
[20:36] <zyga> about two weeks for most of the cut to heal
[20:36] <zyga> and in a month I should be able to sit normally again
[20:54] <zyga> jdstrand: do you have any experimental options set?
[20:54] <jdstrand> zyga: I do. is there an easy to list them all?
[20:55] <jdstrand> ah yes
[20:55] <jdstrand> $ sudo snap get system experimental
[20:55] <jdstrand> Key                              Value
[20:55] <jdstrand> experimental.hotplug             true
[20:55] <jdstrand> experimental.parallel-instances  true
[20:55] <jdstrand> zyga: ^
[20:56] <zyga> thanks
[21:37] <zyga> jdstrand: no luck with a reproducer
[21:37] <zyga> I'll try more tomorrow
[21:37] <zyga> I pushed what I have
[21:38] <zyga> https://github.com/snapcore/snapd/compare/master...zyga:fix/lp-1888305?expand=1
[21:38] <zyga> o/