[14:44] <kkeithley> s390x question: I just did builds of glusterfs-8 in https://launchpad.net/~gluster.   Even though automake is not an explicit requires in control, it was installed.  But 10min later doing glusterfs-7 builds automake is not found and the build fails
[14:44] <kkeithley> previous glusterfs-7 builds worked on s390x
[14:45] <kkeithley> but I'm probably in the wrong place for this
[14:47] <cjwatson> kkeithley: Can you provide a link to the failed build?
[14:49] <cjwatson> Oh, maybe https://launchpadlibrarian.net/489648063/buildlog_ubuntu-groovy-s390x.glusterfs_7.7-ubuntu1~groovy2_BUILDING.txt.gz?
[14:49] <kkeithley> yes
[14:49] <cjwatson> kkeithley: The error is specifically that automake-1.13 is not found
[14:49] <cjwatson> Get:54 http://ftpmaster.internal/ubuntu groovy/main s390x automake all 1:1.16.2-3ubuntu1 [548 kB]
[14:50] <cjwatson> kkeithley: This is probably because the source package ships with autoconf/automake output that somebody generated on an old system with automake 1.13.  The usual fix is to use dh-autoreconf to regenerate the build system with modern tools before doing anything else.  I see your package build-depends on dh-autoreconf, but maybe it doesn't actually use it?
[14:51] <kkeithley> yes, I'm building the .dsc on a focal box
[14:51] <cjwatson> It's best to make it irrelevant what series you built it in.
[14:51] <cjwatson> *on
[14:51] <kkeithley> er, the source_changes
[14:51] <cjwatson> And indeed, I see that your glusterfs-8 build log mentions running dh_autoreconf, but your glusterfs-7 build log does not.
[14:52] <cjwatson> That's where I would start investigating.
[14:52] <cjwatson> It may be automatic depending on debhelper compat version.
[14:52] <kkeithley> hmm.. okay. I'm not a debian packager by any stretch. let me see what I can figure out.
[14:53] <kkeithley> thanks for the hint
[14:53] <cjwatson> Ah yes - your glusterfs-7 package uses debhelper compat level 9 (see debian/compat), while your glusterfs-8 package uses debhelper compat level 11.
[14:54] <cjwatson> "man debhelper" documents that dh_autoreconf is run by default as of compat level 10.
[14:54] <kkeithley> indeed
[14:54] <cjwatson> But the least invasive fix is probably to leave the compat level alone, and instead add "--with autoreconf" (or add autoreconf to an existing dh --with) when using compat <10.
[14:55] <kkeithley> okay.  fwiw I inherited this job years ago and it has usually run smoothly.  Except when it doesn't. :-)
[14:55] <cjwatson> Changing the compat level changes various other things, and if you aren't familiar with them it's probably best not to get into that when you're just trying to fix this one issue.
[14:56] <kkeithley> noted.
[14:57] <cjwatson> You might need to explicitly add dh-autoreconf to Build-Depends when doing that, too.
[14:58] <kkeithley> okay