=== tinwood is now known as tinwood-afk | ||
=== tinwood-afk is now known as tinwood | ||
stickupkid | manadart_, achilleasa can one of you review this bad boy? https://github.com/juju/juju/pull/11848 | 10:58 |
---|---|---|
stickupkid | hml, I've updated the description to include the other fields now https://github.com/juju/description/pull/83 | 14:32 |
stickupkid | hml, so it's up for re-review :) | 14:32 |
hml | stickupkid: do we have an answer to my question in the PR? sorry, don’t remember | 14:33 |
hml | i’ll review after lunch | 14:33 |
stickupkid | hml, yes, i added the fields to model the charm. I was just waiting to understand what we wanted to model and get approval for it | 14:33 |
hml | stickupkid: rgr | 14:33 |
achilleasa | stickupkid: got some minor comments on your PR | 15:00 |
=== ulidtko|k is now known as ulidtko | ||
stickupkid | achilleasa, sorry missed this message | 16:11 |
stickupkid | sure will check | 16:11 |
stickupkid | achilleasa, done | 16:34 |
thumper | morning | 20:43 |
hml | hi thumper | 20:43 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!