[04:30] <wallyworld> hpidcock: jenkins is busy and is timing out a bit, but there's some final test runs in progress (snap, release, ci) for this PR https://github.com/CanonicalLtd/juju-qa-jenkins/pull/482
[04:53] <hpidcock> wallyworld: looking
[04:54] <wallyworld> hpidcock: ty, i just pushed a small change to add extra validation to the git commit sha params. i added a validating string plugin to jenkins
[04:58] <wallyworld> ah balls, just broke it, fixing
[04:58] <hpidcock> wallyworld: loving the validating-string for job params
[04:59] <wallyworld> yeah
[04:59] <wallyworld> i just remove dstaging root as a param for release job and injected it but not evrything picks it up, sigh
[04:59] <wallyworld> there's a few jobs like that
[04:59] <wallyworld> where param injection seems to be flakey
[05:00] <hpidcock> wallyworld: welcome to my world
[05:01] <wallyworld> i'll just add it back as a param for now
[05:10] <hpidcock> wallyworld: added some comments
[05:10] <wallyworld> ty
[05:12] <wallyworld> hpidcock: i already pushed validating strings in those other places :-)
[05:13] <wallyworld> hpidcock: and yeah, deliberately killed 2.7 cause no more releases and if we do, we will make it work the new way
[09:36] <stickupkid> achilleasa, whoops https://github.com/juju/description/pull/84
[09:37] <achilleasa> stickupkid: done
[09:38] <stickupkid> ta
[09:48] <manadart_> achilleasa: Can you look at this one? https://github.com/juju/juju/pull/11856
[09:49] <achilleasa> manadart_: sure; give me a few min and I can look
[10:53] <manadart_> achilleasa: Found an issue with it.
[11:38] <achilleasa> manadart_: did you see my comments in the PR?
[11:42] <manadart_> achilleasa: Yep, thanks. I think I've addressed it all and fixed the prior issue. QA is working now.
[14:20] <manadart_> Anyone able to tick a forward merge? https://github.com/juju/juju/pull/11858
[14:44] <SpecialK|Canon> .win 25
[14:44] <SpecialK|Canon> sorry; new keyboard
[14:45] <stickupkid> SpecialK|Canon, mechanical keyboard with flashy LEDs?
[14:45] <SpecialK|Canon> stickupkid: laptop keyboard with no ortho :(
[14:48] <achilleasa> stickupkid: these validators make me sad https://github.com/juju/description/blob/v2/model.go#L1042... guess why :D
[14:49] <stickupkid> why does a dto have validation :|
[14:49] <achilleasa> see the sets being passed in by value?
[14:50] <stickupkid> MAP
[14:50] <stickupkid> set.Strings
[14:50] <stickupkid> not yours, don't modify it
[14:50] <stickupkid> NYDMI
[14:50] <achilleasa> there are more such validators there
[14:50] <achilleasa> I will do a drive-by
[16:00] <stickupkid> hml, the ground works for refresh API https://github.com/juju/juju/pull/11815
[16:00] <hml> stickupkid: rgr
[16:28] <achilleasa> stickupkid: or hml can one of you take a look at https://github.com/juju/description/pull/85?
[16:28] <achilleasa> let me know if the PR description seems confusing :D
[16:28] <stickupkid> EOW... I'll pick it up neext week if hml doesn't get a chance
[16:29] <achilleasa> no rush; I changed juju's go.mod to work with my local copy so I can keep working until this bit is reviewed
[16:29] <achilleasa> I 'm EOW in 30min as well :D