[00:31] <lubot> <tsimonq2> @ItzSwirlz [good for you], Who asked?
[00:32] <lubot> <teward001> @tsimonq2 [Who asked?], your mom.
[00:32] <lubot> <teward001> :P
[01:01] <lubot> <ItzSwirlz> shut up guys
[01:01] <lubot> <ItzSwirlz> fr this sucks
[01:01] <lubot> <ItzSwirlz> people are stupid
=== DrewRWx_ is now known as DrewRWx
=== ddevault is now known as Guest80933
=== ddevault_ is now known as ddevault
[11:01] <The_LoudSpeaker> is 20.04.1 image ready?
[11:02] <The_LoudSpeaker> https://phab.lubuntu.me/D98 this was supposed to go in with 20.04.1 
[11:03] <The_LoudSpeaker> ^ wxl @tsimonq2 @kc2bez approve ploxx
[12:30] <lubot> <tsimonq2> I guess it must have snuck up on us
[16:54] <The_LoudSpeaker> ?
[16:55]  * The_LoudSpeaker doesn't have english as his native.
[18:46] <The_LoudSpeaker> @kc2bez: just read your comment. Did you have the lubuntu-grub-theme package installed After installation? Also, can you paste your /etc/default/grub ?
[18:52] <The_LoudSpeaker> I remember pusing to rMETA but not uploading it.
[18:52] <The_LoudSpeaker> I forgot if the upload is required for rMETA
[18:53] <kc2bez> https://paste.ubuntu.com/p/PdFGpfgRMM/
[18:56] <kc2bez> https://paste.ubuntu.com/p/5d32sgcVvV/
[18:57] <kc2bez> There you go @The_LoudSpeaker ^
[18:57] <The_LoudSpeaker> thanks!
[18:57] <kc2bez> np
[18:57] <The_LoudSpeaker> I see that the THEME variable isn't set yet
[18:58] <The_LoudSpeaker> The D98 specifically sets it
[18:58] <kc2bez> I applied D98 to a live session
[18:58] <The_LoudSpeaker> do you have any files in /etc/default/grub.d/ ?
[19:00] <kc2bez> init-select.cfg is in there
[19:00] <The_LoudSpeaker> nope thats always there.
[19:01] <kc2bez> right
[19:01] <kc2bez> all the lines are commented out anyway
[19:03] <The_LoudSpeaker> where do I check if GRUB_ENABLE_CRYPTODISK: true was applied? 
[19:13] <kc2bez> That should only get applied if LUKS is used.
[19:13] <The_LoudSpeaker> okay
[19:14] <The_LoudSpeaker> https://www.gnu.org/software/grub/manual/grub/grub.html#Configuration this confirms GRUB_THEME is the correct parameter. 
[19:14] <The_LoudSpeaker> Why doesn't it get applied then?
[19:44] <The_LoudSpeaker> I guess we should set GRUB_THEME as a cfg in /etc/default/grub.d/
[19:51] <The_LoudSpeaker> The problem with using /etc/default/grub.d/ is that it gets considered when update-grub is run and not when grub-mkconfig is run. the latter runs during lubuntu installation.
[19:53] <The_LoudSpeaker> we had implemented /etc/default/grub.d/grub-theme.cfg previosly but I remember GRUB_THEME not getting set during installation.
[19:57] <TJ-> The_LoudSpeaker: could that be due to calamares ordering ?
[19:58] <The_LoudSpeaker> We can do what breeze theme does, append a line to /etc/default/grub itself. We already have overrite: false set in https://phab.lubuntu.me/source/calamares-settings-ubuntu/browse/master/lubuntu/modules/grubcfg.conf so it won't get overritten when putting other things in that file.
[19:58] <The_LoudSpeaker> TJ-: how can I check?
[19:59] <TJ-> The_LoudSpeaker: well, check how it does things. if like you say it diretyl calls grub-mkconfig then that isn't going to play well but it ought to call "update-grub, the shell-script wrapper
[20:00] <The_LoudSpeaker> ^ wxl you know the order?
[20:01] <kc2bez> https://phab.lubuntu.me/source/calamares-settings-ubuntu/browse/master/lubuntu/settings.conf
[20:02] <TJ-> The_LoudSpeaker: looking at the shell script /usr/sbin/grub-mkconfig it actually *does* source those files:  for x in ${sysconfdir}/default/grub.d/*.cfg ; do
[20:02] <TJ-> The_LoudSpeaker: so which-ever way it is triggered those files should be included (file permissions allowing)
[20:04] <The_LoudSpeaker> then I don't know why it didn't work last time.
[20:04] <The_LoudSpeaker> I will give it another try.
[20:05] <The_LoudSpeaker> forget D98
[20:05] <TJ-> Typo in the variable name?
[20:06] <The_LoudSpeaker> I don't remember so.
[20:19] <The_LoudSpeaker> https://phab.lubuntu.me/rARTc7b5bed2ff91d1c410cd75328fb4431d69f40a1c#change-uhCaCizq56ep
[20:19] <The_LoudSpeaker> This was the previos one.
[20:32] <The_LoudSpeaker> I have pushed the changes to phab for the cfg. 
[20:32] <The_LoudSpeaker> Now uploading.
[20:37] <TJ-> one thing that occurs; the .postinst script is doing "update-grub" - that'll only work if /usr/sbin/ is in the PATH at that point - might be worth checking the installer's environment and how it works - is it creating a chroot for the /target/ and if so is that in the PATH? might be worth explicitly calling "/usr/sbin/update-grub" and testing
[20:52] <The_LoudSpeaker> I think it wasn't working and that's why we had removed the posy install script later.
[20:53] <The_LoudSpeaker> Right now it only places the things in place like grub2-themes-mate does
[20:54] <The_LoudSpeaker> I am depending on cala to call update-grub and use the cfg file in grub.d 
[21:04] <TJ-> I doubt calamares will call 'update-grub' unless it is Debian/Ubuntu aware; for cross-OS it'd call grub-mkconfig I'd expect
[23:18] <lubot> <ItzSwirlz> h
[23:18] <lubot> <ItzSwirlz> i
[23:18] <lubot> <ItzSwirlz> motus think ubuntu cinnamon is a joke so meanwhile
[23:18] <lubot> <ItzSwirlz> at my 'playground'
[23:18] <lubot> <ItzSwirlz> give me something to do
[23:18] <lubot> <ItzSwirlz> lmfao