| hpidcock | either wallyworld kelvinliu or tlm please review this PR https://github.com/juju/juju/pull/11861 | 03:36 |
|---|---|---|
| tlm | can do, doing one for thumper atm | 03:39 |
| kelvinliu | lgtm, just a few minor imports issues | 03:52 |
| hpidcock | kelvinliu: thank-you :) | 04:12 |
| kelvinliu | np | 04:14 |
| achilleasa | stickupkid: can you please review https://github.com/juju/description/pull/85? | 09:08 |
| stickupkid | achilleasa, sure, let me finish up what I'm doing here | 09:10 |
| achilleasa | stickupkid: no rush; still working with the state tests but I will need to land this before I can push my PR (probably near EOD today) | 09:11 |
| stickupkid | achilleasa, done, sorry should have mentioned before | 15:23 |
| achilleasa | stickupkid: thanks; saw the GH email | 15:23 |
| achilleasa | got the state tests green :-) | 15:23 |
| stickupkid | boom | 15:23 |
| achilleasa | now it's time to play facade surgery | 15:24 |
| stickupkid | achilleasa, version bump, version bump, version bump | 15:30 |
| achilleasa | stickupkid: that's the next PR; this one will just make the existing facades use the nice and shiny state API | 15:31 |
| stickupkid | hml, https://github.com/juju/juju/pull/11862 | 16:18 |
| hml | stickupkid: ack | 16:19 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!