mup | PR snapcraft#3233 opened: travis: set cla check as final stage <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3233> | 00:21 |
---|---|---|
az | https://forum.snapcraft.io/t/get-snap-package-and-dependencies-size-before-installing/19135 | 03:23 |
az | https://forum.snapcraft.io/t/how-to-get-dependencies-and-reserve-dependencies-for-a-sanp-package/19134 | 03:23 |
mborzecki | morning | 05:14 |
pedronis | mborzecki: hi, seems we got a new strange centos failure? https://github.com/snapcore/snapd/pull/9068 | 07:17 |
mup | PR #9068: tests/main/selinux-clean: workaround SELinux denials triggered by linger setup on Centos8 <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9068> | 07:17 |
mborzecki | pedronis: hi, hmmm that's weird | 07:19 |
pedronis | it's not related to your change but yes | 07:19 |
mborzecki | huh, /sys/fs/cgroup/unified really isn't there | 07:22 |
mup | PR snapd#9006 closed: bootloader: compose command line with mode and extra arguments <Squash-merge> <UC20> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/9006> | 07:22 |
mup | PR snapd#9068 closed: tests/main/selinux-clean: workaround SELinux denials triggered by linger setup on Centos8 <Simple 😃> <Created by bboozzoo> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/9068> | 07:22 |
=== pedronis_ is now known as pedronis | ||
mborzecki | pedronis: systemd was switched to use default-hierarchy=legacy | 07:24 |
pedronis | interesting | 07:25 |
mup | PR snapd#9071 closed: release: 2.45.3.1 <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/9071> | 07:27 |
mup | PR snapd#9072 closed: packaging: add placeholder changelog for 2.45.3.1 <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/9072> | 07:27 |
pedronis | mborzecki: I merged the various release related branches, and I uploaded the release source package | 07:28 |
pedronis | to the ppa | 07:28 |
mborzecki | pedronis: great, thank you for working on it | 07:29 |
mborzecki | let's see what the build will contain | 07:29 |
mborzecki | as for centos8, something is off, there is a changelog entry for systemd, but the switch to legacy was back in 2018 in version 239-7 | 07:29 |
pedronis | mborzecki: the changelog here now looks right: https://launchpad.net/~snappy-dev/+archive/ubuntu/image/+packages | 07:30 |
pedronis | let's say how the build goes | 07:30 |
mborzecki | we still have the named systemd hierarchy | 07:30 |
pedronis | s/say/see | 07:31 |
mborzecki | pedronis: hmm, the diff is large | 07:32 |
mborzecki | ah right, it's a diff between 2.45.3 upload (whic was really master) and 2.45.3.1 | 07:33 |
mborzecki | and it removes things that were on master, so looks legit | 07:34 |
pedronis | mborzecki: are you blocked on me on something atm? | 07:37 |
mborzecki | pedronis: no, i'm good | 07:37 |
mborzecki | quick errand, delivery | 07:37 |
mborzecki | or not | 07:38 |
pedronis | mborzecki: when you have a moment, could you review #9067 ? (UC20 related) | 07:40 |
mup | PR #9067: cmd/snap-bootstrap/initramfs-mounts: add doSystemdMount + unit tests <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9067> | 07:40 |
mborzecki | pedronis: yeah, have it open since yesterday :/ | 07:41 |
pedronis | mborzecki: so amd64 build worked, but we have some build failures (test timeouts) | 07:46 |
mborzecki | retry? | 07:49 |
pedronis | yes, that's what I'm doing | 07:49 |
pedronis | there's quite a bit of conflicts merging back into master :/ | 08:15 |
mborzecki | pedronis: #9063 is not waiting for anything, we can land it right? | 08:15 |
mup | PR #9063: cmd/snap/debug: add "snap debug seeding" command for preseeding debugging (4/N) <Preseeding 🍞> <Run nested> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9063> | 08:15 |
pedronis | mborzecki: I think so | 08:15 |
pedronis | mborzecki: btw there were few changes on master to arch PKGBUILD hope they aren't mandatory | 08:16 |
mborzecki | pedronis: i can take a look when you open the 2.45->master merge branch | 08:17 |
mup | PR snapd#9063 closed: cmd/snap/debug: add "snap debug seeding" command for preseeding debugging (4/N) <Preseeding 🍞> <Run nested> <Created by anonymouse64> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/9063> | 08:18 |
pedronis | mborzecki: there's 20 files in conflict, might take a while | 08:19 |
doko | please could somebody have a look at the snapd autopkg test regressions triggered by dpkg? | 08:20 |
mborzecki | doko: do you have a link to the test? | 08:36 |
doko | mborzecki: https://people.canonical.com/~ubuntu-archive/proposed-migration/update_excuses.html | 08:38 |
mborzecki | hmm that should be an easy fix hopefully | 08:40 |
mborzecki | quick errand, this time for real | 08:42 |
mup | PR snapd#9073 opened: release: 2.45.3.1 <Created by pedronis> <https://github.com/snapcore/snapd/pull/9073> | 09:23 |
mborzecki | re | 09:41 |
mborzecki | doko: this should be fixed in 2.45.3 | 09:46 |
mborzecki | and .3.1 too | 09:47 |
mup | PR snapd#9074 opened: bootloader: extend managed assets bootloader interface to compose a candidate command line <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9074> | 10:33 |
mborzecki | pedronis: do you know how the vendor, no_vendor tarballs get generated for the github releases page? | 11:51 |
pedronis | mborzecki: not really, but I would imagine no vendor can be created with git archive maybe? | 11:53 |
mborzecki | pedronis: hm my guess it's from slicing the tarball we have in LP, mvo usually uploaded those after the builds were done | 11:55 |
pedronis | mborzecki: do we have a tarball in LP? | 11:55 |
mborzecki | pedronis: there's the source tarball that was uploaded for build | 11:56 |
pedronis | there is, that has vendor in though | 11:56 |
mborzecki | ha, w8 i think i got something | 11:57 |
ijohnson | morning folks | 12:04 |
ijohnson | seems that #9063 was landed without some of the changes that I made in #9035 | 12:05 |
mup | PR #9063: cmd/snap/debug: add "snap debug seeding" command for preseeding debugging (4/N) <Preseeding 🍞> <Run nested> <Created by anonymouse64> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/9063> | 12:05 |
mup | PR #9035: o/devicestate: save seeding/preseeding times for use with debug seeding api (3/N) <Preseeding 🍞> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9035> | 12:05 |
ijohnson | shall I merge master into #9035 or just open a separate PR to make for simpler git history ? | 12:05 |
ijohnson | 9035 is also green, so perhaps that would be quickest to just get another +1 to that PR | 12:05 |
mborzecki | ijohnson: hey, i'll take a look | 12:17 |
ijohnson | thanks mborzecki | 12:18 |
mborzecki | ijohnson: maybe you could do a pass over #9074 | 12:18 |
mup | PR #9074: bootloader: extend managed assets bootloader interface to compose a candidate command line <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9074> | 12:18 |
ijohnson | it's just two patches after pedronis' review fixing error message and tests | 12:18 |
ijohnson | mborzecki: sure I will add it to my queue | 12:18 |
mborzecki | ijohnson: oh, and i fixed the caching & artifact | 12:18 |
ijohnson | mborzecki: yes I saw that, thanks for keeping up with that | 12:18 |
ijohnson | seems my idea last night was a bit too naive | 12:18 |
mborzecki | fwiw 33MB of a snap is ok to fit in the cache ;) | 12:19 |
mborzecki | wonder how large the files can be and if we can use that in an interesting ways maybe | 12:20 |
pedronis | mborzecki: did you find out how to make those tars? | 12:23 |
mborzecki | pedronis: sorry, yes, there's a release-tools/repack-debian-tarball.sh script in snapd source tree which does the slicing and stitching | 12:24 |
mborzecki | pedronis: ./repack-debian-tarball.sh snapd_2.45.3.1.tar.xz will produce 3 tarballs | 12:26 |
pedronis | ah, good | 12:27 |
mup | PR snapd#9035 closed: o/devicestate: save seeding/preseeding times for use with debug seeding api (3/N) <Preseeding 🍞> <Created by stolowski> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/9035> | 12:29 |
mup | PR snapd#9075 opened: daemon/api: use pointers to time.Time for debug seeding aspect <Preseeding 🍞> <Simple 😃> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9075> | 12:29 |
ijohnson | thanks mborzecki I just merged it | 12:29 |
ijohnson | and opened the final bit for snap debug seeding, 9075, which is very simple | 12:29 |
mborzecki | ijohnson: https://github.com/snapcore/snapd/pull/9067#discussion_r462261549 little tweak | 12:33 |
mup | PR #9067: cmd/snap-bootstrap/initramfs-mounts: add doSystemdMount + unit tests <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9067> | 12:33 |
ijohnson | mborzecki: thanks! I will take that into a followup I think since this is green | 12:35 |
* ijohnson really likes how green things are to master as of late | 12:35 | |
* ijohnson (with much kicking of github actions) | 12:35 | |
mup | PR snapd#9067 closed: cmd/snap-bootstrap/initramfs-mounts: add doSystemdMount + unit tests <UC20> <Created by anonymouse64> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/9067> | 12:39 |
mup | PR snapd#8558 closed: tests: make the nested library usable independently of spread <Created by sergiocazzolato> <Closed by sergiocazzolato> <https://github.com/snapcore/snapd/pull/8558> | 13:09 |
* cachio afk -> buy a medicine | 13:48 | |
ijohnson | pedronis: #8867 is sudo git mergable, the tests that failed are unrelated, but we could also try to make it green with a master merge | 13:50 |
mup | PR #8867: interfaces: add uinput interface <Needs Samuele review> <⛔ Blocked> <Created by jdstrand> <https://github.com/snapcore/snapd/pull/8867> | 13:50 |
pedronis | ijohnson: did you look at it, it changed a bit since it was last reviewed by others but me? | 14:11 |
ijohnson | pedronis: sorry no I didn't, do you want me to do another review since it changed ? | 14:12 |
pedronis | ijohnson: yes, also maybe a master merge is in order, though I think is quite self contained | 14:12 |
ijohnson | pedronis: ok, I will do a master merge and review it then | 14:12 |
pedronis | ijohnson: thank you | 14:13 |
ijohnson | pedronis: I approved that PR and merged master there | 14:25 |
mborzecki | cmatsuoka: hmm i forgot we have ModeRun/ModeRecover in the boot pacakge | 14:27 |
mup | PR snapcraft#3233 closed: travis: set cla check as final stage <tooling> <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3233> | 14:27 |
ijohnson | 8-line test only PR that only needs 1 more +1: https://github.com/snapcore/snapd/pull/8998 | 14:32 |
mup | PR #8998: tests/cmd/snap-bootstrap/initramfs-mounts: add test case for empty recovery_mode <Simple 😃> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8998> | 14:32 |
ijohnson | also pedronis do you need me to review 9073 too ? | 14:33 |
pedronis | mborzecki: :) | 14:33 |
pedronis | ijohnson: yes if you can | 14:34 |
ijohnson | pedronis: ack will do | 14:34 |
mborzecki | cmatsuoka: btw can you try your branch with the code from #9074 ? | 14:35 |
mup | PR #9074: bootloader: extend managed assets bootloader interface to compose a candidate command line <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9074> | 14:35 |
ogra_ | do we still have the limitation that content interfaces can only be consumed if both snaps come from the same publishr (by default that is ... ) ? | 16:29 |
ijohnson | ogra_: that limitation is only about _auto-connection_ | 16:29 |
ijohnson | ogra_: you can have a content interface from snap from publisher A and another snap from publisher B use that content snap, but either you need to get an auto-connection from the store or make the connection manually | 16:30 |
ogra_ | okay, thanks ... i guess that means a store-request then | 16:31 |
mup | PR snapcraft#3231 closed: file utils: rename get_tool_path() to get_snap_tool_path() <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3231> | 16:33 |
mup | PR snapcraft#3234 opened: project loader: refactor errors to conform to SnapcraftException <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3234> | 16:53 |
mup | PR snapcraft#3235 opened: tests: fix assert ordering for error format tests <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3235> | 17:03 |
mup | PR snapd#8867 closed: interfaces: add uinput interface <Created by jdstrand> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/8867> | 17:15 |
=== ijohnson is now known as ijohnson|lunch | ||
mup | PR snapcraft#3225 closed: specifications: default tracks <specification> <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3225> | 18:38 |
* cachio kinesiologist | 18:45 | |
mup | PR snapcraft#3236 opened: snap: use python3-apt stage-package <maintenance> <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3236> | 20:18 |
mup | PR snapd#8932 closed: o/ifacestate: update security profiles in connect undo handler <Bug> <Created by stolowski> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/8932> | 22:11 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!