| manadart_ | stickupkid, achilleasa: Can I get a review of https://github.com/juju/juju/pull/11853 ? | 09:22 |
|---|---|---|
| achilleasa | manadart_: can look in 5min | 09:23 |
| manadart_ | Ta. | 09:23 |
| manadart_ | achilleasa: I'm tucking into yours now. | 09:25 |
| achilleasa | manadart_: wait a few min; pushing a commit to address Tim's and Ian's comments | 09:26 |
| manadart_ | Righto. | 09:26 |
| achilleasa | manadart_: pushed the changes; taking a look at your PR now | 09:33 |
| manadart_ | achilleasa: Ack. | 09:33 |
| manadart_ | achilleasa: Heads-up: networkconfigapi_test.go is a large change, hidden by default. | 09:39 |
| achilleasa | manadart_: nw, I always expand anything that is not a mock :D | 09:42 |
| stickupkid | the status test failing is a right pain... | 12:10 |
| stickupkid | also this one has started to fail "WorkerSuite.TestRemovedModel" | 12:12 |
| ballot | Hello | 13:20 |
| ballot | I'm trying to see if I can avoid duplicates in a k8s charm with the operator framework in the config items. I would like to have only in one place the "juju-external-hostname" config, so I can configure my ingress. I don't have any of the "kubernetes" related config of the charm in self.model.config. Is there any way to get them ? | 13:21 |
| stickupkid | achilleasa, what can be stored in a charm channel? | 14:43 |
| achilleasa | stickupkid: anything... we used to have validation but because of https://bugs.launchpad.net/juju/+bug/1862091 we just pass whatever we see to the client and the charmstore deals with the validation server-side | 14:56 |
| mup | Bug #1862091: client side channel validation needs to be removed <juju:Fix Released by achilleasa> <https://launchpad.net/bugs/1862091> | 14:56 |
| manadart_ | achilleasa, stickupkid, hml: Regarding our discussion today. What if we inverted the abstraction and made the state objects decorators of a model operation? | 15:05 |
| achilleasa | manadart_: interesting idea. how would that work in the ports example we were discussing? | 15:06 |
| manadart_ | achilleasa: Let me look at that more closely tomorrow. | 15:08 |
| stickupkid | manadart_, achilleasa interested :+1: | 15:10 |
| stickupkid | achilleasa, got a sec? | 16:12 |
| achilleasa | stickupkid: sure | 16:14 |
| achilleasa | daily? | 16:15 |
| stickupkid | yeap | 16:15 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!