jam | morning all | 06:04 |
---|---|---|
* Chipaca struggles to find his voice | 09:29 | |
* bthomas recommends some ginger tea | 09:35 | |
mup | PR operator#369 closed: use yaml instead of json for pod-spec-set call <Created by chipaca> <Closed by chipaca> <https://github.com/canonical/operator/pull/369> | 09:55 |
Chipaca | oops | 09:56 |
mup | PR operator#369 opened: use yaml instead of json for pod-spec-set call <Created by chipaca> <https://github.com/canonical/operator/pull/369> | 09:56 |
facundo__ | ยกMuy buenos dรญas a todos! | 10:15 |
=== facundo__ is now known as facubatista | ||
bthomas | ๐๐ฌ๐ฌ๐ก ๐๐ฌ๐ฏ๐ซ๐ฆ๐ซ๐ค | 10:17 |
bthomas | 10:17 | |
facubatista | hola bthomas :) | 10:18 |
bthomas | :) | 10:18 |
mup | PR operator#370 closed: Update README.md <Created by alejdg> <Merged by chipaca> <https://github.com/canonical/operator/pull/370> | 11:46 |
Chipaca | ballot: have you been able to set aside a bit of time for testing the fix to #293? | 11:56 |
mup | Issue #293: passing k8s_resources to pod.set_spec does not work <juju-workaround> <Created by jetpackdanger> <https://github.com/canonical/operator/issues/293> | 11:56 |
Chipaca | heh, i just realised why you said "if pjdc doesn't have the time" | 11:57 |
ballot | Chipaca: hello ! Not yet, was planning to do this afternoon. Since I need to compile juju and I have only go 1.12 setup on my laptop, I might have to do some tweak. The fix is committed but not released so I guess I need that to test fully the code | 11:57 |
Chipaca | ballot: why comile juju? | 11:58 |
Chipaca | ohh.... no i meant just the fix on operator side, ie #369 | 11:58 |
mup | PR #369: use yaml instead of json for pod-spec-set call <Created by chipaca> <https://github.com/canonical/operator/pull/369> | 11:58 |
Chipaca | because after noticing the fix on juju side, i realised we'd still be broken on older jujus so we really should work around it ourselves as well | 11:58 |
ballot | Chipaca: aaaah, ok, much easier then :) | 11:58 |
ballot | I thought I needed the fix on both sides | 11:59 |
mup | PR operator#368 closed: Clarify ops.testing.Harness.update_config usage <Created by darkalia> <Merged by chipaca> <https://github.com/canonical/operator/pull/368> | 11:59 |
Chipaca | ballot: both fixes fix the issue independently :) | 12:01 |
Chipaca | off to lunch, bbl | 12:18 |
Chipaca | facubatista: #113 could use a re-review | 13:17 |
mup | Issue #113: Automatically transform config into pod spec <Created by knkski> <Closed by niemeyer> <https://github.com/canonical/operator/issues/113> | 13:17 |
Chipaca | er | 13:17 |
Chipaca | charmcraft#113 | 13:17 |
mup | PR charmcraft#113: init: include series in metadata.yaml <Created by chipaca> <https://github.com/canonical/charmcraft/pull/113> | 13:17 |
Chipaca | narindergupta: ๐ | 13:18 |
narindergupta | Chipaca, hey I am starting work on writing a new k8s charm from scratch for Cassandra on k8s just need to know how to start with the k8s component in framework? | 13:19 |
Chipaca | narindergupta: so I pulled mark's work into https://github.com/chipaca/ops-lib-k8s | 13:20 |
Chipaca | narindergupta: the way you use it, add that to your requirements.txt, and then 'k8s = ops.lib.use("k8s", 0, "chipaca@canonical.com")' | 13:21 |
Chipaca | narindergupta: the "that" is "git+https://github.com/chipaca/ops-lib-k8s.git", but it'll be in pip as soon as it's "done" (at which point the API will bump to 1) | 13:22 |
Chipaca | narindergupta: am i making sense? | 13:22 |
narindergupta | Chipaca, so start with charm craft init then make the change | 13:22 |
Chipaca | yep! | 13:23 |
narindergupta | Chipaca, ok I think I can see that | 13:28 |
narindergupta | ops_lib_k8s-0.0.dev0+unknown.dist-info/ and ops-0.8.0.dist-info/ in c=venv | 13:28 |
narindergupta | After charm build | 13:29 |
Chipaca | 'charmcraft build' i hope :') | 13:29 |
facubatista | narindergupta, you should not use the 'charm' tool | 13:29 |
narindergupta | facubatista, I am using charmcraft | 13:29 |
facubatista | great | 13:30 |
facubatista | narindergupta, what is "c=venv"? | 13:30 |
narindergupta | What I meant is in venv directory | 13:31 |
narindergupta | Chipaca, yes I am able to start the work now and still has to go through the pod status to make sure I set the status in charm application as well. Do we still explicitly set the status? | 13:43 |
Chipaca | narindergupta: sorry i didn't follow that | 13:45 |
narindergupta | Chipaca, in my earlier charm I explicitly set the status of the application using activestatus call based on the pods status. Are we following the same as well? | 13:46 |
narindergupta | Like _on_start(self) | 13:46 |
narindergupta | if (self.model.pod.is_leader()): | 13:47 |
narindergupta | self.model.app.status = ActiveStatus('ready') | 13:47 |
narindergupta | Basically I wanted to set the application status as pod status if it is leader | 13:49 |
facubatista | narindergupta, I'm lost if you attempted to do that and didn't work, if it worked but you're not sure if it's the best way of doing it | 13:58 |
Chipaca | narindergupta: that is something the charm would do, yes | 14:01 |
Chipaca | narindergupta: I'm not sure if that's your question though | 14:01 |
narindergupta | Chipaca, yes that answers it and currently seeing to pass app data to k8s pod | 14:01 |
narindergupta | Will let you know if come across any issues | 14:02 |
Chipaca | narindergupta: also note you can write self.app.status (it's the same, just shorter) | 14:02 |
narindergupta | Chipaca, gotchu you that is helpful | 14:03 |
Chipaca | narindergupta: and AFAIK it's not pod.is_lader but unit.is_leader :) | 14:03 |
Chipaca | so you can write self.unit.is_leader | 14:04 |
narindergupta | Chipaca, thank you | 14:04 |
Chipaca | ok, i'm out of here | 17:08 |
Chipaca | ttfn! | 17:08 |
drewn3ss | qq, I'm moving from using submodule to pull mod/operator for the ops module to using charmcraft to build my charm. What should be done with the dead symlink from $CHARM_ROOT/lib/ops that prior pointed to ../mod/operator/ops? charmcraft dies on looking for where this symlinks to. https://pastebin.ubuntu.com/p/GKmQy44jTm/ | 17:38 |
drewn3ss | is there a specific path I should look for when doing import ops? | 17:38 |
drewn3ss | or is it just available in my built venv? | 17:39 |
drewn3ss | and I shouldn't worry about pathing | 17:39 |
drewn3ss | ok, I did a build of my charm. the venv directory didn't get created....I see that requirements.txt at the top level is actually equivalent of wheelhouse for reactive. | 17:58 |
drewn3ss | that seems really weird, but I'll roll with it | 17:58 |
drewn3ss | I think long term it'll make more sense for people joinnig into charming, so I'm okay with the rename | 17:59 |
drewn3ss | answer: use requirements.txt to get the modules you want installed from pip into the charm's venv. | 18:26 |
drewn3ss | and remove symlinks and calls to lib paths for anything that was submoduled. | 18:26 |
drewn3ss | because the import will work because it's part of the venv | 18:26 |
narindergupta | Chipaca do you know why am I getting this error ERROR cannot repackage charm: symlink "config.yaml" is absolute: "/home/ubuntu/narinder/charm-k8s-cassandra/config.yaml" | 18:38 |
narindergupta | I am trying to deploy the charm but getting this error | 18:39 |
drewn3ss | how do I make charmcraft build include my CHARM_ROOT/files directory? | 18:50 |
drewn3ss | or /templates, or any other path for that matter | 18:50 |
drewn3ss | seems it pulls in /lib and /src and several .yaml/version files | 18:50 |
drewn3ss | I'd expected it to pull everything not in .jujuignore | 18:51 |
drewn3ss | facubatista: ^ | 18:51 |
facubatista | drewn3ss, it will do that, I'm currently working on it: https://github.com/canonical/charmcraft/issues/39 | 18:53 |
facubatista | narindergupta, how are you deploying the charm? | 18:54 |
drewn3ss | I see https://github.com/canonical/charmcraft/blob/master/charmcraft/commands/build.py#L123 if your entrypoint dir for build is same as your whole charm dir, then it skips all files | 18:54 |
facubatista | drewn3ss, the "entrypoint" is your main Python file, not a directory | 18:55 |
drewn3ss | ack | 18:56 |
facubatista | drewn3ss, to hack it until a proper solution is ready, you could include your files in the CHARM_OPTIONAL list | 18:56 |
facubatista | drewn3ss, in that build.py, line ~38 | 18:56 |
drewn3ss | is that environmental, arg-able or am I forking the code? | 18:56 |
drewn3ss | forking the code...cool. | 18:56 |
drewn3ss | that's...a non-starter | 18:56 |
facubatista | drewn3ss, as I said, I'm working on the proper solution | 18:57 |
drewn3ss | thank you :) | 18:57 |
drewn3ss | I can also move my files dir to src | 18:58 |
drewn3ss | as it seems all of src is included | 18:58 |
drewn3ss | that's reasonable for now | 18:58 |
* facubatista eods | 21:12 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!