Elladan | I installed a snap named "arduino" on Mint 19.3, and when I start it it just crashes with: "java.lang.UnsatisfiedLinkError: /snap/arduino/41/usr/lib/jvm/java-11-openjdk-amd64/lib/libsplashscreen.so: libX11.so.6: cannot open shared object file: No such file or directory" | 00:16 |
---|---|---|
Elladan | Another snap I have installed using X11 works fine. | 00:17 |
jamesh | Elladan: The "snap info" output for that snap suggests reporting problems at https://github.com/snapcrafters/arduino/issues | 03:31 |
jamesh | I haven't used that snap, so don't have much more to suggest. | 03:33 |
oerheks | howcome you could install snaps on mint? | 03:34 |
oerheks | they blocked that in a funny way | 03:35 |
jamesh | oerheks: they replaced some "deb to snap" transition packages in their archive overlay. I don't think they've done anything to actively break snap support if you install it | 03:36 |
jamesh | unless there's something else new. | 03:36 |
oerheks | They introduced this etc/apt/preferences.d/nosnap.pref file | 03:37 |
jamesh | Ah. I missed that. | 03:40 |
jamesh | Presumably if the user managed to install a snap, then they would have got past that setting though. | 03:41 |
oerheks | first remove that blob, then you could install snapd, | 03:41 |
=== JanC is now known as Guest56745 | ||
=== JanC_ is now known as JanC | ||
mborzecki | morning | 06:19 |
mup | PR snapd#9144 closed: bootloader: add helper for creating a bootloader based on gadget <Squash-merge> <UC20> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/9144> | 06:37 |
mborzecki | mvo: hey | 06:43 |
mborzecki | omg, forgot about squash merge label i added myself | 06:44 |
mvo | mborzecki: good morning | 06:44 |
mborzecki | mvo: we're not doing $kernel after all? | 06:46 |
mup | PR snapd#9130 closed: [RFC] Support for gadget.yaml "$kernel:" style references (1/N) <Created by mvo5> <Closed by mvo5> <https://github.com/snapcore/snapd/pull/9130> | 06:47 |
mup | PR snapd#9142 closed: sandbox/cgroup: detect dangling v2 cgroup <Bug> <Created by zyga> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9142> | 06:47 |
mup | PR snapd#9147 closed: [RFC] Support for gadget.yaml "$kernel:" style references (2/N) <Created by mvo5> <Closed by mvo5> <https://github.com/snapcore/snapd/pull/9147> | 06:47 |
mup | PR snapd#9148 opened: gadget: add new Kernel{Info,Asset} struct and helpers <Created by mvo5> <https://github.com/snapcore/snapd/pull/9148> | 06:57 |
mborzecki | pstolowski: hey | 07:04 |
mvo | good morning pstolowski | 07:04 |
pstolowski | morning o/ | 07:04 |
mborzecki | pedronis: hey, thanks for the feedback | 07:57 |
mborzecki | pedronis: i've updated #9145 | 08:59 |
mup | PR #9145: boot: track trusted assets during initial install, assets cache <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9145> | 08:59 |
pedronis | mborzecki: thx, I will look in a little bit (was in meetings) | 09:01 |
mborzecki | pedronis: sure, let me know if we should have a chat as well | 09:01 |
* mborzecki goes looking for a copy-tree helper | 09:01 | |
mborzecki | zyga is coming back and should be online in a bit | 09:18 |
zyga-mbp | what a day | 09:35 |
zyga-mbp | mvo I will file half day off, | 09:35 |
zyga-mbp | there was a leak at my parent's flat, someone upstairs from them had a broken pipe or something | 09:35 |
zyga-mbp | I need to spend a moment to file the insurance claim | 09:36 |
zyga-mbp | I'll be back around noon | 09:36 |
mvo | zyga-mbp: ok | 09:37 |
zyga-mbp | how is master? are we green? | 09:39 |
mborzecki | zyga-mbp: yeah, the PRs i restarted today were green | 09:41 |
mborzecki | (as in all green) | 09:42 |
zyga-mbp | super-green :) | 09:42 |
mup | PR snapd#9129 closed: sandbox/cgroup: remove temporary workaround for multiple cgroup writers <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/9129> | 09:42 |
mborzecki | zyga-mbp: #28a745 green | 09:43 |
mup | PR #28: Updated import path, closes #27 <Created by fgimenez> <Merged by elopio> <https://github.com/snapcore/snapd/pull/28> | 09:43 |
zyga-mbp | "super green" is a quote, from, I think, the 5th element | 09:43 |
mborzecki | hm now that you reminded me, i'd love to watch it again | 09:44 |
zyga-mbp | ok , paperwork ready | 09:50 |
zyga-mbp | eh | 09:50 |
zyga-mbp | let's focus on work now | 09:50 |
mup | PR snapd#9118 closed: tests: detect unexpected xenial kernels <Test Robustness> <Created by zyga> <Closed by zyga> <https://github.com/snapcore/snapd/pull/9118> | 09:52 |
pedronis | mborzecki: do we need to discuss something? | 09:58 |
mborzecki | pedronis: idk, do you want to go over the PR maybe? | 09:59 |
mborzecki | pedronis: otherwise we're good i suppose | 10:00 |
mborzecki | pedronis: btw. we haven't discussed it, but we should probably add boot.SealWithModeenv() or similar at some point | 10:01 |
pedronis | mborzecki: I'm sure I have mentioned it many times | 10:02 |
pedronis | without a name yet | 10:02 |
mup | PR snapd#9149 opened: [RFC] gadget: provide new gadget.ResolveContentPaths() (2/N) <Created by mvo5> <https://github.com/snapcore/snapd/pull/9149> | 10:02 |
pedronis | Isaid we need functions that seal/reseal based on a modeenv (or at least to start a function that takes a modeenv and produces sealing params) | 10:03 |
mborzecki | pedronis: ok, i'll add a stub when i open the bits with content update observer | 10:03 |
pedronis | mborzecki: please coord with Claudio on this | 10:03 |
mborzecki | pedronis: yup, will do | 10:04 |
pedronis | mborzecki: a few more comments | 10:12 |
mvo | mborzecki, pedronis I'm moving kernel.yaml reading into the kernel package now, but one open question is the edition, it's private to gadget right now, so I would either need to copy or extract it | 10:13 |
mvo | mborzecki, pedronis (the edition datastructure) - any recommendations for this? | 10:13 |
pedronis | mvo: gadget will to import kernel, right? | 10:15 |
mvo | pedronis: yes | 10:15 |
pedronis | *will have to | 10:15 |
pedronis | mvo: it's annoying, but I recommend making a tiny gadget/edition package | 10:16 |
pedronis | with edition.Number | 10:16 |
mvo | pedronis: works for me, thanks | 10:16 |
mborzecki | or maybe we could move editionNumber to snap? | 10:16 |
pedronis | not unless we use for a 3rd thing | 10:16 |
mborzecki | fair enough | 10:16 |
pedronis | I see the appeal, but snap is already full of things | 10:17 |
pedronis | and snap/edition is not better than gadget/edition | 10:17 |
mborzecki | missing a kitchen sink ;) | 10:17 |
zyga-mbp | mborzecki snap/mime and we're close to sending email | 10:28 |
mup | PR snapd#9148 closed: gadget: add new Kernel{Info,Asset} struct and helpers <Created by mvo5> <Closed by mvo5> <https://github.com/snapcore/snapd/pull/9148> | 10:38 |
mvo | pedronis, mborzecki updated the kernel yaml stuff in 9150, sorry I got confused by GH | 10:52 |
mup | PR snapd#9150 opened: gadget,kernel: add new kernel.{Info,Asset} struct and helpers <Created by mvo5> <https://github.com/snapcore/snapd/pull/9150> | 10:53 |
zyga | brb | 11:11 |
mborzecki | pedronis: hm, i think we've forgotten to support a forced bootloader in ForGadget, anyways we can remedy that later | 11:13 |
pedronis | mborzecki: I'm sure it will be obvious when you need it :) | 11:20 |
zyga | most tests are red, are we in another wave of problems or are those just old? | 11:21 |
pedronis | I don't know if people merged master in their PR, some of michael stuff has vet/fmt problems | 11:26 |
pedronis | it seems some uc20 prepare are timing out | 11:27 |
pedronis | mborzecki: uc20 prepare is timing out here: https://github.com/snapcore/snapd/pull/9145, real problem? | 11:28 |
mup | PR #9145: boot: track trusted assets during initial install, assets cache <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9145> | 11:28 |
mborzecki | hmmm | 11:29 |
mborzecki | interesting, let me check locally in a vm | 11:30 |
pedronis | zyga: can you point to an interesting bit of history in 7285 that you think we don't have in master atm | 11:35 |
zyga | pedronis: I think I can but it will take me a moment, there's a lot of discussion there and resulting patches | 11:36 |
pedronis | zyga: well the discussion is in the PR, not the commits | 11:36 |
pedronis | there's a lot of back and forth that has no footprint in master | 11:36 |
pedronis | at this point | 11:36 |
zyga | yes but the comments contain responses in code commits | 11:37 |
pedronis | but I'm not sure that's a bug | 11:37 |
mborzecki | pedronis: well, pushed mocking of for gadget bootloader too to 9145 | 11:49 |
mborzecki | hm the core-20 spread tests don't use a tpm & secboot, do they? | 11:51 |
pedronis | mborzecki: not those ones | 11:52 |
pedronis | zyga: I found only https://github.com/snapcore/snapd/pull/7825#discussion_r411269504 | 11:52 |
mup | PR #7825: many: use transient scope for tracking apps and hooks <Needs security review> <Security-High> <⛔ Blocked> <Created by zyga> <https://github.com/snapcore/snapd/pull/7825> | 11:52 |
mborzecki | wierd, anyways snap prepare-image is downlaoding all snaps, we'll know what's wrong in a bit | 11:52 |
* zyga debugs something as well | 11:59 | |
mborzecki | pedronis: hm looks like Observe is called with a nil structure | 12:11 |
pedronis | interesting | 12:16 |
pedronis | seems some preexisting bug in gadget though? | 12:17 |
mup | PR snapd#9151 opened: vendor: update secboot to fix key data validation <Simple 😃> <UC20> <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/9151> | 12:18 |
mborzecki | pedronis: unclear, gadget unit tests assert that structure is non-nil | 12:19 |
pedronis | some weird case of := vs = | 12:19 |
pedronis | that's a way to get nil where you don't expect one staring at the code | 12:20 |
cmatsuoka | mborzecki: did an impossible situation happen in tests? | 12:21 |
pedronis | mborzecki: the other option is something wrapping a nil into an interface, and the thing going past != nil | 12:22 |
mborzecki | hm actually it's more intersting | 12:23 |
mborzecki | observer is nil | 12:23 |
pedronis | ah | 12:23 |
mborzecki | func (o *TrustedAssetsInstallObserver) Observe(op gadget.ContentOperation, affectedStruct *gadget.LaidOutStructure, root, realSource, relativeTarget string) (bool, error) <- so o is nil | 12:23 |
mborzecki | but it's called from a place where it's not nil | 12:24 |
pedronis | well, see my comment about wrapping nils into interfaces | 12:24 |
pedronis | that might be one reason | 12:24 |
pedronis | mborzecki: ah, yes | 12:25 |
pedronis | fun | 12:25 |
ijohnson | morning folks | 12:25 |
cmatsuoka | hey ijohnson | 12:25 |
mborzecki | ijohnson: hey | 12:25 |
ijohnson | hey cmatsuoka mborzecki | 12:25 |
pedronis | mborzecki: the issue is probably the signature of TrustedAssetsInstallObserverForModel | 12:25 |
pedronis | you probably take that and cast implicitly to an interface | 12:25 |
pedronis | that doesn't give you a nil for the interface | 12:26 |
pedronis | mborzecki: does this make sense? | 12:26 |
ijohnson | pedronis: regarding making recover -> run mode automatic via a reboot, I got the initramfs method working easily ... if I base the changes on top of my other 2 initramfs PR's (systemd-mount and cross-check) the test diff is small, otherwise there are a number of conflicts I'd rather not resolve (but could if needed) | 12:29 |
pedronis | ijohnson: yes, I saw your notes, let's chat at the standup | 12:30 |
ijohnson | pedronis: I am going to take a quick stab at the ensure devicemgr method we discussed now to see how much work that is | 12:30 |
ijohnson | pedronis: ack | 12:30 |
mborzecki | pedronis: yes, most likely, https://play.golang.org/p/UWyducWpRj7 | 12:31 |
mborzecki | missing test case in handlers_install too | 12:32 |
pedronis | yes | 12:33 |
pedronis | function returning nil for structs are dangerous | 12:33 |
pedronis | mborzecki: I'm happy to chat about how to clean this up, I think both me and mvo made some comments about those functions originally | 12:34 |
mborzecki | pedronis: and the unit tests check for NotNil with an interface | 12:34 |
zyga | huh | 12:38 |
mborzecki | pedronis: i'm open to suggestions, a chat? | 12:40 |
pedronis | mborzecki: yes | 12:40 |
mup | PR snapd#9152 opened: cmd/snapd-generator: generate drop-in to use fuse in container <Needs Samuele review> <Preseeding 🍞> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9152> | 13:18 |
cachio | zyga, to reproduce the error you can use this image https://storage.googleapis.com/spread-snapd-tests/images/pc-amd64-16-beta/pc.img.xz | 13:37 |
zyga-mbp | cachio sorry, which error? | 13:37 |
cachio | zyga-mbp, the reloading with --user | 13:38 |
zyga-mbp | I see | 13:38 |
zyga-mbp | do you know which commit corresponds to that? | 13:38 |
zyga-mbp | I don't need to look at the image, more at the history | 13:38 |
zyga-mbp | we can look at the image once we know where it is anchored | 13:39 |
cachio | I am running eith the branch for beta | 13:39 |
cachio | 2.46 | 13:39 |
zyga-mbp | ok, I'll check | 13:40 |
zyga-mbp | it probably doesn't have the fixes then | 13:40 |
zyga-mbp | so unlucky fork | 13:40 |
* pstolowski lunch | 13:55 | |
pedronis | zyga-mbp: if you can update the description of #7825 with something that hints at the journey and then ping me | 13:57 |
mup | PR #7825: many: use transient scope for tracking apps and hooks <Needs security review> <Security-High> <⛔ Blocked> <Created by zyga> <https://github.com/snapcore/snapd/pull/7825> | 13:57 |
zyga | pedronis: sure | 13:57 |
ijohnson | zyga: so what I was trying to say in the SU is that I don't think the extra info from mount helps because if the fsck fails or the mount fails, it shows up the same to us when we run `systemd-mount` | 13:58 |
zyga | pedronis: I need to prepare for another call so likely in the evening or tomorrow | 13:58 |
zyga | ijohnson: I see | 13:58 |
ijohnson | i.e. systemd-mount doesn't tell us how things fail it just says that the unit failed | 13:58 |
ijohnson | and then we have to go on digging to find out what failed | 13:58 |
mborzecki | ijohnson: what if we start the fsck unit ourselves? | 13:59 |
ijohnson | mborzecki: yes we could do this | 13:59 |
mborzecki | pedronis: https://github.com/snapcore/snapd/pull/9153 | 14:02 |
mup | PR #9153: overlord/devicestate: workaround non-nil interface with nil struct <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9153> | 14:02 |
mup | PR snapd#9153 opened: overlord/devicestate: workaround non-nil interface with nil struct <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9153> | 14:03 |
* zyga breaks for lunch | 14:05 | |
mborzecki | hmm should have skipped spread there | 14:08 |
* zyga waits for food to heat so https://github.com/snapcore/snapd/pull/9154 | 14:16 | |
mup | PR #9154: tests: unmount FUSE file-systems from XDG runtime dir <Test Robustness> <Created by zyga> <https://github.com/snapcore/snapd/pull/9154> | 14:17 |
mup | PR snapd#9154 opened: tests: unmount FUSE file-systems from XDG runtime dir <Test Robustness> <Created by zyga> <https://github.com/snapcore/snapd/pull/9154> | 14:19 |
mborzecki | ijohnson: can you take a look at https://github.com/snapcore/snapd/pull/9153 ? | 14:21 |
mup | PR #9153: overlord/devicestate: workaround non-nil interface with nil struct <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9153> | 14:21 |
ijohnson | mborzecki: yes | 14:22 |
mborzecki | ijohnson: thanks! | 14:22 |
mvo | ijohnson: I just did | 14:50 |
mvo | mborzecki: just had a look | 14:50 |
mborzecki | mvo: ijohnson: thanks! | 14:50 |
mvo | mborzecki: I will merge once spread is done | 14:50 |
mborzecki | cmatsuoka: thanks too! | 14:51 |
ijohnson | haha wow 3 reviews in under a minute | 14:51 |
mborzecki | haha | 14:51 |
ijohnson | mborzecki's code is real popular | 14:51 |
mvo | woah | 14:51 |
cmatsuoka | :) | 14:51 |
mvo | what a shinny PR :) | 14:51 |
ijohnson | #8931 could use a review too and is a test-only fully green 31 line change :-) | 14:53 |
mup | PR #8931: tests/main/install-fontconfig-cache-gen: enhance test by verifying, add fonts to test <Simple 😃> <Test Robustness> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8931> | 14:53 |
mvo | ijohnson: sure, looking | 14:53 |
mvo | ijohnson: sorry, somehow missed this one (or rather missed that I can review it again) | 14:54 |
ijohnson | no worries | 14:54 |
* cachio lunch | 14:56 | |
ijohnson | thanks mvo | 14:59 |
mborzecki | hmm all jobs are queued? | 15:03 |
mborzecki | nothing in progress here https://github.com/snapcore/snapd/actions?query=is%3Ain_progress | 15:03 |
zyga-mbp | mborzecki looking | 15:15 |
zyga-mbp | mborzecki we're executing 32 spread runs now | 15:16 |
zyga-mbp | it's a message queue, perhaps under load and out of date | 15:16 |
zyga-mbp | we're definitely not idle | 15:16 |
mborzecki | hm maybe | 15:16 |
zyga-mbp | actually some more as I run 4 more locally for extra safety in case one node goes down | 15:18 |
zyga-mbp | oh | 15:18 |
zyga-mbp | cmatsuoka I found that doc about actions | 15:18 |
cmatsuoka | zyga-mbp: ah nice, please share if you can | 15:22 |
zyga-mbp | done | 15:23 |
cmatsuoka | thanks! | 15:23 |
zyga-mbp | I'm happy to talk if you want to set it up | 15:26 |
mup | PR snapd#9017 closed: o/snapstate: disk space check in Ensure (5/N) <Disk space awareness> <Needs Samuele review> <⛔ Blocked> <Created by stolowski> <Closed by stolowski> <https://github.com/snapcore/snapd/pull/9017> | 15:49 |
zyga | Err:125 http://us-east1.gce.archive.ubuntu.com/ubuntu groovy/main amd64 libio-pty-perl amd64 1:1.12-1 | 15:56 |
zyga | Temporary failure resolving 'us-east1.gce.archive.ubuntu.com' | 15:56 |
mup | PR snapcraft#3247 opened: spread tests: fix classic patchelf linker regex to match all arches <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3247> | 16:04 |
mvo | zyga: if you could look at 9152 too that would be great, I think system() is fine here but I would love someone that is not me to come to the same conclusion :) | 16:06 |
zyga | sure | 16:06 |
zyga | looking | 16:06 |
mvo | pstolowski: some interssting points in the generator PR from dimitri | 16:06 |
mvo | zyga: thank you! | 16:06 |
pstolowski | mvo: yes, just looking | 16:06 |
mvo | pstolowski: \o/ | 16:07 |
mborzecki | meh, i'll grow more grey hair waiting for 9153 spread jobs to finish | 16:10 |
mborzecki | it's looking good though, so bbiab | 16:11 |
zyga | reviewed https://github.com/snapcore/snapd/pull/9152#pullrequestreview-466913663 | 16:17 |
mup | PR #9152: cmd/snapd-generator: generate drop-in to use fuse in container <Bug> <Preseeding 🍞> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9152> | 16:17 |
mup | PR snapd#9153 closed: overlord/devicestate: workaround non-nil interface with nil struct <UC20> <Created by bboozzoo> <Merged by cmatsuoka> <https://github.com/snapcore/snapd/pull/9153> | 16:59 |
mup | PR snapd#9154 closed: tests: unmount FUSE file-systems from XDG runtime dir <Test Robustness> <Created by zyga> <Merged by cmatsuoka> <https://github.com/snapcore/snapd/pull/9154> | 16:59 |
mborzecki | yay, cmatsuoka thanks! | 17:13 |
ijohnson | ughhhhhh I spent like all week trying to understand why the user wasn't added to this core-initrd nested spread test, turns out the code was expecting the user1 user, but I was creating the ubuntu user | 17:20 |
ijohnson | 🤦 | 17:20 |
mborzecki | #9145 is now unblocked | 17:23 |
mup | PR #9145: boot: track trusted assets during initial install, assets cache <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9145> | 17:23 |
mborzecki | ijohnson: uhh, kind of reminds me of snapstate tests, fakestore and assumptions about snap names that aren't obvious | 17:25 |
ijohnson | mborzecki: yeah lots of copying and surgical extraction of code which has assumptions that aren't obvious makes simple things more frustrating, just glad I finally figured it out | 17:39 |
pedronis | ijohnson: thanks for the review, no I think adding bootState in that interface is fine | 18:33 |
ijohnson | pedronis: ack I can push that change up for you and add that comment | 18:33 |
pedronis | ijohnson: thx, that would be nice | 18:33 |
ijohnson | sounds good | 18:33 |
ijohnson | pedronis: need anything else from me before you EOD/EOW ? | 18:34 |
pedronis | don't think so, I'm trying to wrap (as I said) the next PR for validation sets | 18:34 |
ijohnson | I chatted with mvo and we will work on landing the open uc20 PR's I have then I will work on cloud-init for uc20 after those have landed as my next big uc20 thing | 18:34 |
pedronis | ijohnson: ok, do you need to rediscuss quickly what's the plan for that? | 18:35 |
ijohnson | that's not a bad idea, give me a minute to look at the doc/matrix again to refresh my memory | 18:35 |
pedronis | yea, I'm not sure it completely reflects what we agreed after we started fixing the bug | 18:36 |
* cachio afk | 18:36 | |
ijohnson | pedronis: ok, ready when you are I can join the SU HO | 18:39 |
pedronis | let me join it | 18:40 |
mup | PR snapd#9155 opened: asserts/snapasserts: introduce ValidationSets <validation-sets :white_check_mark:> <Created by pedronis> <https://github.com/snapcore/snapd/pull/9155> | 19:10 |
mup | PR snapd#9151 closed: vendor: update secboot to fix key data validation <Simple 😃> <UC20> <Created by cmatsuoka> <Merged by cmatsuoka> <https://github.com/snapcore/snapd/pull/9151> | 19:15 |
mup | PR snapcraft#3247 closed: spread tests: fix classic patchelf linker regex to match all arches <bug> <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3247> | 19:49 |
mup | Bug #1891564 opened: Fonts are not displayed correctly <Snappy:New> <https://launchpad.net/bugs/1891564> | 22:39 |
mup | Bug #1891564 changed: Fonts are not displayed correctly <Snappy:New> <https://launchpad.net/bugs/1891564> | 22:42 |
mup | Bug #1891564 opened: Fonts are not displayed correctly <Snappy:New> <https://launchpad.net/bugs/1891564> | 22:51 |
mup | PR snapcraft#3244 closed: file utils: introduce get_host_tool_path() to find commands on host <enhancement> <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3244> | 23:40 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!