| mup | PR operator#375 opened: first pass at getting travis to do a windows run <Created by chipaca> <https://github.com/canonical/operator/pull/375> | 09:52 |
|---|---|---|
| facubatista | ¡Muy buenos días a todos! | 11:09 |
| Chipaca | FACUBATISTA: HELLO FROM WINDOWS | 11:22 |
| Chipaca | :-D | 11:22 |
| * Chipaca not really in windows | 11:23 | |
| facubatista | Chipaca, ah, I was about to ask you if needed to be rescued | 11:23 |
| Chipaca | facubatista: https://travis-ci.org/github/canonical/operator/builds/717875138 tho | 11:23 |
| facubatista | ugh | 11:25 |
| Chipaca | facubatista: :) | 11:25 |
| facubatista | Chipaca, let's talk about terminals? You know way more than I about those, and I need some direction here... | 11:26 |
| Chipaca | i just wish i could trigger them directly instead of having to go me → github → travis | 11:26 |
| Chipaca | facubatista: shoot | 11:26 |
| facubatista | ho? | 11:26 |
| facubatista | 1:1? | 11:26 |
| Chipaca | facubatista: 1 sec | 11:29 |
| Chipaca | facubatista: 1:1 | 11:31 |
| Chipaca | facubatista: https://github.com/paramiko/paramiko/blob/master/demos/interactive.py | 11:50 |
| facubatista | oooohhh | 11:57 |
| facubatista | wow Copyright (C) 2003-2007 | 11:57 |
| Chipaca | facubatista: the termios stuff is because of the echo issue i mentioned (which was 'details' also) | 11:58 |
| Chipaca | facubatista: but, well, that's probably what we need | 11:58 |
| * facubatista brb | 12:21 | |
| * facubatista is back | 13:19 | |
| * Chipaca lives | 13:19 | |
| bthomas | standup ? | 13:30 |
| Chipaca | nah | 13:32 |
| Chipaca | :- | 13:32 |
| Chipaca | :-p | 13:32 |
| bthomas | Chipaca: https://www.scivision.dev/python-calling-python-subprocess/ | 13:58 |
| Chipaca | bthomas: yep, it's quite likely that's at least part of it | 13:59 |
| Chipaca | bthomas: thank you | 13:59 |
| narindergupta | Chipaca, I am looking for method to get IP address o pod . I am trying this one self.model.get_binding("").network.ingress_address but there is no binding exist in the kubernetes and it complains ops.model.ModelError: b'ERROR no binding name specified\n' | 14:00 |
| mup | PR operator#376 opened: Move test_model to use Harness for resource, pod-spec tests <Created by chipaca> <https://github.com/canonical/operator/pull/376> | 14:24 |
| facubatista | justinclark, Chipaca, I replaced relativise content by doing pathlib.Path(os.path.relpath(dst, src.parent)) and it worked! thanks! | 14:28 |
| facubatista | my question is if I should leave those tests, or also just remove them | 14:29 |
| facubatista | (and kill relativise itself) | 14:29 |
| Chipaca | i don't understand how | 14:29 |
| Chipaca | because i ran those things and got those results | 14:29 |
| Chipaca | hmm | 14:29 |
| facubatista | Chipaca, let's dig and reproduce, it may be some obscure thing that we better find now | 14:30 |
| Chipaca | i'm definitely getting ../..... things now | 14:31 |
| Chipaca | ¯\_(ツ)_/¯ | 14:31 |
| Chipaca | I blame justinclark | 14:31 |
| Chipaca | he changed all the pythons everywhere just to prove his point | 14:31 |
| Chipaca | that's clearly the only reasonable possibility | 14:32 |
| justinclark | Haha it could have been a python version thing? I'm also not sure what happens if two paths don't contain a common ancestor. | 14:33 |
| justinclark | I tested with 3.8 | 14:33 |
| Chipaca | >>> os.path.relpath(str(dst), str(src.parent)) | 14:34 |
| Chipaca | '../../baz1/baz2/baz3/dst.txt' | 14:34 |
| Chipaca | ^ python 3.5 | 14:34 |
| Chipaca | (you need to str() the pathlibs, but other than that it works) | 14:35 |
| facubatista | justinclark, for our case they always have a common ancestor, as they must be inside the projects dir | 14:35 |
| facubatista | Chipaca, that result for which values of dst and parent? | 14:35 |
| Chipaca | facubatista: in linux they'll always have a common ancestor ('/') :) | 14:36 |
| Chipaca | windows might be more fun | 14:36 |
| Chipaca | facubatista: the same ones justinclark used in https://github.com/canonical/charmcraft/pull/118#discussion_r470604335 | 14:36 |
| mup | PR charmcraft#118: Some changes in preparation for big "include everything but jujuignored" branch <Created by facundobatista> <https://github.com/canonical/charmcraft/pull/118> | 14:36 |
| facubatista | Chipaca, justinclark, considering that in windows this can be tougher, and that the line it's not super small (`pathlib.Path(os.path.relpath(str(dst), str(src.parent)))`) I'll leave the 'relativise' function with the tests | 14:39 |
| facubatista | pushed | 14:40 |
| Chipaca | facubatista: you mean leave the function but it's just that line? | 14:40 |
| facubatista | yeap | 14:40 |
| facubatista | the separated function, with the tests, being that function just that ugly line | 14:41 |
| justinclark | Approved | 14:42 |
| justinclark | agreed - probably good to be safe and keep the tests for windows.. | 14:44 |
| * Chipaca ⇝ physio | 15:16 | |
| Chipaca | bbl to carry on porting fake_script to fake_pyscript | 15:17 |
| Chipaca | the windows test suite read like a edgelord greentext | 17:06 |
| Chipaca | they're all REEEEEEE | 17:06 |
| facubatista | jajaja | 17:16 |
| facubatista | Chipaca, justinclark, jam, dstathis, https://github.com/canonical/charmcraft/pull/112 is ready for review | 17:24 |
| mup | PR charmcraft#112: Include everything but what is explicity ignored to Juju <Created by facundobatista> <https://github.com/canonical/charmcraft/pull/112> | 17:24 |
| facubatista | (thanks) | 17:24 |
| justinclark | Taking a look facubatista. This one will take a bit longer for me to wrap my head around. Even if someone beats me to it, I'm sure it'll still be a good exercise. | 17:35 |
| facubatista | justinclark, exactly! thanks | 17:39 |
| facubatista | ballot, I just annotated a couple of minor details in https://code.launchpad.net/~ballot/charm-k8s-mm-pd-bot/+git/charm-k8s-mm-pd-bot/+merge/388497 , thanks | 17:39 |
| facubatista | Chipaca, ^ | 17:39 |
| dstathis | I'm having some issues with the operator tests | 17:43 |
| dstathis | When I run them, I'm getting 18 errors | 17:43 |
| dstathis | actually I think I figured it out | 17:46 |
| facubatista | dstathis, show us in a pastebin how you're running the tests and the errors you get | 17:46 |
| dstathis | all the errors have the message 'yaml does not have libyaml extensions, using slower pure Python yaml' somewhere in them | 17:47 |
| dstathis | so I'm guessing that's the problem | 17:47 |
| facubatista | dstathis, try doing 'apt build-dep python3-yaml' | 17:51 |
| dstathis | I needed to install libyaml-dev which I had already done. The tricky bit was I needed to reinstall pyyaml with --no-cache-dir | 17:54 |
| justinclark | I noticed that log message in the `ops.main` package ^ https://github.com/canonical/operator/blob/55158e3d1963106702222454c1cb8912c30dd077/ops/main.py#L302 | 17:55 |
| justinclark | Is there actually a "slower pure Python yaml loader" being used somewhere? | 17:55 |
| facubatista | dstathis, looks like this is a good thing to annotate in the README, would you propose a PR for that? thanks | 17:57 |
| mup | PR operator#377 opened: change fake_script so it always creates python scripts <Created by chipaca> <https://github.com/canonical/operator/pull/377> | 18:01 |
| Chipaca | siiiiigh | 18:02 |
| Chipaca | justinclark: if you 'pip install yaml' (as opposed to apt install), and don't have the libyaml bits, you'll use a pure-python one which can be significantly slower | 18:04 |
| Chipaca | like 40× slower | 18:04 |
| Chipaca | thus the warning | 18:04 |
| Chipaca | but my melancholy sigh is because the fake_script PR is nasty, not because of yaml :) | 18:05 |
| Chipaca | but anyway, I'm at EOW | 18:05 |
| justinclark | Oh I see. Thanks Chipaca | 18:05 |
| Chipaca | justinclark: no probs! have a good one | 18:06 |
| mup | Issue operator#378 opened: Docstyle for `ops` is Google doc style but parsed with Sphinx <Created by justinmclark> <https://github.com/canonical/operator/issues/378> | 18:14 |
| mup | PR operator#379 opened: Assume version 0.0.0 if JUJU_VERSION is not set <Created by dstathis> <https://github.com/canonical/operator/pull/379> | 18:22 |
| mup | PR operator#380 opened: Add info about fixing pyyaml in README.md <Created by dstathis> <https://github.com/canonical/operator/pull/380> | 18:37 |
| ballot | facubatista: Ack thanks. I didn't know for the docstring vs "pass", TIL ! | 19:47 |
| facubatista | ballot, :) | 19:48 |
| ballot | facubatista: for the index in fir format style, that's a rule from job -1. It was really really really frowned upon to NOT use index there because we had to support python 2.6 and I guess the habit stuck with me :) | 19:48 |
| facubatista | ballot, ah, yes, in the prehistory it was mandatory | 19:48 |
| ballot | facubatista: prehistory is actually daily lives on some software, sadly :/ | 19:49 |
| ballot | facubatista: especially when you have to support ... centos 6 | 19:49 |
| facubatista | ugh | 19:49 |
| ballot | oh well that's behind me now | 19:49 |
| facubatista | right, charms are py3 only | 19:49 |
| facubatista | >=3.5 | 19:49 |
| ballot | yup | 19:49 |
| ballot | Will adapt accordingly next time I have to touch the charm | 19:50 |
| facubatista | ballot, thanks! | 19:54 |
| justinclark | facubatista: is there an issue or discussion somewhere that gives context to https://github.com/canonical/charmcraft/pull/112? I think that would help me understand what's going on. | 21:12 |
| mup | PR charmcraft#112: Include everything but what is explicity ignored to Juju <Created by facundobatista> <https://github.com/canonical/charmcraft/pull/112> | 21:12 |
| facubatista | justinclark, that issue, but note that inside that issue a discourse page is linked | 21:13 |
| facubatista | that maybe will provide more context | 21:13 |
| facubatista | the bottom line is: what should go inside a charm? we started nickpicking some specific parts (the charm, metadata.yaml, etc), but experience proved that people want more stuff in... so, what should we include? we ended up deciding "everything that is not being ignored by juju" | 21:14 |
| justinclark | I might be blind.. Is there a linked issue in that PR? I see https://github.com/canonical/charmcraft/issues/39 which seems related to what you're saying | 21:18 |
| justinclark | But that gives me plenty to work with ^ thanks facubatista | 21:22 |
| facubatista | justinclark, ah, right, it's linked in the issue, not in the PR | 21:26 |
| facubatista | there I linked the issue to the PR | 21:27 |
| * facubatista eods and eows now | 21:27 | |
| facubatista | see you all on Tuesday! | 21:27 |
| justinclark | Have a good holiday weekend! | 21:35 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!