| === evhan` is now known as evhan | ||
| wallyworld | kelvinliu: i have a small fix for the juju shell for 2.8 https://github.com/juju/juju/pull/11907 | 06:10 |
|---|---|---|
| kelvinliu | looking | 06:10 |
| kelvinliu | wallyworld: lgtm, just need to update the prompt string | 06:20 |
| wallyworld | ty, looking | 06:20 |
| wallyworld | kelvinliu: yeah, i thought i'd leave the string simple and only advertise the easiest approach to quitting | 06:21 |
| wallyworld | and then if people did type "exit" it would also just work | 06:21 |
| kelvinliu | ok, that makes sense | 06:21 |
| wallyworld | otherwise it's a lot of options for them to process | 06:22 |
| kelvinliu | right | 06:24 |
| stickupkid_ | achilleasa, manadart -> https://github.com/juju/charm/pull/314 CR please | 11:23 |
| achilleasa | stickupkid_: done. small question about spew | 11:25 |
| stickupkid_ | achilleasa, no idea, was looking myself | 11:26 |
| stickupkid_ | achilleasa, go mod why tells me nothing | 11:26 |
| achilleasa | stickupkid_: hope nobody landed something with a spew.Dump in non-test code... :D | 11:27 |
| stickupkid_ | achilleasa, hopefully not | 11:28 |
| stickupkid_ | ➜ grep -ir spew . | 11:28 |
| stickupkid_ | ./go.sum:github.com/davecgh/go-spew v1.1.0 h1:ZDRjVQ15GmhC3fiQ8ni8+OwkZQO4DARzQgrnXU1Liz8= | 11:28 |
| stickupkid_ | ./go.sum:github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38= | 11:28 |
| stickupkid_ | ./go.sum:github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c= | 11:28 |
| stickupkid_ | that's all it reports back, which is annoying | 11:28 |
| achilleasa | stickupkid_: quick CR please: https://github.com/juju/juju/pull/11909 | 11:42 |
| stickupkid_ | achilleasa, where did the "@" syntax come from | 12:59 |
| achilleasa | juju config apparently... | 13:00 |
| stickupkid_ | achilleasa, https://github.com/juju/charmrepo/pull/163 | 14:17 |
| stickupkid_ | manadart, :point_up: | 14:49 |
| achilleasa | stickupkid_: sorry; lunching ATM; can look in ~10' if manadart hasn't reviewed it | 14:55 |
| manadart | stickupkid_: Deep in something ATM. | 14:55 |
| stickupkid_ | achilleasa, manadart i can wait | 14:55 |
| stickupkid_ | just wondered if I was sending to dead letters | 14:56 |
| achilleasa | stickupkid_: did you put the comments next to the imports or did your editor do that for you? | 15:12 |
| stickupkid_ | was already there | 15:12 |
| stickupkid_ | i did a sed | 15:13 |
| achilleasa | 'package testing_test' :D | 15:14 |
| stickupkid_ | achilleasa, it gets worse, testing/package_test.go package testing_test | 15:14 |
| stickupkid_ | TEST TEST TEST TEST | 15:14 |
| stickupkid_ | this is a test | 15:14 |
| achilleasa | test that the test-suite is not lying to you? | 15:15 |
| stickupkid_ | haha | 15:15 |
| stickupkid_ | you never know! | 15:15 |
| achilleasa | but then your test-suite will anticipate that and trick you | 15:15 |
| stickupkid_ | lies | 15:15 |
| achilleasa | btw, PR LGTM; there are some empty lines between import that look redundant | 15:16 |
| stickupkid_ | achilleasa, I'll fix | 15:16 |
| stickupkid_ | ah we get XDG_* specification wrong - interesting | 15:19 |
| stickupkid_ | for the acceptance tests | 15:19 |
| stickupkid_ | typical | 15:19 |
| stickupkid_ | achilleasa, the empty lines follow the 3 stanzas | 15:54 |
| achilleasa | ah... we do that everywhere then? | 15:55 |
| stickupkid_ | dunno, juju and charm repo it seems | 15:56 |
| stickupkid_ | note i hate it, but it's a standard | 15:56 |
| achilleasa | thought it was a juju-only thing | 15:56 |
| === arif-ali_ is now known as arif-ali | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!