| wallyworld | kelvinliu_: if you get a chance sometime https://github.com/juju/juju/pull/11917 it's mainly code deletion and some tweaks to refine imports | 03:33 |
|---|---|---|
| kelvinliu_ | looking | 03:34 |
| kelvinliu_ | lgtm thanks | 03:38 |
| wallyworld | tyvm | 03:48 |
| wallyworld | hpidcock: small fix https://github.com/juju/juju/pull/11925 | 05:52 |
| wallyworld | or kelvinliu_^^^^ | 05:55 |
| kelvinliu_ | looking | 05:55 |
| kelvinliu_ | wallyworld: lgtm ty | 06:00 |
| wallyworld | gr8 tyvm | 06:00 |
| soutr | Hey good people, As per my understanding when 'juju remove-relation keystone:certificates vault:certificates', is executed, 'juju export-bundle' or 'juju status keystone --relations' should not show any relation between keystone and vault. But for some reason it is still present. And every time I try to readd the relation it says relation already | 06:02 |
| soutr | exist. Is this the default behaviour? | 06:02 |
| soutr | # juju remove-relation keystone:certificates vault:certificates# juju add-relation keystone:certificates vault:certificatescannot add relation "keystone:certificates vault:certificates": relation keystone:certificates vault:certificates already exists (already exists) | 06:03 |
| soutr | Appreciate any tips/suggestions. Thanks! | 06:03 |
| manadart | achilleasa: Can you look at https://github.com/juju/juju/pull/11926 and see what I have got wrong with merging your patches? | 09:53 |
| manadart | On leave, NVM. | 09:55 |
| stickupkid | manadart, are you allowed to import something from a core package from another core package | 10:40 |
| manadart | stickupkid: I think so. | 10:40 |
| === tmhoang2 is now known as tmhoang | ||
| manadart | stickupkid hml: Here's the patch https://github.com/juju/juju/pull/11927. I was hand-wavy with the QA steps. I will get something together and update with concrete steps, but the code-review can be done now. | 13:50 |
| stickupkid | manadart, not sure the error handling is correct | 14:06 |
| stickupkid | sigh: 200 passed, 1 skipped, 43 FAILED | 14:24 |
| stickupkid | manadart, https://github.com/juju/juju/pull/11927#discussion_r474735254 | 14:30 |
| stickupkid | hml, I've put the PR up, but *may* require more Q&A https://github.com/juju/juju/pull/11928 | 16:12 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!