[03:33] <wallyworld> kelvinliu_: if you get a chance sometime https://github.com/juju/juju/pull/11917 it's mainly code deletion and some tweaks to refine imports
[03:34] <kelvinliu_> looking
[03:38] <kelvinliu_> lgtm thanks
[03:48] <wallyworld> tyvm
[05:52] <wallyworld> hpidcock: small fix https://github.com/juju/juju/pull/11925
[05:55] <wallyworld> or kelvinliu_^^^^
[05:55] <kelvinliu_> looking
[06:00] <kelvinliu_> wallyworld: lgtm ty
[06:00] <wallyworld> gr8 tyvm
[06:02] <soutr> Hey good people, As per my understanding when  'juju remove-relation keystone:certificates vault:certificates', is executed, 'juju export-bundle' or 'juju status keystone --relations' should not show any relation between keystone and vault. But for some reason it is still present. And every time I try to readd the relation it says relation already
[06:02] <soutr> exist. Is this the default behaviour?
[06:03] <soutr> # juju remove-relation keystone:certificates vault:certificates# juju add-relation keystone:certificates vault:certificatescannot add relation "keystone:certificates vault:certificates": relation keystone:certificates vault:certificates already exists (already exists)
[06:03] <soutr> Appreciate any tips/suggestions. Thanks!
[09:53] <manadart> achilleasa: Can you look at https://github.com/juju/juju/pull/11926 and see what I have got wrong with merging your patches?
[09:55] <manadart> On leave, NVM.
[10:40] <stickupkid> manadart, are you allowed to import something from a core package from another core package
[10:40] <manadart> stickupkid: I think so.
=== tmhoang2 is now known as tmhoang
[13:50] <manadart> stickupkid hml: Here's the patch https://github.com/juju/juju/pull/11927. I was hand-wavy with the QA steps. I will get something together and update with concrete steps, but the code-review can be done now.
[14:06] <stickupkid> manadart, not sure the error handling is correct
[14:24] <stickupkid> sigh: 200 passed, 1 skipped, 43 FAILED
[14:30] <stickupkid> manadart, https://github.com/juju/juju/pull/11927#discussion_r474735254
[16:12] <stickupkid> hml, I've put the PR up, but *may* require more Q&A https://github.com/juju/juju/pull/11928