[05:58] <mborzecki> morning
[05:59] <mvo> good morning mborzecki
[05:59] <mborzecki> mvo: hey
[06:19] <mborzecki> mvo: 2.46 branch needs cherry-picks with fixes for the tests
[06:20] <mvo> mborzecki: I think I will just merge master there
[06:20] <mborzecki> mvo: unless we just merge master
[06:20] <mborzecki> cool
[06:20] <mvo> mborzecki: I had hoped for some fixes from sergio
[06:20] <mup> PR snapd#9191 closed: interfaces/{docker,kubernetes}-support: load overlay and support systemd cgroup driver <Created by jdstrand> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/9191>
[06:20] <mvo> mborzecki: before I do that
[06:20] <mvo> mborzecki: thanks for merging this
[06:20] <mvo> mborzecki: also nice to see green PRs again
[06:21] <mborzecki> mvo: yeah, even if it's just temporary ;)
[06:23] <mvo> mborzecki: ha! you are such a pessimist :) it will be perfect from now on!
[06:23] <mborzecki> mvo: weird, this branch https://github.com/snapcore/snapd/pull/9196 is in the upstream repo instead of zyga-mbp's fork
[06:23] <mup> PR #9196: osutil: add OpenExistingLockForReading <Created by zyga> <https://github.com/snapcore/snapd/pull/9196>
[06:24] <mvo> mborzecki: he probably made this by mistake :/
[06:25] <mborzecki> mvo: wonder if there's some fine grained permission switches to prevent from pushing new branches unless they meet certain pattern (eg. release/..)
[06:25] <mvo> mborzecki: aha, I think so
[06:35] <mup> PR snapd#9186 closed: interfaces: add vcio interface <Created by jdstrand> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9186>
[06:50] <zyga-mbp> good morning
[06:51] <zyga-mbp> wha'ts up?
[06:51] <zyga-mbp> oh did I push to origin?
[06:51]  * zyga-mbp reads backlog while eating breakfast cereals on the side
[06:52] <zyga-mbp> interesting how this failed, wonder why
[06:55] <mup> PR snapd#9196 closed: osutil: add OpenExistingLockForReading <Created by zyga> <Closed by zyga> <https://github.com/snapcore/snapd/pull/9196>
[07:00] <zyga-mbp> reopened from my fork
[07:00] <mup> PR snapd#9197 opened: osutil: add OpenExistingLockForReading <Created by zyga> <https://github.com/snapcore/snapd/pull/9197>
[07:01] <pstolowski> morning
[07:01] <mvo> good morning pstolowski
[07:03] <zyga-mbp> hey Pawel
[07:05] <mup> PR snapd#9198 opened: features: add HiddenSnapFolder feature flag <Created by zyga> <https://github.com/snapcore/snapd/pull/9198>
[07:21] <mborzecki> pstolowski: zyga-mbp: hey
[07:35]  * zyga-mbp reboots for upgrades
[07:42] <mvo> stgraber: hey, do you think you could have a quick look at lp 1892568 ? it's about a nested lxd test we run that is failing on 16.04 and we need advise if it's worth keeping this test. I can trivial reproduce this if you need any debug from me
[07:42] <mvo> zyga: lp 1892568 might also be interessting for you, it has my findings about the nested lxd issue on 16.04
[07:47]  * mvo takes a short break
[07:48] <mborzecki> sourcing nested.sh in the debug shell sets -e, so a first non-successful command ends your shell :/
[07:50] <mup> PR snapd#9161 closed: kernel: add kernel.Validate() <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9161>
[09:11]  * zyga-x240 goes afk for 30 min
[10:04] <mvo> mborzecki: I think/hope that I have kernel-refs in gadget updates working now but writing the spread test for it is such a chore
[10:05] <mborzecki> mvo: hahah, i feel your pain
[10:05] <mborzecki> mvo: have you looked at the gadget update spread tests?
[10:06] <mup> PR snapd#9199 opened: snapstate: installSizeInfo helper that calculates total size of snaps and their prerequisites <Needs Samuele review> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9199>
[10:14] <zyga-mbp> re
[10:14] <zyga-mbp> man, lucy misses mom badly today
[10:15]  * zyga-mbp hugs mvo and mborzecki for writing excellent tests for hard cases
[10:21] <mup> PR snapd#9197 closed: osutil: add OpenExistingLockForReading <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/9197>
[10:23] <zyga-x240> mvo: back?
[10:23] <mvo> meeting
[10:23] <zyga-x240> mvo: so about https://launchpad.net/bugs/1892568 - I get 404
[10:23] <zyga-x240> what am I missing?
[10:24] <zyga-x240> https://github.com/snapcore/snapd/pull/9200 <- super simple
[10:24] <mup> PR #9200: runinhibit: open the lock file in read-only mode in IsLocked <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/9200>
[10:26] <mup> PR snapd#9200 opened: runinhibit: open the lock file in read-only mode in IsLocked <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/9200>
[11:36]  * zyga-x240 small break
[11:45] <cachio> mvo, hi, the PR 116 on core has been merged today right?
[11:45] <mup> PR #116: Feature/mount snaps <Created by mvo5> <Closed by mvo5> <https://github.com/snapcore/snapd/pull/116>
[11:45] <cachio> it is not included in core on edge yet, right?
[11:55] <mvo> cachio: yes, this morning
[11:55] <mvo> cachio: quite possible, I can trigger a rebiuld for core
[11:58] <mvo> zyga-mbp: https://bugs.launchpad.net/snapd/+bug/1892468
[11:58] <mup> Bug #1892468: Nested dbus test useful? <snapd:New> <https://launchpad.net/bugs/1892468>
[11:58] <cachio> mvo, yes please
[11:59] <cachio> so I can test the fix for the failover test
[11:59] <zyga-x240> mvo: thanks, weird that the other link did not work
[11:59] <mvo> cachio: I triggered a build now
[11:59] <mvo> zyga-x240: maybe I did a typo?
[11:59] <cachio> mvo, thanks
[12:03] <pstolowski> i see selinux-lxd failures on all selinux systems, not sure if this is related to my PR; has anyone seen it on other branches?
[12:07] <mborzecki> pstolowski: got logs?
[12:09] <pstolowski> mborzecki: https://pipelines.actions.githubusercontent.com/xS8oSnypZkPEQZqiZgDaRp2kdvQJKbOY08TesHp7E8vn7g4hYR/_apis/pipelines/1/runs/11690/signedlogcontent/67?urlExpires=2020-08-21T12%3A10%3A26.5605826Z&urlSigningMethod=HMACV1&urlSignature=vfCuP7XdBACxjXIQPWWvoGYGTxdhjW9ptv9tIA%2BbDPY%3D
[12:09] <pstolowski> (PR #9084)
[12:09] <mup> PR #9084: o/snapstate: check disk space before creating automatic snapshot on remove (3/N) <Disk space awareness> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9084>
[12:23] <zyga-x240> 2020-08-21T11:51:03.3746915Z type=AVC msg=audit(1598010641.669:5223): avc:  denied  { getattr } for  pid=131226 comm="snapd" path="/var/snap/lxd/common/ns/shmounts" dev="nsfs" ino=4026532238 scontext=system_u:system_r:snappy_t:s0 tcontext=system_u:system_r:unconfined_service_t:s0 tclass=file permissive=1 <-
[12:23] <zyga-x240> oh, pawel is gone
[12:41] <mup> PR snapd#9201 opened: [RFC] boot: observe update & rollback of trusted assets <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9201>
[12:48] <zyga-x240> OMG
[12:48]  * zyga-x240 learned something fantastically terrible 
[12:48] <zyga-x240> O M G
[12:48] <mborzecki> zyga-x240: hm?
[12:49] <zyga-x240> you will never believe how insanely surprising shell is
[12:49] <zyga-x240> set -e is ignored in some cases
[12:49] <zyga-x240> and man, there's a super super super silly case
[12:49] <zyga-x240> you can have pages of shell code
[12:49] <zyga-x240> you can set -e
[12:49] <zyga-x240> you can set -e 10 times in a row
[12:49] <zyga-x240> run false
[12:49] <zyga-x240> then true
[12:49] <zyga-x240> and that doesn't stop
[12:49] <zyga-x240> set -e
[12:50] <zyga-x240> echo "LOL shell"
[12:50] <zyga-x240> false
[12:50] <zyga-x240> echo "I'm still here"
[12:50] <zyga-x240> true
[12:50] <zyga-x240> how you ask?
[12:50] <zyga-x240> simple
[12:50] <zyga-x240> just _at any level above_
[12:50] <zyga-x240> put that in a context where set -e is ignored
[12:50] <zyga-x240> such as
[12:50] <zyga-x240> if foo; then ... fi
[12:50] <zyga-x240> if that set -e and echo and false and true was in a "foo" function
[12:50] <zyga-x240> set -e is irrelevant
[12:51] <zyga-x240> I'm still here prints
[12:51] <zyga-x240> and $? is 0
[12:51] <zyga-x240> because that's a shell list
[12:51] <zyga-x240> the return value is the return value of the last element
[12:51] <zyga-x240> and the fact that this is a function which sets -e is irrelevant
[12:51] <mup> PR snapd#9202 opened: tests/nested/core20/tpm: verify trusted boot assets tracking  <Run nested> <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9202>
[12:52] <zyga-x240> because the context of the function call (at any level above!) is one where set -e is ignored
[12:52] <zyga-x240> like ! foo
[12:52] <zyga-x240> if foo
[12:52] <zyga-x240> foo | bar
[12:52] <zyga-x240> or other similar
[12:52] <stgraber> mvo: 404
[12:52] <zyga-x240> how f**** crazy is that
[12:52] <zyga-x240> stgraber: try https://bugs.launchpad.net/snapd/+bug/1892468
[12:52] <mup> Bug #1892468: Nested lxd test useful? <snapd:New> <https://launchpad.net/bugs/1892468>
[12:52] <zyga-x240> mborzecki: surprise
[12:53] <mborzecki> zyga-x240: it's friday and i think i'm a bit slow already, do you have an example?
[12:53] <zyga-x240> mborzecki: yeah, I have a very complex one
[12:53] <zyga-x240> let me try to make a simple script now that I get it
[12:53] <zyga-x240> and the manual documents this
[12:53] <zyga-x240> but doesn't connect the dot
[12:54] <zyga-x240> between set -e ignored
[12:54] <zyga-x240> and _any parent call_ set -e ignored
[12:59] <zyga-x240> https://paste.ubuntu.com/p/QDh6JwqCW9/
[12:59] <zyga-x240> mvo: ^ tell me how many bugs we have left?
[12:59] <zyga-x240> mvo: in shell
[13:07] <mup> PR snapd#9172 closed: tests: update spread test for unknown plug/slot with snapctl is-connected <Simple 😃> <Test Robustness> <Created by stolowski> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/9172>
[13:32] <zyga-x240> mvo: onto that test now
[13:32] <zyga-x240> ogra_: https://paste.ubuntu.com/p/7njRQNhRZz/
[13:32] <zyga-x240> ogra_: check this out
[13:32] <mvo> zyga-x240: \o/ *thank you*
[13:32] <mvo> zyga-x240: also for sharing that snippet
[13:33] <mvo> zyga-x240: I wonder if shellcheck should warn about "if func()", I would argue it should
[13:33]  * ijohnson afk little bit
[13:34] <zyga-x240> mvo: I don't know, it's such a misfeature
[13:34] <zyga-x240> maybe it should if set -e is in effect
[13:34] <zyga-x240> I feat it may be very noisy
[13:34] <mvo> zyga-x240: I think this is worth a bugreport
[13:34] <mvo> zyga-x240: not sure, do you think if func() is common?
[13:34] <zyga-x240> mvo: yeah, I'll file one over weekend
[13:34] <zyga-x240> I want to write a blog post about this as well
[13:34] <mvo> zyga-x240: amen
[13:34] <zyga-x240> I'll refer to bugs in shellcheck and the example
[13:34] <mvo> zyga-x240: please do!
[13:35] <zyga-x240> after being at canonical for a decade I'll write a mail to tech@ ...
[13:42] <pstolowski> mborzecki: can you re-paste what you found about that selinux denial before i dropped from irc?
[13:42] <zyga-x240> mvo: test written, just waiting to see if it passes
[13:45] <mvo> zyga-x240: thanks so much
[13:46] <mvo> zyga-x240: I'm sure for some people it's not a surprise
[13:46] <zyga-x240> mvo: maybe we should hire them?
[13:47] <mvo> zyga-x240: maybe we should write less shell
[14:07] <mborzecki> pstolowski: zyga-x240 belived that snapd traverses too far and trespassed to locations managed by lxd
[14:07] <zyga-x240> mborzecki: not quite, it's not like it's not our space
[14:07] <zyga-x240> it's just that there are weird and wonderful objects there
[14:07] <zyga-x240> that are not just files
[14:07] <zyga-x240> and selinux doesn't like that
[14:07] <mborzecki> right
[14:08] <mborzecki> pstolowski: but i'd ahve to look at the PR again, maybe there's more to it
[14:08] <cachio> zyga-x240, is this enough for the failover test on a core image https://paste.ubuntu.com/p/dTmddSv3Cw/ ?
[14:09] <zyga-x240> cachio: not quite, remember that you cannot restart logind
[14:09] <zyga-x240> you must reboot
[14:09] <cachio> yes
[14:09] <cachio> well I try both things
[14:09] <zyga-x240> well, we tried already
[14:10] <zyga-x240> you cannot restart logind safely until systemd 246
[14:10] <cachio> but still see
[14:10] <cachio> + systemctl --user daemon-reload
[14:10] <cachio> Failed to connect to bus: No such file or directory
[14:10] <zyga-x240> cachio: I'd have to review your changes,
[14:10] <cachio> didnt push it yet
[14:10] <cachio> trying manually first
[14:11] <cachio> but that change that manually did is not enough to make the tests work
[14:12] <zyga-x240> change what manually?
[14:12] <cachio> https://paste.ubuntu.com/p/dTmddSv3Cw/
[14:12] <cachio> that
[14:12] <zyga-x240> cachio: sorry that's not correct
[14:12] <cachio> but with reboot
[14:12] <zyga-x240> I see
[14:13] <zyga-x240> can you tell me loginctl list-sessions after rebooting?
[14:13] <cachio> ok
[14:14] <zyga-x240> cachio: one thing that may be at play, is that root has no session
[14:14] <zyga-x240> since external target uses external user
[14:14] <zyga-x240> so disable-linger root may still, really, just shut stuff down
[14:14] <zyga-x240> but prepare enables linger
[14:14] <zyga-x240> which should make that irrelevant
[14:15] <mup> PR snapcraft#3256 opened: repo: consolidate BaseRepo and Ubuntu & reorganize package <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3256>
[14:15] <cachio> zyga-x240, https://paste.ubuntu.com/p/yp37m39TsD/
[14:16] <zyga-x240> is the external user logged in?
[14:17] <cachio> no
[14:18] <cachio> zyga-x240, https://paste.ubuntu.com/p/d2Wcn7JJdh/
[14:18] <zyga-x240> this is with the external user logged in
[14:18] <cachio> yes
[14:18] <zyga-x240> ok
[14:18] <zyga-x240> well, this much looks sensible
[14:19] <cachio> perhaps the problem is that here we use external instead of root to run the tests
[14:20] <cachio> zyga-x240, could be that affect?
[14:20] <zyga-x240> cachio: well, as I said above
[14:20] <zyga-x240> it should not matter
[14:20] <zyga-x240> so what fails now?
[14:20] <zyga-x240> which of the tests beaks
[14:20] <cachio> fails the same
[14:20] <cachio> spread -debug external:ubuntu-core-16-64:tests/core/core-to-snapd-failover16
[14:20] <cachio> this fails
[14:20] <zyga-x240> mvo: updated https://github.com/snapcore/snapd/pull/9200
[14:20] <mup> PR #9200: runinhibit: open the lock file in read-only mode in IsLocked <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/9200>
[14:20] <cachio> during restore
[14:21] <zyga-x240> cachio: how does it fail?
[14:21] <cachio> zyga-x240, https://paste.ubuntu.com/p/HGjKDsXpKk/
[14:22] <zyga-x240> yeah, I think that test needs tests.session -u root prepare / restore
[14:22] <zyga-x240> try adding that (prepare in 1st line, restore in last line)
[14:22] <zyga-x240> and run that test alone
[14:22] <cachio> sure
[14:23] <zyga-x240> it should pass then, the problem is that systemctl --user really assumes you have root
[14:23] <zyga-x240> that's implicit for our tests
[14:23] <zyga-x240> actually
[14:23] <zyga-x240> cachio: wait
[14:23] <zyga-x240> cachio: so in external mode tests run as non-root entirely?
[14:23] <zyga-x240> or run as root somehow via sudo or something like that?
[14:23] <cachio> they use external user
[14:23] <cachio> they are not root
[14:24] <zyga-x240> mvo: https://github.com/snapcore/snapd/pull/9200/files
[14:24] <mup> PR #9200: runinhibit: open the lock file in read-only mode in IsLocked <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/9200>
[14:24] <zyga-x240> cachio: hmmm
[14:24] <zyga-x240> cachio: then that will not suffice
[14:24] <zyga-x240> cachio: we need a bigger hammer
[14:24] <zyga-x240> cachio: and in addition
[14:24] <zyga-x240> cachio: that test should *not* fail anymore
[14:24] <zyga-x240> + systemctl --user daemon-reload
[14:24] <zyga-x240> if this runs as external
[14:24] <zyga-x240> then when it fails, please list sessions and do systemctl status
[14:24] <zyga-x240> (just without logging in again)
[14:25] <zyga-x240> let's examine what is going on
[14:25] <cachio> zyga-x240, ok
[14:30] <mup> PR snapcraft#3257 opened: plugins v2: use repo.Repo not repo.Ubuntu in colcon <bug> <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3257>
[14:31] <cachio> zyga-x240, https://paste.ubuntu.com/p/RMb9qPVBFp/
[14:31] <cachio> so it connects using external
[14:31] <cachio> but then uses root
[14:31] <cachio> as for other backends
[14:32] <zyga-x240>              │ │ ├─3480 sudo -i /bin/bash /tmp/tmp.zwRt33mi04
[14:32] <zyga-x240> but it uses sudo
[14:32] <zyga-x240> cachio: I'm about to EOD
[14:32] <zyga-x240> this needs more oomph
[14:32] <zyga-x240> sudo is incorrect
[14:32] <cachio> ok
[14:32] <cachio> lets continue on Mondya
[14:32] <zyga-x240> ok
[14:33] <cachio> enjoy the weekend
[14:33]  * zyga-x240 takes a break and heads for PT
[14:33] <zyga-x240> cachio: thank you, you too
[14:33] <zyga-x240> cachio: we need to either not use sudo
[14:33] <zyga-x240> cachio: or give root a real session
[14:33] <zyga-x240> cachio: not a mismatch of the two
[14:33] <ijohnson> zyga-x240: github meeting? or will you miss that?
[14:34] <zyga-x240> ijohnson: I'll pass
[14:34] <ijohnson> k
[14:34] <zyga-x240> I need to prep for PT
[14:34] <zyga-x240> I marked myself as optional
[14:34] <zyga-x240> and I'm tired
[14:35] <zyga-x240>  cachio is that sudo from spread or from us?
[14:35] <cachio> I think spread does it
[14:35] <zyga-x240> ok
[14:36] <cachio> let me check
[14:36] <cachio> zyga-x240, I see this in spread
[14:36] <cachio> func (c *Client) sudo() string {
[14:36] <cachio> 	if c.config.User == "root" {
[14:36] <cachio> 		return ""
[14:36] <cachio> 	}
[14:36] <cachio> 	return "sudo -i "
[14:36] <cachio> }
[14:36] <cachio> in the client
[14:44] <zyga-x240> we will need some changes then
[14:44] <zyga-x240> it's not broken per se
[14:44] <zyga-x240> but it's not the same as logging in as root
[14:44] <zyga-x240> so bummer
[14:46] <pstolowski> cachio: a few comments to nested PR
[14:47] <cachio> pstolowski, thanks!
[14:47] <cachio> zyga-x240, nice, tanks for the help, so lets continue on Monday
[15:03]  * cachio lunch
[16:09] <ijohnson> jdstrand: hey in #9191 I noticed that you didn't add overlay as a kernel module for the kubernetes-support interface like you did with docker, is there a reason you made it docker-support only?
[16:09] <mup> PR #9191: interfaces/{docker,kubernetes}-support: load overlay and support systemd cgroup driver <Created by jdstrand> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/9191>
[16:10] <ijohnson> jdstrand: also not sure if you saw my ping about a possible typo in #9188
[16:10] <mup> PR #9188: interfaces: misc policy updates xlvi <Created by jdstrand> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9188>
[16:55] <mup> PR snapcraft#3257 closed: plugins v2: use repo.Repo not repo.Ubuntu in colcon <bug> <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3257>
[17:06] <ijohnson> man it feels good to have green PR's again that we can just merge
[17:07] <mup> PR snapd#9190 closed: cmd/s-b/initramfs-mounts: make recover -> run mode transition automatic <Run nested> <UC20> <Created by anonymouse64> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/9190>
[17:37]  * zyga is back from PT
[17:37] <zyga> ijohnson: it does feel good :)
[17:38] <mup> PR snapd#9200 closed: runinhibit: open the lock file in read-only mode in IsLocked <Simple 😃> <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/9200>
[18:01] <mup> PR snapcraft#3258 opened: schema/snapcraft.json: allow type: os with build-base <Created by anonymouse64> <https://github.com/snapcore/snapcraft/pull/3258>
[18:32] <cachio> ijohnson, hey
[18:32] <cachio> for some raeson nested tests are fialing to boot on uc16 and 18 after merging with master
[18:32]  * ijohnson is meeting, will look in a bit
[18:33] <cachio> ijohnson, sure, thanks
[19:07] <ijohnson> cachio: so what's failing?
[19:07] <ijohnson> cachio: and is it 100% reproducible ?
[19:07] <cachio> I can't login
[19:07] <cachio> it is like hte user is not created
[19:07] <ijohnson> cachio: for all nested spread tests ?
[19:08] <cachio> not sure if all but many
[19:08] <cachio> I ran
[19:08] <cachio> google-nested:ubuntu-16.04-64:tests/nested/core/core-snap-refresh-on-core
[19:08] <cachio> and could reproduce it
[19:08] <cachio> still have a shell
[19:09] <ijohnson> cachio: ok I will take a look
[19:09] <cachio> the cloud init info is copied correctly
[19:09] <ijohnson> cachio: usually what I have taken to doing to reproduce these things is to shut down the nested-vm systemd service, then start the VM manually with qemu, but using -serial mon:stdio then create a user via console-conf to login to the VM and poke around to see what ran/didn't run, etc.
[19:10] <ijohnson> cachio: it's running now
[19:10] <ijohnson> let's see what we get
[19:10] <cachio> yes
[19:10] <cachio> ip 34.74.111.154
[19:28] <jdstrand> ijohnson: I'm not really here but it is because overlay is needed for docker and containerd. k8s can be configured for either and therefore must also plugs docker-support
[19:29] <ijohnson> jdstrand: ack, makes sense
[20:02] <ijohnson> cachio: I opened #9203 to fix that
[20:02] <mup> PR #9203: tests/lib/nested.sh: fix partition typo, unmount the image on uc20 too <Run nested> <Simple 😃> <Test Robustness> <⚠ Critical> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9203>
[20:03] <mup> PR snapd#9203 opened: tests/lib/nested.sh: fix partition typo, unmount the image on uc20 too <Run nested> <Simple 😃> <Test Robustness> <⚠ Critical> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9203>
[20:08] <cachio> ijohnson, in configure_cloud_init_nested_core_vm_uc20 is ok to use p2 right?
[20:08] <ijohnson> cachio: yes p2 is ubuntu-seed on uc20
[20:08] <cachio> good
[20:08] <ijohnson> but uc16 / uc18 have p3 as writable
[20:09] <cachio> yes
[20:09] <cachio> I see you added kpartx -d "$IMAGE"
[20:09] <cachio> in configure_cloud_init_nested_core_vm_uc20
[20:09] <cachio> it never was there?
[20:10] <cachio> ijohnson, +1
[20:11] <ijohnson> cachio: yes I accidentally dropped it in my previous PR I think
[20:11] <ijohnson> maybe it wasn't ever there tbh though
[20:12] <cachio> ijohnson, ok, np
[20:15] <ijohnson> cachio: actually to be fair it was never there before my refactor
[20:15] <cachio> ijohnson, ouch
[20:16] <ijohnson> cachio: this might have been why some of the uc20 tests will randomly fail if they get the wrong image that was leftover from before still mounted, we could copy files to the wrong image
[20:18] <cachio> ijohnson, yes
[20:18] <cachio> it could be
[20:18] <cachio> I am taking a look the the history
[20:18] <ijohnson> hopefully this is all green on this PR
[20:21] <cachio> I removed that
[20:21] <cachio> I found when
[20:22] <cachio> could that produce the randome reboots?
[20:22] <ijohnson> cachio: probably not
[20:24] <zyga> cachio: o/
[20:24] <zyga> cachio: have we lost xdelta3?
[20:24] <zyga> https://github.com/snapcore/snapd/pull/9203/checks?check_run_id=1014017904
[20:24] <mup> PR #9203: tests/lib/nested.sh: fix partition typo, unmount the image on uc20 too <Run nested> <Simple 😃> <Test Robustness> <⚠ Critical> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9203>
[20:24] <ijohnson> whelp
[20:24] <ijohnson> that seems problematic
[20:24] <zyga> hey ijohnson
[20:25] <ijohnson> hey zyga
[20:25]  * zyga likes cross-timezone work, pop into irc and there are your colleagues, any time of the day
[20:25] <cachio> zyga, didnt update the images since mongay
[20:25] <ijohnson> :-D
[20:25] <cachio> monday
[20:25] <zyga> cachio: hmm, any idea what may be going on then?
[20:25] <zyga> this is nested, maybe it didn't run for a while?
[20:28] <cachio> it is failing in ubuntu and debian
[20:28] <cachio> let me boot an instance
[20:28] <cachio> all the ubuntus
[20:28] <ijohnson> zyga: I've been running nested tests basically all day
[20:28] <ijohnson> let me see if I can reproduce running it again
[20:33] <zyga> hmm
[20:33] <zyga> thnx
[20:34] <cachio> this seems to be happening in the machines which run spread
[20:34] <cachio> not in gce
[20:34] <ijohnson> yeah spread is running fine on my machine
[20:34] <cachio> zyga, are those machines running in your home??
[20:38] <cachio> zyga, I see this Runner name: 'claudio-spread-1'
[20:38] <ijohnson> cmatsuoka: mmmm
[20:38] <cachio> cmatsuoka, are yo uhosting github action clients?
[20:38] <cmatsuoka> yes
[20:38] <cmatsuoka> one runner
[20:39] <cmatsuoka> is it misbehaving?
[20:39] <ijohnson> cmatsuoka: is xdelta3 installed on that machine ?
[20:39] <cachio> yes
[20:39] <cmatsuoka> let me check, I just ran zyga's runner building script
[20:40] <cmatsuoka> ijohnson: no xdelta3
[20:40]  * cmatsuoka installs 
[20:40] <ijohnson> cmatsuoka: so yeah we will need to install that
[20:40] <ijohnson> and update zyga's doc
[20:40] <cmatsuoka> done
[20:41] <cachio> nice
[20:41] <cachio> cmatsuoka, thanks
[20:43] <cmatsuoka> zyga sent me instructions by email so I'm replying with a note about the missing package
[20:43] <zyga> cmatsuoka: ohhh
[20:43] <zyga> cmatsuoka: also install python-launchpadlib
[20:43] <cmatsuoka> ah
[20:43] <zyga> cmatsuoka: and we should drop that mail into a gdoc or whatever that we are happy with and can be updated
[20:44] <cmatsuoka> python3-launchpadlib was already installed
[20:44] <zyga> ok
[20:44] <cmatsuoka> python3-launchpadlib is already the newest version (1.10.13-1).
[20:52] <zyga> https://github.com/zyga/bashcov/blob/master/bashunit
[20:53] <zyga> run that
[20:53] <zyga> write stuff like that
[20:53] <zyga> https://github.com/zyga/bashcov/blob/master/bashcov_test.sh
[20:54] <zyga> try breaking the test, the output is interesting as well
[20:55]  * zyga EODs and goes to pay taxes
[20:58] <zyga> taxes paid
[21:07] <ijohnson> have a good weekend zyga!
[21:56] <mup> PR snapcraft#3259 opened: cli: introduce set-default-tracks <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3259>
[22:19] <mup> PR snapd#9203 closed: tests/lib/nested.sh: fix partition typo, unmount the image on uc20 too <Run nested> <Simple 😃> <Test Robustness> <⚠ Critical> <Created by anonymouse64> <Merged by cmatsuoka> <https://github.com/snapcore/snapd/pull/9203>
[22:19] <ijohnson> cmatsuoka: mmm but the tests weren't done running :-/
[22:19] <cmatsuoka> oh really? the button was green
[22:20] <ijohnson> https://github.com/snapcore/snapd/pull/9203/checks?check_run_id=1014236898
[22:20] <mup> PR #9203: tests/lib/nested.sh: fix partition typo, unmount the image on uc20 too <Run nested> <Simple 😃> <Test Robustness> <⚠ Critical> <Created by anonymouse64> <Merged by cmatsuoka> <https://github.com/snapcore/snapd/pull/9203>
[22:20] <ijohnson> shows the nested runs were still running
[22:20] <cmatsuoka> oh noes
[22:20] <ijohnson> perhaps github's ui shows it's green when all the required ones are green?
[22:20] <ijohnson> all the other tests had finished except the spread-nested
[22:20] <ijohnson> labels
[22:21] <cmatsuoka> humm it's possible, I'll pay attention to the run status even when it's green
[22:22] <cmatsuoka> i was quite sure it wouldn't allow you to merge before the tests completed :\
[22:22] <ijohnson> for the required checks yes it won't
[22:22] <ijohnson> but for the non-required ones, I always thought the button would show up as grey
[22:22] <ijohnson> as in you could still click it but it wasn't fully green
[22:23] <cmatsuoka> oh well let's hope it finishes without any issues now
[22:30] <cmatsuoka> well even if it fails the p2 fix was needed anyway
[22:31]  * cmatsuoka EOWs
[22:32] <cmatsuoka> have a nice weekend
[22:33] <ijohnson> thanks cmatsuoka you too!