[05:04] <mup> PR snapd#9209 opened: Correctly parse Content-Type HTTP header <Created by robert-ancell> <https://github.com/snapcore/snapd/pull/9209>
[07:02] <pstolowski> morning
[07:04] <mvo> hey pstolowski
[07:28] <zyga> good morning
[07:29] <zyga> maciek's question from last evening made me realize why things are broken
[07:29] <mvo> good morning zyga
[07:32] <zyga> I think the 11AM thing will be necessary, today kids were very time consuming
[07:32] <zyga> and grandparents had to leave early in the morning so it was all on my head
[07:32] <zyga> anyway, maciek asked why are we hitting session bus for hooks and he is right, we should not
[07:33] <zyga> hah, there's even a TODO that says exactly what maciej suggested in the code
[07:33] <zyga> so that's easy
[07:47] <zyga> pstolowski what are you using for IRC?
[07:48] <pstolowski> zyga: textual7
[07:48] <zyga> same
[07:48] <zyga> I stand up and make tea and my mbp suspends :)
[07:48] <zyga> I miss an always-on imac
[07:48] <zyga> well, imac also suspends
[07:48] <zyga> so it's just an illusion
[07:48] <zyga> macos suspends so aggressively
[07:53] <pstolowski> zyga: hmm, doesn't happen here, but i'm plugged most of the time
[07:53] <zyga> pstolowski I'm on defaults and suspend time is ...
[07:54] <zyga> 2 minutes
[07:54] <zyga> yeah on a cable its' 10
[07:55] <pstolowski> zyga: ah, ok, i bumped them a bit and already forgot
[08:45] <mup> PR snapd#9210 opened: [RFC] daemon: add /v2/systems "reboot" action API <Created by mvo5> <https://github.com/snapcore/snapd/pull/9210>
[08:46] <zyga> testing the change now
[08:50]  * zyga makes coffee while tests run
[08:50] <zyga> I think my PT is starting to work
[08:56] <mvo> pedronis: would be great if you could double check https://github.com/snapcore/snapd/pull/9158/commits/a0786608b312063025ff713b2a896cecf6a1df43 - had to do a small extra change to this PR because of a bug in go 1.9 :/
[08:56] <mup> PR #9158: logger: add support for setting snapd.debug=1 on kernel cmdline <Documentation> <Created by mvo5> <https://github.com/snapcore/snapd/pull/9158>
[08:58] <zyga> ok that worked fine
[08:58] <zyga> but now I have new denials
[08:59] <zyga> type=AVC msg=audit(08/25/20 08:57:14.811:930) : avc:  denied  { search } for  pid=29402 comm=snap name=dbus dev="tmpfs" ino=17427 scontext=system_u:system_r:snappy_cli_t:s0 tcontext=system_u:object_r:system_dbusd_var_run_t:s0 tclass=dir permissive=1
[08:59] <zyga> type=AVC msg=audit(08/25/20 08:57:14.811:931) : avc:  denied  { write } for  pid=29402 comm=snap name=system_bus_socket dev="tmpfs" ino=17428 scontext=system_u:system_r:snappy_cli_t:s0 tcontext=system_u:object_r:system_dbusd_var_run_t:s0 tclass=sock_file permissive=1
[08:59] <zyga> type=AVC msg=audit(08/25/20 08:57:14.816:932) : avc:  denied  { connectto } for  pid=29402 comm=snap path=/run/dbus/system_bus_socket scontext=system_u:system_r:snappy_cli_t:s0 tcontext=system_u:system_r:system_dbusd_t:s0-s0:c0.c1023 tclass=unix_stream_socket permissive=1
[08:59] <zyga> I'll propose this separately and park that until Maciek is back
[09:01] <pedronis> mvo: ok, will look in a little bit
[09:12]  * zyga adds tests for tracking services and hooks to verify everything
[09:35] <zyga> tested hooks and services now, let's expand that to more systems and add session-level service tracking tests
[09:45] <zyga> oh drat
[09:45] <zyga> need power
[10:05] <zyga> ok, let's test on all the systems now
[10:05] <zyga> and add a test for session-level service tracking
[10:30] <mup> PR snapd#9211 opened: o/snapstate: disk space check with InstallMany <Disk space awareness> <⛔ Blocked> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9211>
[10:51] <mvo> zyga: if you are in review mood, please check out 8982 :)
[10:51] <zyga> mvo let me look
[10:52] <zyga> oh a biggie
[10:52] <zyga> but I need to grok snapshots more anyway
[10:53] <zyga> in 10 minutes, let me open a PR with a small but important fix
[10:59] <zyga> mvo reviewing now
[11:00] <zyga> https://github.com/snapcore/snapd/pull/9212 is ready for review, this will help with the feedback from maciek and will allow me to adjust the selinux policy next
[11:00] <mup> PR #9212: cgroup,snap: track hooks on system bus only <Bug> <Created by zyga> <https://github.com/snapcore/snapd/pull/9212>
[11:01] <mup> PR snapd#9212 opened: cgroup,snap: track hooks on system bus only <Bug> <Created by zyga> <https://github.com/snapcore/snapd/pull/9212>
[12:01] <mup> PR snapd#9213 opened: secboot: read kernel efi image from snap file <UC20> <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/9213>
[12:13]  * zyga goes for lunch
[12:13] <zyga> mvo 90% done with review
[12:13] <zyga> mvo but it will be a -1 so please don't merge
[12:48] <zyga> mvo done
[12:57] <mvo> zyga: thanks you
[12:58] <zyga> thanks me :)
[13:30] <mup> PR snapcraft#3262 opened: specifications: configurable apt mirror <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3262>
[13:51] <mup> PR snapd#9158 closed: logger: add support for setting snapd.debug=1 on kernel cmdline <Documentation> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9158>
[13:54] <pedronis> zyga: mvo: I checked the go code (quickest thing), there is padding, probably not completed padding but is there
[13:54] <pedronis> s/completed/complicated/
[13:59] <zyga> pedronis in the per-member header?
[14:01] <zyga> In the call I was confused by the question and I replied about gzip padding, not tar padding
[14:02] <zyga> I think we can expland the tar writer to have an optimized mode when TarWriter.Write cheats and assumes the header had the right size and ignores the source
[14:04] <pedronis> we were talking about tar
[14:04] <pedronis> the zip files are just put in a tar
[14:04] <zyga> yes, I looked at tar now as well
[14:05] <zyga> I think the optimization is not hard to do, we should fix the small stuff, land this and I can open a follow-up
[14:32]  * cachio afk
[14:37] <ijohnson> pedronis: instead of `emptyMap` is `cleanBootVars` an ok var name for #9205 ?
[14:37] <mup> PR #9205: boot/initramfs_test.go: reset boot vars on the bootloader for each iteration <Simple 😃> <Test Robustness> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9205>
[14:37] <pedronis> ijohnson: yes, either clean or reset
[14:38] <ijohnson> pedronis: ack since it's just 7 lines I am going to force push with `cleanBootVars`
[14:38] <zyga> https://github.com/snapcore/snapd/pull/9212 is green and relatively simple (most changes are just additional testes)
[14:38] <mup> PR #9212: cgroup,snap: track hooks on system bus only <Bug> <Created by zyga> <https://github.com/snapcore/snapd/pull/9212>
[14:40] <zyga> coffee and back to debugging
[14:42] <ijohnson> cachio: hey I just noticed we don't actually run the tests/nested/core20 suite with the run-nested label do we ?
[14:45] <mup> PR snapcraft#3260 closed: tools: update setuptools in environment-setup <tooling> <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3260>
[14:50] <mup> PR snapcraft#3261 closed: requirements: pin setuptools devel requirement <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3261>
[14:54] <ijohnson> zyga: +1d that simple PR
[15:01] <mup> PR snapcraft#3263 opened: colcon v2 plugin: honour http(s) proxy for all build commands <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3263>
[15:01] <zyga> thanks!
[15:12] <ijohnson> pedronis: actually I looked into a bit more, I don't think we should use `-f` for reboot from the initramfs, see https://github.com/snapcore/snapd/pull/9207#discussion_r476526179
[15:12] <mup> PR #9207: boot/bootstate20: reboot to rollback to previous kernel <Bug> <Run nested> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9207>
[15:12] <ijohnson> pedronis: given my findings there, do you think we should actually switch to using `systemctl reboot`? or should I ask x n o x (who is away this week at plumbers)
[16:00]  * zyga runs one more tests and calls it a day
[16:11] <cachio> ijohnson, sorry for the delay, I had to to buy a medicine and the had lunch
[16:11] <cachio> it should run core20
[16:11] <cachio> we are running tests/nested/
[16:11] <ijohnson> cachio: no worries, which spread-nested task on github actions runs tests/nested/core20 ?
[16:12] <cachio> google-nested:ubuntu-20.04
[16:13] <ijohnson> cachio: ah thanks, I got confused by the breakdown
[16:13] <ijohnson> thanks I see the test I was interested in actually failed
[16:15] <cachio> ijohnson, which one?
[16:15] <ijohnson> cachio: a test I proposed in https://github.com/snapcore/snapd/pull/9208/checks?check_run_id=1023281431
[16:15] <mup> PR #9208: tests/nested/core20/kernel-failover: add test for failed refresh of uc20 kernel <Run nested> <Test Robustness> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9208>
[16:15] <ijohnson> tests/nested/core20/kernel-failover failed there due to silly bashisms
[16:19] <mvo> cachio: 2.46 is getting released now, snapd snap beta should be ready in ~30min, core will be ~1h or so
[16:19] <cachio> mvo, nice, thanks
[16:20] <zyga> ijohnson good silly or bad silly
[16:20] <zyga> ijohnson was it masking a real bug
[16:20] <ijohnson> zyga: nah just I thought using `local` would work not in a function but it doesn't, I made a change to the test after it passed locally thinking it was harmless, seems it's not
[16:20] <ijohnson> 2020-08-24T20:19:32.8528139Z + local retry=120
[16:20] <ijohnson> 2020-08-24T20:19:32.8528330Z /bin/bash: line 82: local: can only be used in a function
[16:21] <ijohnson> oh hey this came up while you were out zyga
[16:21] <zyga> yeah?
[16:21] <zyga> nested.sh needs love
[16:21] <ijohnson> forgot to bring this up, but retry does not work with functions sourced from i.e. nested.sh
[16:21] <zyga> I need to review the changes from cachio tomorrow
[16:21] <ijohnson> how do you think we could make retry work with functions ?
[16:21] <mvo> zyga: I'm done with my meetings and mostly with the release, I'm happy to do your suggested fixes on 8982 in my morning (I will be up early). but if you get to it that's welcome of course. but don't feel obliged, you have a a lot of important stuff on your plate :)
[16:21] <zyga> ijohnson retry doesn't work with any function
[16:21] <zyga> it works with programs
[16:21] <ijohnson> zyga: yes
[16:21] <ijohnson> zyga: but could it be made to work with functions ?
[16:22] <ijohnson> or is this just another rat hole not worth trying to fix
[16:22] <mup> PR snapd#9214 opened: release: 2.46 <Skip spread> <Created by mvo5> <https://github.com/snapcore/snapd/pull/9214>
[16:22] <zyga> ijohnson it would be unsafe, I really don't want to go there
[16:22] <ijohnson> fair
[16:22] <zyga> I think it could be
[16:22] <zyga> I mean, yeah,
[16:22] <zyga> but the semantics is not something I'm 100% sure
[16:22] <cachio> zyga, tx
[16:22] <ijohnson> I realize this would work much better if nested.sh becomes a tool program instead of a sourced program
[16:23] <ijohnson> so maybe we just do that instead of trying to make retry work with functions
[16:23] <zyga> yeah, I think so
[16:23] <ijohnson> ok, fair enough
[16:24] <ijohnson> this came up while you were out and I forgot about it til just now
[16:24] <zyga> I think that's a fail desire but it's really more robust to compose programs than functions
[16:24] <zyga> let's see what we can do about nested.sh first
[16:24] <zyga> I lied, I ran more tests
[16:24] <zyga> but I need to run
[16:25] <zyga> my wife calls me
[16:46] <zyga> mvo released snapd
[16:46] <zyga> arch pings me to update
[16:46] <zyga> heh
[16:54] <ijohnson> zyga: how dare we not release to arch immediately, we must be lazy :-)
[17:33] <cachio> zyga, should we test on opensuse leap 15.2 as well?
[17:33] <cachio> there are new gce images
[17:47] <mvo> cachio: armhf failed to build in the ppa so core is a little bit delayed there
[17:48] <cachio> mvo, ok, np
[17:48] <cachio> I'll start with snapd
[17:48] <cachio> mvo, is snapd delayed as well?
[17:49] <mvo> cachio: no, but it looks like the change to "mkversion.sh" we did gives it a terrible version number :(
[17:49] <cachio> mvo, 2.46+git2.46.2.46
[17:49] <cachio> mvo, is it the final version for snapd?
[17:51] <ijohnson> oh no was that my fault
[17:51] <mvo> cachio: well, it should be 2.46
[17:51] <ijohnson> sorry
[17:51] <mvo> ijohnson: a bit unclear, no worries just yet
[17:51] <cachio> mvo, ijohnson no problem
[17:51] <cachio> just wanted to make sure
[17:52] <mvo> cachio: it's the right binary content but the version needs fixing :/
[17:56] <mup> PR snapcraft#3109 closed: pcache: introduce persistent cache decorator <enhancement> <Created by cjp256> <Closed by cjp256> <https://github.com/snapcore/snapcraft/pull/3109>
[17:56] <mup> PR snapcraft#3110 closed: repo: use persistent cache for fetching stage packages <enhancement> <Created by cjp256> <Closed by cjp256> <https://github.com/snapcore/snapcraft/pull/3110>
[18:04] <mvo> ijohnson: hm, I suspect "git describe --dirty" is not quite fixed :/
[18:04] <ijohnson> ah darn do we build with an old version of snapcraft in LP?
[18:04] <mvo> ijohnson: I think I set it to "candidate"
[18:05] <mvo> ijohnson: we build it here https://code.launchpad.net/~snappy-dev/+snap/snapd-2.46
[18:06] <ijohnson> mvo: but that bug is marked as fix released for snapcraft 3.1 which was released in jan 2019 :-(
[18:06] <ijohnson> the bug that the dirty thing referenced that is, https://bugs.launchpad.net/snapcraft/+bug/1806746
[18:06] <mup> Bug #1806746: Move state file to avoid dirtiness when snap is used for code <19.04> <19.04-external> <Snapcraft:Fix Released by sergiusens> <https://launchpad.net/bugs/1806746>
[18:07] <ijohnson> mvo: when I run mkversion.sh from master with your changelog placeholder mkversion.sh works fine
[18:08] <ijohnson> ah but I bet it is built from the release/2.46 branch let me try that one
[18:08] <ijohnson> mvo: it still gives me a valid version number it just has
[18:08] <ijohnson> ./mkversion.sh
[18:08] <ijohnson> *** Setting version to '2.46' from git.
[18:08] <mvo> ijohnson: it might be snapcraft in LP that is the problem
[18:08] <mvo> ijohnson: it works for me locally too
[18:09] <ijohnson> argh I think I know why
[18:09] <ijohnson> the core snap builds with "legacy" snapcraft because it doesn't specify a base or build-base in the snapcraft.yaml
[18:09] <mvo> ijohnson: this is the snapd snap
[18:09] <ijohnson> oh then I don't know why
[18:11] <ijohnson> mvo: I'm going to try and reproduce building snapd locally from release/2.46 then
[18:11] <ijohnson> mvo: does it only happen for snapd snap or the core snap too ?
[18:12] <mup> PR snapd#9215 opened: mkversion.sh: do not use git describe --dirty <Created by mvo5> <https://github.com/snapcore/snapd/pull/9215>
[18:13] <mvo> ijohnson: just snapd snap it seems
[18:13] <mvo> ijohnson: core just finished
[18:13] <ijohnson> ok, I've got a build going locally, should be done in a couple minutes
[18:14] <mvo> ijohnson: thanks, I will need to do some stuff around the house, should be back in 15min or so
[18:14] <mvo> ijohnson: in the meantime *maybe* 9215 will help
[18:14] <ijohnson> mvo: I will start a parallel build of your branch too just to see
[18:17] <ijohnson> silly snapcraft doesn't let multiple lxd containers for the same snap to run simultaneously
[18:26] <mup> PR snapcraft#3264 opened: colcon v2 plugin: don't strip environment for stage-runtime-dependencies <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3264>
[18:30] <ijohnson> mvo: I did manage to reproduce with snapcraft locally, debugging now
[18:31] <ijohnson> ah but actually there is a diff, it is dirty!
[18:31] <ijohnson> -                       "checksumSHA1": "UHhUJNcYbKn3xxZDuPh9GX6BWrM=",
[18:31] <ijohnson> +                       "checksumSHA1": "uLS+3ymPr8NztAjDjmiRkpKIsIQ=",
[18:32] <mvo> oh, what makes it dirty?
[18:32] <ijohnson> get-deps.sh modifies vendor.json with the above patch
[18:32] <ijohnson> I'm gonna try a fresh build with that changed on release/2.46 and committed
[18:33] <ijohnson> ah but then it won't be building 2.46 tag
[18:33] <ijohnson> hmm
[18:33] <ijohnson> I could always move the tag locally on my repo
[18:34] <mvo> oh, interessting
[18:34] <ijohnson> alright build running again let's see what happens
[18:35] <mvo> aha, secboot hm, hm
[18:35] <mvo> strange that we did not encounter this before
[18:35] <ijohnson> mvo: but actually though we have encountered this frequently
[18:36] <ijohnson> that secboot SHA keeps changing for myself and claudio and pedronis and possibly also others too locally
[18:40] <mvo> oh
[18:42] <mvo> so maybe that's the fix - updating vendor.json instead of --dirty
[18:42] <mvo> anyway, stuff for tomorrow, I need to call it a day
[18:42]  * mvo waves
[18:57] <mup> PR snapd#9216 opened: vendor.json: update mysterious secboot SHA again <⚠ Critical> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9216>
[20:18] <mup> PR snapd#9217 opened: run-checks: add typos from auto-tools when using `make hack` <Simple 😃> <Test Robustness> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9217>
[21:48] <mup> PR snapd#9218 opened: tests: running tests on opensuse leap 15.2 <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9218>