| mup | PR snapcraft#3263 closed: colcon v2 plugin: honour http(s) proxy for all build commands <bug> <Created by cjp256> <Closed by cjp256> <https://github.com/snapcore/snapcraft/pull/3263> | 02:32 |
|---|---|---|
| zyga-x240 | o/ | 06:23 |
| zyga-x240 | mvo: I saw your message yesterday | 06:23 |
| zyga-x240 | oh boy I open my laptop and Lucy wakes up | 06:23 |
| mvo | zyga-x240: good morning | 06:24 |
| zyga-x240 | :) | 06:24 |
| mvo | zyga-x240: no worries, either way is fine | 06:24 |
| zyga-x240 | until she's fully awake, changed and fed I will not be fully available | 06:25 |
| zyga-x240 | just a few more days till next week | 06:25 |
| mvo | zyga-x240: no worries | 06:26 |
| mvo | can someone please approve 9214? it's just changelog updaes | 06:32 |
| mup | PR snapd#9215 closed: mkversion.sh: do not use git describe --dirty <Created by mvo5> <Closed by mvo5> <https://github.com/snapcore/snapd/pull/9215> | 06:40 |
| mup | PR snapd#9215 opened: mkversion.sh: do not use git describe --dirty <Created by mvo5> <https://github.com/snapcore/snapd/pull/9215> | 06:45 |
| pstolowski | morniing | 07:04 |
| mvo | good morning pstolowski | 07:05 |
| zyga | re | 07:18 |
| zyga | mvo looking | 07:18 |
| zyga | mvo merged | 07:19 |
| mup | PR snapd#9214 closed: release: 2.46 <Skip spread> <Created by mvo5> <Merged by zyga> <https://github.com/snapcore/snapd/pull/9214> | 07:20 |
| mvo | zyga: \o/ | 07:23 |
| zyga | mvo in a way it's good we'll need 2.47 | 07:24 |
| zyga | we should release it in a few weeks at most | 07:24 |
| zyga | and get back to small releases | 07:24 |
| zyga | that are fast | 07:24 |
| mup | PR snapd#9219 opened: run-checks: only check files in git for misspelling <Created by mvo5> <https://github.com/snapcore/snapd/pull/9219> | 07:25 |
| zyga | mvo reviewed with a question | 07:27 |
| mvo | zyga: \o/ | 07:28 |
| zyga | mvo I'm available now, shall I pick up snapshot export PR? | 07:28 |
| mvo | zyga: if you want, I did not manage to and have meetings soon :/ | 07:28 |
| zyga | ok | 07:28 |
| * mvo hugs zyga | 07:28 | |
| zyga | gladly | 07:28 |
| zyga | on it | 07:28 |
| zyga | it's a new topic | 07:28 |
| zyga | that feels good sometimes | 07:28 |
| zyga | btw, offtopic, my lxd install stopped working | 07:28 |
| zyga | it says it needs manual network configuration | 07:28 |
| zyga | as it cannot find a free subnet or something | 07:29 |
| zyga | I have a 10.x.y.z/8 netmask | 07:29 |
| zyga | so I'm quite surprised | 07:29 |
| zyga | mvo shellcheck complained about the spell changing | 07:31 |
| mvo | zyga: yeah, I am a muppet | 07:34 |
| mvo | zyga: I force pushed a fix, I don't have $GOPATH/bin in my $PATH | 07:34 |
| zyga | k | 07:34 |
| mvo | zyga: so for local testing I did that (I don't like the idea of something like $GOPATH/bin in my PATH, feels too dangerous) | 07:34 |
| mvo | anyway | 07:34 |
| mvo | silly me | 07:34 |
| zyga | it's okay | 07:34 |
| mvo | zyga: I replied, I can add comments about where the ignore comes from, maybe a good idea | 07:35 |
| zyga | mvo replied too | 07:36 |
| mup | PR snapd#9205 closed: boot/initramfs_test.go: reset boot vars on the bootloader for each iteration <Simple 😃> <Test Robustness> <UC20> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9205> | 07:50 |
| zyga | mvo I've updated https://github.com/snapcore/snapd/pull/8982 and left two unresolved comments: | 09:08 |
| mup | PR #8982: snapshots: export of snapshots <Created by slimjim777> <https://github.com/snapcore/snapd/pull/8982> | 09:08 |
| zyga | mvo one is about the help message of export-snapshot, I need to ask Graham for help here | 09:08 |
| zyga | it can also happen in a follow up I guess but it might be easy enough to do todat | 09:08 |
| zyga | *today | 09:08 |
| zyga | the second one is about error handling in https://github.com/snapcore/snapd/pull/8982#discussion_r476372693 | 09:09 |
| zyga | and I think I need pstolowski help on that | 09:09 |
| zyga | can you look and express your opinion please pawel? | 09:09 |
| zyga | other code seems to handle errors from requests in a different way | 09:09 |
| zyga | and can use the body to unpack error details | 09:09 |
| zyga | we should either be consistent about it or leave a comment why we are not doing this | 09:09 |
| zyga | mvo I left the tar improvements out for a new PR | 09:10 |
| zyga | and adjusted everything else | 09:10 |
| zyga | so it means someone other than me should do a review | 09:10 |
| mvo | zyga: in a meeting, but *thanks* | 09:10 |
| pstolowski | zyga: sure | 09:11 |
| pedronis | I can look about the error handling as well but in a bit, I suspect the difference might relate that the happy response is not json here | 09:15 |
| pedronis | but I suspect the error ones should be | 09:15 |
| zyga | yeah, I think so too | 09:19 |
| zyga | thanks! | 09:19 |
| zyga | I'll return to my other tasks and try to finish the tar optimize after PT in the evening | 09:20 |
| pstolowski | zyga: it looks like e.g. maintenance status on error may be interesting to have | 09:26 |
| mvo | zyga: just looked over your changes, looks fine | 10:03 |
| mvo | zyga: thank you! | 10:03 |
| zyga | mvo cheers :) | 10:05 |
| mvo | pstolowski: I wonder if the client error handling should be done in a followup, I'm not sure we need more here tbh but even if it seems the exiting code is not wrong, just that it could be improved(?) | 10:05 |
| mvo | pstolowski: I'm in favor of merging (if green :) | 10:05 |
| pstolowski | mvo: yes, absolutely, a followup is gine | 10:05 |
| pstolowski | *fine | 10:05 |
| zyga | mvo I'm okay with that as well | 10:05 |
| pstolowski | hmm services PR failed and the failure looks real on 14.04 | 10:26 |
| mup | PR snapd#9220 opened: o/snapstate: disk space check with single snap install <Disk space awareness> <â›” Blocked> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9220> | 10:41 |
| zyga | pstolowski how did it fail? | 10:55 |
| pstolowski | zyga: state of services not as expected | 10:56 |
| zyga | mmm | 10:56 |
| pstolowski | oddly only on 14.04. i'm going to investigate in a bit | 10:56 |
| zyga | what was the unexpected status? | 10:57 |
| pstolowski | zyga: enabled/inactive instead of disabled/inactive | 11:06 |
| mup | PR snapd#9221 opened: tests: disk space awareness spread test <Disk space awareness> <â›” Blocked> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9221> | 11:06 |
| mup | PR snapd#8982 closed: snapshots: export of snapshots <Created by slimjim777> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8982> | 11:16 |
| mup | PR snapd#9199 closed: snapstate: installSize helper that calculates total size of snaps and their prerequisites <Disk space awareness> <Needs Samuele review> <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9199> | 11:21 |
| pedronis | pstolowski: should I re-review the service PR or wait? | 11:31 |
| mup | PR snapd#9222 opened: osutil: add a package doc comment (via doc.go) <Simple 😃> <Created by pedronis> <https://github.com/snapcore/snapd/pull/9222> | 11:51 |
| pstolowski | pedronis: please wait, i'll let you know | 12:04 |
| pedronis | pstolowski: ok, thx | 12:04 |
| pedronis | pstolowski: when you have a moment, can you merge master into #9211 ? | 12:05 |
| mup | PR #9211: o/snapstate: disk space check with InstallMany <Disk space awareness> <â›” Blocked> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9211> | 12:05 |
| pstolowski | yes | 12:07 |
| pedronis | mvo: #9222 is small/simple and touches something you did | 12:11 |
| mup | PR #9222: osutil: add a package doc comment (via doc.go) <Simple 😃> <Created by pedronis> <https://github.com/snapcore/snapd/pull/9222> | 12:11 |
| === benfrancis7 is now known as benfrancis | ||
| mvo | pedronis: thank you | 12:58 |
| mup | PR snapd#9206 closed: boot: complain about reused asset name during initial install <UC20> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9206> | 13:01 |
| mup | PR snapd#9222 closed: osutil: add a package doc comment (via doc.go) <Simple 😃> <Created by pedronis> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9222> | 13:01 |
| Chipaca | hey-o | 13:09 |
| Chipaca | i've recently found that i need to restart snapd.socket manually every so often | 13:09 |
| === benfrancis6 is now known as benfrancis | ||
| mvo | pstolowski: 9211 has some unhappy unit test but looks great otherwise | 14:06 |
| pstolowski | mvo: ah, i forgot to rename after mergin master, thanks | 14:08 |
| cachio | zyga, hey | 14:08 |
| cachio | about the error related to the failober tests | 14:08 |
| zyga | re | 14:09 |
| cachio | of rexternal backend | 14:09 |
| zyga | Chipaca, oh what's the state of the socket when you do? | 14:09 |
| zyga | cachio, yeah? | 14:09 |
| cachio | do you have in mind anython to fix that? | 14:09 |
| Chipaca | zyga: a fair question. i'll look next time it happens. | 14:09 |
| zyga | cachio sorry, the failure we talked about before or some new one? | 14:09 |
| zyga | Chipaca I did observe something weird related to pulse socket like that | 14:09 |
| zyga | oh, sorry | 14:09 |
| zyga | not to the pulse socket | 14:09 |
| cachio | zyga, the one we talked before | 14:09 |
| zyga | to the snapd socket in fact | 14:09 |
| zyga | it was related to snapd-userd socket | 14:10 |
| zyga | when we changed the socket definition | 14:10 |
| zyga | (just rewrite it) | 14:10 |
| zyga | and not reload systemd-userd | 14:10 |
| cachio | zyga, which failed because external backend does "sudo su to run the spread script" | 14:10 |
| zyga | cachio right | 14:10 |
| zyga | cachio that's fundamentally broken sadly :/ | 14:10 |
| zyga | cachio we have to change that | 14:11 |
| zyga | it should, at minimum, do sudo -l | 14:11 |
| cachio | zyga, so change spread | 14:11 |
| zyga | er, wait | 14:11 |
| zyga | not -l | 14:11 |
| zyga | su -l, for sudo that's .... | 14:11 |
| mup | PR snapd#9217 closed: run-checks: add typos from auto-tools when using `make hack` <Simple 😃> <Test Robustness> <Created by anonymouse64> <Closed by anonymouse64> <https://github.com/snapcore/snapd/pull/9217> | 14:12 |
| zyga | cachio sudo -i (or sudo --login for clarity) | 14:12 |
| zyga | not tested | 14:12 |
| zyga | but that should be much better if it works as I expect | 14:12 |
| zyga | if that's convenient, change spread and see if this fixes it | 14:12 |
| cachio | zyga, ok, I'll make the change | 14:12 |
| zyga | ok | 14:12 |
| cachio | zyga, thanks for the suggestion | 14:12 |
| zyga | Chipaca in any case, thanks for the heads up | 14:13 |
| zyga | I'm running snapd without rebooting on metal to observe weird things as well but I have been unable to spend the time to dig into the things I saw | 14:13 |
| zyga | (insert commas for best sense) | 14:13 |
| ijohnson | zyga: mvo: so for #9216, what should I do? the changelog typo fix is not on release/2.46 so I'm not sure what to force push ? | 14:16 |
| mup | PR #9216: vendor.json: update mysterious secboot SHA again <âš Critical> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9216> | 14:16 |
| mup | PR snapd#9215 closed: mkversion.sh: do not use git describe --dirty <âš Critical> <Created by mvo5> <Closed by mvo5> <https://github.com/snapcore/snapd/pull/9215> | 14:17 |
| zyga | ijohnson I was unclear, sorry, I expected to find only the hash change, not the typo fixes | 14:17 |
| ijohnson | zyga: sure but then no tests run against the PR if I don't fix the typos here | 14:17 |
| zyga | are they necessary in this branch? | 14:17 |
| zyga | oh | 14:17 |
| zyga | meh | 14:17 |
| zyga | that sucks, can we just merge the fixes separately? | 14:17 |
| ijohnson | i.e. open any PR against release/2.46 and tests don't run | 14:17 |
| zyga | it's not a biggie | 14:17 |
| ijohnson | I'll leave to mvo to decide what to do, I'll leave the PR as-is for now | 14:18 |
| zyga | ijohnson due to the typos? | 14:18 |
| zyga | ok | 14:18 |
| ijohnson | zyga: yes | 14:18 |
| zyga | I trust mvo's merge button | 14:18 |
| ijohnson | the unit / static tests fail on the typos and don't do spread runs | 14:18 |
| mup | PR snapcraft#3264 closed: colcon v2 plugin: don't strip environment for stage-runtime-dependencies <bug> <Created by cjp256> <Closed by cjp256> <https://github.com/snapcore/snapcraft/pull/3264> | 14:18 |
| ijohnson | normally I'd say it's fine but this sha thing is mysterious enough to make me want to see spread results of building with this vendor.json change | 14:18 |
| zyga | ijohnson I would just merge the typos separately | 14:20 |
| zyga | and then rebase this branch | 14:20 |
| zyga | so we can see a single thing to track, not that with other bits | 14:20 |
| ijohnson | zyga: sure but I would rather wait til mvo says what he prefers | 14:22 |
| zyga | ok | 14:22 |
| mup | PR snapcraft#3265 opened: colcon v2 plugin: honour http(s) proxy for stage-runtime-dependencies <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3265> | 14:23 |
| pedronis | mvo: pstolowski: there is no daemon support yet for ErrInsuffiecientSpace ? also that name is not following style conventions | 14:29 |
| pstolowski | pedronis: correct, no daemon yet | 14:30 |
| cachio | zyga, so currently it is doing "sudo -i /bin/bash /tmp/tmp.zwRt33mi04" | 14:35 |
| cachio | to execute the script | 14:35 |
| pedronis | pstolowski: I left some comments | 14:36 |
| zyga | cachio currently as in with some changes or vanilla? | 14:36 |
| mvo | ijohnson, zyga sorry, meetings will look at the backlog | 14:37 |
| cachio | zyga, vanilla | 14:37 |
| zyga | cachio ok, perhaps it needs some more oomph | 14:37 |
| pstolowski | pedronis: ty | 14:37 |
| zyga | can you try changing that to su -l | 14:38 |
| cachio | zyga, sure | 14:38 |
| ijohnson | mvo: I opened https://github.com/snapcore/snapd/pull/9223 to fix the --dirty handling in mkversion.sh | 14:40 |
| mup | PR #9223: mkversion.sh: simple hack to include dirty in version if the tree is dirty <Bug> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9223> | 14:40 |
| ijohnson | hopefully that is the best of all possible worlds (but all possible worlds are still terrible) | 14:41 |
| ijohnson | mvo: also please advice on next steps for #9216 | 14:41 |
| mup | PR #9216: vendor.json: update mysterious secboot SHA again <âš Critical> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9216> | 14:41 |
| mup | PR snapd#9223 opened: mkversion.sh: simple hack to include dirty in version if the tree is dirty <Bug> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9223> | 14:42 |
| mup | PR snapd#9216 closed: vendor.json: update mysterious secboot SHA again <âš Critical> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9216> | 15:07 |
| pedronis | pstolowski: mvo: do we plan to have checks also for refresh ? | 15:07 |
| mup | PR snapcraft#3266 opened: cli: add --enable-experimental-extensions option for expand-extensions <enhancement> <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3266> | 15:08 |
| mvo | pstolowski, pedronis: I think that would be good | 15:09 |
| pstolowski | pedronis: yes i think so | 15:09 |
| pedronis | pstolowski: mvo: given that we remove old revisions only after installing the new ones, it's probably not too different form install | 15:15 |
| pedronis | *from | 15:15 |
| mvo | pedronis: yeah | 15:15 |
| mvo | pedronis: one interessting point for really low disk space system is that we may need to provide a mode in the future to change this behavior to "remove-before-install" | 15:16 |
| pedronis | ok, sounds something to think about when we get there | 15:19 |
| pedronis | it means no rollback unless you keep two old revisions | 15:21 |
| pedronis | which would take more space | 15:22 |
| pedronis | mvo: if you really want just one revision there's no undo | 15:23 |
| * cachio lunch | 15:28 | |
| * mvo nods | 15:29 | |
| mup | PR snapd#9224 opened: Added MIRKey to U2F devices list in interfaces/builtin <Created by kobusgrobler> <https://github.com/snapcore/snapd/pull/9224> | 15:42 |
| pstolowski | hmm there is something wonky with 'systemctl enable --root=/ on 14.04 ...' | 15:47 |
| pstolowski | mvo: interesting idea | 15:48 |
| mvo | pstolowski: all later | 15:49 |
| pstolowski | sure, ack | 15:49 |
| mvo | pstolowski: just an idea because we were talking about really low disspace systems | 15:49 |
| pstolowski | systemctl enable --root=/ on 14.04 creates symlinks sunch as "snap.disabled-svcs-kept.svc.service -> ///etc/systemd/system/snap.disabled-svcs-kept.svc.service" and things seem to go wrong from there | 15:51 |
| pedronis | pstolowski: what is using enable --root ? a test? | 15:52 |
| pstolowski | pedronis: Enable(..) in our systemd package, and it's now used in my services PR. no problems except for 14.04 | 15:53 |
| pstolowski | so it's used for real, not in test | 15:54 |
| pedronis | pstolowski: is that related to preseeding ? | 15:55 |
| pstolowski | pedronis: no | 15:55 |
| pedronis | or it was always like that? | 15:55 |
| pstolowski | pedronis: as far as systemd package is concerned , --root is 1 year old | 15:56 |
| pedronis | it's related to user services it seems | 15:56 |
| pstolowski | pedronis: but it's now used for snap start.. in my PR. i need to compare with master | 15:56 |
| pstolowski | pedronis: likely, the change was from James | 15:57 |
| pedronis | not sure | 15:57 |
| pedronis | James didn't change that | 15:57 |
| pedronis | at least not in the obvious PR | 15:58 |
| * mvo hockey, available via tg for ugent cases | 15:59 | |
| pstolowski | pedronis: right, he just touched the line but didn't change semantics. anyway, something in my PR to fix, i need to check what did we do in master, most likely --root wasn't and shouldn't be passed in this case | 16:01 |
| pedronis | afaict even on master we pass it everywhere | 16:02 |
| pedronis | ah, no | 16:02 |
| pedronis | sorry, I'm confused is the problem enable or start? | 16:02 |
| pstolowski | pedronis: start --enable our our side, which translates to separate enable followed by start | 16:04 |
| pedronis | pstolowski: I see, anyway --root was there since that code started using systemctl in 2016 | 16:06 |
| pedronis | pstolowski: 5106ed3bcb193bf | 16:07 |
| mup | PR snapd#9225 opened: many: cloud-init cleanups from previous PR's <Cleanup :broom:> <Simple 😃> <Test Robustness> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9225> | 16:07 |
| pstolowski | pedronis: yes, but afaict it wasn't used with this exec-command tasks where systemctl was called directly, that's the thing | 16:11 |
| pstolowski | anyway i need to eod, appointment | 16:11 |
| mup | PR snapd#9226 opened: cmd/snap-bootstrap/initramfs-mounts: compute string outside of loop <Cleanup :broom:> <Simple 😃> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9226> | 16:12 |
| pedronis | ijohnson: does #9225 need to run with nested tests enabled? | 16:17 |
| mup | PR #9225: many: cloud-init cleanups from previous PR's <Cleanup :broom:> <Simple 😃> <Test Robustness> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9225> | 16:17 |
| cachio | zyga, no luck with sudo -l | 16:18 |
| ijohnson | pedronis: ah yes good point, let me re-open with that label | 16:18 |
| pedronis | ijohnson: I reviewed the cleanup PRs | 16:21 |
| ijohnson | thanks | 16:21 |
| mup | PR snapd#9219 closed: run-checks: only check files in git for misspelling <Skip spread> <Created by mvo5> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/9219> | 16:27 |
| ijohnson | cachio: can you add to your nested test TODO to fix the regexp here for the ubuntu-16.04-64:tests/nested/core/extra-snaps-assertions test? https://pastebin.ubuntu.com/p/8y5pYY5PQw/ | 16:29 |
| ijohnson | pedronis: the last change you requested re cloud-init was in nested.sh from the private reviews, but I pushed it to https://github.com/snapcore/snapd/pull/9208/commits/9d1a8d64f0eb1242ce912875fc9e9f977fe72fe3 since that branch needed a restart anyways and is already nested.sh related | 16:30 |
| mup | PR #9208: tests/nested/core20/kernel-failover: add test for failed refresh of uc20 kernel <Run nested> <Test Robustness> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9208> | 16:30 |
| ijohnson | pedronis: you originally requested it here: https://github.com/anonymouse64/snapd-private/pull/8/files/bbfe9f9fc266d9cc43fe2c45c44620f4ad6ff2d0#r451357700 | 16:30 |
| cachio | ijohnson, to fix? | 16:30 |
| cachio | let me check | 16:30 |
| ijohnson | cachio: see the pastebin, the regexp for the core snap is wrong, it doesn't expect to see a pre version there | 16:31 |
| mup | PR snapd#9227 opened: snap: add stat to the random access file return interface <Simple 😃> <UC20> <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/9227> | 16:32 |
| cachio | ijohnson, ahhh, the pre + git | 16:33 |
| ijohnson | yes | 16:33 |
| cachio | in my pr | 16:33 |
| cachio | I am not checkin hte version when the rev ix x1 | 16:33 |
| cachio | because we test that as part of the listing test in main suite | 16:34 |
| cachio | so what I did is to simplify what we test in case we build core | 16:34 |
| cachio | ijohnson, does it make sense for you? | 16:34 |
| ijohnson | cachio: sure if it doesn't make sense to check that you can just remove that check that's fine | 16:35 |
| ijohnson | just wanted to make sure you knew about the failure | 16:35 |
| cachio | ijohnson, nice, so that problem is covered in #9098 | 16:38 |
| mup | PR #9098: tests: new organization for nested tests <Run nested> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9098> | 16:38 |
| ijohnson | great | 16:39 |
| zyga | cachio, can you check if if su -l creates a logind session? | 16:51 |
| cachio | zyga, sure | 16:51 |
| * zyga feels so so | 16:51 | |
| zyga | I think I may be getting the same thing my wife has | 16:52 |
| cachio | zyga, go to rest | 16:52 |
| ijohnson | zyga: oh no | 16:52 |
| zyga | cachio alternatively try this | 16:53 |
| zyga | cachio run without sudo | 16:53 |
| zyga | cachio use sudo to create a systemd unit, maybe via systemd-run or manually | 16:53 |
| zyga | have the unit run the shell script | 16:53 |
| cachio | zyga, run the script without sudo? | 16:54 |
| zyga | and start the unit similarly to how session-tool does it, with runuser -l | 16:54 |
| zyga | cachio start the script with runuser -l, as the desired user (root) but inside a systemd system unit | 16:55 |
| zyga | cachio it's all a bit convoluted but that's one scenario that I know should behave correctly | 16:55 |
| zyga | cachio you can then try to reduce this | 16:55 |
| cachio | zyga, ok, I'll try that | 16:56 |
| ijohnson | cmatsuoka: what's the keyboard shortcut to open a debug shell for a uc20 vm again? I seem to remember it was ctrl+f8 or something but that doesn't do anything :-/ | 17:06 |
| zyga | ijohnson, cmatsuoka: please review simple bug fix https://github.com/snapcore/snapd/pull/9228 | 18:04 |
| mup | PR #9228: interfaces/systemd: compare dereferenced Service <Bug> <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/9228> | 18:04 |
| zyga | customer bug | 18:04 |
| zyga | and my shame | 18:04 |
| zyga | as I wrote this | 18:04 |
| ijohnson | cmatsuoka: hey on your spread runner do you have python installed? | 18:04 |
| ijohnson | cmatsuoka: see https://github.com/snapcore/snapd/runs/1032308198?check_suite_focus=true | 18:04 |
| zyga | ijohnson: python-launchpadlib probably | 18:04 |
| zyga | or python3-launchpadlib | 18:05 |
| ijohnson | the CLA checker failed because it couldn't find python | 18:05 |
| zyga | anyway | 18:05 |
| ijohnson | zyga: sure I'll have a look | 18:05 |
| cachio | zyga, back to this | 18:05 |
| cachio | zyga, you said start the script with runuser -l | 18:05 |
| cachio | which script are you talking about? | 18:05 |
| zyga | cachio runuser -l is like sudo | 18:05 |
| cachio | zyga, yes | 18:05 |
| zyga | but it has the right pam config so it gives you a logind session | 18:06 |
| zyga | the logind session is only created if the invoking process does not belong to a cgroup which is considered part of a session | 18:06 |
| cachio | you mean spread has do to that? | 18:06 |
| cachio | instead of doing sudo -i | 18:06 |
| zyga | hence the workaround with running a systemd unit to run runuser -l | 18:06 |
| zyga | yes | 18:06 |
| cachio | zyga, ah, ok | 18:06 |
| zyga | or offer a way for us to do this via spread | 18:06 |
| cmatsuoka | ijohnson: installing python-is-python3 | 18:07 |
| zyga | otherwise, the external user has a session | 18:07 |
| zyga | and root does not | 18:07 |
| ijohnson | cmatsuoka: thanks | 18:07 |
| zyga | and our tests are not compatible wiith that | 18:07 |
| cmatsuoka | zyga: will check asap | 18:07 |
| ijohnson | cmatsuoka: also did you see my ping before you logged off about the debug shell on a VM? | 18:07 |
| mup | PR snapd#9228 opened: interfaces/systemd: compare dereferenced Service <Bug> <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/9228> | 18:07 |
| cmatsuoka | ijohnson: yes, I answered it (alt+f9) but maybe it was lost in a reconnection? | 18:08 |
| ijohnson | cmatsuoka: yeah I didn't see the response | 18:08 |
| zyga | Thank you for the quick review Ian | 18:08 |
| zyga | btw, if my wife is okay and she goes back to work next week | 18:08 |
| zyga | I will shift my hours to start at 11 AM or perhaps even at noon | 18:08 |
| ijohnson | cmatsuoka: hmm so I added rd.systemd.debug-shell=1 to the kernel command line via grub.cfg but alt-f9 still doesn't work | 18:08 |
| zyga | to be with lucy in the morning | 18:08 |
| ijohnson | zyga: that's great that your wife is okay | 18:08 |
| ijohnson | happy to hear that | 18:08 |
| zyga | and then hand off to her (my wife will work part time) | 18:08 |
| zyga | ijohnson: she's not yet, I meant "iff she's okay" | 18:09 |
| ijohnson | zyga: ah I missed the most critical word there | 18:09 |
| zyga | ijohnson: so if that all works out I will be working more with you guys :) | 18:09 |
| ijohnson | :-) | 18:09 |
| zyga | more overlap during the day | 18:09 |
| cmatsuoka | zyga: reviewed | 18:09 |
| zyga | thank you guys! | 18:10 |
| zyga | complex day | 18:10 |
| zyga | older kids fighting | 18:10 |
| zyga | lucy not seeing mom all day, being very grumpy about that | 18:11 |
| zyga | wife coming home sick | 18:11 |
| zyga | eh | 18:11 |
| zyga | eh | 18:11 |
| zyga | and now bugs | 18:11 |
| mup | PR snapcraft#3267 opened: ci: re-enable appveyor artifact collection <tooling> <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3267> | 18:34 |
| cachio | zyga, tried that but the session was not created | 18:43 |
| cachio | allways have the external and test sessions but can make it for the root session | 18:44 |
| cachio | I need to go to the kinesiologist now | 18:44 |
| cachio | I tried manuall | 18:44 |
| cachio | y | 18:44 |
| cachio | once I am back I'll continue reading documentation | 18:45 |
| cachio | zyga, if you have any idea please leave a note | 18:45 |
| cachio | zyga, thanks | 18:45 |
| * cachio -> kinesiologist | 18:45 | |
| cmatsuoka | ijohnson: did you add dangerous too? | 19:07 |
| ijohnson | cmatsuoka: yes I did still didn't work, but I was able to work around it anyways | 19:07 |
| cmatsuoka | ijohnson: it works for me with regular systemd.debug-shell, it's been a long time since I used rd.systemd but it should work using the same mechanism | 19:09 |
| cmatsuoka | afk, /me forgot to pay some bills | 19:11 |
| ijohnson | cachio: I reviewed #9098, I think it is getting close just a few more comments | 21:22 |
| mup | PR #9098: tests: new organization for nested tests <Run nested> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9098> | 21:22 |
| cachio | ijohnson, thanks | 21:22 |
| ijohnson | np | 21:23 |
| cachio | ijohnson, any idea how to create a user session for root when I an using external user? | 21:23 |
| cachio | I tried what zyga suggested | 21:23 |
| cachio | but no luck | 21:23 |
| ijohnson | ahh no unfortunately I don't I would need to spend a bit of time looking at the problem first, I haven't looked at the user session stuff in a while | 21:24 |
| ijohnson | if you still can't get it worked out tomorrow maybe I can have a look tomorrow afternoon | 21:24 |
| cachio | ijohnson, np, tomorrow I'll continue with zyga | 21:24 |
| ijohnson | sounds good | 21:25 |
| cachio | not it is too late for him | 21:25 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!