| wallyworld | hpidcock: tiny PR to fix an build number issue https://github.com/juju/juju/pull/11939 | 01:05 |
|---|---|---|
| hpidcock | @wallyworld looking | 01:06 |
| hpidcock | @wallyworld approved | 01:08 |
| wallyworld | ty | 01:08 |
| hpidcock | kelvinliu: tlm: https://github.com/juju/juju/pull/11940 | 01:10 |
| kelvinliu | looking | 01:11 |
| kelvinliu | hpidcock: lgtm ty | 01:19 |
| === tmhoang2 is now known as tmhoang | ||
| hpidcock | kelvinliu or tlm https://github.com/juju/juju/pull/11941 | 04:06 |
| kelvinliu | i will leave this one to tlm since im reviewing his pr. :) | 04:08 |
| hpidcock | kelvinliu: 👍 | 04:11 |
| tlm | looking now, thanks kelvinliu | 04:12 |
| tlm | lgtm hpidcock | 04:20 |
| kelvinliu | tlm: just left a few comments. ty | 04:41 |
| tlm | ta, look in a sec | 04:45 |
| jam | morning all | 13:06 |
| stickupkid | CR for https://github.com/juju/juju/pull/11936 | 14:57 |
| stickupkid | manadart, upgrade-series validate ^ | 14:57 |
| manadart | stickupkid: OK to do it first thing? Need to get home and take the kids. This should fix the NIC update problem too: https://github.com/juju/juju/pull/11943 | 15:01 |
| stickupkid | manadart, take your time | 15:02 |
| manadart | Might actually make things a little faster when landing a bunch of containers. | 15:02 |
| stickupkid | can we get icey to test this patch? | 15:03 |
| icey | stickupkid: if you can get me a built jujud soon, I can even test it today - otherwise, tomorrow morning | 15:04 |
| * icey doesn't know how to build go things | 15:04 | |
| manadart | icey: This one poses an issue the other way around from how we've been doing it - this is needed agent-side rather than controller-side. | 15:05 |
| icey | manadart: ah - super fun | 15:05 |
| manadart | So we have to do a --build-agent, or get it into a stream. | 15:05 |
| icey | does the --build-agent have to be at bootstrap time? | 15:06 |
| stickupkid | you can do it for upgrade-controller | 15:06 |
| icey | (alternately, streams somewhere sounds nice :-P ) | 15:06 |
| manadart | I'll see what I can come up with tomorrow. | 15:06 |
| stickupkid | or you could totally do some upload tools thing I bet | 15:06 |
| stickupkid | and bounce the controller | 15:06 |
| icey | ok - tomorrow AM works for me too | 15:06 |
| icey | whatever works, I'm probably 20 minutes from EoD | 15:07 |
| manadart | o/ | 15:07 |
| stickupkid | hml, approved | 15:18 |
| hml | stickupkid: ta | 15:18 |
| === _thumper_ is now known as thumper | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!