/srv/irclogs.ubuntu.com/2020/08/31/#snappy.txt

mborzeckimorning05:09
mborzeckiha, i'm not the one seeing osx failures06:30
mborzeckimvo: hey06:44
mvogood morning mborzecki06:45
mupPR snapd#9211 closed: o/snapstate: disk space check with InstallMany <Disk space awareness> <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9211>06:50
mborzeckipstolowski: heya07:04
pstolowskihi!07:05
mvohey pstolowski ! good morning07:05
pstolowskihey mvo!07:06
zygagood morning07:22
mupPR snapd#9239 closed: many: misc doc-comment changes and typo fixes <Simple 😃> <Skip spread> <Created by anonymouse64> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/9239>07:30
pstolowskiehhh @systemd07:41
pedronispstolowski: mvo: hi, do we need to have a chat about disk space checks?07:45
zygapstolowski: problems?07:46
mvopedronis, pstolowski maybe, I'm not super worried. was mostly thinking about something simple (like a system option) to disable the checks07:48
pedronismvo: well, some checks have landed already07:48
mupPR snapd#9242 opened: github: run macOS job with Go 1.14 <Simple 😃> <Skip spread> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9242>08:10
mborzeckiheh, it's green (the macos job at least)08:16
mborzeckizyga: can you take a look ^^^ ?08:16
pedroniszyga: can you look at https://bugs.launchpad.net/snapd/+bug/1892895 when you have a moment08:17
mupBug #1892895: unable to allow an app to access all devices with a certain major number via a <majordev>:* device cgroup rule <snapd:New for zyga> <https://launchpad.net/bugs/1892895>08:17
pedronismborzecki: mvo: are we working on this https://bugs.launchpad.net/snapd/+bug/1776622 ?08:30
mupBug #1776622: snapd updates on focal never finish installing. Can't install any other updates. <amd64> <apport-bug> <champagne> <focal> <regression> <snapd:Confirmed for mvo> <snapd (Ubuntu):Confirmed for mvo> <systemd (Ubuntu):Invalid> <https://launchpad.net/bugs/1776622>08:30
pstolowskipedronis: systemctl status check (what we discussed last friday wrt --root semantics difference when unit is missing) is going to be messy or maybe we need to do something else, the bahvior of systemctl status is different in 14.04. i wonder if we shouldn't land https://github.com/snapcore/snapd/pull/9241/ to unblock services PR (and in the meantime i'll work on a solution)08:30
mupPR #9241: tests: do not set rsyslog.disable in core18 config defaults test <Test Robustness> <â›” Blocked> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9241>08:30
pedronispstolowski: it's a real issue, no? is not just the tests08:33
zygare08:46
zygamborzecki, pedronis: ack08:46
zyga(my laptop suspended during my 1:1)08:46
zygathat udev permission issue is very interesting08:46
zygait kind of forces us to re-think the entire cgroup access logic08:46
zygabut, there is some hope that cgroupv2 mode may allow us to do this race free08:46
zygamborzecki: reviewed08:46
zygapedronis: we should talk about that during the standup a little08:46
zygapedronis: I'll think about this and write down some ideas08:46
pstolowskipedronis: it's an issue if the config flag is set (e.g. via defaults) but the service file doesn't exist08:46
pstolowskii suppose it would be an issue if flag was set and then the service was uninstalled08:46
mupPR snapd#9242 closed: github: run macOS job with Go 1.14 <Simple 😃> <Skip spread> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/9242>08:46
mupPR snapd#9202 closed: tests/nested/core20/tpm: verify trusted boot assets tracking  <Run nested> <UC20> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/9202>09:00
mborzeckithe nested suite seems to be doing strage stuff and the state from one test seems to leak to the next one09:02
mborzeckisee https://github.com/snapcore/snapd/runs/105010532909:02
mborzeckihttps://github.com/snapcore/snapd/runs/1050105322 this one09:03
zygahmm, let's tell sergio about it09:07
zygahopefully the nested fixes he was doing will help09:07
mvohm, I see some failures in macos-sanity in or 923809:10
mvodid we acciently break that?09:10
mvoI also noticed it was not a required check :( I fixed that now09:10
mborzeckimvo: it's fixed already, merge master please09:11
mvomborzecki: ta09:11
mupPR snapd#9238 closed: many: check that users of BaseTest don't forget to consume cleanups <Created by pedronis> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9238>09:15
mvopedronis: I replied in 177662209:25
mvopedronis: (just fyi)09:25
zygapedronis: small question on now-merged https://github.com/snapcore/snapd/pull/9238/files#r48001407009:41
mupPR #9238: many: check that users of BaseTest don't forget to consume cleanups <Created by pedronis> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9238>09:41
mborzeckizyga: the new set of denials in https://github.com/snapcore/snapd/pull/9204 looks sane09:49
mupPR #9204: sandbox: track applications unconditionally <Created by zyga> <https://github.com/snapcore/snapd/pull/9204>09:49
mupPR snapd#9240 closed: o/devicestate/devicestate_cloudinit_test.go: test cleanup for uc20 cloud-init tests <Simple 😃> <Skip spread> <Test Robustness> <UC20> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9240>09:51
mborzeckizyga: left a note with a snippet that you can try adding to the policy https://github.com/snapcore/snapd/pull/9204#issuecomment-68368313209:55
mupPR #9204: sandbox: track applications unconditionally <Created by zyga> <https://github.com/snapcore/snapd/pull/9204>09:55
mupPR snapd#9224 closed: interfaces/utf: Add MIRKey to u2f devices <Needs security review> <Created by kobusgrobler> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9224>09:56
zygamborzecki: thank you, I'll do that09:56
mupPR snapd#9243 opened: testutil: add checkers for symbolic link target <Created by zyga> <https://github.com/snapcore/snapd/pull/9243>10:06
zygamborzecki: updated, I also left a TODO to implement the equivalent session bus permission10:06
zygamborzecki: but our tests are not measuring that yet10:06
mborzeckizyga: cool, let's see what will fail this time ;)10:10
* pstolowski lunch10:55
zygahexchat got stuck on ssl somehow11:15
* zyga lunch12:10
pedroniscmatsuoka: I answered your doubt, hopefully correctly, in mborzecki PR12:56
cmatsuokapedronis: thanks, I'll check there12:56
mupPR snapd#9201 closed: boot: observe update & rollback of trusted assets <UC20> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/9201>12:56
mborzeckipedronis: thanks, there was an implicit call to reseal the key after the first backup pass in BeforeWrite()12:56
cmatsuokapedronis: ah, that was what I thought too12:59
mborzeckizyga: https://github.com/snapcore/snapd/pull/9204#discussion_r48011540713:04
mupPR #9204: sandbox: track applications unconditionally <Created by zyga> <https://github.com/snapcore/snapd/pull/9204>13:04
zygamborzecki: in one or in both places?13:05
mborzeckizyga: just the closing ')13:05
mborzeckizyga: the opening one is (`13:06
zygaah, ok13:06
zygathanks13:06
jdstrandkenvandine: fyi, I've seen that firefox font thing several times since we last talked. unfortunately, I've had no time to debug :\13:43
jdstrandrestarting the browser does seem to correct it. that is pretty much the extent of debugging I can do atm13:45
mupPR snapd#9244 opened: boot: add unit test helpers <Simple 😃> <Skip spread> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9244>13:52
cachiopstolowski, hey, I see the preseed-lxd test failing today13:54
mborzeckicmatsuoka: ijohnson: ^^ trivial PR13:54
cachiopstolowski, did you see that as well?13:55
ijohnsonmborzecki: sure13:55
pstolowskicachio: no, do you have a link?13:55
cmatsuokamborzecki: checking...13:56
ijohnsonmborzecki: could you also look at https://github.com/snapcore/snapd/pull/9207 ? just needs another +113:56
mupPR #9207: boot/bootstate20: reboot to rollback to previous kernel <Bug> <Run nested> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9207>13:56
cachiopstolowski, https://github.com/snapcore/snapd/pull/9098/checks?check_run_id=1051196015#step:5:111513:56
mupPR #9098: tests: new organization for nested tests <Run nested> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9098>13:56
mborzeckiijohnson: sure13:56
ijohnsonthanks!13:56
pstolowskicachio: is this on your PR?13:59
cachioyes13:59
cachiopstolowski, I updated nested13:59
cachiobut also the images were updated13:59
cachioso I dont know what could hte the root cause14:00
cmatsuokamborzecki: added a question there about bootloader.Force(nil)14:00
pstolowskicachio: /home/gopath/src/github.com/snapcore/snapd/tests/lib/preseed.sh: line 66: /mnt/cloudimg/var/lib/snapd/seed/seed.yaml: No such file or directory14:00
cachiopstolowski, 6 hours ago the images in the bucked were updated14:01
pstolowskicachio: it seems this path in inject_snap_into_seed is no longer valid14:01
mborzeckicmatsuoka: the helper already adds a cleanup via .AddCleanup()14:01
cmatsuokamborzecki: ah ok14:01
cachiopstolowski, I'll try with master to discard the problem is in my pr14:01
ijohnsoncachio: pstolowski: how are the tests failing ?14:01
mborzeckicmatsuoka: see https://github.com/snapcore/snapd/pull/9244/files/accda18257efd4aedf6d32b3d5704709b02d50ca#diff-a69542b9519987a9ee6b8ef3f670f3cbR6414:02
mupPR #9244: boot: add unit test helpers <Simple 😃> <Skip spread> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9244>14:02
* ijohnson may have written inject_snap_into_seed IIRC14:02
cachioijohnson, https://github.com/snapcore/snapd/pull/9098/checks?check_run_id=1051196015#step:5:111514:02
mupPR #9098: tests: new organization for nested tests <Run nested> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9098>14:02
cachiothis is the log14:02
ijohnsoncachio: that link is 500 for me14:02
ijohnsonoh well I can just look at the PR14:02
cachio1 sec14:03
cachioijohnson, https://paste.ubuntu.com/p/gyQnPVgCNV/14:04
ijohnsoncachio: thanks looking now14:05
cachioijohnson, I am running on master just to see if the error is not caused by my PR14:07
ijohnsoncachio: that cloud image has no snaps seeded in it at all14:09
ijohnsonpstolowski: ^14:09
ijohnsonI just mounted it and this is what is in /var/lib/snapd/:14:10
ijohnsonhttps://pastebin.ubuntu.com/p/FPXJfThJ3X/14:10
pstolowski🤔14:10
ijohnsonseems to be a busted image to me if they dropped all snaps from the image14:10
mupPR snapd#9244 closed: boot: add unit test helpers <Simple 😃> <Skip spread> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/9244>14:12
pstolowskiijohnson: can you ask/check on preseed channel?14:13
ijohnsonpstolowski: sure14:13
pstolowskithanks14:14
ijohnsonpstolowski: cachio: actually before I ask, where does this image come from?14:14
ijohnsoncachio: I downloaded the same img as the spread test:14:14
ijohnsonhttps://storage.googleapis.com/spread-snapd-tests/images/cloudimg/bionic-server-cloudimg-amd64.img14:14
ijohnsoncachio: that looks like an image you maintain, is there maybe something wrong with your image there ?14:15
ijohnsonin the meantime, I am trying the generic image link from https://cloud-images.ubuntu.com/bionic/current/bionic-server-cloudimg-amd64.img14:16
cachioijohnson, 1 sec14:16
cachioijohnson, https://cloud-images.ubuntu.com/bionic/current/bionic-server-cloudimg-amd64.img14:17
cachiothis is the same Image14:17
ijohnsoncachio: that image from cloud-images.ubuntu.com also doesn't have snaps on it, so yeah I'll take it upstream14:17
ijohnsonthanks14:17
cachioI copy that to gce weekly14:17
cachioyaw14:18
mupPR snapd#9245 opened: o/snapstate, features: add feature flags for disk space awareness <Disk space awareness> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9245>14:22
ijohnsoncmatsuoka: have you see install fail with this before:14:25
ijohnson```14:25
ijohnsontaskrunner.go:271: [change 2 "Setup system for run mode" task] failed: cannot create partitions: cannot create the partitions: partition not available: device /dev/vda4 not available14:25
ijohnson```14:25
cmatsuokaijohnson: humm, no, never seen that14:26
cmatsuokaijohnson: is it a special scenario/device?14:26
ijohnsoncmatsuoka: no it's from nested tests on GCE, one sec I can provide full logs (well as full as we have)14:27
ijohnsoncachio: huh I think something may have gone wrong with your test / organization14:27
ijohnsoncachio: the command being run is14:27
ijohnson` IMGURL=$(get_google_image_url_for_nested_vm ubuntu-20.04-64)`14:27
ijohnsonbut the image it downloaded is a bionic image ?14:27
cachioijohnson, ran with master and passed14:28
cachioto the issue is in my PR14:28
cachioijohnson, thanks for the hint, I'll take a look14:29
ijohnsoncachio: yeah I think your PR has a problem resolveing `nested_get_image_url_for_vm ubuntu-20.04-64` to a bionic image14:29
ijohnsonit should be getting a focal image14:29
ijohnsoncmatsuoka: https://pastebin.ubuntu.com/p/VdqWrf5qGS/ is the full log we have from spread14:30
cmatsuokaijohnson: ok, checking...14:30
mborzeckiijohnson: restarted the spread job in 920714:32
ijohnsonmborzecki: ohhhh14:32
ijohnsonI was looking at the spread logs14:32
ijohnsonok seems I have the logs saved14:33
pstolowskiijohnson: thanks for figuring that out14:33
ijohnsonnp14:33
ijohnsoncachio: the issue with getting the wrong URL is that the function nested_get_image_url_for_vm takes an argument, but it isn't passing that argument through to the function nested_get_google_image_url_for_vm14:38
cachioijohnson, yes, I already fixed that14:40
cachionow testing14:40
ijohnsoncachio: ah ok, I just left a review on your PR for that14:40
cachioijohnson, thanks14:40
mborzeckierrands, bbl14:43
mupPR snapd#9246 opened: boot: handle canceled update <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9246>14:47
cmatsuokaijohnson: that's a very strange error, it seems that for some reason the device node is not there, even retriggering udev14:47
cmatsuokaijohnson: is it random or reproducible?14:48
ijohnsoncmatsuoka: I dunno I didn't try reproducing it yet14:49
ijohnsonI haven't ever seen it before though14:49
cachioijohnson, fix pushed14:58
* cachio lunch14:58
* zyga EODs and prepares for PT15:03
mupPR snapd#9207 closed: boot/bootstate20: reboot to rollback to previous kernel <Bug> <Run nested> <UC20> <Created by anonymouse64> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/9207>15:12
cmatsuokaijohnson: could you have a look at https://github.com/snapcore/snapd/pull/9138?15:13
mupPR #9138: many: refactor tpm seal parameter setting <UC20> <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/9138>15:13
cmatsuokaijohnson: it should make the seal transition to boot a lot easier15:14
ijohnsoncmatsuoka: yes I will look today15:16
cmatsuokathanks15:16
mupPR snapcraft#3269 opened: spread tests: remove references of core16 <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3269>16:27
cachioijohnson, about the comment related to SC212016:39
ijohnsonyes?16:39
cachioI just copied the same we had for the google function16:40
cachiobecause the unit test checks that and fails16:40
ijohnsoncachio: ok, if it fails leave it in16:40
cachioijohnson, ok, thanks16:40
ijohnsonI'm slightly surprised that we don't run shellcheck in such a way that shellcheck could see how the script is used, but oh well16:40
ijohnsons/script/function/16:41
ijohnsoncachio: I reviewed #9235, I'm not sure whether we should go this route or not yet16:43
mupPR #9235: tests: new tests for nested and external <Run nested> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9235>16:43
ijohnsoncachio: I would like to see some others comment on the approach, perhaps zyga could take a look when available16:43
cachioijohnson, thanks for the review16:43
cachiothis should go after 909816:43
ijohnsonyes16:43
cachioI'll tag it16:43
cachioijohnson, I'll try to implement something like you suggested in 923516:46
ijohnsoncachio: don't spend too much time on it, maybe others think this approach is ok, in which case I wouldn't want you to waste a bunch of time on implementing my suggestion16:46
cachioijohnson, we also could have tests duplicated :)16:47
ijohnsoncachio: true that's another option :-)16:47
cachiobecause there are just few we need to run in both worlds16:47
cachioI'll ask in the standup tomorrow16:47
ijohnsonyeah maybe16:48
mupPR snapd#9247 opened: secboot: use EFIImage type in load sequences <Simple 😃> <UC20> <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/9247>17:02
mupPR snapcraft#3270 opened: Add PYTHONPATH to environment (fixes #1893262) <Created by hellsworth> <https://github.com/snapcore/snapcraft/pull/3270>18:07
cmatsuokapedronis: it's easy to compose the boot chains using slice of BootImage defined in bootloader, however how do you envision the actual chain parameters being passed to the sealer?18:44
pedroniscmatsuoka: ?18:45
cmatsuokapedronis: do you have time for a quick chat?18:45
pedroniscmatsuoka: yes, in a couple minutes18:47
cmatsuokapedronis: thanks, I'll be in the su room18:47
mupPR snapd#9248 opened: exportstate: add scaffolding for the export manager <Created by zyga> <https://github.com/snapcore/snapd/pull/9248>19:03
zygapedronis: ^ some early code for the export manager, I would appreciate ack/nack on the data structures / names19:10
zygapedronis: but you should really get some rest, let's look at it tomorrow19:10
cachiozyga, hey, about zfs19:19
cachiowhich should be the idea of that image?19:20
cachioeveryhing zfs?19:20
zygacachio: the 20.04 image offers a new installer option to use zfs19:28
zygacachio: it should be representative of that image19:28
zygacachio: it's a complex setup, please try a desktop install to examine it19:28
cachiozyga, I see19:28
cachioI'll do that19:29
zygacachio: zfs uses lots of mount points for everything,19:29
cachioand see if it is possible to replicated that for gce19:29
zygacachio: it's not like ext4 but zfs19:29
zygacachio: try a desktop image locally in qemu or otherwise first19:29
zygacachio: to see how that looks like19:29
cachiozyga, ok, I'll start with that19:30
cachiotx19:30
zygacachio: no, thank you :)19:33
mupPR snapd#9247 closed: secboot: use EFIImage type in load sequences <Simple 😃> <UC20> <Created by cmatsuoka> <Closed by cmatsuoka> <https://github.com/snapcore/snapd/pull/9247>19:48
pedronisijohnson: cmatsuoka: I went ahead in the end and proposed this: https://github.com/snapcore/snapd/pull/924920:01
mupPR #9249: boot,bootloader,gadget: apply new bootloader.Options.Role <Run nested> <UC20> <Created by pedronis> <https://github.com/snapcore/snapd/pull/9249>20:01
ijohnsonpedronis: ack20:01
pedroniscmatsuoka: the Role type there might be useful for you as well20:01
cmatsuokapedronis: will check, thanks20:02
ijohnsonmmm I like this, Role seems much more intuitive20:02
mupPR snapd#9249 opened: boot,bootloader,gadget: apply new bootloader.Options.Role <Run nested> <UC20> <Created by pedronis> <https://github.com/snapcore/snapd/pull/9249>20:03
cachioijohnson, hi20:41
ijohnsonhey cachio20:41
cachiorunning in nested I see that if I stop the vm and the service sometimes the users that I created cant login anymore20:42
cachioso, first I create the instace, then I start it20:42
cachiothen I create the test and external users20:43
cachiothen I shutdown the vm and stop the service20:43
cachioI do that because I need to backup the vm for future tests20:43
ijohnsoncachio: how are you shutting down the VM ?20:43
cachio> shutdown now20:44
cachiorun shoutdown now20:44
cachiowhen I cannot connect through ssh20:44
cachioI stop the service20:44
ijohnsoncachio: before running that, on the host (not in the VM), you should run `sync`, I have seen before where if you do not sync state then file changes in the nested VM disappears20:44
cachioijohnson, ahhh, nice20:45
cachioso sync in the host20:45
ijohnsonit's probably a bug somewhere20:45
ijohnsonbut yeah on the host is what fixed it for me20:45
cachioijohnson, thanks, I'll try that20:45
ijohnsonthis happened reliably to me when I was working on the cloud-init nested tests20:45
cachioijohnson, I remember that you told it in the stand up20:46
ijohnsonyeah hopefully this works for you20:46
* cachio afk21:29
mupPR snapd#9250 opened: Uc20 bootloader boot image <UC20> <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/9250>22:43

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!