[05:09] <mborzecki> morning
[06:30] <mborzecki> ha, i'm not the one seeing osx failures
[06:44] <mborzecki> mvo: hey
[06:45] <mvo> good morning mborzecki
[06:50] <mup> PR snapd#9211 closed: o/snapstate: disk space check with InstallMany <Disk space awareness> <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9211>
[07:04] <mborzecki> pstolowski: heya
[07:05] <pstolowski> hi!
[07:05] <mvo> hey pstolowski ! good morning
[07:06] <pstolowski> hey mvo!
[07:22] <zyga> good morning
[07:30] <mup> PR snapd#9239 closed: many: misc doc-comment changes and typo fixes <Simple 😃> <Skip spread> <Created by anonymouse64> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/9239>
[07:41] <pstolowski> ehhh @systemd
[07:45] <pedronis> pstolowski: mvo: hi, do we need to have a chat about disk space checks?
[07:46] <zyga> pstolowski: problems?
[07:48] <mvo> pedronis, pstolowski maybe, I'm not super worried. was mostly thinking about something simple (like a system option) to disable the checks
[07:48] <pedronis> mvo: well, some checks have landed already
[08:10] <mup> PR snapd#9242 opened: github: run macOS job with Go 1.14 <Simple 😃> <Skip spread> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9242>
[08:16] <mborzecki> heh, it's green (the macos job at least)
[08:16] <mborzecki> zyga: can you take a look ^^^ ?
[08:17] <pedronis> zyga: can you look at https://bugs.launchpad.net/snapd/+bug/1892895 when you have a moment
[08:17] <mup> Bug #1892895: unable to allow an app to access all devices with a certain major number via a <majordev>:* device cgroup rule <snapd:New for zyga> <https://launchpad.net/bugs/1892895>
[08:30] <pedronis> mborzecki: mvo: are we working on this https://bugs.launchpad.net/snapd/+bug/1776622 ?
[08:30] <mup> Bug #1776622: snapd updates on focal never finish installing. Can't install any other updates. <amd64> <apport-bug> <champagne> <focal> <regression> <snapd:Confirmed for mvo> <snapd (Ubuntu):Confirmed for mvo> <systemd (Ubuntu):Invalid> <https://launchpad.net/bugs/1776622>
[08:30] <pstolowski> pedronis: systemctl status check (what we discussed last friday wrt --root semantics difference when unit is missing) is going to be messy or maybe we need to do something else, the bahvior of systemctl status is different in 14.04. i wonder if we shouldn't land https://github.com/snapcore/snapd/pull/9241/ to unblock services PR (and in the meantime i'll work on a solution)
[08:30] <mup> PR #9241: tests: do not set rsyslog.disable in core18 config defaults test <Test Robustness> <⛔ Blocked> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9241>
[08:33] <pedronis> pstolowski: it's a real issue, no? is not just the tests
[08:46] <zyga> re
[08:46] <zyga> mborzecki, pedronis: ack
[08:46] <zyga> (my laptop suspended during my 1:1)
[08:46] <zyga> that udev permission issue is very interesting
[08:46] <zyga> it kind of forces us to re-think the entire cgroup access logic
[08:46] <zyga> but, there is some hope that cgroupv2 mode may allow us to do this race free
[08:46] <zyga> mborzecki: reviewed
[08:46] <zyga> pedronis: we should talk about that during the standup a little
[08:46] <zyga> pedronis: I'll think about this and write down some ideas
[08:46] <pstolowski> pedronis: it's an issue if the config flag is set (e.g. via defaults) but the service file doesn't exist
[08:46] <pstolowski> i suppose it would be an issue if flag was set and then the service was uninstalled
[08:46] <mup> PR snapd#9242 closed: github: run macOS job with Go 1.14 <Simple 😃> <Skip spread> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/9242>
[09:00] <mup> PR snapd#9202 closed: tests/nested/core20/tpm: verify trusted boot assets tracking  <Run nested> <UC20> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/9202>
[09:02] <mborzecki> the nested suite seems to be doing strage stuff and the state from one test seems to leak to the next one
[09:02] <mborzecki> see https://github.com/snapcore/snapd/runs/1050105329
[09:03] <mborzecki> https://github.com/snapcore/snapd/runs/1050105322 this one
[09:07] <zyga> hmm, let's tell sergio about it
[09:07] <zyga> hopefully the nested fixes he was doing will help
[09:10] <mvo> hm, I see some failures in macos-sanity in or 9238
[09:10] <mvo> did we acciently break that?
[09:10] <mvo> I also noticed it was not a required check :( I fixed that now
[09:11] <mborzecki> mvo: it's fixed already, merge master please
[09:11] <mvo> mborzecki: ta
[09:15] <mup> PR snapd#9238 closed: many: check that users of BaseTest don't forget to consume cleanups <Created by pedronis> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9238>
[09:25] <mvo> pedronis: I replied in 1776622
[09:25] <mvo> pedronis: (just fyi)
[09:41] <zyga> pedronis: small question on now-merged https://github.com/snapcore/snapd/pull/9238/files#r480014070
[09:41] <mup> PR #9238: many: check that users of BaseTest don't forget to consume cleanups <Created by pedronis> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9238>
[09:49] <mborzecki> zyga: the new set of denials in https://github.com/snapcore/snapd/pull/9204 looks sane
[09:49] <mup> PR #9204: sandbox: track applications unconditionally <Created by zyga> <https://github.com/snapcore/snapd/pull/9204>
[09:51] <mup> PR snapd#9240 closed: o/devicestate/devicestate_cloudinit_test.go: test cleanup for uc20 cloud-init tests <Simple 😃> <Skip spread> <Test Robustness> <UC20> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9240>
[09:55] <mborzecki> zyga: left a note with a snippet that you can try adding to the policy https://github.com/snapcore/snapd/pull/9204#issuecomment-683683132
[09:55] <mup> PR #9204: sandbox: track applications unconditionally <Created by zyga> <https://github.com/snapcore/snapd/pull/9204>
[09:56] <mup> PR snapd#9224 closed: interfaces/utf: Add MIRKey to u2f devices <Needs security review> <Created by kobusgrobler> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9224>
[09:56] <zyga> mborzecki: thank you, I'll do that
[10:06] <mup> PR snapd#9243 opened: testutil: add checkers for symbolic link target <Created by zyga> <https://github.com/snapcore/snapd/pull/9243>
[10:06] <zyga> mborzecki: updated, I also left a TODO to implement the equivalent session bus permission
[10:06] <zyga> mborzecki: but our tests are not measuring that yet
[10:10] <mborzecki> zyga: cool, let's see what will fail this time ;)
[10:55]  * pstolowski lunch
[11:15] <zyga> hexchat got stuck on ssl somehow
[12:10]  * zyga lunch
[12:56] <pedronis> cmatsuoka: I answered your doubt, hopefully correctly, in mborzecki PR
[12:56] <cmatsuoka> pedronis: thanks, I'll check there
[12:56] <mup> PR snapd#9201 closed: boot: observe update & rollback of trusted assets <UC20> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/9201>
[12:56] <mborzecki> pedronis: thanks, there was an implicit call to reseal the key after the first backup pass in BeforeWrite()
[12:59] <cmatsuoka> pedronis: ah, that was what I thought too
[13:04] <mborzecki> zyga: https://github.com/snapcore/snapd/pull/9204#discussion_r480115407
[13:04] <mup> PR #9204: sandbox: track applications unconditionally <Created by zyga> <https://github.com/snapcore/snapd/pull/9204>
[13:05] <zyga> mborzecki: in one or in both places?
[13:05] <mborzecki> zyga: just the closing ')
[13:06] <mborzecki> zyga: the opening one is (`
[13:06] <zyga> ah, ok
[13:06] <zyga> thanks
[13:43] <jdstrand> kenvandine: fyi, I've seen that firefox font thing several times since we last talked. unfortunately, I've had no time to debug :\
[13:45] <jdstrand> restarting the browser does seem to correct it. that is pretty much the extent of debugging I can do atm
[13:52] <mup> PR snapd#9244 opened: boot: add unit test helpers <Simple 😃> <Skip spread> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9244>
[13:54] <cachio> pstolowski, hey, I see the preseed-lxd test failing today
[13:54] <mborzecki> cmatsuoka: ijohnson: ^^ trivial PR
[13:55] <cachio> pstolowski, did you see that as well?
[13:55] <ijohnson> mborzecki: sure
[13:55] <pstolowski> cachio: no, do you have a link?
[13:56] <cmatsuoka> mborzecki: checking...
[13:56] <ijohnson> mborzecki: could you also look at https://github.com/snapcore/snapd/pull/9207 ? just needs another +1
[13:56] <mup> PR #9207: boot/bootstate20: reboot to rollback to previous kernel <Bug> <Run nested> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9207>
[13:56] <cachio> pstolowski, https://github.com/snapcore/snapd/pull/9098/checks?check_run_id=1051196015#step:5:1115
[13:56] <mup> PR #9098: tests: new organization for nested tests <Run nested> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9098>
[13:56] <mborzecki> ijohnson: sure
[13:56] <ijohnson> thanks!
[13:59] <pstolowski> cachio: is this on your PR?
[13:59] <cachio> yes
[13:59] <cachio> pstolowski, I updated nested
[13:59] <cachio> but also the images were updated
[14:00] <cachio> so I dont know what could hte the root cause
[14:00] <cmatsuoka> mborzecki: added a question there about bootloader.Force(nil)
[14:00] <pstolowski> cachio: /home/gopath/src/github.com/snapcore/snapd/tests/lib/preseed.sh: line 66: /mnt/cloudimg/var/lib/snapd/seed/seed.yaml: No such file or directory
[14:01] <cachio> pstolowski, 6 hours ago the images in the bucked were updated
[14:01] <pstolowski> cachio: it seems this path in inject_snap_into_seed is no longer valid
[14:01] <mborzecki> cmatsuoka: the helper already adds a cleanup via .AddCleanup()
[14:01] <cmatsuoka> mborzecki: ah ok
[14:01] <cachio> pstolowski, I'll try with master to discard the problem is in my pr
[14:01] <ijohnson> cachio: pstolowski: how are the tests failing ?
[14:02] <mborzecki> cmatsuoka: see https://github.com/snapcore/snapd/pull/9244/files/accda18257efd4aedf6d32b3d5704709b02d50ca#diff-a69542b9519987a9ee6b8ef3f670f3cbR64
[14:02] <mup> PR #9244: boot: add unit test helpers <Simple 😃> <Skip spread> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9244>
[14:02]  * ijohnson may have written inject_snap_into_seed IIRC
[14:02] <cachio> ijohnson, https://github.com/snapcore/snapd/pull/9098/checks?check_run_id=1051196015#step:5:1115
[14:02] <mup> PR #9098: tests: new organization for nested tests <Run nested> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9098>
[14:02] <cachio> this is the log
[14:02] <ijohnson> cachio: that link is 500 for me
[14:02] <ijohnson> oh well I can just look at the PR
[14:03] <cachio> 1 sec
[14:04] <cachio> ijohnson, https://paste.ubuntu.com/p/gyQnPVgCNV/
[14:05] <ijohnson> cachio: thanks looking now
[14:07] <cachio> ijohnson, I am running on master just to see if the error is not caused by my PR
[14:09] <ijohnson> cachio: that cloud image has no snaps seeded in it at all
[14:09] <ijohnson> pstolowski: ^
[14:10] <ijohnson> I just mounted it and this is what is in /var/lib/snapd/:
[14:10] <ijohnson> https://pastebin.ubuntu.com/p/FPXJfThJ3X/
[14:10] <pstolowski> 🤔
[14:10] <ijohnson> seems to be a busted image to me if they dropped all snaps from the image
[14:12] <mup> PR snapd#9244 closed: boot: add unit test helpers <Simple 😃> <Skip spread> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/9244>
[14:13] <pstolowski> ijohnson: can you ask/check on preseed channel?
[14:13] <ijohnson> pstolowski: sure
[14:14] <pstolowski> thanks
[14:14] <ijohnson> pstolowski: cachio: actually before I ask, where does this image come from?
[14:14] <ijohnson> cachio: I downloaded the same img as the spread test:
[14:14] <ijohnson> https://storage.googleapis.com/spread-snapd-tests/images/cloudimg/bionic-server-cloudimg-amd64.img
[14:15] <ijohnson> cachio: that looks like an image you maintain, is there maybe something wrong with your image there ?
[14:16] <ijohnson> in the meantime, I am trying the generic image link from https://cloud-images.ubuntu.com/bionic/current/bionic-server-cloudimg-amd64.img
[14:16] <cachio> ijohnson, 1 sec
[14:17] <cachio> ijohnson, https://cloud-images.ubuntu.com/bionic/current/bionic-server-cloudimg-amd64.img
[14:17] <cachio> this is the same Image
[14:17] <ijohnson> cachio: that image from cloud-images.ubuntu.com also doesn't have snaps on it, so yeah I'll take it upstream
[14:17] <ijohnson> thanks
[14:17] <cachio> I copy that to gce weekly
[14:18] <cachio> yaw
[14:22] <mup> PR snapd#9245 opened: o/snapstate, features: add feature flags for disk space awareness <Disk space awareness> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9245>
[14:25] <ijohnson> cmatsuoka: have you see install fail with this before:
[14:25] <ijohnson> ```
[14:25] <ijohnson> taskrunner.go:271: [change 2 "Setup system for run mode" task] failed: cannot create partitions: cannot create the partitions: partition not available: device /dev/vda4 not available
[14:25] <ijohnson> ```
[14:26] <cmatsuoka> ijohnson: humm, no, never seen that
[14:26] <cmatsuoka> ijohnson: is it a special scenario/device?
[14:27] <ijohnson> cmatsuoka: no it's from nested tests on GCE, one sec I can provide full logs (well as full as we have)
[14:27] <ijohnson> cachio: huh I think something may have gone wrong with your test / organization
[14:27] <ijohnson> cachio: the command being run is
[14:27] <ijohnson> ` IMGURL=$(get_google_image_url_for_nested_vm ubuntu-20.04-64)`
[14:27] <ijohnson> but the image it downloaded is a bionic image ?
[14:28] <cachio> ijohnson, ran with master and passed
[14:28] <cachio> to the issue is in my PR
[14:29] <cachio> ijohnson, thanks for the hint, I'll take a look
[14:29] <ijohnson> cachio: yeah I think your PR has a problem resolveing `nested_get_image_url_for_vm ubuntu-20.04-64` to a bionic image
[14:29] <ijohnson> it should be getting a focal image
[14:30] <ijohnson> cmatsuoka: https://pastebin.ubuntu.com/p/VdqWrf5qGS/ is the full log we have from spread
[14:30] <cmatsuoka> ijohnson: ok, checking...
[14:32] <mborzecki> ijohnson: restarted the spread job in 9207
[14:32] <ijohnson> mborzecki: ohhhh
[14:32] <ijohnson> I was looking at the spread logs
[14:33] <ijohnson> ok seems I have the logs saved
[14:33] <pstolowski> ijohnson: thanks for figuring that out
[14:33] <ijohnson> np
[14:38] <ijohnson> cachio: the issue with getting the wrong URL is that the function nested_get_image_url_for_vm takes an argument, but it isn't passing that argument through to the function nested_get_google_image_url_for_vm
[14:40] <cachio> ijohnson, yes, I already fixed that
[14:40] <cachio> now testing
[14:40] <ijohnson> cachio: ah ok, I just left a review on your PR for that
[14:40] <cachio> ijohnson, thanks
[14:43] <mborzecki> errands, bbl
[14:47] <mup> PR snapd#9246 opened: boot: handle canceled update <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9246>
[14:47] <cmatsuoka> ijohnson: that's a very strange error, it seems that for some reason the device node is not there, even retriggering udev
[14:48] <cmatsuoka> ijohnson: is it random or reproducible?
[14:49] <ijohnson> cmatsuoka: I dunno I didn't try reproducing it yet
[14:49] <ijohnson> I haven't ever seen it before though
[14:58] <cachio> ijohnson, fix pushed
[14:58]  * cachio lunch
[15:03]  * zyga EODs and prepares for PT
[15:12] <mup> PR snapd#9207 closed: boot/bootstate20: reboot to rollback to previous kernel <Bug> <Run nested> <UC20> <Created by anonymouse64> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/9207>
[15:13] <cmatsuoka> ijohnson: could you have a look at https://github.com/snapcore/snapd/pull/9138?
[15:13] <mup> PR #9138: many: refactor tpm seal parameter setting <UC20> <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/9138>
[15:14] <cmatsuoka> ijohnson: it should make the seal transition to boot a lot easier
[15:16] <ijohnson> cmatsuoka: yes I will look today
[15:16] <cmatsuoka> thanks
[16:27] <mup> PR snapcraft#3269 opened: spread tests: remove references of core16 <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3269>
[16:39] <cachio> ijohnson, about the comment related to SC2120
[16:39] <ijohnson> yes?
[16:40] <cachio> I just copied the same we had for the google function
[16:40] <cachio> because the unit test checks that and fails
[16:40] <ijohnson> cachio: ok, if it fails leave it in
[16:40] <cachio> ijohnson, ok, thanks
[16:40] <ijohnson> I'm slightly surprised that we don't run shellcheck in such a way that shellcheck could see how the script is used, but oh well
[16:41] <ijohnson> s/script/function/
[16:43] <ijohnson> cachio: I reviewed #9235, I'm not sure whether we should go this route or not yet
[16:43] <mup> PR #9235: tests: new tests for nested and external <Run nested> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9235>
[16:43] <ijohnson> cachio: I would like to see some others comment on the approach, perhaps zyga could take a look when available
[16:43] <cachio> ijohnson, thanks for the review
[16:43] <cachio> this should go after 9098
[16:43] <ijohnson> yes
[16:43] <cachio> I'll tag it
[16:46] <cachio> ijohnson, I'll try to implement something like you suggested in 9235
[16:46] <ijohnson> cachio: don't spend too much time on it, maybe others think this approach is ok, in which case I wouldn't want you to waste a bunch of time on implementing my suggestion
[16:47] <cachio> ijohnson, we also could have tests duplicated :)
[16:47] <ijohnson> cachio: true that's another option :-)
[16:47] <cachio> because there are just few we need to run in both worlds
[16:47] <cachio> I'll ask in the standup tomorrow
[16:48] <ijohnson> yeah maybe
[17:02] <mup> PR snapd#9247 opened: secboot: use EFIImage type in load sequences <Simple 😃> <UC20> <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/9247>
[18:07] <mup> PR snapcraft#3270 opened: Add PYTHONPATH to environment (fixes #1893262) <Created by hellsworth> <https://github.com/snapcore/snapcraft/pull/3270>
[18:44] <cmatsuoka> pedronis: it's easy to compose the boot chains using slice of BootImage defined in bootloader, however how do you envision the actual chain parameters being passed to the sealer?
[18:45] <pedronis> cmatsuoka: ?
[18:45] <cmatsuoka> pedronis: do you have time for a quick chat?
[18:47] <pedronis> cmatsuoka: yes, in a couple minutes
[18:47] <cmatsuoka> pedronis: thanks, I'll be in the su room
[19:03] <mup> PR snapd#9248 opened: exportstate: add scaffolding for the export manager <Created by zyga> <https://github.com/snapcore/snapd/pull/9248>
[19:10] <zyga> pedronis: ^ some early code for the export manager, I would appreciate ack/nack on the data structures / names
[19:10] <zyga> pedronis: but you should really get some rest, let's look at it tomorrow
[19:19] <cachio> zyga, hey, about zfs
[19:20] <cachio> which should be the idea of that image?
[19:20] <cachio> everyhing zfs?
[19:28] <zyga> cachio: the 20.04 image offers a new installer option to use zfs
[19:28] <zyga> cachio: it should be representative of that image
[19:28] <zyga> cachio: it's a complex setup, please try a desktop install to examine it
[19:28] <cachio> zyga, I see
[19:29] <cachio> I'll do that
[19:29] <zyga> cachio: zfs uses lots of mount points for everything,
[19:29] <cachio> and see if it is possible to replicated that for gce
[19:29] <zyga> cachio: it's not like ext4 but zfs
[19:29] <zyga> cachio: try a desktop image locally in qemu or otherwise first
[19:29] <zyga> cachio: to see how that looks like
[19:30] <cachio> zyga, ok, I'll start with that
[19:30] <cachio> tx
[19:33] <zyga> cachio: no, thank you :)
[19:48] <mup> PR snapd#9247 closed: secboot: use EFIImage type in load sequences <Simple 😃> <UC20> <Created by cmatsuoka> <Closed by cmatsuoka> <https://github.com/snapcore/snapd/pull/9247>
[20:01] <pedronis> ijohnson: cmatsuoka: I went ahead in the end and proposed this: https://github.com/snapcore/snapd/pull/9249
[20:01] <mup> PR #9249: boot,bootloader,gadget: apply new bootloader.Options.Role <Run nested> <UC20> <Created by pedronis> <https://github.com/snapcore/snapd/pull/9249>
[20:01] <ijohnson> pedronis: ack
[20:01] <pedronis> cmatsuoka: the Role type there might be useful for you as well
[20:02] <cmatsuoka> pedronis: will check, thanks
[20:02] <ijohnson> mmm I like this, Role seems much more intuitive
[20:03] <mup> PR snapd#9249 opened: boot,bootloader,gadget: apply new bootloader.Options.Role <Run nested> <UC20> <Created by pedronis> <https://github.com/snapcore/snapd/pull/9249>
[20:41] <cachio> ijohnson, hi
[20:41] <ijohnson> hey cachio
[20:42] <cachio> running in nested I see that if I stop the vm and the service sometimes the users that I created cant login anymore
[20:42] <cachio> so, first I create the instace, then I start it
[20:43] <cachio> then I create the test and external users
[20:43] <cachio> then I shutdown the vm and stop the service
[20:43] <cachio> I do that because I need to backup the vm for future tests
[20:43] <ijohnson> cachio: how are you shutting down the VM ?
[20:44] <cachio> > shutdown now
[20:44] <cachio> run shoutdown now
[20:44] <cachio> when I cannot connect through ssh
[20:44] <cachio> I stop the service
[20:44] <ijohnson> cachio: before running that, on the host (not in the VM), you should run `sync`, I have seen before where if you do not sync state then file changes in the nested VM disappears
[20:45] <cachio> ijohnson, ahhh, nice
[20:45] <cachio> so sync in the host
[20:45] <ijohnson> it's probably a bug somewhere
[20:45] <ijohnson> but yeah on the host is what fixed it for me
[20:45] <cachio> ijohnson, thanks, I'll try that
[20:45] <ijohnson> this happened reliably to me when I was working on the cloud-init nested tests
[20:46] <cachio> ijohnson, I remember that you told it in the stand up
[20:46] <ijohnson> yeah hopefully this works for you
[21:29]  * cachio afk
[22:43] <mup> PR snapd#9250 opened: Uc20 bootloader boot image <UC20> <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/9250>