mupPR snapd#9257 opened: bootloader: retrieve boot chains from bootloader <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/9257>00:39
zygagood morning05:03
mborzeckistarting a bit later, need to drive kids to school05:25
zygamborzecki: ok05:28
zygabrb again, time to fetch charger06:08
zygaI have the 12v power ;)06:14
* zyga is struggling a little with the export provider algorithm, it probably indicates I need a different data model06:15
mvogood morning zyga06:22
zygahello :)06:22
zygamvo: first day of morning shift, I'm trying to re-think the data model for exports06:22
zygamvo: good luck with your meetings06:22
zygamvo: ian's feedback last night was very useful, may simplify zfs support06:23
mvozyga - oh, nice! in what PR was that feedback provided?06:24
mvozyga or was it here on irc?06:24
zygamvo: the one about exchange06:24
zygamvo: ian's comments made me think that all I may need, after all, is the plain old rename06:25
mvozyga oh, ok06:26
mvozyga: getting away with this would be great, less-code++06:27
mborzeckimvo: zyga: morning guys06:34
mvogood morning mborzecki06:35
mborzeckiwow, the weather turned to shit pretty quickly this year06:35
zygamborzecki: how was first day of school?06:35
zygamborzecki: it's 202006:35
mborzeckizyga: 13C, raining all of yesterday and during the night06:35
mborzeckizyga: ofc, also a short power outage yday, and my primary internet link is down ;P06:35
zygamborzecki: nothing like 1st of September to remind everyone that holidays are over06:36
* zyga cannot get used to the fact that some places start school mid-August 06:36
mborzeckiyeah, bringing everyone up to speed with the harsh reality ;)06:36
zygamborzecki: I have a question, a comment from ian relating to RENAME_EXCHANGE indicated you did some research about atomic properties of that operation06:37
zygamborzecki: do you recall any problems with that?06:37
zygait was in relation to AtomicSylink helpers06:37
mborzeckizyga: let me take a look at the notes06:38
zygamborzecki: it's not a biggie if you don't find anything06:39
zygajust reading that comment made me wonder if you found something about rename+exchange that is still racy06:39
mborzeckizyga: hm not much in my notes, aside from #8045 and 8044/804306:42
mupPR #8045: osutil: add helpers for creating symlinks and renaming in an atomic manner <Created by bboozzoo> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/8045>06:42
* zyga was tired, re-reading Ian's comment now makes a lot more sense06:44
zygamborzecki: thanks!06:44
zygagood morning pawel07:03
mborzeckipstolowski: hey07:03
mvogood morning ps07:05
mvogood morning pstolowski07:05
mborzeckipedronis: hi, thanks for the cleanup in #924907:18
mupPR #9249: boot,bootloader,gadget: apply new bootloader.Options.Role <Run nested> <UC20> <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/9249>07:18
pedronismborzecki: thx07:22
zygaLucy just woke up07:22
mupPR snapd#9255 closed: o/snapstate, features: add feature flag for disk space check on remove (2.46) <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9255>07:36
* zyga-kaveri starts the day09:03
zyga-kaverimvo: there's some progress on building understanding of the apparmor notification protocol09:14
zyga-kaverimvo: I will try to spend Fridays on that, there's a good chunk of code I can now write09:14
zyga-kaverimvo: so the meetings work :)09:14
mvozyga-kaveri: cool09:14
zyga-kaverimvo: in a way the kernel is really full of murky #defines and bitfield and modes and masks and stuff09:15
zyga-kaveriwriting a good, high-level abstraction for this is only possible with hands-on access to insight not present in the .h files09:15
* mvo nods09:18
mborzeckipedronis: i've updated #924609:24
mupPR #9246: boot: handle canceled update <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9246>09:24
pedronismborzecki: thx, I put it back on my queue09:24
mborzeckipedronis: thanks!09:24
mborzeckiquick errand, back in 3009:35
mupPR snapd#9258 opened: devicestate: add tests around logging in RequestSystemAction <Created by mvo5> <https://github.com/snapcore/snapd/pull/9258>09:41
=== mborzeck1 is now known as mborzecki
mupPR snapd#9259 opened: client, api: handle insufficient space error <Disk space awareness> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9259>10:31
pstolowskihah, nice touch from github: typing # in the text fields not only auto-completes PR numbers, it actually understands strings and finds PRs by titles. i wish I knew that earlier ;)10:32
mborzeckipstolowski: is that a new thing?10:36
pstolowskimborzecki: i have not idea, just discovered by accident10:37
mborzeckianyways nice, i would often launch a new tab, look for the PR and then use the number10:37
pstolowskii always assumed numbers10:37
pstolowskiyeah, that's what i was always doing10:37
mvopedronis: given that 9250 is green and there is a followup planned anyway, do you mind if I merge it (even without the doc updates?)10:40
* pstolowski lunch10:41
zyga-kaveripstolowski: neat :)10:43
zyga-kaveripstolowski: maybe it does more, #fixthisbugplease10:44
pedronismvo: it's fine, let's just not forget10:49
mupPR snapd#9250 closed: many: use BootFile type in load sequences <UC20> <Created by cmatsuoka> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9250>11:01
pedronismvo: we should try to land https://github.com/snapcore/snapd/pull/8920 no? it might need a master merge, and a re-run11:05
mupPR #8920: interfaces: update cups-control and add cups for providing snaps <Needs Samuele review> <Squash-merge> <Created by jdstrand> <https://github.com/snapcore/snapd/pull/8920>11:05
mupPR snapd#9260 opened: seed/seedwriter: test local asserted snaps with UC20 grade signed <UC20> <Created by pedronis> <https://github.com/snapcore/snapd/pull/9260>11:06
mupPR snapd#9261 opened: bootloader: tweak doc comments (thanks Samuele) <Created by mvo5> <https://github.com/snapcore/snapd/pull/9261>11:06
* zyga-kaveri afk for 1511:10
pedronispstolowski: what's the status of #8960?  should I stil wait to review it? do we need to discuss about it?11:24
mupPR #8960: o/snapstate,servicestate: use service-control task for service actions (9/9) <Needs Samuele review> <Services ⚙️> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8960>11:24
pstolowskipedronis: i've a tentative fix and need to update unit tests for it, not pushed yet11:29
pstolowskipedronis: but it's not the workaround we discussed earlier this week11:30
pedronismvo: I re-reviewed, tbh not a fan of the new logging code refactor11:54
mupPR #9210: daemon: add /v2/systems "reboot" action API <Created by mvo5> <https://github.com/snapcore/snapd/pull/9210>11:54
mvopedronis: that's fine, happy to redo it, the important part is that we have tests now so it's easier12:00
pedronismvo: maybe it's quicker if I push a re-refactor?12:08
mvopedronis: please do, in a meeting12:11
* zyga-kaveri takes a lunch break and looks at apparmor sources12:25
pedronismvo: pushed12:53
mvopedronis: thank you!12:53
pedronishopefully is not worse12:54
mupPR #9210: daemon: add /v2/systems "reboot" action API <Created by mvo5> <https://github.com/snapcore/snapd/pull/9210>12:55
mupPR snapd#9262 opened: configcore: rework how console-conf is disabled <Created by mvo5> <https://github.com/snapcore/snapd/pull/9262>13:47
mupPR snapd#9263 opened: interfaces/fpga: add fpga interface <Created by alfonsosanchezbeato> <https://github.com/snapcore/snapd/pull/9263>14:52
* cachio lunch15:35
ijohnsoncachio: let me know when you're back15:45
mupPR snapd#9254 closed: sysconfig/cloudinit.go: add DisableNoCloud to CloudInitRestrictOptions <Simple 😃> <UC20> <Created by anonymouse64> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/9254>15:47
mupPR snapd#9264 opened: [RFC] many: introduce ContentChange for tracking gadget content in observers <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9264>15:53
pedroniscmatsuoka: I did a pass on #925716:00
mupPR #9257: bootloader: retrieve boot chains from bootloader <UC20> <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/9257>16:00
cachioijohnson, hey16:01
cachioI am here16:01
cmatsuokapedronis: thanks, I was in the process of making the mock trusted bootloader functions consistent with the mocked trusted assets16:02
cachioijohnson, I see I can't boot anymore uc20 on nested16:03
ijohnsoncachio: hey I need to write a manual nested with my own model assertion when building the image, do you think I should modify the function to get the model assertion to use a global var that I define in the test? Does that make sense?16:04
ijohnsoncachio: re uc20 not booting in nested, what's wrong? can you provide logs? is this on your PR or on master ?16:04
cachioijohnson, about the mode, yes16:04
cachioa var for the model sounds good16:05
ijohnsoncachio: ack I will add that then16:05
cachioijohnson, https://paste.ubuntu.com/p/rstDJgrkqq/16:06
cachioijohnson, could be related to reseal?16:06
ijohnsoncachio: mmm I don't think enough of that has landed to be related to resealing16:07
ijohnsoncachio: was this from master or from your branch ?16:07
cachioit is my branch16:08
cachioI merged with master16:08
cachionot sure if it is the root cause16:08
ijohnsoncachio: I'll have a look in a bit16:13
cachioI thnik it is something in edge channel because the iamges created from beta work well16:15
ijohnsoncachio: I've got google-nested:ubuntu-20.04-64:tests/nested/core20 running from master now, let's see what happens16:18
cachioijohnson, nice, manual also fails for some tests16:19
ijohnsoncachio: which tests ? is it reproducible ?16:19
ijohnsoncachio: yes I've seen that one fail intermittently on PR's16:20
cachioijohnson, I am still waiting for more results16:20
cachiobut fails to prepare, basically can't login16:20
cachioin the logs I don't see any reboot16:21
cachioijohnson, the weird part is that I ran with kvm and there are not any reboot16:23
ijohnsoncmatsuoka: have you ever seen this failure on gce before?16:33
ijohnson2020-08-26T17:52:35.2828113Z Aug 26 17:46:06 ubuntu snapd[1116]: secboot_tpm.go:416: TPM provisioning error: cannot access resource at handle TPM_RH_LOCKOUT because an authorization check failed16:33
ijohnson2020-08-26T17:52:35.2828332Z Aug 26 17:46:06 ubuntu snapd[1116]: taskrunner.go:271: [change 2 "Setup system for run mode" task] failed: cannot create partitions: cannot seal the encryption key: cannot provision TPM: cannot access resource at handle TPM_RH_LOCKOUT because an authorization check failed16:33
ijohnsonseems like the TPM wasn't properly reset before it was used to boot this image?16:33
ijohnsoncachio: yeah very odd, my run is almost done preparing the image, just waiting for it to either finish successfully or get stuck16:34
cmatsuokaijohnson: yes, it happened to cachio a couple of times. according to chris this shouldn't happen, unless the TPM was not properly cleared16:34
cmatsuoka(or the simulator is faulty)16:34
ijohnsonmmm yeah this is with the swtpm-mvo snap16:34
cmatsuokaijohnson: do you see any possibility of the TPM not being cleared before this test?16:36
pedronisijohnson: I tried to answer your considerations in #925316:43
mupPR #9253: sysconfig/cloudinit.go: add AllowCloudInit and use GadgetDir for cloud.conf <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9253>16:43
ijohnsonmmm seems my internet is out :-/16:43
ijohnsoncmatsuoka: actually yes I see how it could happen, we don't ever reset the TPM from swtpm-mvo, if it's already installed, we should reset it if it's already installed when we boot a VM16:44
ijohnsonI can send a pr when my internet is back16:44
cmatsuokaijohnson: ah, mystery solved then. I thought the nv data file was deleted before each test16:45
ijohnsonpedronis ack thanks for clarifying, I will leave the function as-is, copying gadget config if it is found16:45
ijohnsonErr rather I'll refactor to first check if AllowCloudInit, then if it's allowed then copy the gadget config16:46
ijohnsonyay internet is back16:49
pedronisijohnson: I think the points are mostly order, rename and comments16:51
cachioijohnson, cmatsuoka at some point we were reseting this16:52
cachioI added that when we originally had that problem and claudio told me to add that16:52
ijohnsonWell apparently my internet is not back16:52
cachiodon't know if it is gone with a refactor16:52
* ijohnson is back to the phone 16:52
ijohnsonpedronis ack yes I will push up an update later today16:53
ijohnsoncachio I don't see it anywhere, where were we doing this?16:53
ijohnsoncachio all I see on master is that `if ! snap list swtpm-mvo ...`16:53
cachioijohnson, it is not there anymore16:54
cachioI think during a refactor we remove that16:54
cachioI'll take a look to the logs16:54
cachioI can add that to my PR as well16:54
cachioso perhaps that is affecting also16:55
ijohnsoncachio: please don't add it to your pr16:55
ijohnsoncachio: I really want to land that pr without further iteration16:55
ijohnsoncachio: that pr is really big, I am almost done with another review for you16:55
cachioijohnson, sure16:55
cachioijohnson, ah, nice, thanks16:55
cachioit started small16:56
ijohnsonyes it started small, but is no longer small :-)16:56
ijohnsoncachio: well re the failing uc20 nested tests, I lost my internet connection so I don't know if the test failed or not, I will try again now hopefully my internet doesn't cut out again16:59
cachioijohnson, np17:03
cachiothe test in this pr could be failing because the tpm or the kernel repack thing17:04
cachiowhich are already being fixed in other prs17:04
cachioijohnson, here we have a lot of problems with the internet too, all the children having zoom meetings for school17:05
ijohnsonpedronis: is it expected that `snap ack` on a system-user assertion doesn't "just work" and that the system-user assertion needs to be imported by a usb drive for example?17:05
cachioand so many people working from home in this area as well17:05
ijohnsoncachio: yeah that's what I expect for our neighborhood too, it's all virtual learning here too pretty much17:05
ijohnsonpedronis: `snap ack system-user.assert` returns 0, but no user is created17:06
ijohnsonpedronis: ah I see from the docs on system-user assertions:17:07
ijohnson> The simple addition of such assertions to a device assertion database should not be enough to trigger the user creation17:07
ijohnsonso nvm me, it is not enough to just `snap ack`17:07
cmatsuokapedronis: addressed the issues but not sure if the grub NoSlashBoot fix is what you had in mind17:14
pedronisijohnson: that's by design, auto import from usb does a step more, but ack alone is not alone17:18
pedronis*is not enough17:18
ijohnsonYes I see that now17:19
pedroniscmatsuoka: it's fine, but probably better not to use TrustedAssets in boot chain now we the vars17:22
cmatsuokapedronis: thanks, will update accordingly17:22
* cmatsuoka breaks for lunch17:31
pedronisijohnson: could you look at #9246 ?17:40
mupPR #9246: boot: handle canceled update <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9246>17:40
ijohnsonpedronis: sure I can look this afternoon17:40
ijohnsoncachio: both of the tests/nested/core20 from master failed for me17:53
ijohnsoncachio: I think what happened is that cloud-init took too long to run and got disabled by snapd17:53
ijohnsoncachio: but I need to do another run with persistent logging to know for sure what happened17:53
ijohnsonit's rather annoying that we don't have persistent logging enabled by default :-/17:54
cachioijohnson, thanks for checking that18:03
mupPR snapcraft#3274 closed: schema: rename package-repository's "deb-types" to "format" <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3274>18:13
pedronisijohnson: isn't our cloud-init timeout fairly generous?18:13
pedronisdo we need to increase it?18:14
ijohnsonpedronis: well without logs I don't know what happened, all I know is that cloud-init didn't create the user even though the right files were put onto /etc/cloud from ubuntu-seed, but the disabled file was installed by snapd from the previous boot18:14
ijohnsonpedronis: we give cloud-init 5 minutes to finish running18:15
ijohnsonpedronis: but also note that these VM's are excruciatingly slow18:15
ijohnson*nested VM's18:15
ijohnsonso maybe it does actually take more than 5 minutes during a first boot for cloud-init to finish, I dunno18:15
ijohnsonI have a run in progress with persistent logging enabled via the gadget so hopefully I can see what happened for sure18:16
cachioijohnson, I'll be afk about 1 hour, need to go to the kinesiologist now, please let me know if you find anything else18:17
ijohnsoncachio: sounds good18:17
cachioI'll go back to this once I am back18:17
mupPR snapcraft#3259 closed: cli: introduce set-default-track <enhancement> <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3259>18:18
mupPR snapcraft#3275 closed: cli: ignore sudo warning when using multipass <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3275>18:18
mupPR snapcraft#3276 closed: meta: add suite/component validation checks for package-repositories <Created by cjp256> <Closed by cjp256> <https://github.com/snapcore/snapcraft/pull/3276>18:18
* cachio -> kinesiologist18:20
mupPR snapd#9260 closed: seed/seedwriter: test local asserted snaps with UC20 grade signed <Test Robustness> <UC20> <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/9260>18:33
mupPR snapd#9261 closed: bootloader: tweak doc comments (thanks Samuele) <Created by mvo5> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/9261>18:38
ijohnsoncachio: I +1'd 9098, I think you should merge it when it goes green19:02
ijohnsonlet's just handle cleanups and followups, the PR is changing a lot and it's difficult to keep tracking19:02
ijohnsonmmm this is odd19:53
ijohnsondevicemgr.go:702: System initialized, cloud-init reported to be done, set datasource_list to [ None ]19:53
ijohnsonseems cloud-init ran, it did in face take more than 5 minutes, but also it seems that cloud-init finished without actually doing anything19:54
ijohnsonSep 02 19:25:19 ubuntu systemd[1]: Reached target Cloud-init target.19:54
ijohnsonSep 02 19:25:19 ubuntu systemd[1]: Startup finished in 52.655s (kernel) + 5min 16.330s (userspace) = 6min 8.985s.19:54
ijohnsoncachio: I think I understand why nested uc20 tests are broken20:21
ijohnsoncachio: it is because of a PR landed to the core20 snap which breaks cloud-init20:21
ijohnsoncachio: I have debugged it and will be opening a PR shortly to fix the problem20:40
mupPR core20#84 opened: static/writable-paths: use transition instead of none for /etc/cloud <Created by anonymouse64> <https://github.com/snapcore/core20/pull/84>20:45
cachioijohnson, awesome20:48
mupPR core20#84 closed: static/writable-paths: use transition instead of none for /etc/cloud <Created by anonymouse64> <Merged by xnox> <https://github.com/snapcore/core20/pull/84>20:50
cachioijohnson, please take a look to the answers I left in the PR #909821:24
mupPR #9098: tests: new organization for nested tests <Run nested> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9098>21:24
ijohnsoncachio: yes I saw, looks fine to me21:24
cachioijohnson, thanks21:24
ijohnsoncachio: as soon as the pr goes green, please merge I think it's ok without a second +121:24
cachioijohnson, nice, thank21:24
mupPR snapd#9265 opened: many: move seal code from gadget/install to boot <UC20> <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/9265>22:04
cachiozyga-kaveri, when you have 5 minutes, could you please take a final view to #909822:06
mupPR #9098: tests: new organization for nested tests <Run nested> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9098>22:06
mupPR snapd#9266 opened: tests/lib/nested.sh: reset the TPM when we create the uc20 vm <Bug> <Run nested> <Test Robustness> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9266>22:49
cmatsuokaijohnson: is "partion" a real word or can I assume it's mispelled partition?22:56
ijohnsoncmatsuoka: afaik it's not a word23:04
cmatsuokaijohnson: from the context I'll assume it's intended to be "partition"23:04
ijohnsoncmatsuoka: is this from one of my prs?23:07
cmatsuokaijohnson: I found many instances, just grep -Ri partion. I'm preparing a PR to change them to partition23:08
mupPR snapd#9267 opened: many: fix partion vs partition typo <Simple 😃> <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/9267>23:24

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!