mborzeckiehh some random failures on arch06:31
mborzeckimvo: morning06:31
mvomborzecki: good morning06:32
mborzeckimvo: can you use your superpowers to merge https://github.com/snapcore/snapd/pull/9246 ?06:52
mupPR #9246: boot: handle canceled update <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9246>06:52
mvomborzecki: sure thing06:53
mborzeckimvo: thanks!06:53
zyga-kaverigood morning06:53
mvomborzecki: done06:53
mvozyga-kaveri: good morning06:53
mborzeckimvo: yay, thanks!06:53
mborzeckizyga-kaveri: hey06:53
mupPR snapd#9246 closed: boot: handle canceled update <UC20> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9246>06:56
mupPR snapd#9258 closed: devicestate: add tests around logging in RequestSystemAction <UC20> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9258>07:06
mborzeckipedronis: i'll rebase #9264 on top of master now that Canceled has landed07:12
mupPR #9264: [RFC] many: introduce ContentChange for tracking gadget content in observers <Needs security review> <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9264>07:12
pedronismborzecki: thx07:12
mvomborzecki: I addressed your comments in 9210, I think this is ready for another look07:14
mupPR snapd#9268 opened: daemon: add API for checking and installing available theme snaps <Created by jhenstridge> <https://github.com/snapcore/snapd/pull/9268>07:16
mupPR snapd#9257 closed: bootloader: retrieve boot chains from bootloader <UC20> <Created by cmatsuoka> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9257>07:21
mupPR snapd#9269 opened: devicestate: rename "mockLogger" to "logbuf" <Simple 😃> <Skip spread> <Created by mvo5> <https://github.com/snapcore/snapd/pull/9269>07:21
mupPR snapd#9267 closed: many: fix partion vs partition typo <Simple 😃> <Created by cmatsuoka> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/9267>07:31
mborzeckihm i think i found a subtle bug in gadget updates handling of new files on rollback when there's an unexpected reboot in between08:13
* zyga-kaveri will really start at 11:00, but is wondering if this is a good long-term model08:16
mborzeckizyga-kaveri: probably not08:16
zyga-kaverimborzecki: PT interferes but fortunately I do at-home PT today08:17
pedronismborzecki: I re-commented in 926408:45
pedronismborzecki: also maybe, silly idea, could backupOrCheckpointFile return the ContentChange or nil directly? or doesn't it have the right info?08:46
mborzeckipedronis: hm good point, it should have all the data, and != nil means somethign will be written08:48
mborzeckipedronis: pushed now09:00
pedronisthx, I have a meeting now09:01
zygaheh, lucy is just now sleeping, as my wife is back09:05
* zyga focuses on coding 09:05
zygahmm, some issue with spread09:07
zygapstolowski: offtopic, I think we have a bug in services09:13
zygapstolowski: look at those days09:14
zygaUndoing  2020-05-06  2020-05-06  Stop snap "lxd" services09:14
zygaperhaps lxd's special arrangement with services makes our code ineffective09:15
zygaI rebooted the machine as it was stuck using lots of cpu as lxd was in a weird state09:15
zygabut I think this change should have progressed somehow09:15
zygaeither by failing09:15
zygaor by continuing with lxd services not stopped09:15
zyganote that this is the undo path09:15
zygaso maybe it's a less prominent bug09:15
zygaI rebooted that device09:16
zygait's rebooted and in the same state?!09:17
pstolowskizyga: i don't understand what's going on, but 2020-05-13  and 2020-05-06 looks werid09:18
zygait's like this for a long time09:18
zygalook at this now09:18
zygaanything else I can provide?09:19
zygaI can refresh snapd09:20
zygait's not the latest by far09:20
zygabut I wonder why didn't it refresh by itself09:20
zygais it the lxd change in flight?09:21
zygaI didn't set any refresh schedules or anything like that09:21
zygapstolowski: lxd is also in a funny state: https://paste.ubuntu.com/p/w69fpSx3df/09:23
zygathis keeps showing up over and over09:23
zygazyga@pi3-2:~$ sudo snap stop lxd09:24
zygaerror: snap "lxd" has "auto-refresh" change in progress09:24
zygaI stopped both the lxd.activate and lxd.dameon services09:29
zygaand the machine is no longer spinning like crazy09:30
zygaand now all the tasks have finished09:30
zyga    restart-condition: on-failure09:30
zygalxd will restart forever when it is broken09:30
zygapstolowski: what happens when:09:31
zygapstolowski: a snap has a service which has restart-condition: on-failure09:31
zygapstolowski: snap has more than one service, one that talks to a socket (like activate) and causing socket-activation, and another one that is broken09:32
zygapstolowski: will we ever manage to stop that?09:32
pstolowskizyga: would be good to have a simple reproducer as a spread test (without lxd), i don't know from top of my head09:35
zyganow store assertions service times out09:35
zyga- Fetch and check assertions for snap "core18" (1889) (Get https://api.snapcraft.io/api/v1/snaps/assertions/snap-revision/i_FldUJXgbUZueGCJo8M5l_yJeF-i1p9ienjEtN3SRfRmi8Wpckx_ZI8qm-r5Mdg?max-format=0: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers))09:35
zygapstolowski: yeah, I agree09:35
zygaeh, it sucks we throw away a snap download when assertions fail09:36
zygaI'm re downloading core and snapd again09:36
zygaisn't there a cache we have?09:36
pstolowskizyga: you're probably onto something but this is a bit complicated to reason about without a test09:36
mupPR snapd#9270 opened: wrappers, systemd: allow empty root dir and conditionally do not pass --root to systemctl <Run nested> <Services ⚙️> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9270>09:36
zygapstolowski: I can review that09:37
pstolowskizyga: thanks09:37
zygaI think we could try to fetch assertions before the download09:37
pstolowskizyga: i guess failed assertion means we cannot trust cache?09:37
zygathat's probably not a high cost in code09:37
zygapstolowski: not really, we can keep an incomplete cache of downloads09:37
pstolowskizyga: ah, ok, it's downloading assertions09:37
pstolowskizyga: so yeah, probably09:38
zygaif I break network at 90% of a huge snap09:38
zygait's really silly to throw that away09:38
zygaeven before we have any assertions09:38
pstolowskizyga: i marked that PR RFC/draft09:38
zygaand it failed again!09:38
zygapedronis: is the store assertion service broken?09:39
zyga- Fetch and check assertions for snap "snapd" (8792) (Get https://api.snapcraft.io/api/v1/snaps/assertions/snap-revision/eZZ56DeorGzQUHotTBqlJ_T4LLyZKnAA0IkKn9YISRHfkTjiCENUBpcH5flV-kCA?max-format=0: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers))09:39
mvozyga: he is in a meeting, maybe someone from the store knows?09:39
zygaI see09:39
zygafor context, this fails when doing this:09:43
zyga- Fetch and check assertions for snap "snapd" (8792) (Get https://api.snapcraft.io/api/v1/snaps/assertions/snap-revision/eZZ56DeorGzQUHotTBqlJ_T4LLyZKnAA0IkKn9YISRHfkTjiCENUBpcH5flV-kCA?max-format=0: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers))09:43
zygaConsider re-refresh of "core18", "pi", "lxd", "htop", "snapd", "pi-kernel"                                                                                                                                                                    |09:43
zygait's re-refreshing a handful of snaps09:43
zygaand probably fails because of that09:44
zygayep, failed again09:44
zygaand re-refresh fails the whole change09:44
zygapstolowski: https://github.com/snapcore/snapd/pull/9270#pullrequestreview-48167654309:48
mupPR #9270: [RFC] wrappers, systemd: allow empty root dir and conditionally do not pass --root to systemctl <Run nested> <Services ⚙️> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9270>09:48
pstolowskizyga: thank you, i think's a new ctor is a good idea, although i think NewInChroot is confusing09:52
zygapstolowski: New vs NewChroot or something similar09:53
zygaspread workers will be back shortly09:56
pstolowskizyga: i would just avoid "Chroot" in the name, but yes09:56
pedronispstolowski: New and NewUnderRoot ?10:02
pstolowskipedronis: yes, works for me10:03
mborzeckiheh, cancelling github action jobs is kind of flaky10:04
mborzeckipretty sure i canceled the right one, but a different run failed?10:04
mborzeckiall in the same PR10:04
zygamborzecki: spread refuses to be cancelled10:08
zygamborzecki: it works if the process cooperates10:08
zygamborzecki: I had to restart workers so that's expected10:08
mborzeckizyga: wouldn't the worker send SIGTERM at some point?10:08
zygamborzecki: spread ignores that10:09
zygamborzecki: it's a known bug10:09
mborzeckiuh meant SIGKILL10:09
zygamborzecki: ah, no it doesn't do that10:09
zygacompilers usually behave10:09
mborzeckiwell, you can run arbitrary commands there10:09
mborzeckido actual deployments and so on10:10
zygaI know but usually tools take SIGINT just fine10:10
zygaok, we should have a bit more stability now, there's some extra ram for excessive spiky loads10:12
mborzeckiwell, you can run arbitrary commands there10:16
mborzeckiduh, wrong window10:16
zygals ;)10:16
clmsyHi Everyone, is there any date in mind for this milestone release ? https://launchpad.net/snapd/+milestone/2.4610:25
clmsythe fixes has been committed for a while10:25
zygamvo: ^^^10:25
* zyga changes hosts10:31
pstolowskizyga-kaveri: can you report a bug for that lxd services issue and collect all the info there?10:40
mupPR snapd#9271 opened: boot: keep track of the original asset when observing updates  <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9271>10:42
pedronispstolowski: shouldn't most places keep New, and just very few use UnderRoot? are you not doing that because of tests?10:48
pstolowskipedronis: yes, i just wanted to limit changes to the minimum I know was problematic for services PR. i can do it all if you prefer that way?10:51
pedronispstolowski: I think we need to have a chat so I understand what's the final state we want10:52
zyga-kaveripstolowski: yes, on it10:52
pedronispstolowski: can we have a chat after standup? or ealier if you want?10:54
pstolowskipedronis: sure, anytime works for me10:54
pstolowskipedronis: i'll have a lunch break now, so maybe before or after standup, let me know10:59
pedronisok, I have a meeting noew10:59
cachiozyga, hi11:06
cachiozyga, I need last review for #909811:06
mupPR #9098: tests: new organization for nested tests <Run nested> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9098>11:06
cachiozyga, could you please take a look today?11:07
zyga-kavericachio: sure11:10
cachiozyga-kaveri, thanks11:10
pedronispstolowski: I scheduled something11:51
pstolowskipedronis: thanks11:52
mupPR snapd#9262 closed: configcore: rework how console-conf is disabled <⛔ Blocked> <Created by mvo5> <Closed by mvo5> <https://github.com/snapcore/snapd/pull/9262>12:02
zyga-kavericachio: https://github.com/snapcore/snapd/pull/9098#pullrequestreview-48174154012:08
mupPR #9098: tests: new organization for nested tests <Run nested> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9098>12:08
cachiozyga-kaveri, o makes good compression, I'll put there the values , give me 10 minutes12:10
zyga-kavericachio: cool, thanks12:12
zyga-kaverithat is not a blocker12:12
zyga-kaverithe few issues are real blockers12:12
zyga-kaverionce those are done we can merge and iterate12:12
cachiozyga-kaveri, I updated the function names12:29
cachiozyga-kaveri, the changes you told me about core revert test, I don't see the same thing than you12:30
zyga-kavericachio: about !?12:31
zyga-kavericachio: function names were not a blocker12:31
cachiothis test has been already with the others, could be that one cached for you?12:31
zyga-kavericachio: cached?12:31
zyga-kaveriare we talking about the use of negation?12:31
cachiozyga-kaveri, this one https://github.com/snapcore/snapd/pull/9098#discussion_r48292383812:33
mupPR #9098: tests: new organization for nested tests <Run nested> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9098>12:33
cachiofor example12:33
zyga-kaveriI didn't read your comments there12:34
zyga-kaveribut do you understand the fundamental problem with sh, functions, set -e and if / while / !?12:34
zyga-kaveriyou cannot use all three at the same time12:34
zyga-kaveriset -e; hello() { false; echo "blah" }; if ! hello; then echo "unreachable"; fi12:35
zyga-kaverifalse does not break execution of hello12:35
cachioI am not talking about the negation12:36
zyga-kavericachio: replace `if` with `while/until` and `!`12:36
zyga-kaveriok, let me read your comments12:36
cachioyou see variables like CORE_REFRESH_CHANNEL but I dont12:37
zyga-kaverithat's not what I'm referring to12:38
cachioI know12:38
zyga-kaveriI was only referring to the usage of functions inside control statements12:38
cachio1 sec, let me check github code12:39
zyga-kaveriare we in agreement what is the problem with those functions?12:40
zyga-kaveriI'm confused if we are talking about the same thing12:40
cachioI think github is doing something wrong12:40
cachioit shows in the main page of the pr some comments but then if I go to the file I see the real one12:42
cachioit is like an overlap12:42
cachioI think it was caching here12:43
cachionow I see well12:43
cachioabout the negations, we allways used the ! and not for execute_remote, in this PR I just updated the name12:44
zyga-kaveriit's still wrong :)12:45
zyga-kaverinot lalalalal is true12:45
zyga-kaverinot function_not_command is always true12:45
zyga-kaverithat part was not testing anything real12:45
zyga-kaveri! function is very very fragile12:46
zyga-kaveriunless the function is coded for it12:46
zyga-kaveriit will misbehave12:46
zyga-kaveriwhile function and if function are equally fragile12:46
zyga-kavericachio: don't get me wrong, those do not have to be fixed in this pr12:50
zyga-kavericachio: they are wrong though12:50
cachiozyga-kaveri, ok, I'll open a new pr with that12:51
cachiozyga-kaveri, we should organize all the changes needed for nested12:51
zyga-kaveriyeah, let's fix the small things here and work towards fixing the rest12:51
cachioI am creating a todo list12:51
zyga-kaveriI'm not sure how to fix it yet12:51
mupPR snapd#9272 opened: configcore: "service.console-conf.disable" is gadget defaults only <Created by mvo5> <https://github.com/snapcore/snapd/pull/9272>13:02
mborzeckioff to pick up the kids13:59
pedronis#9264 needs 2nd reviews14:02
mupPR #9264: many: introduce ContentChange for tracking gadget content in observers <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9264>14:02
mupPR snapd#9273 opened: [RFC]  boot: mark successful with boot assets  <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9273>14:02
mborzeckicmatsuoka: can you take a look at 9264 maybe?14:03
cmatsuokamborzecki: sure14:03
mborzeckicmatsuoka: thanks!14:03
* mborzecki really leaves this time to pick up the kids, bbl14:04
cmatsuokamborzecki: done14:11
ijohnsoncachio: have you seen this journal-state failure before ? https://pastebin.ubuntu.com/p/zqGBMpPxgF/14:29
* zyga-kaveri focuses on coding14:30
mupPR snapd#9264 closed: many: introduce ContentChange for tracking gadget content in observers <UC20> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9264>14:33
ijohnsonmvo: pedronis: we can just land #9269 now and I can merge master into my PR14:33
mupPR #9269: devicestate: rename "mockLogger" to "logbuf" <Simple 😃> <Skip spread> <Created by mvo5> <https://github.com/snapcore/snapd/pull/9269>14:33
ijohnsonI need to merge master into my PR anyways14:33
pedronisijohnson: ok, if that works for you14:33
ijohnsonyeah that's fine14:33
ijohnsonI +1d it, not sure if we want a 2nd +1 on the PR, it's quite simple14:34
cachioijohnson, cheking14:34
pedronisijohnson: I merged it14:35
cachioijohnson, mmm, no14:35
cachiobut at some point we added that retry to avoid an error14:36
cachioI'll try to reproduce it14:36
mupPR snapd#9269 closed: devicestate: rename "mockLogger" to "logbuf" <Simple 😃> <Skip spread> <Created by mvo5> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/9269>14:38
ijohnsonthanks pedronis14:39
ijohnsoncachio: yeah I just saw it once, I don't think it's happening all the time14:39
pedronisijohnson: mvo: I commented here: https://github.com/snapcore/snapd/pull/9253/files#r48302434714:41
mupPR #9253: sysconfig/cloudinit.go: add AllowCloudInit and use GadgetDir for cloud.conf <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9253>14:41
ijohnsonpedronis: I responded, I think returning right now is the right thing14:42
ijohnsonpedronis: but eventually returning right there is not what we want14:42
pedronisijohnson: we are setting CloudInitSrcDir only for dangerous atm, right?14:44
ijohnsonpedronis: yes14:44
pedronisso we don't strictly need to return14:44
pedroniswe might want to add a comment about that and vs the TODO though14:45
ijohnsonpedronis: do you think the existing TODO I have is sufficient or should I add another TODO ?14:45
pedronisah, I was confused you have already a return nil14:46
pedronisthat return nil needs its own TODO, about the fact that combining cloud.conf and renumbering / filtered seed data should be ok14:47
mvocan I interesst someone in a review for 9210 maybe :) ? would unblock the "snap reboot" command14:47
ijohnsonmvo: I can take a look in my PM14:48
ijohnsonqueued it up14:48
pedronisijohnson: #9273 is also something you should look (I don't know if I'll get to it myself today)14:54
mupPR #9273: [RFC]  boot: mark successful with boot assets  <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9273>14:54
ijohnsonpedronis: ack I will add it to the queue, also #9253 is updated again15:03
mupPR #9253: sysconfig/cloudinit.go: add AllowCloudInit and use GadgetDir for cloud.conf <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9253>15:03
pedronisijohnson: +115:05
pedronismvo: I merged master into #892015:10
mupPR #8920: interfaces: update cups-control and add cups for providing snaps <Needs Samuele review> <Squash-merge> <Created by jdstrand> <https://github.com/snapcore/snapd/pull/8920>15:10
pedronispstolowski: #9245 doesn't need to target 2.46 anymore, right?15:11
mupPR #9245: o/snapstate, features: add feature flags for disk space awareness <Disk space awareness> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9245>15:11
pstolowskipedronis: yes, cleared, thank you15:12
mupPR snapcraft#3269 closed: spread tests: remove references of core16 <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3269>15:15
pedronispstolowski: maybe I'm confused but now  TestRemoveDiskSpaceForSnapshotNotCheckedWhenSnapshotsDisabled and TestRemoveDiskSpaceCheckDisabled are the same test basically? so we should keep only one?15:20
pstolowskilet me check15:20
pedronisor one is about the default?15:21
pedronisyes, one of the two is about the default vs explicitly disabling, maybe they should share some code, and need better names15:23
pedronispstolowski: sorry, maybe I'm distracting you, I thought that one would be an easy win15:25
mvopedronis: looking at cups in a sec15:30
pstolowskipedronis: np, i was just checking, yes, one is about not doing a snapshot becuase of ErrNothingToDo, the other is about feature flag but it has a mistake and is not really testing the flag becuase it also hits ErrNothingToDo15:30
pstolowskipedronis: thanks for spotting, i'll fix that15:31
* cachio lunch15:48
ijohnsonmvo: could you use your superpowers on #9266 ? the only failed test is on 16.04, and it's a known failure that is not related to the PR16:01
mupPR #9266: tests/lib/nested.sh: reset the TPM when we create the uc20 vm <Bug> <Run nested> <Test Robustness> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9266>16:01
mvoijohnson: sure16:03
mvoijohnson: done16:03
pstolowskipedronis: done with https://github.com/snapcore/snapd/pull/9274 ; 3 tests share same code now16:05
mupPR #9274: tests: simplify and fix tests for disk space checks on snap remove <Test Robustness> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9274>16:06
mupPR snapd#9266 closed: tests/lib/nested.sh: reset the TPM when we create the uc20 vm <Bug> <Run nested> <Test Robustness> <UC20> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9266>16:08
mupPR snapd#9274 opened: tests: simplify and fix tests for disk space checks on snap remove <Test Robustness> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9274>16:08
ijohnsoncachio: zyga-kaveri: is it likely that we can land 9098 today or will that take some more work to refactor things16:13
ijohnsonI have some other (simple) nested changes I need to propose, just wondering if I should wait for that to land or just propose them as-is now16:14
mupPR snapd#9275 opened: tests/main: mv core specific tests to core suite <Simple 😃> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9275>16:18
cachioijohnson, I see all the jobs for 9098 -> Queued — Waiting to run this check...16:36
ijohnsoncachio: ah yeah might need to close and re-open the PR to trigger them16:36
cachioijohnson, and it has conflicts16:36
ijohnsonI see that on my PR's as well16:36
ijohnsonah ok I didn't know it has conflicts too16:36
ijohnsoncachio: is it ok if I propose a small improvement to nested.sh today then ?16:37
cachiozyga-kaveri, could you please give last review to 9098?16:38
zyga-kavericachio: in 1-2 hours16:38
zyga-kaverifocused on coding now16:38
zyga-kaveribut before EOD16:38
cachiozyga-kaveri, nice, thanks16:39
cachioijohnson, I am colleting all the comments for the following PRs16:49
=== King_InuYasha is now known as Conan_Kudo
=== Conan_Kudo is now known as King_InuYasha
cachiozyga-kaveri, is there any easy way to skip an invariant check?17:53
cachioI need to skip it for new desktop run17:53
zyga-kaverinot really17:54
zyga-kaverican you tell me more17:54
zyga-kaverimaybe we need to extend it17:54
zyga-kaveriis it the dbus check?17:54
cachiobecause in my desktop image we have more dbus-sessions running17:54
cachioand the invariant fails17:54
zyga-kaveriis it for the gdm user?17:55
cachiolet me check, I think it is power user17:55
zyga-kaveriplease add an exception to the invariant to allow those users on certain backends17:56
cachiotests.invariant: more than one dbus-daemon running17:57
cachiopid:1200 cmdline:/usr/bin/dbus-daemon --session --address=systemd: --nofork --nopidfile --systemd-activation --syslog-only17:57
cachiopid:1387 cmdline:/usr/bin/dbus-daemon --config-file=/usr/share/defaults/at-spi2/accessibility.conf --nofork --print-address 317:57
zyga-kaveriwhat user runs those?17:58
cachiotit is hte ubuntu user17:59
cachioit is another user in the system17:59
cachiowhich is hte default user for this desktop18:00
cachiozyga-kaveri, so perhaps for classic desktop we should allow this18:00
cachiobecause we allways have at least 1 extra user18:00
cachioI'll update now the invariant to support the ubuntu user which will be our default for desktop18:03
cachiozyga-kaveri, does it make sense?18:03
zyga-kavericachio: why is the ubuntu user logged in>18:04
cachiozyga-kaveri, it is beacuse I created that in the zfs machine18:05
cachioas default user18:05
zyga-kaveriwhy is it logged in?18:05
zyga-kaveriI don't understand18:05
zyga-kaveriis it running our tests?18:05
zyga-kaveriare you logged in interactively?18:05
cachionI ran the snapd suite18:06
cachioIt is a desktop machine18:06
cachiothe ubuntu user is not logged in afaik18:06
zyga-kaveriso if it is not logged in, why is there a session for it?18:06
zyga-kaveriI don't mind adding exceptions if it makes sense18:07
zyga-kaveriso far we are missing something18:07
zyga-kaveriare pid 1200 and 1387 both owned by that user>18:07
cachioI yes18:07
zyga-kaveridoes loginctl list-sessions shows a session for that user?18:07
cachiodont know why are those pid running, I already rebooted the machine before running the tests18:08
zyga-kaveriperhaps it has auto-login enabled18:08
cachio 2 1000 ubuntu   seat0 tty218:08
zyga-kaveriso ubuntu is logged in18:08
zyga-kaveriis the auto-login enabled for that user in gdm?18:09
zyga-kaveriI believe this is stored in /etc somewhere but I don't recall the details18:10
cachioI just checked that in the systemd info18:10
zyga-kavericachio: so if you reboot that machine, tty2 has ubuntu logged in?18:10
zyga-kaverinot linger18:10
zyga-kaveriauto-login is a gdm feature18:10
zyga-kaveriit's not related to systemd18:10
cachioI'll reboot again the machine and systems18:10
cachionot systemd18:11
cachiosystems settings18:11
cachiook, I'll run it again18:12
cachioafter a reboot18:12
cachioI'll login with the external user18:12
cachioand validate there is not any user session for ubuntu user18:13
zyga-kaveriI'm sure there's something18:14
cachiozyga-kaveri, what about this one? c1  125 gdm      seat0 tty118:17
zyga-kaveriyes, gdm should be allowed18:17
zyga-kaveriit's easy to filter by user18:17
cachiozyga-kaveri, ah, ok, nice18:17
mupPR snapcraft#3148 closed: specifications: environment-manager datastore <specification> <Created by cjp256> <Closed by cjp256> <https://github.com/snapcore/snapcraft/pull/3148>18:26
ijohnsonpedronis: should we update `snap model` to mention the grade in the default output?18:47
ijohnsonseems like a nice thing to have18:47
ijohnsonalso grade is not in --verbose, it should at least be there18:48
pedronisijohnson: yes, but also we need to support "snaps"  (vs required-snaps) at some point in verbose18:49
ijohnsonpedronis: ah yeah good point18:49
ijohnsonpedronis: I will throw up a quick PR adding grade to the default model output (if the assertion has it of course), and we can deal with snaps later I think18:49
zygacachio I'll review your branch now18:54
mupPR snapd#9252 closed: osutil: add ExchangeFiles <Created by zyga> <Closed by zyga> <https://github.com/snapcore/snapd/pull/9252>18:59
zyga-mbpcachio: some comments are not replied to or acked19:07
cachiozyga-mbp, I collected that for the following PR19:07
zyga-mbpcachio: this is wrong now: https://github.com/snapcore/snapd/pull/9098#pullrequestreview-48212427719:08
mupPR #9098: tests: new organization for nested tests <Run nested> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9098>19:08
zyga-mbpI mean, it's fine to collect stuff for another PR that requires more work19:08
zyga-mbpthis is a variable with wrong name19:08
zyga-mbpnext to a local with different name19:08
zyga-mbpso we set a global instead19:08
pedroniscmatsuoka: I looked again and there is work for us vs using PCR 4, it's done magically by secboot19:08
zyga-mbpmaybe it's correct but it looks fishy19:08
pedroniscmatsuoka: it's *not* done magically19:08
zyga-mbpfollow-ups are for more complex work or for non-broken things that need tweaks (like the execute -> exec rename) for consistency19:09
cmatsuokapedronis: oh ok, let's do it then19:10
pedroniscmatsuoka: as I said let's finish what we have, but you can start looking atm we are using AddEFISecureBootPolicyProfile, right?19:10
pedronis(that uses PCR 7)19:11
cmatsuokapedronis: yes, we are19:11
* cmatsuoka checks19:11
cachiozyga-mbp, ok, I'll fix it in a moment19:11
pedroniscmatsuoka: there's a new AddEFIBootManagerProfile as well in secboot (based on PCR 4) that we need to use as well19:11
cmatsuokapedronis: mm ok, I'll have a look19:12
pedronisit takes the same kind of params19:13
pedronisnot sure if there is something we need to pay particular attention combining things, if it's not obvious we should chat with chris19:14
mupPR snapd#9276 opened: tests: new backend for desktop and external classic <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9276>19:24
cachiozyga-kaveri, done19:41
cachiowent 1 by 119:41
cachioanswered all hte comments19:41
cachiosome of the improvements like the negation one will be included in the following pr19:41
cachiozyga-kaveri, hold on19:42
cachioI have to push something else19:42
cachiogithub was hidding more comments19:43
cachiozyga-kaveri, now it is complete for real19:46
cmatsuokapedronis: it could be something as simple as PR #9277, but I don't know if there are other constraints there such as order or something like that19:46
mupPR #9277: secboot: add boot manager profile to pcr protection profile <UC20> <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/9277>19:46
cachiozyga-kaveri, there were some comments that github was hidding me so I didn't see those and for that raeson I didnt answer and fixed those19:47
mupPR snapd#9277 opened: secboot: add boot manager profile to pcr protection profile <UC20> <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/9277>19:49
zyga-mbpcachio https://github.com/snapcore/snapd/pull/9098#pullrequestreview-48215812719:58
mupPR #9098: tests: new organization for nested tests <Run nested> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9098>19:58
ijohnsonzyga-mbp: cachio: any objections to squash-merging 9098 ?20:03
ijohnsonit has 58 commits now20:04
zyga-mbpno, please squash20:04
zyga-mbpgood idea20:04
ijohnsongreat yes let's squash20:04
zyga-mbpvs code + remote extension == bliss20:05
zyga-mbpthis is so amazing20:05
zyga-mbpmicrosoft made the best editor20:05
ijohnsonnice, I have been meaning to test out the remote extension but haven't gotten around to it just yet20:06
cachiozyga-mbp, ijohnson thanks guys20:06
zyga-mbpthe only downside is the proprietary nature which limits the set of architectures20:06
zyga-mbpso no riscv or ppc builds20:06
zyga-mbpthe real value is in the excellent non-free extensions20:07
ijohnsonI do really like some of the other extensions they have for it, the github one is really good with one kinda big deal-breaker for me which is the lack of the ability to respond to comments in pr's, you just leave a comment generally on the pr, not in response to someone's comment20:07
ijohnsonzyga-mbp: which part is proprietary ? you mean the extensions ?20:07
zyga-mbpoh, I didn't try that part20:07
zyga-mbpvirtually all microsoft extensions are non-free20:07
zyga-mbpthe editor itself is20:08
zyga-mbpbut the superb extensions are not20:08
ijohnsonah interesting I didn't realize that20:08
cachioijohnson, zyga-kaveri is degraded test failing on your PRs for groovy?20:21
zygacachio I saw that failure, yes20:21
ijohnsoncachio: I see it fail sometimes but other times it passes20:22
zygawe discussed this a few days ago, something related to DBX updates?20:22
ijohnsonyeah dbx related20:22
cachiozyga, ijohnson I was trying to reproduce it the whole day and I couldn't20:22
ijohnsoncachio: yeah I haven't seen that one fail today actually, but earlier this week I saw it fail, perhaps it was fixed upstream in groovy20:23
cachiotests errors try to avoid me20:24
ijohnsonhaha yeah sounds about right20:24
* zyga EODs but will work on code tomorrow, the export manager is close to doing its job now20:26
bdxhello, quick question about ulimits and snapped processes20:40
bdxsystem level ulimit configuration doesn't seem to apply to my snapped process, is there some additional work I must do in order to ensure the snapped process gets the desired ulimit settings?20:41
bdxI found https://forum.snapcraft.io/t/how-to-customize-systemd-service-created-by-snapd/18397/220:41
bdxwhich makes me think that I need to apply my ulimit commands at the app level inside of the snap in that case, using a command-chain20:42
bdxabout to start diving in and testing some things, but I thought someone might have a bit of input that will make my journey easier20:43
bdx:) thx20:43
mupPR snapd#9275 closed: tests/main: mv core specific tests to core suite <Simple 😃> <Created by anonymouse64> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/9275>20:44

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!