| mup | PR operator#400 opened: Fix trivial typo in docstring <Created by mthaddon> <https://github.com/canonical/operator/pull/400> | 07:19 |
|---|---|---|
| bthomas | !!!! | 08:10 |
| bthomas | Good Morning | 08:10 |
| Chipaca | bthomas: ｇｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｄ ｍｏｒｎｉｎｇ！ | 08:11 |
| Chipaca | bthomas: does erc do colours? | 08:14 |
| bthomas | Morning Chipaca. Yes ERC does colours by default | 08:14 |
| Chipaca | phew | 08:15 |
| bthomas | What really love is it supports LaTeX too. I recently switched to ERC from Pidgin after finding this out. | 08:15 |
| Chipaca | bthomas: right there insid erc? | 09:01 |
| Chipaca | inside* | 09:01 |
| bthomas | Chipaca: You mean LaTeX . If so yes it is using ERC-TeX https://www.emacswiki.org/emacs/erc-tex.el | 09:02 |
| Chipaca | neat | 09:02 |
| bthomas | I changed the delimiter to $$ from $ since $$ is what other IRC clients seem to use for TeX markup | 09:02 |
| bthomas | I presume you have seen https://github.com/millejoh/emacs-ipython-notebook | 09:03 |
| bthomas | and https://sites.google.com/site/imaximaimath/ which is now part of official upstream | 09:04 |
| Chipaca | i had not, i will add them to my interesting-stuff backlog :) | 09:19 |
| facubatista | ¡Muy buenos días a todos! | 09:43 |
| bthomas | नमस्ते facubatista | 10:01 |
| facubatista | hola bthomas ! | 10:02 |
| bthomas | Chipaca: I am seeing harness.update_config values set in one unit test persisting in a different unit test even though I have done self.addCleanup(self.harness.cleanup) in setUp(). Is this because I have not used the "unset" argument to update_config ? | 10:11 |
| Chipaca | bthomas: sounds like you're carrying the stored state database between tests | 10:11 |
| Chipaca | bthomas: this shouldn't happen (tm) | 10:12 |
| bthomas | Chipaca: how to I clear StoredState() between tests ? | 10:14 |
| Chipaca | bthomas: it's an in-memory sqlite, it should not be surviving between tests | 10:15 |
| bthomas | I do see if I add unset argument to update_config, I can resolve the problem. Is this good enough for now ? | 10:15 |
| Chipaca | bthomas: i'd even say it can't | 10:15 |
| bthomas | hmmm | 10:16 |
| Chipaca | bthomas: something deeper is wrong, so no | 10:16 |
| Chipaca | bthomas: this is using harness, yes? | 10:16 |
| bthomas | yes harness | 10:16 |
| bthomas | Chipaca: ok let me dig, let us catchup after standup if you have time. | 10:16 |
| Chipaca | bthomas: that's a long time away :) but sure | 10:17 |
| bthomas | Chipaca: I split my time between writing documentation/unit tests for charm and writing documentation for charmhub. | 10:17 |
| Chipaca | ok | 10:17 |
| bthomas | I will be understanding the reactive Charm Hook docs (https://discourse.juju.is/t/charm-hooks/1040) and adapting it for Operator Charms. I am writing my draft in Markdown so that it can be imported into a google doc. If either of this sounds like a bad idea please let me know. | 11:20 |
| facubatista | bthomas, google docs understand markdown? | 11:32 |
| bthomas | awesome | 11:33 |
| bthomas | facubatista: I googled and there seems to be options to import markdown | 11:33 |
| bthomas | in any case I can always cut/pastes. Using my familar editor and familiar markup for now. | 11:34 |
| facubatista | oh, nice! it has "export" too? but we'll end up in Discourse, so I don't want to loose that markdown | 11:34 |
| bthomas | ok I will save it. | 11:34 |
| facubatista | bthomas, I'm writing in markdown too, I just don't want to lose it | 11:34 |
| bthomas | got it | 11:35 |
| Chipaca | facubatista: are we having the bug revue today, or is it docs docs docs? | 11:57 |
| Chipaca | copy-pasting from google docs into discourse preserves formatting (but it's slightly less pretty than hand-written markdown) | 11:58 |
| facubatista | Chipaca, let's have it, it should be short | 11:58 |
| Chipaca | ok | 11:59 |
| mup | Issue operator#398 closed: Improve opslib functionality <Created by facundobatista> <Closed by facundobatista> <https://github.com/canonical/operator/issues/398> | 12:12 |
| Chipaca | facubatista: https://k8syaml.com/ fwiw | 12:24 |
| facubatista | nice | 12:28 |
| Chipaca | facubatista: yes but also an idea of the size of the problem :) | 12:29 |
| facubatista | not a problem! but an opportunity :p | 12:30 |
| Chipaca | facubatista: you say potato i say ghoughpteighbteau | 12:45 |
| facubatista | ja | 12:46 |
| bthomas | Looks like I have introduced a bug in my prometheus yaml by a recent code change. So I will switch track back to the charm and fix that before continuing on documentation. | 13:16 |
| facubatista | bthomas, a bug in the yaml because of a code change? | 13:24 |
| facubatista | ah, prometheus specific yaml? not cham's? | 13:24 |
| bthomas | facubatista: looks like it | 13:24 |
| bthomas | yep prometheus yaml | 13:24 |
| bthomas | The yaml is generated by code. If we use yaml loaded from disk then I could have validated the yaml by using it to launch prometheus on the host. | 13:25 |
| jam | o/ | 13:26 |
| facubatista | bthomas, as it's being generated by code, you can test that code | 13:26 |
| facubatista | hola jam | 13:26 |
| bthomas | indeed | 13:27 |
| jam | morning facubatista | 13:27 |
| bthomas | morning jam | 13:27 |
| facubatista | jam, question! when "dispatch" explodes in juju's face (because of a syntax error in the charm, *for example*), juju logs in DEBUG the problem: https://pastebin.canonical.com/p/gVnm9SsDV2/ | 13:28 |
| facubatista | jam, how difficult it would be that that error is logged in ERROR? | 13:28 |
| facubatista | (so the user will see the problem by default, without needing her to get the model in DEBUG) | 13:28 |
| jam | facubatista, IIRC, we log all of the stdout of a script at DEBUG, and we don't do anything special about content of that output | 13:29 |
| jam | I don't think all stderr should end up at ERROR, maybe WARNING? | 13:29 |
| facubatista | jam, I don't know if *all* stderr, but at least everything that was shown if the process not ends in 0? | 13:31 |
| facubatista | or you log before knowing the final outcome? | 13:31 |
| facubatista | s/you/juju/ :p | 13:31 |
| jam | facubatista, that would imply buffering everything so that you could change the log level, which is possible but has its own risks | 13:31 |
| facubatista | jam, which risks? we were thinking maybe about sending all stderr to a temp file and calling `juju-log` on that content, if retcode != 0 | 13:32 |
| facubatista | (doing that in the dispatch script, I mean) | 13:32 |
| jam | facubatista, do we know whether it is stderr or stdout? (I'm guessing err) | 13:35 |
| facubatista | jam, stderr, as it's a standard "python crash" | 13:36 |
| Chipaca | facubatista: it sounds like dispatch should do this itself then | 13:38 |
| bthomas | seems like I fixed bug. will test and push to github | 13:59 |
| * bthomas grabs coffee before getting back to writing eloquent prose for charmhub | 14:05 | |
| bthomas | Chipaca: Can I add a 20-30 min 1:1 at 5:00pm to your calendar today ? | 14:28 |
| Chipaca | bthomas: can it be at 4pm? | 14:38 |
| bthomas | Chipaca: sure. Adding it now | 14:38 |
| jam | facubatista, so Juju currently puts stdout and stderr into the same stream and then logs it all at DEBUG: https://github.com/juju/juju/blob/7901bce5eef92c2f7af11f0e38cb3f482a25e013/worker/uniter/runner/runner.go#L516 | 14:59 |
| jam | I don't see why we couldn't split that | 15:00 |
| jam | stderr feels more like Warning than Error to me, though tracebacks would be more Error. | 15:00 |
| facubatista | jam, the detail is if you wait to have the process finished before logging (so you can decide based on its retcode) | 15:01 |
| bthomas | https://james-iry.blogspot.com/2009/05/brief-incomplete-and-mostly-wrong.html | 15:52 |
| * facubatista -> lunch | 15:52 | |
| justinclark | For a bit more info on the relations.. Both prometheus and grafana charms are deployed independently. However, "juju add-relation grafana prometheus" returns "ERROR no relations found" | 16:12 |
| justinclark | It seems like the metadata.yamls for grafana [1] and prometheus [2] are not the issue as they have corresponding endpoints. | 16:13 |
| justinclark | [1] https://github.com/justinmclark/grafana-charm-base/blob/master/metadata.yaml | 16:13 |
| justinclark | [2] https://github.com/balbirthomas/prometheus-charm/blob/master/metadata.yaml | 16:13 |
| bthomas | justinclark: are you providing any more arguments to the the add-relation command line other than application names ? | 16:15 |
| justinclark | bthomas - just the relation names | 16:17 |
| bthomas | In that case I do not understand how the two applications know which port and IP to use | 16:17 |
| bthomas | justinclark: I will give this a try too. Could you try adding --via arguments to add-relation | 16:18 |
| bthomas | justinclark: I am able to access the prometheus web page from my host system so I know it is serving an http api. | 16:18 |
| justinclark | So the relation I'm struggling with is the juju relation itself. Regardless of the configuration that needs to happen between the two. | 16:19 |
| justinclark | I have both apps deployed via juju and can access the grafana dashboard and even add the prometheus datasource to that manually. The problem is just the "juju add-relation" command. | 16:20 |
| justinclark | bthomas: we can worry about how to set the relation data once we figure this out. Want to hop on a 1-1 call? | 16:21 |
| bthomas | justinclark: ok will join stand up link in 30 sec | 16:22 |
| bthomas | justinclark: your link froze and terminated | 16:27 |
| jam | facubatista, we could do that, though it might be more straightforward if we just always put stderr into INFO/WARNING level, rather than conditional on return code. | 16:27 |
| bthomas | justinclark: I have both grafana and prometheus charms running on my system | 16:31 |
| justinclark | Okay - I'm about to rejoin the hangout | 16:32 |
| * facubatista is back | 16:41 | |
| facubatista | jam, my objective is that people will see errors in the called script by default | 16:42 |
| facubatista | jam, so all stderr to info/warning, is fine (also to ERROR, as it's stdERR...) | 16:43 |
| facubatista | if the charm/script is sending stuff to stdERR that is not an ERRor, well, that scrip/charm needs to be fixed | 16:43 |
| jam | facubatista, well, stderr is for any content that you don't want in your output. eg 'curl' uses it for a progress bar | 16:48 |
| jam | I don't think the "err" in stderr is that hard defined | 16:48 |
| facubatista | yeap | 16:48 |
| facubatista | that's why I'm fine with anything that shows the error to the user by default | 16:48 |
| facubatista | (without needing to put the model in DEBUG, for example) | 16:49 |
| facubatista | jam, shall I open an issue about this or you take it? | 16:49 |
| jam | facubatista, I believe we already have a bug around it, i'll try to track it down, I was using you as a part sounding board for working through it. | 16:49 |
| facubatista | jam, \o/ wonderful | 16:50 |
| jam | facubatista, bug #1893993 | 16:50 |
| jam | fwiw | 16:50 |
| facubatista | jam, thanks | 16:54 |
| facubatista | bthomas, about using google docs but keeping markdown... for me when I paste into google docs it eats all my newlines, does it happen for you too? | 16:55 |
| bthomas | facubatista: I have not tried yet | 16:55 |
| facubatista | bthomas, I'm not finding an "import" either | 16:59 |
| facubatista | ah! "paste without formatting" doesn't eat my newlines | 17:01 |
| bthomas | facubatista: import was external plugins. | 17:01 |
| bthomas | thanks for the paste without formatting tip | 17:02 |
| * bthomas bbiab | 17:49 | |
| mup | PR operator#400 closed: Fix trivial typo in docstring <Created by mthaddon> <Merged by facundobatista> <https://github.com/canonical/operator/pull/400> | 18:11 |
| bthomas | justinclark: I am back. Will be online for another hour or two. | 18:35 |
| justinclark | bthomas: sounds good. I think I'm fairly close. The data is being passed correctly but for some reason isn't recognized by the grafana service. Possibly configuration issues but everything matches the grafana docs as far as I can tell. I'll keep you posted though | 18:50 |
| bthomas | thanks justinclark : there is always the possibility of bugs in the prometheus code. Do message me at the slightest possibility of this so I can have a look. | 18:51 |
| justinclark | Actually, I think it is working properly. | 18:52 |
| bthomas | yay! | 18:53 |
| bthomas | justinclark: there is a "monitor-k8s" option in the prometheus config, that | 18:53 |
| bthomas | will make it gather monitoring data from the k8s cluster. I will try this tomorrow. If you are starved for data :-) try that. | 18:54 |
| mup | PR operator#399 closed: Handle removal of non-existant relation data <Created by stub42> <Merged by facundobatista> <https://github.com/canonical/operator/pull/399> | 18:59 |
| justinclark | I lied :( | 19:00 |
| * justinclark punts computer | 19:00 | |
| bthomas | :) | 19:03 |
| jam | facubatista, to finish the thread we started here https://github.com/juju/juju/pull/11980 should address the tracebacks-by-default | 21:41 |
| mup | PR juju/juju#11980: Change hook stderr output to be logged at WARNING level <Created by jameinel> <https://github.com/juju/juju/pull/11980> | 21:41 |
| facubatista | jam, thanks | 22:26 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!