mupPR snapd#9299 closed: tests/core/uc20-recovery: fix check for at least specific calls to mock-shutdown <Test Robustness> <UC20> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9299>04:38
mvogood morning mb05:56
mvomborzecki: good morning05:56
mborzeckimvo: hey06:06
mborzeckimvo: i see the PRs have landed mostly, and claudio updated #930006:06
mupPR #9300: boot: build bootchains data for sealing <Run nested> <UC20> <⛔ Blocked> <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/9300>06:06
mvomborzecki: yeah06:07
mvomborzecki: that's great, so just one more to go, right?06:08
mborzeckihopefully ;)06:10
mupPR snapd#9310 opened: tests: remove "set -e" from function only shell libs <Created by mvo5> <https://github.com/snapcore/snapd/pull/9310>06:24
zyga-kaverigood morning06:56
zyga-kaveristarting early although I'm still pretty sleepy06:56
zyga-kaveritoday is a strong coffee day06:56
mvogood morning zyga-kaveri06:57
mvoand good morning pstolowski06:57
zyga-kaveripstolowski: hey :)06:57
pstolowskihey, good morning!06:57
zyga-kaveripstolowski: are you by any chance using vscode?06:57
pstolowskizyga-kaveri: yes06:58
zyga-kaveripstolowski: I would like to try a code sharing session sometime today06:58
pstolowskizyga-kaveri: sure06:58
zyga-kaveriI have a question and I wanted to check how this works compared to screen sharing06:58
zyga-kaveribut please let me wake up first06:58
zyga-kaveripstolowski: try https://prod.liveshare.vsengsaas.visualstudio.com/join?D184D6AF59242DB6AAB93D1D2585F4E2A08E07:02
mborzeckizyga-kaveri: pstolowski: hey07:04
zyga-kaverihey :)07:05
mborzeckizyga-kaveri: hm interesting, i joined with a browser(?!)07:05
zyga-kaverimborzecki: cool07:05
zyga-kaverimborzecki: it's pretty neat07:05
zyga-kaveridid you have to log in?07:05
zyga-kaveriI've installed the audio sharing extension as well07:05
mborzeckizyga-kaveri: feels like it's pulling vs into firefox atm07:05
zyga-kaveriso I could talk to you if you did the same07:06
pstolowskizyga-kaveri: ok, i think i joined after a few hops07:06
mborzeckikinda flaky in firefox, let me try chromium instead07:06
zyga-kaverimborzecki: try in vscode07:08
zyga-kaverione sec guys07:08
pstolowskizyga-kaveri: i think you session died07:08
zyga-kaveriyeah one sec :)07:08
mborzeckiyeah. 40407:09
zyga-kaveriI had to reload to install the extension07:09
zyga-kaverimborzecki: I sent you an invite by mail now07:09
zyga-kaverior try this07:10
mborzeckihahah working07:11
zyga-kaverican you see the session chat?07:12
mupPR snapd#9311 opened: nested: add support to telnet to serial port in nested VM <Created by mvo5> <https://github.com/snapcore/snapd/pull/9311>07:19
zyga-kaverithat was quick and productive, thank you both07:22
pstolowskizyga-kaveri: yw07:22
zyga-kaverihow was the quality on your end?07:23
zyga-kaveriwas it better than video share?07:23
pstolowskizyga-kaveri: you closed the session right? cause it said i left it07:23
pstolowskizyga-kaveri: yeah i think it's much better, no artifacts07:23
mborzeckizyga-kaveri: goot that at least it works in the browser07:23
pstolowskizyga-kaveri: plus the client controls the look/fonts etc07:23
zyga-kaveriI'm not sure, I sometimes hit a wrong key on my all-blank-keycaps keyboard07:23
zyga-kavericould you see my three-tab view07:24
pstolowskizyga-kaveri: i think it makes sense for longer sessions07:24
zyga-kaveriI wonder how it adjusts from one screen size to another07:24
zyga-kaveripstolowski: it also supports read/write editing07:25
pstolowskizyga-kaveri: yes i saw this07:25
pstolowskialso terminal can be interactive07:25
pstolowskizyga-kaveri: i don't think i saw your three-tab view07:26
pstolowskibut i'm unclear what you mean by that07:26
zyga-kaveripstolowski: ah that's good, I have a wide monitor and I was worried that would not translate well to other aspect ratios07:26
zyga-kaveripstolowski: three columns of text07:26
zyga-kaveri+ terminal at the bottom07:26
zyga-kaverimvo: do you need the run nested label?07:27
pstolowskizyga-kaveri: see the screenshot on mattermost07:27
mvozyga-kaveri: yeah, probably. let me do that07:27
zyga-kaveripstolowski: I see it07:29
zyga-kaveriso the editor layout is custom per participant07:29
zyga-kaverinow that I understand the problem all I need to do is to code the fix07:30
zyga-kaverithank you again :)07:30
pstolowskii don't remember the exact reason it's done that way there. maybe we could have fixed auto-connect and make it smarter. but perhaps there was a good reason07:32
pstolowskii touched this line 2 years ago, amazing...07:32
zyga-kaveriit seems like an upgrade path for old systems07:32
zyga-kaverithat upgrade to new snapd and new snapd needs to run their tasks maybe?07:33
pstolowskizyga-kaveri: ah yes, there is a comment at the top07:34
pedronismvo: did you see? we found the (one) issue with nested07:47
mborzeckipedronis: hi, shall we have a quick chat about 9300?07:49
pedronismborzecki: yes07:49
mborzeckipedronis: ok, in 5/10 maybe?07:50
mvopedronis: yes, I'm wrapping my tweaks up now right now07:51
mvopedronis: good that it's not something deeper and that nested is back to function it seems07:52
pedronismvo: yes, but annoying, one of those situation where splitting a PR created its own issues07:52
mvopedronis: yeah, it's a combinations of issues it seems, the fact that the nested tests only run sometimes is also contributing to the issue07:52
pedronismvo: yes, but otoh our tests are flaky and slow already :/07:53
pedroniseven before nested07:53
zyga-kaverimvo: we could add an action that runs nested every 12 hours07:53
mvopedronis: yeah07:53
zyga-kaveriit gets reported in github pretty nicely07:53
zyga-kaveri(on master)07:53
pedronismvo: I mean I had a very frustrating evening, staying around to force merge things07:54
mvozyga-kaveri: as long as we make sure that each nested failure is considered high priority I think that's a good one07:54
mvopedronis: .(07:54
mvopedronis: what tests in particular ?07:54
mvopedronis: or all over the place?07:54
zyga-kaverimvo: I'll cook something today07:54
pedronisa bit all over the place07:54
mvopedronis: the nested suite *should* be more robust, we only tests very robust stuff there07:54
pedronisone issue was uc20-recovery, but we have also random failures in ohter places07:54
mvopedronis: well, "should"07:55
mvopedronis: uc20-recover should now be fixed after merging ian PR07:55
pedronislike arch seems to fail on cgroup-tracking:root often but not always07:55
mvopedronis: but yeah, I feel your pain :(07:55
mvopedronis: I saw this one too!07:55
pedronisand then various interface-* tests failing sometimes07:55
pedronisand snap run timeouts sometimes but not always on strace07:56
pedronisI saw it on 1807:56
pedronissaw all over the place07:56
pedronisbut in places that are required07:56
mborzeckipedronis: joining standup07:58
mvopedronis: sry! I will watch out for failures and see if I can fix them07:58
pedronismborzecki: maybe I confused you:  https://github.com/snapcore/snapd/pull/9300#discussion_r48614901308:19
mupPR #9300: boot: build bootchains data for sealing <Run nested> <UC20> <⛔ Blocked> <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/9300>08:19
pedronismborzecki: the Kernel BootFile should have full paths, it's the Kernel fields that should be ok with just names08:20
pedronis(it's not super deep, it's mostly for consistency)08:21
* zyga-x240 caved and ran from the office upstairs08:31
zyga-x240it's so much warmer in the sun08:31
zyga-x240I'll go there later08:31
zyga-x240PT is at home today so I can get to the bottom of remaining tests :)08:32
mupPR snapd#9312 opened: o/snapstate: disk space check with snap update <Disk space awareness> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9312>08:44
pedronismvo: I reviewed #9021, it needs a new 2nd review08:57
mupPR #9021: snap: implement new `snap reboot` command <UC20> <Created by mvo5> <https://github.com/snapcore/snapd/pull/9021>08:57
mvopedronis: \o/ thank you08:59
mvopstolowski: are you up for a second review of 9021?08:59
mvopedronis: I assume 9300 is not quite ready for a review yet(?)09:00
pstolowskimvo: sure. btw is #9284 now critical to unbreak something in nested?09:00
mupPR #9284: tests: some fixes and improvements for nested execution <Run nested> <⚠ Critical> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9284>09:00
pedronismvo: mborzecki is working on it09:00
mvopstolowski: I see failures with nested on master right now09:00
mvopstolowski: and with 9284 it seems no failures anymore09:01
mvoI will also make the nested runs required, so that if they are activated we can only merge if they are green09:02
pstolowskiok, i'll conclude my review of 9284 then09:02
mupPR snapd#9313 opened: boot: do not reorder boot assets when generating predictable boot chains <Simple 😃> <Skip spread> <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9313>09:05
mborzeckipedronis: mvo: https://github.com/snapcore/snapd/pull/9313 a prerequisite09:05
mupPR #9313: boot: do not reorder boot assets when generating predictable boot chains <Simple 😃> <Skip spread> <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9313>09:05
mborzeckiskipped spread, so that we can land it quickly09:05
mvomborzecki: thanks, checking09:06
zyga-x240I switched to a hybrid09:09
zyga-x240with tasks for the things where undo is easier as tasks (export, unexport)09:09
pedronismborzecki: I am bit confused by tests there09:09
zyga-x240and a pointer helper for the link09:09
zyga-x240to avoid the complexity of link snap relationship09:09
zyga-x240making the changes now but I think this is best of both worlds09:09
pedronismborzecki: I think the tests needs a cleanup, now that the assets are not ordered in themselves we don't need so many weird cases in them09:12
pedronisif I'm making sense09:17
mborzeckipedronis: i've updated #930009:45
mupPR #9300: boot: build bootchains data for sealing <Run nested> <UC20> <⛔ Blocked> <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/9300>09:45
pedronismborzecki: did you forget to push to 9313 ?10:20
mborzeckipedronis: #9313 is updated now too10:23
mupPR #9313: boot: do not reorder boot assets when generating predictable boot chains <Simple 😃> <Skip spread> <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9313>10:23
mvomborzecki, pedronis fwiw, I just merged 9284 and nested runs are green, I also made green nested runs a requirement for merging PRs (anything without the run-nested label gets an automatic green here)10:42
mvomborzecki: thanks for the update on 9313 - fwiw, looks all right to me10:44
mupPR snapd#9284 closed: tests: some fixes and improvements for nested execution <Run nested> <⚠ Critical> <Created by sergiocazzolato> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9284>10:45
mupPR snapd#9314 opened: o/snapstate: disk space check on UpdateMany <Disk space awareness> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9314>11:00
mupIssue core20#32 closed: The machine-id file should be writable <question> <Created by zyga> <Closed by xnox> <https://github.com/snapcore/core20/issues/32>11:01
mupIssue core20#72 closed: move docker user/group to extrausers <Blocked> <Created by anonymouse64> <Closed by xnox> <https://github.com/snapcore/core20/issues/72>11:01
mupPR core20#82 closed: [RFC] hooks: mv docker user/group definition to extrausers <Created by anonymouse64> <Merged by xnox> <https://github.com/snapcore/core20/pull/82>11:01
mupPR core20#83 closed: static/writable-paths: make /etc/default/crda writable <Created by anonymouse64> <Merged by xnox> <https://github.com/snapcore/core20/pull/83>11:01
zyga-x240pstolowski: do we need a check on remove?11:01
zyga-x240currently remove can fail if we have no space for the snapshot11:01
pstolowskizyga-x240: that's done and landed already11:02
pstolowskizyga: unless you found a bug11:02
pstolowskiit's behind feature flag too11:03
pedronismborzecki: thanks for the changes in 9300, there are probably some tweaks that can make it easier to reuse the bits for reseal11:03
pstolowskizyga-x240: correction, single snap remove does that already in master; remove-many is about to land11:05
zyga-x240pstolowski: ah, no I just realized this should be so while reading the other PR11:05
zyga-x240pstolowski: that's great11:05
pstolowskizyga-x240: yeah i think all major ops are covered now11:05
pedronismvo: mborzecki: I pushed some small tweaks/simplifcations to 931311:27
mborzeckipedronis: thanks!11:28
pedronisI will look at 9300 again in a bit11:29
mvopedronis: looking11:29
mborzeckipedronis: do you know whether #9032 is getting replaced by something else?11:34
mupPR #9032: secboot: add call to reseal an existing key <UC20> <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/9032>11:34
pedronisit's not afaik, it's used by #9287 which is the one to tweaks after we are happy with 930011:35
mupPR #9287: secboot: reseal key to parameters specified in modeenv <UC20> <⛔ Blocked> <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/9287>11:35
mborzeckihmm wonder whether claudio has some unpushed merge with master in 928711:40
* pstolowski lunch11:47
pedronismborzecki: anyway, I reviewed 9300, there are things to improve there11:49
mborzeckilet me see11:50
mborzeckipedronis: tweaked buildRecoveryBootChain to actually takea list of systems, which in the initial install case will be just the current recovery system, or in a general case, the recovery systems we have12:03
* zyga-x240 -> lunch12:14
mborzeckipedronis: ok, another push to #930012:21
mupPR #9300: boot: build bootchains data for sealing <Run nested> <UC20> <⛔ Blocked> <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/9300>12:21
mborzeckicmatsuoka: hi, we've hijacked a bit your PRs :) please take a look at 9300 as well, hope i've not messed up something12:22
cmatsuokamborzecki: thanks, I'm glad you're working on it12:22
* zyga-x240 also errand12:24
zyga-x240mvo: my update in case I cannot connect for standup12:24
zyga-x240mvo: synced with pawel and maciek in the morning to debug issue from yesterday, guys solved it instantly!12:25
pedronismborzecki: thanks12:25
zyga-x240mvo: split tasks so that export/unexport just handles files and not the "current" symlink12:25
zyga-x240mvo: used a hack to update current inside doLinkSnap, avoiding complex test failures related to task changes after link-snap12:25
zyga-x240mvo: tweaked description of the exported content so that undo path has no custom code left, just loads data from task state and calls the regular remove method12:26
zyga-x240mvo: I will tweak some tests and open a new PR today12:27
zyga-x240now everything should pass okay12:27
* zyga-x240 runs to do the errand12:27
mborzeckipedronis: cmatsuoka: should we sync before the standup?12:28
cmatsuokamborzecki: I can, SU room?12:32
pedroniscmatsuoka: mborzecki: I'm there12:39
mborzeckicmatsuoka: we're there12:40
mupPR snapd#9313 closed: boot: do not reorder boot assets when generating predictable boot chains and other small tweaks <Simple 😃> <Skip spread> <UC20> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/9313>12:55
mupPR snapd#9315 opened: tests: fix snap-routime-portal-info test <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9315>13:01
cachioijohnson, #9208 has conflicts13:35
mupPR #9208: tests/nested/core20/kernel-failover: add test for failed refresh of uc20 kernel <Run nested> <Test Robustness> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9208>13:35
ijohnsoncachio: ack I see, I will resolve those now13:38
cachioijohnson, nice, thanks13:47
mupPR snapd#9021 closed: snap: implement new `snap reboot` command <UC20> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9021>14:16
mupPR snapd#9316 opened: tests: use full path to test-snapd-refresh.version binary <Simple 😃> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9316>14:16
mupPR snapd#9317 opened: [RFC] devicestate: keep log from install-mode on installed system <Created by mvo5> <https://github.com/snapcore/snapd/pull/9317>14:21
pedronismborzecki: cmatsuoka: 9300 seems to have passed all relevant tests, still needs the 2nd review14:29
mupPR snapcraft#3278 closed: cli: client side check for setting default tracks <enhancement> <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3278>14:35
mborzeckipedronis: cmatsuoka: since it's green, and if 2nd review comments on cosmetics/messages, i think we should land it and do a simple followup with the tweka14:36
mborzeckis/tweka/tweaks/ ofc14:40
=== popey8 is now known as popey
mvopedronis, mborzecki, cmatsuoka I have one more meeting, then I should be able to have a look15:00
mvo(unless someone else beats me to it :)15:00
cmatsuokamvo: thanks, it would be great if you could have a look15:06
* cmatsuoka will return after lunch15:11
ijohnsonone question on 930015:14
ijohnson(left in the PR that is)15:14
pedronisijohnson: I answered15:16
* cachio lunch15:16
ijohnsonpedronis: I +1d 9300, not sure if you still want someone else like mvo to +1 it, I have not kept up to date on all the resealing pr's this week15:37
pedronisat this point I think we should land it and cmatsuoka can work on the small follow ups, and the next ones. OTOH if mvo has time to post-review it that's also welcome15:40
mvosure, let's land it15:41
mupPR snapd#9312 closed: o/snapstate: disk space check with snap update <Disk space awareness> <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9312>15:46
mupPR snapd#9314 closed: o/snapstate: disk space check on UpdateMany <Disk space awareness> <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9314>15:46
mupPR snapd#9300 closed: boot: build bootchains data for sealing <Run nested> <UC20> <Created by cmatsuoka> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9300>15:51
mupPR snapd#9310 closed: tests: remove "set -e" from function only shell libs <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9310>15:51
mupPR snapd#9294 closed: o/snapstate: check available disk space in RemoveMany <Disk space awareness> <Needs Samuele review> <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9294>16:01
mupPR snapd#9318 opened: .github/workflows/test.yaml: also run 20.04 nested tests with UC20 label <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9318>16:06
mvopedronis: I get dinner now, please let me know if I can do anything after dinner, I will read backlog16:07
pedronismvo: I think we need more code from cmatsuoka before anything else16:16
mvopedronis: ok, thanks, I will just read backlog then :)16:18
pedroniscmatsuoka: I don't know if you noticed yet, but 9032 itself needs update because of the change to the params16:24
pedronisto support trees16:25
cmatsuokapedronis: I'll check16:25
pedronisit's fascinating, it doesn't conflict, but then it gets unhappy about types16:25
cmatsuokapedronis: ah yes, that's true, I'll open a PR with the small fixes for 9300 and fix 903216:26
* mvo hugs cmatsuoka and pedronis 16:26
zyga-mbpI think pedronis deserves a day off, at least, for recent crunch16:30
zyga-mbphe seems to work in all the timezones at once16:30
cmatsuokazyga-mbp: and all the complex subsystems16:31
mupPR snapd#9319 opened: seal: error message and function name adjusts <UC20> <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/9319>16:31
zyga-mbpthat was a given16:32
zyga-mbptoday is a bit more patchy, with errands and now remote school meeting16:33
zyga-mbpgosh if we ever complain about hangouts or anything like that16:33
zyga-mbptry putting 30 parents with poor tech know-how16:33
zyga-mbpand have them achieve anything16:33
cmatsuokabeen there16:33
ijohnson#9208 is ready for a review, I de-conflicted it now16:34
mupPR #9208: tests/nested/core20/kernel-failover: add test for failed refresh of uc20 kernel <Run nested> <Test Robustness> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9208>16:34
ijohnsoncachio: ^16:34
cachioijohnson, tx16:34
pedronis#9319 should have had skip spread16:41
mupPR #9319: boot: in seal.go adjust error message and function names <UC20> <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/9319>16:41
pedronisijohnson: ^ should be quick to review, and has the comment you asked now16:50
* pedronis dinner16:50
pedronisnow GH is sending (resending?) old emails ??17:26
cmatsuokahmm I didn't receive anything strange from GH recently17:34
zyga-mbpneither did I17:35
mupPR snapd#9320 opened: boot: group SealKeyModelParams by model <UC20> <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/9320>17:37
cmatsuokaafk for a short while, /me completely forgot to pay some bills yesterday17:40
cachiomvo, I see that is really weird17:42
cachiomvo, starting stopping many times until it reaches the limit17:43
mupPR snapd#9319 closed: boot: in seal.go adjust error message and function names <Skip spread> <UC20> <Created by cmatsuoka> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/9319>18:02
pedroniscmatsuoka: I reviewed 9032, my remark can probably be addressed in a follow up18:08
cmatsuokapedronis: thanks, I'll check18:09
pedroniscmatsuoka: are you assuming we land #9320 (I didn't think it was urgent) ?18:22
mupPR #9320: boot: group SealKeyModelParams by model <UC20> <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/9320>18:22
mupPR snapd#9321 opened: cmd/snap/model: specify grade in the model command output <Simple 😃> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9321>18:22
cmatsuokapedronis: not urgent, I prepared it because it looked easy enough18:22
cmatsuokapedronis: now working on the new reseal call18:23
mupPR snapd#9032 closed: secboot: add call to reseal an existing key <UC20> <Created by cmatsuoka> <Merged by cmatsuoka> <https://github.com/snapcore/snapd/pull/9032>19:19
* zyga-mbp works on a few more tests19:38
cachioijohnson, hey19:44
cachioI am checking basic20 test which fails19:45
cachioand see this19:45
cachioMATCH '# Snapd-Boot-Config-Edition: [0-9]+' < /run/mnt/ubuntu-seed/EFI/ubuntu/grub.cfg19:45
cachiothe check fails19:45
cachioijohnson, but, it metches19:46
cachioMATCH '# Snapd-Boot-Config-Edition: [0-9]+' < /boot/grub/grub.cfg19:46
ijohnsoncachio those are two different files19:48
ijohnsonOne is /boot/grub/grub.cfg and the other is /run/mnt/ubuntu-seed/EFI/ubuntu/grub.cfg19:48
ijohnsoncachio which test is this19:49
cachiothe check for /run/mnt/ubuntu-seed/EFI/ubuntu/grub.cfg is failing19:50
cachioijohnson, https://paste.ubuntu.com/p/25wQdj2qFW/19:50
ijohnsoncachio so this test will only work if the image that was created was flashed with a new enough snapd used by ubuntu-image19:51
ijohnsoncachio how was that image built?19:52
cachioijohnson, I build that today, using beta19:52
cachioijohnson, should I update snapd?19:53
ijohnsoncachio you need to point ubuntu-image to snapd from your system with an env var19:53
ijohnsoncachio set UBUNTU_IMAGE_SNAP_CMD=$(which snap)19:54
pedroniscmatsuoka: how it's going? any problems?19:54
ijohnsonThen call ubuntu-image19:54
cachioijohnson, ahh, nice, I'll retry with that19:55
cmatsuokapedronis: I did reseal, now I'm running a quick test before opening the PR19:55
cachioijohnson, thanks19:55
ijohnsoncachio just to be on the safe side try with snapd from edge or beta on your host too19:56
cmatsuokaand... it failed! for some reason19:57
* cmatsuoka investigates19:57
zyga-mbpfar fewer failures20:00
zyga-mbpbut some bugs still remain,20:00
zyga-mbpI think snapstate.Info description is misleading20:00
zyga-mbpit doesn't work for snaps that are not in state20:00
cmatsuokaI think i just can't do what I'm trying to do (resealing just after sealing)20:02
zyga-mbpcmatsuoka: do you think the TPM does not support that?20:03
cmatsuokazyga-mbp: I think we lock the tpm after we seal because reseal can't even open it20:03
mupPR snapd#9322 opened: boot: add call to reseal an existing key <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/9322>20:04
cmatsuokaalso closing the previous PR that did the same thing20:05
zyga-mbpbrb, need to restart wifi20:08
mupPR snapd#9287 closed: secboot: reseal key to parameters specified in modeenv <UC20> <⛔ Blocked> <Created by cmatsuoka> <Closed by cmatsuoka> <https://github.com/snapcore/snapd/pull/9287>20:09
cachioijohnson, I also see this change https://paste.ubuntu.com/p/Vft4S47VP4/20:11
cachiowhich fails20:11
cachioit should be fixed whith the new snapd?20:11
ijohnsoncachio: no that test needs to be updated for external systems20:12
cachioor I need to update the test20:12
ijohnsoncachio: that test depends on the image used20:12
cachioijohnson, ok20:12
cachioyes, makes sense20:12
zyga_2K insertions20:14
zyga_I need about 500 more to finish20:14
mupPR snapd#9248 closed: exportstate: add scaffolding for the export manager <Needs Samuele review> <Created by zyga> <Closed by zyga> <https://github.com/snapcore/snapd/pull/9248>20:14
mupPR snapd#9323 opened: snap/naming: upgrade TODO to TODO:UC20 <Simple 😃> <Skip spread> <Created by zyga> <https://github.com/snapcore/snapd/pull/9323>20:14
cachioijohnson, do you know where I can get the info to check snap recovery?20:16
ijohnsoncachio: the info comes from the model assertion and the recovery system label20:16
cachioijohnson, and do we store that in a file?20:19
ijohnsoncachio: the 2nd column in the output of `snap recovery` will match the output of the brand from `snap model`20:19
ijohnsoncachio: the 3rd column will match the output of `snap model | grep model`20:19
cachioijohnson, nice20:19
cachioI'll get the info from there20:20
cmatsuokazyga-kaveri: ha, the tpm device was left open after sealing20:26
cmatsuokaand now it works20:28
zygatime for spread20:46
zygaI have one unit test failure but debugging some of the state engine failures is a bit mysterious20:46
zygabut that's okay, let's see what spread shows20:46
* cachio afk20:47
mupPR core18#169 opened: snapcraft.yaml: use build-base for modern snapcraft, and use lxd in travis to build the snap <Created by anonymouse64> <https://github.com/snapcore/core18/pull/169>20:54
mupPR snapd#9323 closed: snap/naming: upgrade TODO to TODO:UC20 <Simple 😃> <Skip spread> <Created by zyga> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/9323>21:04
mupPR snapd#9324 opened: secboot: adjust parameters to buildPCRProtectionProfile <Simple 😃> <UC20> <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/9324>21:04
ijohnsonnp, thanks for fixing it :-)21:05
zygaI know what to do next21:13
mupPR snapd#9325 opened: strutil: add SortedListsUniqueMerge <Created by pedronis> <https://github.com/snapcore/snapd/pull/9325>21:24
zygaok, no unit test failures,21:30
zygaa few XXXes21:30
zygarunning spread again21:30
zygashould be all green now21:30
pedronisijohnson: cmatsuoka: I worked a bit more on #9320, it has more tests for some of things in the previous PRs, it needs #932521:34
mupPR #9320: boot: group SealKeyModelParams by model, improve testing <Run nested> <UC20> <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/9320>21:34
mupPR #9325: strutil: add SortedListsUniqueMerge <Created by pedronis> <https://github.com/snapcore/snapd/pull/9325>21:34
cmatsuokapedronis: ack, checking21:34
zygapedronis what does sh stand for?21:35
pedroniswhere ?21:35
zygaline 7921:35
mupPR #9325: strutil: add SortedListsUniqueMerge <Created by pedronis> <https://github.com/snapcore/snapd/pull/9325>21:35
pedronisyes, size21:36
* zyga reads sz as sh due to the pronounciation in his language which sometimes makes things confusing21:37
zygapedronis why the else at the end21:48
zygacannot we drain both lists?21:48
zygaonly one would be21:48
zygaI'll wait for tests to finish21:53
zygaand run one more overnight21:53
zygaI'm mainly interested in seeing core tests21:53
zygatomorrow the last stretch to complete this21:53
pedroniszyga: yes, if they are both true we would still be in the previous loop21:54
zyganice code :)21:54
cmatsuokaafk, phone call22:02
pedronisijohnson: I commented on your note in the standup, the difference between snap recovery and snap model is expected22:02
pedroniswe have the same difference in other places (is the difference between list vs info-like output)22:03
pedroniscmatsuoka: I missed you had opened #932222:04
mupPR #9322: boot: add call to reseal an existing key <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/9322>22:04
mupPR snapd#9326 opened: tests: fix for basic20 test running on external backend and rpi <Simple 😃> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9326>22:05
cmatsuokapedronis: and now I noticed it failed the macos test, probably something related to nosecboot22:05
pedroniscmatsuoka: looks good looking quickly, but one comment, I will look closer in the morning22:07
cmatsuokapedronis: ok, thanks, I'll see the macos and the other issue you raised in a moment, I need to make a few phone calls first22:07
pedronisthx, calling it a day22:08
zygagood night pedronis22:10
=== secretfader49 is now known as fader

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!