mup | Issue operator#402 opened: Allow way for harness to trigger upgrade-charm event <Created by hloeung> <https://github.com/canonical/operator/issues/402> | 08:55 |
---|---|---|
Chipaca | belated good morning, all | 09:17 |
* Chipaca ← toothache :-( | 09:17 | |
bthomas | Morning Chipaca | 09:18 |
bthomas | Clove oil applied topically can give temporary relief from the pain if brufen does not work. | 09:19 |
Chipaca | ibuprofen seems to be helping | 09:24 |
bthomas | Is the "start" Charm hook only run after the *first* config-changed hook ? In other works the is the start hook, like the install hook run only once in the charm's lifecycle ? | 09:48 |
bthomas | s/works/words/ | 09:48 |
axino | facubatista: updated my MP with fixes as per your review | 09:54 |
axino | thanks ! | 09:54 |
mthaddon | bthomas: https://discourse.juju.is/t/charm-hooks/1040 might be useful | 10:13 |
mthaddon | I read that as saying yes, it's only run once in a unit's lifecycle | 10:14 |
bthomas | mthaddon: I am adpating that document for the purposes of creating documentation for the Operator Framework. | 10:14 |
mthaddon | ack | 10:14 |
bthomas | mathaddon : thanks | 10:14 |
Chipaca | off to the friday school run. wish me luck... | 14:13 |
Chipaca | (first full week of 'normal' school! teachers are going to want to have a word) | 14:14 |
* bthomas wishes Chipaca all the luck | 14:17 | |
justinclark | bthomas the configmap problem you mentioned yesterday is the issue. Now everything works as expected. I'm not sure if I like my solution. Thoughts? <Chipaca> off to the friday school run. wish me luck... | 14:35 |
justinclark | <Chipaca> (first full week of 'normal' school! teachers are going to want to have a word) | 14:35 |
justinclark | * bthomas wishes Chipaca all the luck | 14:35 |
justinclark | Oops - I must have inadvertently copied the previous text.. Good luck Chipaca! haha | 14:35 |
justinclark | Here's the link: https://github.com/justinmclark/grafana-charm-base/blob/296d94229e9f209390eb6aba355824bd3349cb89/src/charm.py#L524 | 14:35 |
bthomas | justinclark: working is good. The rest we can talk to Chipaca, facundo and jam | 14:36 |
bthomas | justinclark: I had a quick look and can see you are using "pod_change_var". This is fine. But if you are unhappy with it you can always try adding a k8s label . For example a label such as "prometheus" with a value "associated" or "un-associated" or anything like that you find reasonable. What I am not sure is how k8s labels are set in Juju Pod spec. | 14:40 |
* bthomas notes another thing (juju to k8s pod spec) to document or link into charmhub docs | 14:41 | |
justinclark | I thought of using labels or annotations also but I didn't see clear documentation on whether that's something we can add in the Juju pod spec. I'll bring this up in standup and see if there are other ideas. | 14:41 |
bthomas | sounds like a plan | 14:42 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!