[04:20] <wallyworld> tlm: or hpidcock: or kelvinliu: a small constraints PR https://github.com/juju/juju/pull/12020
[04:27] <hpidcock> wallyworld: looking
[04:45] <kelvinliu> wallyworld: got this pr for adding priority and priority, could u take a look plz https://github.com/juju/juju/pull/12022  thanks
[04:46] <wallyworld> i cam
[04:46] <kelvinliu> also tested updateStrategy
[04:49] <wallyworld> kelvinliu: lgtm, tyvm
[04:51] <kelvinliu> wallyworld: as i can see, i tested updatestrategy working as expected, im not sure why cory got that parsing error, probably he wasn't using 2.8+?
[04:51] <wallyworld> kelvinliu: yeah, i believe he was using 2.8.1 or something
[05:14] <kelvinliu> tlm: https://github.com/juju/juju/pull/12015 got this pr for caas firewaller worker for embedded apps, there are a few todos in the pr will be implemented in following prs, could u take a look plz? thanks
[05:25] <wallyworld> looking
[05:41] <wallyworld> kelvinliu: lgtm with a question about the api calls
[05:44] <kelvinliu> wallyworld: right, I will change the CharmInfo(url string) to CharmInfo(appName string)
[05:45] <wallyworld> ty
[05:46] <kelvinliu> thx for reviewing
[08:02] <taohansen> I'm trying to wrap my head around Juju: is Juju Charmed Kubernetes? Why would I want Juju over microk8s? Juju can consume microk8s to make a Juju cloud but I don't know specifically why I would want to do this. "A cloud is a target that Juju knows how to manage workloads for. " But Kubernetes is already a tool for managing workloads across pods and nodes.
[08:02] <taohansen> It looks like Charms are equivalent to Helm Charts. Is this a fair assumption?
[08:24] <icey> that's a new one: `Create instance: Invalid devices: Device validation failed "eth1": Invalid value for device option "mtu": Out of MTU range (1280-9202) "9214"`
[10:03] <stickupkid> manadart, fixes the documentation issue https://github.com/juju/juju/pull/12023
[10:04] <manadart> stickupkid: Nice.
[10:04] <stickupkid> not like me to miss documentation :|
[10:30] <achilleasa> stickupkid: yet another one... cursed yaml! https://github.com/juju/bundlechanges/pull/70
[10:46] <achilleasa> stickupkid: small fix for an NPE in charm that I discovered while testing: https://github.com/juju/charm/pull/320
[10:55] <manadart> stickupkid: Small one - https://github.com/juju/juju/pull/12024. achilleasa, having trouble with my Microstack; wanted to get this one up before a reboot. Be back on your review presently.
[10:56] <achilleasa> manadart: did you get it to work out of the box with snap?
[10:56] <achilleasa> I had to use the edge with --devmode and add an ip to get it to init
[10:57] <stickupkid> achilleasa, https://github.com/juju/juju/pull/11253/files#diff-a86032d7aeab77815b81f23cdfb46921
[10:58] <achilleasa> stickupkid: I also had to "ip add X 10.20.20.1" to allow it to find rabbit
[11:11] <manadart> achilleasa: Yeah, I had the same issue. No change from when it was last working, but I lost the device addresses.
[11:12] <manadart> Then I hung on configuring the bootstrap machine...
[11:12] <manadart> Back up all fresh, see how it goes.
[11:16] <achilleasa> manadart: if you set up spaces and stuff please also try the last step in the QA (moving subnets)
[11:17] <manadart> achilleasa: Yeah, I was also going to delete a space. How would that go?
[11:22] <achilleasa> it should also work because the space-id in the subnets collection will change
[11:22] <achilleasa> and it will trigger a refresh of the rules
[12:44] <achilleasa> stickupkid: just pushed the PR for including expose settings in diff-bundle output. If you 've got some spare time can you take a look at https://github.com/juju/juju/pull/12025?
[12:44] <stickupkid> won't be till after standup tbh
[12:45] <achilleasa> not in a rush. just wanted to get all remaining chunks of work up for review today as next week I won't be able to work on this
[12:46] <achilleasa> that's the last PR though. Now I need to write a discourse post about it :D
[13:29] <stickupkid> manadart, fixes your issue with acceptance tests https://github.com/juju/juju/pull/12026
[13:44] <jam> Quick review of 2.8 into develop ? https://github.com/juju/juju/pull/12027
=== kirkland is now known as Guest82000
[14:35] <stickupkid> hml, so I've gone back to juju 2.0 and .Update has never been used to set a charm 4ddfc7da4fa771621e5f2a87492e1c6e6f068675
[14:36] <stickupkid> hml, so it was probably used for something, but not sure what tbh
[14:36] <stickupkid> hml, maybe future planning?
=== tamas_erdei is now known as terdei
[14:40] <hml> stickupkid:  no idea…. maybe it was a juju 1 ism?
[14:40] <stickupkid> hml, I just wanted to be sure, but we're all good
[14:41] <hml> stickupkid:  +1
[14:47] <hml> stickupkid:  have we done any upgrade juju testing on the charm origins?
[14:47] <stickupkid> hml, not for a long time
[14:47] <stickupkid> hml, we should do that
[14:48] <hml> stickupkid:  same thoughts
[14:49] <stickupkid> hml, in theory https://github.com/juju/juju/blob/develop/state/upgrades.go#L3108
[14:49] <hml> :-)