=== MmikeM is now known as Mmike
[15:42] <hml> stickupkid: a quick review please? https://github.com/juju/juju/pull/12037
[15:42] <stickupkid> hml, swap you, although I'm unsure what the correct Q&A steps are... I totally forgot about this piece
[15:43] <hml> k
[15:43] <stickupkid> https://github.com/juju/juju/pull/12038
[15:45] <hml> stickupkid: i’m thinking we can review and merge 12029 while waiting for the download bug to be resolved?  or shall i pull out the extra debugging.  it’s handy
[15:45] <stickupkid> hml, land it
[15:46] <stickupkid> hml, propose it, I'll approve, we've both tested it
[15:49] <stickupkid> hml, you need to rebase to force github actions to run
[15:49] <hml> stickupkid: is there a way to get the github action pieces required for landing to run after moving a PR from wip to real?  besides pushing another commit?
[15:50] <hml> darn it.
[16:11] <hml> stickupkid: you need to use GetCharmURLOrigin instead of GetCharmURL so that we have the ID used when the charm was installed.  could be a follow on to 12038?
[16:11] <stickupkid> hml, exactly
[16:12] <stickupkid> hml, read my thoughts, I just wanted to have it wired up first
[16:12] <hml> stickupkid: gotcha
[16:12] <hml> stickupkid:  my eyes are starting to cross with this stuff.  :-D
[16:13] <hml> stickupkid: and the follow on will include the SetCharm updates too then.  gotcha
[16:18] <stickupkid> hml, yeah, will have too
[16:19] <stickupkid> hml, otherwise the PR will get bigger and bigger
[16:21] <hml> yes, a better choice.