| * bthomas needs more coffee to work through framework code :) | 10:13 | |
| facubatista | ¡Muy buenos días a todos! | 11:12 |
|---|---|---|
| bthomas | नमस्ते facubatista | 11:17 |
| facubatista | hola bthomas | 11:19 |
| Chipaca | why wouldn't pytest's ApproxScalar have a __bool__ that raised an exception, to help people not do what i did | 12:18 |
| jam | Chipaca, because all types implement __bool__ in ways that seem "good enough" ? like "if 2.23424" :) | 13:32 |
| facubatista | Chipaca, is your PR #408 ready for re-review? | 13:45 |
| mup | PR #408: These changes make it so that the test suite passes on Windows <Created by chipaca> <https://github.com/canonical/operator/pull/408> | 13:45 |
| Chipaca | facubatista: yes | 13:45 |
| facubatista | Chipaca, related, do we expect for people to use "old juju" in windows? | 13:47 |
| facubatista | I mean, can we get away with saying "only dispatch in windows"? | 13:47 |
| Chipaca | facubatista: maybe, why? | 13:48 |
| mup | PR operator#411 opened: make model.config immutable <Created by chipaca> <https://github.com/canonical/operator/pull/411> | 13:48 |
| facubatista | Chipaca, maybe it makes the code simpler? didn't explore it enough | 13:49 |
| facubatista | Reviews appreciated! https://github.com/canonical/charmcraft/pull/153 | 14:00 |
| mup | PR charmcraft#153: Adjust help messages in all cases to UX indications <Created by facundobatista> <https://github.com/canonical/charmcraft/pull/153> | 14:00 |
| * facubatista -> short errands | 14:02 | |
| * facubatista is back | 14:29 | |
| bthomas | Just an FYI: I am going to clean up my hooks doc now/tonight, removing all todos and writing as much as I can (even if partially complete). Things I have already written are unlikely to change. I will not make any changes tomorrow so it can be reviewed then and changed as per review. | 16:00 |
| Chipaca | bthomas: thanks for the heads-up | 16:01 |
| axino | Chipaca: answer to my "mocking StoredState() in __init__" of the other day : https://git.launchpad.net/charm-k8s-gunicorn/tree/tests/unit/test_charm.py?id=1fba68c784b3647526c1bab017b3663b4886da5a#n42 | 16:03 |
| axino | question** of the other day | 16:03 |
| Chipaca | axino: seems reasonable to me, yes? | 16:12 |
| axino | Chipaca: indeed, indeed | 16:13 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!