| wallyworld | hpidcock: tags create on juju/utils, also a request to delete obsolete packages for v2 | 00:31 |
|---|---|---|
| hpidcock | wallyworld: thanks | 00:31 |
| hpidcock | wallyworld: did you want a take a quick look at the final changes I made https://github.com/juju/utils/pull/313 ? | 00:48 |
| wallyworld | ok | 00:48 |
| wallyworld | hpidcock: awesome, good to see that old stuff gone, will make auto completion of imports much nicer | 00:50 |
| hpidcock | wallyworld: ok will make a PR for develop now | 00:50 |
| hpidcock | wallyworld: can you do a $$merge$$ on that project, looks like for some reason its not responding to me | 00:54 |
| hpidcock | wait | 00:55 |
| hpidcock | all good | 00:55 |
| wallyworld | merged! | 00:56 |
| hpidcock | wallyworld: https://github.com/juju/juju/pull/12039 | 01:02 |
| hpidcock | please and thankyou | 01:02 |
| wallyworld | looking | 01:02 |
| wallyworld | hpidcock: lgtm, ty | 01:12 |
| hpidcock | wallyworld: thanks | 01:13 |
| hpidcock | wallyworld: sorry there is more https://github.com/juju/names/pull/106 | 01:20 |
| wallyworld | np looking | 01:20 |
| wallyworld | lgtm | 01:22 |
| hpidcock | thanks | 01:22 |
| hpidcock | wallyworld: hah wow, yes there is more, thank-you again https://github.com/juju/testing/pull/153 | 01:29 |
| wallyworld | sure | 01:31 |
| wallyworld | hpidcock: lgtm, i'm sure there will be more | 01:32 |
| === niemeyer_ is now known as niemeyer | ||
| wallyworld | kelvinliu: we finally get to remove roacle classic provider https://github.com/juju/juju/pull/12043 | 05:46 |
| kelvinliu | looking | 05:47 |
| wallyworld | tyvm | 05:48 |
| kelvinliu | wallyworld: lgtm, huge and simple lol | 05:48 |
| hpidcock | wallyworld: today is a good day to delete code | 06:12 |
| wallyworld | it is, the more the better | 06:12 |
| stickupkid | hml, https://github.com/juju/juju/pull/12046 | 15:09 |
| hml | stickupkid: looking | 15:10 |
| hml | stickupkid: approved | 15:10 |
| === _thumper_ is now known as thumper | ||
| stickupkid | hml, can you CR this https://github.com/juju/juju/pull/12044 | 16:42 |
| === evhan` is now known as evhan | ||
| wallyworld | kelvinliu: can you recall why the restriction was add so that for a podspec, the primary service account for the pod can only have one role? "the prime service can only have one role or cluster role" | 23:40 |
| kelvinliu | wallyworld: initially, it was a slice as i remembered, | 23:42 |
| wallyworld | it is, so why do we allow only 1 for the primary service account? | 23:42 |
| wallyworld | there was a reason but i can't recall | 23:43 |
| wallyworld | and there's this bug 1896076 | 23:43 |
| mup | Bug #1896076: Pod_spec : cannot apply namespaced role and cluster role to a serviceaccount <juju:New> <https://launchpad.net/bugs/1896076> | 23:43 |
| kelvinliu | wallyworld: u prefer we only have one :) | 23:43 |
| wallyworld | not sure what the thinking was there | 23:44 |
| wallyworld | can you see a reason not to have > 1? | 23:44 |
| wallyworld | i can do a quick PR to fix it for 2.8.4 | 23:44 |
| kelvinliu | the idea was to make it simpler and cleaner | 23:44 |
| kelvinliu | I don't see a reason not to have 1+ | 23:46 |
| wallyworld | ok, will do a quick PR | 23:46 |
| kelvinliu | just need to ensure the names of the bindings | 23:47 |
| kelvinliu | have to uniq and no conflicts | 23:48 |
| wallyworld | maybe that was it | 23:48 |
| kelvinliu | nah, we had proper naming for that | 23:48 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!