=== niemeyer_ is now known as niemeyer
[08:07] <Chipaca> morning all
[08:55]  * Chipaca starts pronouncing 'lifecycle' to rhyme with 'bicycle'
[09:40] <Chipaca> bthomas: why do you like, commas so much 🙂
[09:42] <bthomas> Good point Chipaca :-). I tend to write long complex statements. I was hammered by my dissertation advisor to break them down into smaller statements or use commas for pause. Looks like both you and facundo have indigetion with the consumption of so many commas, so I will cede to the democratic will here :-). Do let me know if the sentenses are complex I will break them down.
[09:44] <bthomas> Chipaca: My biggest concern is this. All the big edits suggested by you and facundo I can make it both in the google docs and my local markdown copy. I will try to do the same with the commas too, but not having a robotic attention span this can be error prone. I am not sure what our process will be to convert these docs in to web format.
[09:44] <Chipaca> bthomas: i agree you should break long statements into shorter ones, but sprinkling commas at random is rarely the right approach
[09:45] <Chipaca> bthomas: once you asked us to review the google doc, your local copy became irrelephant
[09:45] <bthomas> ok
[09:49] <Chipaca> bthomas: WRT commas, maybe http://www.hemingwayapp.com/ helps?
[09:51] <bthomas> Chipaca: That is very cool. I will use it next time. BTW I like Hemingway and John Steinback.
[09:52] <Chipaca> bthomas: i'm pausing my editing for a while, if you want to review
[09:53] <Chipaca> (don't remove the CHECKPOINT comment so i can continue)
[09:53] <bthomas> Chipaca: on it now
[10:15] <bthomas> Chipaca: Do we have a preference in terms - Application or Charm. I can't decide. Pick one.
[10:15] <Chipaca> bthomas: they are not equivalent
[10:15] <bthomas> Chipaca: There is one subtly though the Charm manages the application.
[10:15] <bthomas> Indeed I was just typing.
[10:15] <bthomas> ok let give it a thought
[10:16] <Chipaca> bthomas: yes, a charm drives an application, inside a unit -- but juju's "application" is a collection of units
[10:16] <Chipaca> bthomas: so in general i'd talk about the charm, and only use application when it is very clear which of these two you mean
[10:16] <bthomas> ok
[10:42] <mup> PR operator#412 opened: add __repr__ for EventBase, LazyMapping, and RelationData <Created by chipaca> <https://github.com/canonical/operator/pull/412>
[11:11] <mup> PR operator#413 opened: bail out of main() if use_juju_for_storage=True and unsupported <Created by chipaca> <https://github.com/canonical/operator/pull/413>
[11:38] <facubatista> ¡Muy buenos días a todos!
[12:00] <Chipaca> facubatista: 👋❗
[12:01] <facubatista> hola Chipaca
[12:01]  * bthomas is skipping overtures today - hard at work with docs :-)
[12:04] <Chipaca> could i get reviews for #412? got another pr coming based on it and would rather not have to do the rebase dance
[12:04] <mup> PR #412: add __repr__ for EventBase, LazyMapping, and RelationData <Created by chipaca> <https://github.com/canonical/operator/pull/412>
[12:05] <Chipaca> (and it's super easy as reviews go)
[12:12] <mup> Issue operator#414 opened: Ensure all code has proper docstrings <Created by facundobatista> <https://github.com/canonical/operator/issues/414>
[13:02]  * bthomas -> lunch 
=== deej` is now known as deej
[15:12] <Chipaca> facubatista: WDYT WRT pydocstyle in test_infra?
[15:15] <Chipaca> hml: 👋
[15:15] <hml> Chipaca: hi
[15:15] <Chipaca> hml: facubatista is probably the person you want to chat with :)
[15:15] <hml> Chipaca: ty!
[15:16] <hml> facubatista: i’m trying to charmcraft release to a track/risk combo… but i get “Store failure! Invalid track: testme
[15:16] <hml> for whatever track i say
[15:16] <hml> release to a risk is fine
[15:17] <hml> am i missing a step?
[15:17] <facubatista> hml, you can not create tracks at will, it's a errand you need to Store people to enable it to you
[15:17] <hml> facubatista: interesting.  i had no idea.
[15:17] <Chipaca> facubatista: poor will
[15:18] <facubatista> hml, you would need to create a new topic here asking for that, IIRC: https://forum.snapcraft.io/
[15:18] <facubatista> (probably there would be something similar for charms in the future, I don't think there's a process in stone for charms yet)
[15:18] <Chipaca> facubatista: that's just for now, right? later tracks for charms would be requested in a more charming place :)
[15:18] <hml> facubatista: okay.
[15:18] <Chipaca> right
[15:19] <hml> i’m trying to do juju dev/testing, so more complicated channel release info is needed for my test charms
[15:24] <Chipaca> hml: https://forum.snapcraft.io/t/process-for-aliases-auto-connections-and-tracks/455/1
[15:25] <Chipaca> hml: i'm guessing that's what facundo is suggesting you do
[15:34] <hml> a suggestion - an error message telling you to get the track approved and added would be helpful!
[15:35] <hml> instead of an error  of invalid track.
[16:01]  * facubatista -> lunch
[16:42] <bthomas> facubatista: when you are back can we have a quick 1:1 10 min.
[16:43] <bthomas> Chipaca: are you planning to doing the rest of review today or when you are back next week ?
[16:43] <Chipaca> bthomas: i'll do it tonight
[16:43] <Chipaca> if that's ok
[16:44] <bthomas> Chipaca: That is good, if possible but don't strain yourself. Since then we can save the reviewed doc for future use and then remove sections facubatista would prefer to have removed. Thereby we would not need to do a second review in the future when we put them back (hopefully :-) ).
[16:46] <bthomas> should add if we put them back :)
[16:54] <Chipaca> I could use a 2nd review for #412 as it has a followup
[16:54] <mup> PR #412: add __repr__ for EventBase, LazyMapping, and RelationData <Created by chipaca> <https://github.com/canonical/operator/pull/412>
[16:55] <bthomas> Chipaca: having a look
[16:56] <bthomas> Chipaca: this reminds me it would be nice to have and string or machine readable representation for the event descriptor "on" . Something that lists the events currently supported.
[16:56] <Chipaca> bthomas: intersting idea. file an issue for it plz
[16:57]  * facubatista is back
[16:57] <Chipaca> there might be complications but it's worth exploring
[16:57] <bthomas> Chipaca: will do
[17:01] <bthomas> facubatista: are you free for a couple of mins
[17:01] <facubatista> bthomas, sure
[17:01] <bthomas> stand up hangout 10 mins . going now
[17:02] <bthomas> facubatista: waiting for you
[17:02] <mup> Issue operator#250 closed: Improve __str__ of developer exposed objects <bug> <Created by facundobatista> <Closed by chipaca> <https://github.com/canonical/operator/issues/250>
[17:02] <mup> PR operator#412 closed: add __repr__ for EventBase, LazyMapping, and RelationData <Created by chipaca> <Merged by chipaca> <https://github.com/canonical/operator/pull/412>
[17:07] <mup> PR operator#415 opened: Log event deferral and reëmission <Created by chipaca> <https://github.com/canonical/operator/pull/415>
[17:08]  * Chipaca runs away
[17:12]  * bthomas switch to non-work laptop
[17:25] <hml> is it possible to upload a bundle via charmcraft?  if so, how to a contruct the files to be uploaded
[17:30] <facubatista> not yet
[17:33] <hml> facubatista: is there an eta on that?  do you know if there is another wya to get a bundle into charmhub?
[17:33] <facubatista> hml, no ETA, this is the issue where we track it: https://github.com/canonical/charmcraft/issues/128
[17:33] <hml>  facubatista  ty
[17:34] <hml> facubatista:  different topic, how do i set a version?  i put a version file in the charm directory and did charmcraft build and upload, but the version was set to the same as the revision, not what i set it too
[17:36] <facubatista> interesting, let's see that
[17:39] <hml> facubatista:  https://paste.ubuntu.com/p/Dtb249ycyB/
[17:50] <facubatista> hml, can you confirm that you do NOT have a "version" file in the "build" directory, please?
[17:50] <hml> facubatista:  no, I  have a version file.
[17:50] <facubatista> jam, Chipaca, any idea why we are ignoring the "version" file in the build? We have `/version` in the `default_juju_ignore` string
[17:50] <hml> I “DO” have one
[17:51] <facubatista> in the build directory?
[17:51] <facubatista> or in your project's directory?
[17:52] <facubatista> 2020-09-23 14:51:49,717  charmcraft.commands.build      DEBUG    Ignoring file because of rules: 'version'
[17:58] <hml> facubatista:  i’m not up on the terminalogy, it’s in the same directory as the metadata.yaml and where i run charmcraft build from
[17:58] <hml> like in the youtube charmcraft build tutorial
[17:59] <facubatista> hml, no, it's de "build" directory created by charmcraft when you build it
[18:00] <facubatista> hml, alternatively, can you please do `charmcraft -v build` and pass me that, so I can see those logs?
[18:01] <hml> facubatista:  sure.  afaik, the directory is like what’s here:  https://discourse.juju.is/t/tutorial-using-charmcraft-to-build-upload-and-release-charms/3386
[18:03] <hml> facubatista:  here’s the output https://pastebin.canonical.com/p/KxnKXCNzgx/
[18:04] <facubatista> right, line 27 is the problem
[18:05] <hml> facubatista: okay… how do i fix this.  there is no version file in the build directory created when i run charmcraft build.
[18:06] <facubatista> hml, you'd need to... a) hack the charmcraft source code (I can guide you);  b) unzip the .charm, put the file, zip it again, upload it;  or c) wait for Monday
[18:07] <hml> facubatista: rgr.  I’ll go with B.  ty.  should i file a bug? o
[18:08] <facubatista> hml, https://github.com/canonical/charmcraft/issues/165
[18:08] <facubatista> (I already did)
[18:08] <hml> facubatista:  ty!
[18:14] <facubatista> jam, I requested your review on this one, thanks! https://github.com/canonical/charmcraft/pull/166
[18:14] <mup> PR charmcraft#166: Don't ignore important files (like version) by default <Created by facundobatista> <https://github.com/canonical/charmcraft/pull/166>
[18:24] <jam> facubatista, commentedv
[18:26] <facubatista> jam, but charmcraft should fill it itself in the case it's missing, otherwise we're overruling the author, and that's probably always a bad idea
[18:26] <facubatista> if it's there, why not respect it?
[18:27] <jam> facubatista, so 'revision' can also be there, but is almost always wrong/stale. Same for 'version'. If you unpack a .zip of a charm, you would expect it to be there, but if you then reuploaded that, you would not want to take the stale one IMO
[18:30] <facubatista> jam, revision and version are handled diferently; the revision is always indicated by the store, it's an integer, always growing; the version can be any string that the user wants, to represent the proper version of the charm
[18:30] <facubatista> the revision will be incremented on each binary uploaded to the store, the version is author responsibility
[18:31] <facubatista> we're ignoring a posible "revision" file too (don't know why), but in any case the store will not use that for anything; OTOH the store parses and keeps what's in "version"
[18:32] <jam> I'm not opposed to having it, but I'm much more in favor of populating it by the build command.
[18:33] <facubatista> jam, so you say that if the author indicates that version should be X, we go ahead and push to the store something that will end up in version Y? that's super surprising
[18:34] <jam> facubatista, you can warn if you want, but I trust a static file on disk much less than the build process
[18:37] <facubatista> for me it's matter of trusting the author, not the file; if the author would want automatic versioning, she can always remove the file and let charmcraft take charge
[18:37] <facubatista> let's talk about this on Monday with Chipaca
[18:38] <facubatista> I commented this ^ in the PR
[20:53]  * facubatista eods and is off tomorrow, will be back on Friday