| AsciiWolf | rbasak, hi, I will have to update my torbrowser-launcher SRU... there is a new (simple) patch needed since Tor Browser 10.0 release: https://salsa.debian.org/pkg-privacy-team/torbrowser-launcher/-/commit/fa3115fbf6c2d298b12c1ccee8f679c13682c92c | 11:54 |
|---|---|---|
| AsciiWolf | I have already tested the patch and it works fine | 11:55 |
| rbasak | AsciiWolf: sounds good, thanks | 11:55 |
| AsciiWolf | the patch is in Debian Experimental... should I wait until it gets pushed to Debian Testing/Unstable or can I update the SRU now? | 11:56 |
| rbasak | AsciiWolf: could you create a new bug to track the version number situation being broken please | 11:56 |
| rbasak | We need the fix in Groovy before we SRU it | 11:56 |
| rbasak | The bug can track the status of that | 11:56 |
| rbasak | If appropriate, we can sync into Groovy from Debian experimental | 11:56 |
| rbasak | We're in feature freeze in Ubuntu, so we can do that sync only if there are no feature changes | 11:57 |
| rbasak | Otherwise we can fix the bug by cherry-picking the fix into Groovy too | 11:57 |
| AsciiWolf | already did: https://bugs.launchpad.net/ubuntu/+source/torbrowser-launcher/+bug/1896752 :) | 11:59 |
| ubottu | Launchpad bug 1896752 in torbrowser-launcher (Ubuntu) "Version checking error in torbrowser-launcher since Tor Browser 10.0 was released" [Undecided,New] | 11:59 |
| rbasak | Great! :) | 11:59 |
| teward | *was told to look here* | 12:12 |
| teward | *reads* | 12:12 |
| teward | rbasak: worst case I can manually nitpick the patch in and get that in as a bug, if we need to | 12:12 |
| teward | torbrowser's one of the essential tools for cybersecurity people to dissect email spam links,etc so :) | 12:13 |
| teward | (I'm subbed to both bugs now) | 12:13 |
| teward | also thanks AsciiWolf for tolerating my pickyness - after enough years of having rbasak and the rest of the SRU team tell me "none" is not a valid justification, I get picky over it :0 | 12:13 |
| teward | (assuming sync isn't an option) | 12:13 |
| teward | looks like my IRC client sent stuff out of order >.> | 12:14 |
| teward | *kicks his IRC client* | 12:14 |
| AsciiWolf | :) | 12:18 |
| rbasak | teward: thank you for looking at torbrowser-launcher. Shall I leave it to you then please, to arrange with AsciiWolf as needed to get an SRU upload when ready? | 12:33 |
| rbasak | teward: I also have bug 1888749 on my list that I think you sponsored the first time, if you don't mind looking again please? | 12:33 |
| ubottu | bug 1888749 in sup-mail (Ubuntu Focal) "sup-mail broken and unusable after Bionic to Focal upgrade" [Medium,In progress] https://launchpad.net/bugs/1888749 | 12:33 |
| teward | rbasak: yeah, I can handle getting the SRU upload handled/ready when it's ready. | 12:36 |
| teward | so long as you keep the bugs updated with status AsciiWolf (I don't check IRC as much as I should anymore >.>) | 12:36 |
| teward | rbasak: sup-mail is already uploaded but in NEW it seems | 12:37 |
| teward | which means you and AAs need to go poking | 12:37 |
| teward | I:NoMoreActionFromSponsorsRequired | 12:37 |
| teward | unless something happened that I missed? | 12:37 |
| teward | or are you asking me to review and give SRU my blessing on it? | 12:37 |
| ItzSwirlz | Hey guys, any MOTU's available to help me get reviews/sponsors? | 12:38 |
| teward | rbasak: yeah, this is AA/SRU territory now: https://bugs.launchpad.net/ubuntu/+source/sup-mail/+bug/1888749/comments/8 | 12:38 |
| ubottu | Launchpad bug 1888749 in sup-mail (Ubuntu Focal) "sup-mail broken and unusable after Bionic to Focal upgrade" [Medium,In progress] | 12:39 |
| teward | been uploaded there since July, but y'all slacking ;) | 12:39 |
| ItzSwirlz | (IGNORED) | 12:39 |
| ItzSwirlz | :clap: :clap: | 12:39 |
| teward | rbasak: also looks like there was a *second* upload of the same package/version as well later | 12:39 |
| rbasak | teward: ah. I didn't realise it was in NEW. Thanks! | 12:40 |
| teward | rbasak: my two cents: reject the one that Lucas uploaded and accept mine from July if there's no other functional changes | 12:40 |
| rbasak | I will check it over from an SRU perpsective and then see if I can find an AA. | 12:40 |
| teward | rbasak: but yes it's in NEW so up to you guys to handle it | 12:41 |
| teward | ItzSwirlz: you realize we all have about a trillion tasks to handle yes? | 12:41 |
| teward | since we're approaching major freeze points : | 12:41 |
| ItzSwirlz | teward: No need to be toxic here and I TOTALLY understand that (past knowing you) | 12:41 |
| teward | and no that's not me being toxic | 12:41 |
| teward | that's me making a statement | 12:41 |
| ItzSwirlz | But 1) we have already passed about half of our freeze points | 12:41 |
| ItzSwirlz | (I'm the one being toxic maybe) | 12:41 |
| teward | also: | 12:41 |
| teward | > Hey guys, any MOTU's available to help me get reviews/sponsors? | 12:41 |
| teward | you need specifics | 12:41 |
| ItzSwirlz | 2) My patches have been waiting since uhhh lets see | 12:41 |
| teward | not just ask "is anyone available to help with XYZ" | 12:42 |
| ItzSwirlz | Oh yeah theres a queue for that | 12:42 |
| teward | rbasak: ^ your turn | 12:42 |
| ItzSwirlz | Teward I understand but however I'mt rying here to make things easy | 12:42 |
| ItzSwirlz | And at the end of the day if I do want those sponsors for my application it relies on them | 12:42 |
| ItzSwirlz | I hope you understand my point. | 12:43 |
| ItzSwirlz | So am I, approaching our freeze opints | 12:43 |
| ItzSwirlz | And if you think they are all Focal, I have one groovy so /shrug | 12:43 |
| ItzSwirlz | teward: Understood? | 12:45 |
| ItzSwirlz | You do your job and I'll do mine. | 12:45 |
| teward | Detected: hostile-client. Response: Not willing to assist. Your hostility in this matter ain't helping you. | 12:45 |
| teward | *goes to fix a few hundred other things on his radar today including a broken email server for a client* | 12:46 |
| ItzSwirlz | Hos.. tility? huh? | 12:46 |
| ItzSwirlz | Go check the IRC logs | 12:46 |
| ItzSwirlz | That aside, anybody else around? | 12:51 |
| ItzSwirlz | 58 people online, I'd assume about 10 of those are MOTUs, let's not with the dead silence | 12:54 |
| ItzSwirlz | Seriously guys? | 12:57 |
| ItzSwirlz | (dead silence) | 13:20 |
| ItzSwirlz | I continue to wait since 9/15. | 13:29 |
| AsciiWolf | teward, sure, I will keep updating the SRU ticket :) | 14:14 |
| AsciiWolf | I am waiting for the second torbrowser-launcher patch to be added in Groovy, will update the Focal SRU afterwards :) | 14:15 |
| ItzSwirlz | I think you can status track in groovy | 14:16 |
| ItzSwirlz | While nothings happening, is anyone here able to assist me on my Cinnamon DE SRUs? | 14:33 |
| ItzSwirlz | It has been an hour, nor esponse | 15:35 |
| ItzSwirlz | Unbeliavable | 15:35 |
| teward | AsciiWolf: if we want to expedite it I can nitpick the patch (from Experimental) into the package and put it into Groovy | 16:04 |
| teward | (I'm in the midst of poking some things at the moment though) | 16:05 |
| teward | that's relatively trivial | 16:05 |
| AsciiWolf | teward, that would be great, thanks! :-) | 17:05 |
| AsciiWolf | I will update the Focal SRU right after it is patched in Groovy :) | 17:08 |
| teward | AsciiWolf: chances are both SRUs will get updated by me *before* the patch lands in Groovy :P Because the SRU will be both of them (and I can write the debdiffs too, to include both patches) | 17:11 |
| teward | AsciiWolf: chances are both SRUs will get updated by me *before* the patch lands in Groovy :P Because the SRU will be both of them (and I can write the debdiffs too, to include both patches - in some SRU cases we can batch fixes together, like this one) | 17:11 |
| teward | but i have a few things to do first | 17:11 |
| teward | blah i keep forgetting this ain't slack or such | 17:11 |
| AsciiWolf | teward, yay! :) | 17:32 |
| AsciiWolf | thanks! :) | 17:33 |
| teward | yep, i'm in the middle of things right now so can't address it yet | 17:33 |
| AsciiWolf | :)) | 17:33 |
| teward | AsciiWolf: is the key issue also an issue in Groovy? | 17:33 |
| AsciiWolf | yup | 17:33 |
| teward | ok | 17:34 |
| teward | i'll address both. | 17:34 |
| AsciiWolf | but Focal needs one more patch, see: https://bugs.launchpad.net/ubuntu/+source/torbrowser-launcher/+bug/1896085 | 17:34 |
| ubottu | Launchpad bug 1896085 in torbrowser-launcher (Ubuntu) "[SRU] Backport patch to update Tor Browser Developers public key into Ubuntu 20.04" [Undecided,New] | 17:34 |
| AsciiWolf | teward, feel free to use my SRU bug ticket if you want :) | 17:44 |
| teward | oh i intend to :P | 17:58 |
| teward | AsciiWolf: i know i'm subbed to both bugs ;) | 17:58 |
| teward | Groovy needs 1 patch, Focal needs 2 | 17:58 |
| teward | i think | 17:58 |
| teward | has Groovy gotten the updated key patch yet though? | 17:59 |
| teward | rbasak: to sync you in on it, i looked at torbrowser-launcher in Debian, the only changes between Unstable and Experimental are bugfix packages and a no-change rebuild for buster-backports | 18:00 |
| teward | which is what they're using experimental for | 18:00 |
| AsciiWolf | yup, the updated patch should already be in Groovy :) | 18:00 |
| teward | so i'll have to do something more along the lines of a merge for Groovy | 18:00 |
| teward | AsciiWolf: if I don't get to it today I'll get to it tomorrow | 18:00 |
| AsciiWolf | I picked the key for my focal sru debdiff from latest source package from groovy ;) | 18:00 |
| AsciiWolf | teward, ok :) | 18:00 |
| AsciiWolf | thanks again for working on it! | 18:01 |
| teward | yup | 18:02 |
| teward | AsciiWolf: are https://bugs.launchpad.net/ubuntu/+source/torbrowser-launcher/+bug/1896085 and https://bugs.launchpad.net/ubuntu/+source/torbrowser-launcher/+bug/1896752 the only two bugs I need to address for this upload/SRU? | 18:04 |
| ubottu | Launchpad bug 1896085 in torbrowser-launcher (Ubuntu Groovy) "[SRU] Backport patch to update Tor Browser Developers public key into Ubuntu 20.04" [Undecided,In progress] | 18:04 |
| ubottu | Launchpad bug 1896752 in torbrowser-launcher (Ubuntu Groovy) "Version checking error in torbrowser-launcher since Tor Browser 10.0 was released" [Undecided,In progress] | 18:04 |
| AsciiWolf | teward, yes :) | 18:46 |
| AsciiWolf | if you want, there is one more thing | 18:46 |
| AsciiWolf | but that is optional and up to you... | 18:46 |
| AsciiWolf | however, it would be nice if it was fixed in Focal :) | 18:46 |
| AsciiWolf | teward, https://salsa.debian.org/pkg-privacy-team/torbrowser-launcher/-/commit/f83349ae954a888a7913ac64c98dbb53a284932f , https://salsa.debian.org/pkg-privacy-team/torbrowser-launcher/-/commit/68908ebd6567fad56642c57d2fb1f75dad6efe4a | 18:48 |
| AsciiWolf | these two gpg fixes :) | 18:48 |
| AsciiWolf | they are also already in Groovy | 18:49 |
| AsciiWolf | by the way, the version fix is now in unstable: https://salsa.debian.org/pkg-privacy-team/torbrowser-launcher/-/commits/debian/sid/ :) | 18:50 |
| AsciiWolf | *version comparison fix | 18:50 |
| AsciiWolf | and I see that they also added an apparmor fix: https://salsa.debian.org/pkg-privacy-team/torbrowser-launcher/-/commit/87859bce5779f89b37c4e4be334f7e1670b0a9f3#8d7b992e6498241fd42bd62f09b292c2af70ed1d | 18:51 |
| AsciiWolf | but as far as I know, this fix is needed only on systems with older libstdc++ such as older stable Debian or (probably) Ubuntu 18.04... it should work fine without this fix on Focal | 18:53 |
| AsciiWolf | tl; dr: if you want, you can add patch for https://salsa.debian.org/pkg-privacy-team/torbrowser-launcher/-/commit/f83349ae954a888a7913ac64c98dbb53a284932f and https://salsa.debian.org/pkg-privacy-team/torbrowser-launcher/-/commit/68908ebd6567fad56642c57d2fb1f75dad6efe4a | 19:05 |
| AsciiWolf | if not, just add the version checking fix patch and new devel key patch and it should be fine :) | 19:06 |
| AsciiWolf | for Groovy, just add the version checking patch or sync (as a Freeze Exception, if possible) the latest 0.3.2-14 package from Unstable :) | 19:07 |
| AsciiWolf | teward, oops, I see that the libstdc++ version appears to be the same in Ubuntu Focal/Groovy as in Debian Stable :( | 19:15 |
| AsciiWolf | so, ignore what I said, you probably need to backport the AppArmor patch as well :( in both Focal and Groovy | 19:15 |
| AsciiWolf | so, to sum this up: | 19:21 |
| AsciiWolf | for Groovy, you will need to backport: https://salsa.debian.org/pkg-privacy-team/torbrowser-launcher/-/commit/fa3115fbf6c2d298b12c1ccee8f679c13682c92c#4683e32f16f357bd7bdda440e5d9123dde283449 and https://salsa.debian.org/pkg-privacy-team/torbrowser-launcher/-/commit/87859bce5779f89b37c4e4be334f7e1670b0a9f3#8d7b992e6498241fd42bd62f09b292c2af70ed1d | 19:22 |
| AsciiWolf | for Focal, you will need to backport the same two patches + the new developer key patch that is already in my SRU | 19:24 |
| AsciiWolf | + optionally, for Focal, you can (but don't have to, it's up to you) also backport the gpg fix: https://salsa.debian.org/pkg-privacy-team/torbrowser-launcher/-/commit/f83349ae954a888a7913ac64c98dbb53a284932f , https://salsa.debian.org/pkg-privacy-team/torbrowser-launcher/-/commit/68908ebd6567fad56642c57d2fb1f75dad6efe4a | 19:26 |
| AsciiWolf | that's all :) sorry for spamming this chat | 19:26 |
| teward | probably easier to sync it since it's just bugfixes in the packaging | 19:28 |
| teward | for Groovy | 19:28 |
| AsciiWolf | yup | 19:29 |
| teward | AsciiWolf: for Groovy though it may take up to a day to be picked up. `Debian version 0.3.2-14 has not been picked up by LP yet. Please try again later.` | 19:31 |
| teward | LP has to see it first and it's not published yet on tracker.debian.org so... | 19:31 |
| teward | probably tomorrow for Groovy | 19:32 |
| AsciiWolf | ah | 19:32 |
| AsciiWolf | ok :) | 19:32 |
| teward | then i'll backport the patches for SRU | 19:32 |
| AsciiWolf | ok | 19:32 |
| RikMills | it should get picked up in a few hrs | 19:32 |
| RikMills | 6 - 8hrs is usually the max I see | 19:33 |
| teward | i'll check again before going to sleep | 19:34 |
| teward | and if not tonight then when I wake up tomorrow since tomorrow is a day off ;P | 19:34 |
| AsciiWolf | :) | 19:34 |
| RikMills | ditto | 19:34 |
| AsciiWolf | gotta go offline, see ya tomorrow! | 19:34 |
| RikMills | some of the debian servers were down earlier, so a delay is possible | 19:35 |
| teward | RikMills: indeed, that makes sense | 20:05 |
| AsciiWolf | teward, regarding the gpg fix for torbrowser-launcher Focal SRU, I just found out that Linux Mint does not have the gpg2 alias in default install, so I will be really happy if you include the gpg fix in the Focal SRU as well :) | 20:48 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!