facubatista¡Muy buenos días a todos!10:54
bthomasMorning facubatista : early today !11:04
facubatistahola bthomas11:04
facubatistabthomas, it's around the same time as always, my 8am, or did change any timezone because of spring/autumn?11:04
bthomasOk. facubatista : I pushed a cleaned up version of doc strings for charm.py in operator to https://github.com/balbirthomas/operator . There is only a single commit. I have not created pull request because I was not sure about a few attributes in the *Meta classes (see TODO at bottom of file). After you settle in and are free to do a quick 1:1 I can update them and create a pull request. I am now reading prometheus manual but ca11:07
bthomasback to docstrings for framework.py after chat.11:07
facubatistabthomas, but why not doing a PR and I can review it as always?11:08
facubatistaeven if you make it "draft"11:08
bthomasOk will do a draft Pr now.11:08
mupPR operator#417 opened: Added a few doc strings to charm module <Created by balbirthomas> <https://github.com/canonical/operator/pull/417>11:10
facubatistabthomas, I took a look to your PR... do you think there's a chance of proposing part of that as a ready-for-review PR? Just remove the stuff you're unsure or it's not finished, and propose the rest14:13
facubatistabthomas, this way the PR is shorter, and gives us time to decide on the rest14:13
bthomasfacubatista: I am perfectly fine with making that a PR. Are you ok with me leaving a TODO in there so it reminds us that a few things need to be added in. Alternatively if you have a couple of mininutes we can try and pair over hangouts and see if those things can be quickly filled in.14:16
bthomasJust do a search for "TODO" on that page. There are only a couple.14:17
facubatistabthomas, remove those with TODOs and leave them for the second wave14:21
bthomasfacubatista: ok then.14:22
bthomasfacubatista: FYI removed TODO and converted to PR14:42
* facubatista -> lunch16:06
* facubatista isback17:03
* facubatista eods and eows21:10
facubatistasee you all on monday!21:10

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!